Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1942
LGTM for code changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1734
LGTM for the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1984
@mrunalinikankariya One of the commits is not related to the issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1987#discussion_r104140435
--- Diff: server/src/org/apache/cloudstack/region/RegionManagerImpl.java ---
@@ -229,7 +232,7 @@ public boolean deleteUser(DeleteUserCmd cmd
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou Please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1726#discussion_r104374914
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2263,27 +2264,43 @@ public void cleanupDownloadUrls
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/827
@ustcweizhou Do you still have some queries on it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou does it look good to you now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1740
@syed
On the xenserver we always keep the latest snapshot in primary as xenserver
needs it to create delta snapshots. If the snapshot is not present in
xenserver, next snapshot would
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou coding convention issue is taken care
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/2019
LGTM for code changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/899
@SudharmaJain its taken care
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/914#discussion_r109123538
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -3206,25 +3206,33 @@ public long
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1725
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/921
Closing this PR, as this is no longer needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yvsubhash closed the pull request at:
https://github.com/apache/cloudstack/pull/921
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/2012
Tested this change. LGTM for test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/905
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user yvsubhash closed the pull request at:
https://github.com/apache/cloudstack/pull/827
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/827
Closing this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user yvsubhash closed the pull request at:
https://github.com/apache/cloudstack/pull/1721
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1664
@sateesh-chodapuneedi Please take care of the code change in the following
PR as well as i am closing
https://github.com/apache/cloudstack/pull/1721
The change is as follows
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1721
Closing this as change would be added to #1664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1740
Closing this PR as it is no longer needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yvsubhash closed the pull request at:
https://github.com/apache/cloudstack/pull/1740
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1740
The following ticket is opened for fixing this issue
https://issues.apache.org/jira/browse/CLOUDSTACK-9870
---
If your project is set up for it, you can reply to this email and have your
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1756
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/899
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1759
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/914
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1762
@serg38 Is the refactoring suggested by rafael taken care by @nvazquez,
else I would take it up
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/896
CLOUDSTACK-8908 After copying the template charging for that template is
getting stopped
This is happening as the zone id is not part of the query. Zone id is
added to the query and unit
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/899
BUG-ID:CLOUDSTACK-8921
Summary: CLOUDSTACK-8921
snapshot_store_ref table should store actual size of back snapshot in
secondary storage
Calling SR scan to make sure size is
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/905
BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag
Root Cause: Due to wrong search string we are fetching a resource which
does not belong to current account and domain. This results in
Github user yvsubhash commented on the pull request:
https://github.com/apache/cloudstack/pull/905#issuecomment-144683196
It is tested manually with the data similar to the one mentioned in the bug
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/914
BUG-ID CLOUDSTACK-8939
Fixing the error with snapshot size calculation in a vm with memory
You can merge this pull request into a Git repository by running:
$ git pull https
Github user yvsubhash commented on the pull request:
https://github.com/apache/cloudstack/pull/896#issuecomment-146090133
License Added
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/921
CLOUDSTACK-8944 Template download possible from new nfs secondary storage
before download is 100 % complete
Steps to test This
1. Add a new NFS storage
2. Start dowloading any
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/827
BUG-ID: CLOUDSTACK-8849: Usage job should stop usage generation in caâ¦
â¦se of any exception
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/831
CLOUDSTACK-8850: revertSnapshot command does not work
Updating the documentation before the api is actually supported
You can merge this pull request into a Git repository by running
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1586
CLOUDSTACK-9410 Data Disk shown as detached in XS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK-9410
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1586
@wido Replacing the original name with 'detached is not correct as it is
confusing. Anyway data disk being detached is captured in the state of the
volume
---
If your project is set u
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1714
CLOUDSTACK-9553 Usage event is not getting recorded for snapshots in â¦
â¦a specific scenario
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1715
CLOUDSTACK-9554 Juniper Contrail plug-in is publishing events to wronâ¦
Juniper Contrail plug-in is publishing events to message bus instead of
event bus
You can merge this pull request
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1716
CLOUDSTACK-9555 when a template is deleted and then copied over againâ¦
when a template is deleted and then copied over again , it is still marked
as Removed in template_zone_ref table
You
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1715
@rhtyd How abt rebasing it against branch 4.8 and edit the PR to base it to
the same?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1715
@rhtyd PR pointed to 4.8 branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1720
Bug-Id:CS-47456 Deploy from VMsnapshot fails with exception if sourceâ¦
Deploy from VMsnapshot fails with exception if sourcetemplate is removed or
made private Reviewed-By:sudharma
You
Github user yvsubhash closed the pull request at:
https://github.com/apache/cloudstack/pull/1720
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1721
CLOUDSTACK-9557 Deploy from VMsnapshot fails with exception if sourceâ¦
Deploy from VMsnapshot fails with exception if source template is removed
or made private
You can merge this pull
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1721
This should be merged after the merge of
https://github.com/apache/cloudstack/pull/1664
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1722
CLOUDSTACK-9558 Cleanup the snapshots on the primary storage of Xenseâ¦
Cleanup the snapshots on the primary storage of Xenserver after VM/Volume
is expunged
You can merge this pull
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1725
CLOUDSTACK-9559 Why allow deleting zone without deleting the secondaâ¦
CLOUDSTACK-9559 allow deleting zone without deleting the secondary storage
under the zone
You can merge this pull
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1726
CLOUDSTACK-9560 Root volume of deleted VM left unremoved
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yvsubhash/cloudstack CLOUDSTACK
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1726#discussion_r84859378
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -2199,15 +2199,20 @@ public void cleanupDownloadUrls(){
if
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@koushik-das Added the null check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1740
CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Storâ¦
Snapshot on primary storage not cleaned up after Storage migration. This
happens in the following two scenarios
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1586
@cloudmonger None of the test failures are related to the code change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1756
CLOUDSTACK-9585 UI doesn't give an option to select the xentools version
UI doesn't give an option to select the xentools version while registering
template for any user other
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1759
CLOUDSTACK-9589 vmName entries from host_details table for the VM's wâ¦
CLOUDSTACK-9589 vmName entries from host_details table for the VM's whose
state is Expunging should be dele
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1761
CLOUDSTACK-9592 Empty responses from site to site connection status aâ¦
CLOUDSTACK-9592 Empty responses from site to site connection status are not
handled propertly
vpn connection
GitHub user yvsubhash opened a pull request:
https://github.com/apache/cloudstack/pull/1762
CLOUDSTACK-9595 Transactions are not getting retried in case of databâ¦
CLOUDSTACK-9595 Transactions are not getting retried in case of database
deadlock errors
Problem Statement
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1716
@karuturi travis is fine now. two failed tests are not related to this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yvsubhash closed the pull request at:
https://github.com/apache/cloudstack/pull/1740
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user yvsubhash reopened a pull request:
https://github.com/apache/cloudstack/pull/1740
CLOUDSTACK-9572 Snapshot on primary storage not cleaned up after Storâ¦
Snapshot on primary storage not cleaned up after Storage migration. This
happens in the following scenario
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1721
@rhtyd i will merge this to #1664 once the conflicts are resolved int the
other one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/896
@rhtyd rebase to 4.8 is done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/827
@rodrigo93
Exception in this part of code should stop further usage generation.
Catching it here is suppressing the exception. The fix is tested manually by
simulating the scenario
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1761#discussion_r88429916
--- Diff: core/src/com/cloud/agent/api/CheckS2SVpnConnectionsAnswer.java ---
@@ -76,4 +76,14 @@ public String getDetail(String ip
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1761#discussion_r88431269
--- Diff: core/src/com/cloud/agent/api/CheckS2SVpnConnectionsAnswer.java ---
@@ -76,4 +76,14 @@ public String getDetail(String ip
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1761#discussion_r88432900
--- Diff: core/src/com/cloud/agent/api/CheckS2SVpnConnectionsAnswer.java ---
@@ -76,4 +76,14 @@ public String getDetail(String ip
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1759
@jburwell
Change is moved to schema-481to4820.sql and base branch is changed to 4.8
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1586
@syed @koushik-das can one of you please merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/827
@ustcweizhou In case we continue with usage generation, we may miss out
some of the records which actually resulted in exception and would in turn lead
to wrong usage numbers. stopping after
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1722
@koushik-das can you please review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1725
@rhtyd Failures are taken care
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1725
@rhtyd To answer your other question, lets say there are templates in the
secondary storage, they can not be deleted because the zone is no longer there.
As we have checks all other zone
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1759
@rhtyd rebased to 4.9 branch as suggested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1722#discussion_r91569719
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -260,11 +260,15 @@ public boolean
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1722#discussion_r91570095
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -260,11 +260,15 @@ public boolean
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/827
@ustcweizhou By stopping the usage server, we can fix the records and
continue in the next run. If we simply skip we wont come to know abt the
records with errors.
---
If your project is
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/896
@rhtyd Can you plz merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou Volume snapshots would be left over even in case of normal vm
destroy and that is expected. They can be used if there is a need to restore
the volume at a later point in time
Github user yvsubhash closed the pull request at:
https://github.com/apache/cloudstack/pull/1725
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user yvsubhash reopened a pull request:
https://github.com/apache/cloudstack/pull/1725
CLOUDSTACK-9559 Why allow deleting zone without deleting the secondaâ¦
CLOUDSTACK-9559 allow deleting zone without deleting the secondary storage
under the zone
You can merge this
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@rhtyd Can you please merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou In case of volume snapsnots, volume gets set to removed
irrespective of the presence of snapshots. I have verified the same just now
and I am only removing volume not any of
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou As I understand, Volume goes to Expunged state when it is
removed from primary and gets removed when it is removed from secondary
storage. line 2211 to 2215 is to handle
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1725
@rhtyd Can you please merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1726
@ustcweizhou thats good point. It should be removed after all download
links expire. I will address this case
---
If your project is set up for it, you can reply to this email and have your
Github user yvsubhash commented on the issue:
https://github.com/apache/cloudstack/pull/1759
@rhtyd can you suggest me the branch for rebasing this commit against?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user yvsubhash commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1908#discussion_r96598944
--- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java ---
@@ -823,13 +826,39 @@ public int compare(final PublicIpAddress o1, final
93 matches
Mail list logo
