Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1955#discussion_r102687170
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -2216,6 +2225,8 @@ public int compare(final
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1955#discussion_r102687113
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -2158,6 +2166,7 @@ public int compare(final
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1955#discussion_r102687039
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -2059,6 +2060,13 @@ So if getMinSpeed
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1950#discussion_r102688184
--- Diff: .gitignore ---
@@ -51,7 +51,6 @@ tools/cli/build/
*.jar
*.war
*.mar
-*.zip
--- End diff --
Why? Are we adding ZIP
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1582
Just for the record, please use *download.cloudstack.org*.
Let me know if anything is missing there so it can be added.
---
If your project is set up for it, you can reply to this email
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1955
I would like to give a LGTM, but it's only the logging lines which I don't
like yet.
They seem like personal debug lines, but a admin will never know what they
actually mean.
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1955
Do we want to pass the unmap not as a string? Shouldn't that be a enum?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1955
@nathanejohnson: Good! I would like to see that being enums.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1955
LGTM from the code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1707
I rebased the code against master, merges again. Tests are looking good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1955
Yes, we are indeed ready for a merge. Shall we do that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1950
LGTM for me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/2028
CLOUDSTACK-9853: Add support for Secondary IPv6 Addresses and Subnets
This commit adds support for passing IPv6 Addresses and/or Subnets as
Secondary IPs.
This is groundwork for
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/2024
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/2018
Can you explain a bit more why you are changing the iptable rules? As they
can break a lot of things by accident.
---
If your project is set up for it, you can reply to this email and have your
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1864
Are you still working on this update Rohit? Or is there a new PR for
updating the SSVM to Debian 8?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/2023
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/2018
Understood! Looks good to me.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/1864
Ok, understood. I'll see if I can find some time to work on this. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/2033
LGTM
Just tested on Ubuntu 16.04 and works
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/2037
CLOUDSTACK-9871: Set SQL Mode in SQL Session for MySQL 5.7 compatibility
MySQL 5.7 has a more strict SQL mode by default with which CloudStack
is not compatible.
By setting the SQL
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/2038
ipv6: Allow all ICMPv6 traffic if -1 is provided as a ICMP type
ip6tables no longer takes '--icmpv6-type any' as a argument.
To allow all ICMPv6 traffic with ip6tables it
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/2037
Done @rhtyd, how does this look like?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/2039
rbd: Use libvirt to create new volumes and not rados-java
Since libvirt 1.2.2 libvirt will properly create volumes
using RBD format 2.
We can use libvirt to creates the volumes which
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/2036
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/2046
CLOUDSTACK-7958: Add configuration for limit to CIDRs for Admin API calls
The global setting 'management.admin.cidr' is set to 0.0.0.0/0,::/0
by default preserve the current behavio
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111589567
--- Diff: core/src/com/cloud/network/HAProxyConfigurator.java ---
@@ -538,7 +536,7 @@ private String getLbSubRuleForStickiness(final
LoadBalancerTO lbTO
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111589627
--- Diff: api/src/org/apache/cloudstack/config/ApiServiceConfiguration.java
---
@@ -28,6 +28,8 @@
"API end point. Can be used
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111589706
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest
req, final
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/2046#discussion_r111589656
--- Diff: server/src/com/cloud/api/ApiServlet.java ---
@@ -290,6 +292,17 @@ void processRequestInContext(final HttpServletRequest
req, final
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/2046
@DaanHoogland: I improved the logging as you suggested/requested.
A TRACE for every request and WARN when a request is denied. Tried this
locally:
2017-04-14 15:45:58,901
Github user wido commented on the issue:
https://github.com/apache/cloudstack/pull/2046
@PaulAngus This is what we talked about in Prague. Mind taking a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/140#issuecomment-88928090
Yes, it is, but we should log somewhere. Now a machine just reboots. We
should send something to syslog prior to rebooting.
---
If your project is set up for it, you
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1226#issuecomment-164134435
No idea why that is in there indeed. LGTM
Is just a metadata file, never touched by packaging either.
---
If your project is set up for it, you can reply to
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1225#issuecomment-164134517
The build still works indeed, bu I'd love to see if all the tests still
work.
We transfer TOs between the Agent and Mgmt server and they contain full
pa
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164134556
@remibergsma Hmm, that's weird. It compiled on my desktop. This seems like
a Java version thingy.
---
If your project is set up for it, you can reply to this
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164168237
@bhaisaab Good idea to do that indeed. I think many of us want Java 8.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1242
test: Fix Libvirt test so that it works on Windows
This test failed on Windows, using the File.separator it should run fine on
Windows.
You can merge this pull request into a Git repository by
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1242#discussion_r47495825
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtUtilitiesHelperTest.java
---
@@ -37,8 +38,8 @@ public void
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1220#issuecomment-164673949
Closing this one for now since it doesn't work on Java 7.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user wido closed the pull request at:
https://github.com/apache/cloudstack/pull/1220
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-165717186
I'll see if I can run tests on it today with @borisroman on our dev setup
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1230#discussion_r48005662
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
---
@@ -1274,7 +1274,45 @@ public Answer
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1230#discussion_r48026314
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
---
@@ -1274,7 +1274,45 @@ public Answer
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1230#discussion_r48101628
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
---
@@ -1274,7 +1274,46 @@ public Answer
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1230#discussion_r48101631
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
---
@@ -1274,7 +1274,46 @@ public Answer
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-166100502
Last code review is LGTM to me, but didn't have the time to test it yet. I
*think* it works, but need to verify first.
---
If your project is set up for it, yo
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1281#issuecomment-166836536
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-167075932
ping @borisroman. I would like to see this one go in. Code-wise it looks
good.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user wido closed the pull request at:
https://github.com/apache/cloudstack/pull/1054
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user wido reopened a pull request:
https://github.com/apache/cloudstack/pull/1054
CLOUDSTACK-8818: Use MySQL native connector with Python
MySQLdb has been deprecated and is also not supported in Python 3.
mysql.connector is a connector written in Python which talks
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-167965031
Tests seem good according to @borisroman Just looking into why the
XenServer strategy had to be used. That should be all
---
If your project is set up for it, you
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1242#issuecomment-168010431
Any LGTMs on this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1286#issuecomment-168010821
What is the best way to test this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1306#issuecomment-168987361
More tests is always better! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-168987824
One comment I have on the code. Otherwise it looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1297#discussion_r48840288
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -2288,6 +2290,7 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd)
throws
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1291#issuecomment-168988130
LGTM based on the code. Didn't perform a test on it. Trivial fix for some
integers.
---
If your project is set up for it, you can reply to this email and have
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-168988361
Is there a way to test this quickly or do you have any results?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-168988457
Any other LGTMs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-168991998
Checked all the commits, re-read the code and LGTM. Based on the tests
already performed.
---
If your project is set up for it, you can reply to this email and have
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1309
CLOUDSTACK-9210: Pass secondary IPs to default_network_rules() function
This is a mandatory argument but it was NOT passed which caused the
re-programming of security groups to fail
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169063660
@DaanHoogland @remibergsma @resmo Could you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169067941
@DaanHoogland We do not have any unit testing in place for Python. If you
look just 10 lines up you see the method being called exactly that way.
Without this
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169069686
Forgot to add, pylint still works fine. It scores 3.54/10. Not great, but a
lint check still succeeds.
---
If your project is set up for it, you can reply to this
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169117271
@DaanHoogland I agree, this script isn't the best in the world.
In my opinion we should offload this work to libvirt:
- http://libvir
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-169132663
Agree with @DaanHoogland the code doesn't seem bad and probably fixes the
issue. But something is wrong here indeed. Codewise it looks good.
---
If your proje
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1298#issuecomment-169132861
Trivial fix indeed. We can ignore this since our goal has been reached.
LGTM
---
If your project is set up for it, you can reply to this email and have your
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-169133233
Did the tests succeed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169134133
@DaanHoogland No idea. Might work with Xen if we manage those Instances
through libvirt. But in case of KVM we can probably do this with libvirt. Might
need to
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-169134419
Based on the code I don't see anything dangerous though. It still compiles
I see ;)
---
If your project is set up for it, you can reply to this email and have
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1312#issuecomment-169319828
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-169320044
@remibergsma Can we merge this one? It fixes a bug.
To clarify, this is how the method has been defined:
def default_network_rules(vm_name, vm_id
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1341#issuecomment-171657390
I tested this by manually applying all the SQL patches and verifying that
all URLs are still in the database like they should be.
Also added a new template
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1341
CLOUDSTACK-9238: Increase URL fields to 2048 charachters from 255
255 characters is to small for various URLs like S3 pre-signed URLs.
This causes one or more characters to be chopped of
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1341#issuecomment-171703995
Like @kevindierkx indeed says. A VARCHAR can be up to 64k characters long.
It seems that 2k is the maximum length of a URL used in most systems.
That's w
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-172194485
Based on the code yes, @DaanHoogland . Couldn't run any tests on it.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1341#issuecomment-172259203
Thanks @remibergsma !
That is the same reasoning as @kevindierkx and me had while looking into
this. We went for 2k for now as it seems to match almost 100
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1309#issuecomment-172259457
@remibergsma We have this one running in production right now and it is
working as expected.
I spent some time in trying to get a test-case up and running
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-172309253
@nislim No, not really. The people at libvirt-java aren't the fastest.
Thinking about forking it into CloudStack itself.
---
If your project is set up for it, yo
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1348#issuecomment-173357364
Looking at this test I see the problem indeed. I actually created this
regression while fixing it.
One thing though, you mean that the IP of the NFS server is
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1370#issuecomment-175473551
I agree with switching to Java 8, but shouldn't this be a small PR first
where we ONLY switch to Java 8?
Other PRs can follow up quickly.
---
If
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-175824353
Looks good at first, but I would like to see some UnitTests around methods.
I'll comment on those inline.
---
If your project is set up for it, you can reply to
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51040863
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51040885
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51040823
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1332#discussion_r51040901
--- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java ---
@@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg,
String path
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-175825330
Code looks good, but I have no way of testing this since I don't have
Swift...
---
If your project is set up for it, you can reply to this email and have your
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-175826191
Can we rebase against master (4.9)? Seems that this one is ready to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1348#issuecomment-175824842
@DaanHoogland Have you been able to fix this? Code-wise it still seems good.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1379#discussion_r51116786
--- Diff: setup/bindir/cloud-set-guest-sshkey-configdrive.in ---
@@ -0,0 +1,107 @@
+#!/bin/bash
+#
+# Init file for SSH Public Keys Download
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1379#discussion_r51116750
--- Diff: setup/bindir/cloud-set-guest-sshkey-configdrive.in ---
@@ -0,0 +1,107 @@
+#!/bin/bash
+#
+# Init file for SSH Public Keys Download
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-176191880
Seems good to me looking at it. Don't know how to test it properly, but
code-wise the changes look sane to me.
---
If your project is set up for it, you can rep
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-176629568
With the tests this looks good to me. I have no way of verifying the Swift
working itself, but based on the code and tests: LGTM
---
If your project is set up for it
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/780#issuecomment-176693950
This looks good to me. Hard to test though :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1387#issuecomment-177549166
Yes, simple but sane fix indeed. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-179742046
You also change Java code at the same time. Shouldn't this PR ONLY upgrade
maven. Nothing more?
---
If your project is set up for it, you can reply to this emai
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-179847902
Ok, @DaanHoogland I understand.
Tests seem to fail though. Is that legit?
---
If your project is set up for it, you can reply to this email and have your
GitHub user wido opened a pull request:
https://github.com/apache/cloudstack/pull/1408
kvm: Aqcuire lock when running security group Python script
It could happen that when multiple instances are starting at the same
time on a KVM host the Agent spawns multiple instances of
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1408#issuecomment-182246389
@jlk What I've seen is that it all happens in a 2 to 3 second window.
Usually the security group script doesn't run for a very long time, so that
made m
1 - 100 of 1596 matches
Mail list logo
