Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1654
@jburwell looks like @rhtyd already tested this. Do you need another
testing? I am currently setting up my env
---
If your project is set up for it, you can reply to this email and have your
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77209873
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -328,15 +412,64 @@ private void
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77210539
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private void
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77254138
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private void
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259176
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -92,7 +90,34
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259303
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -92,7 +90,34
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259257
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -212,20 +251,47 @@ public
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259202
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -92,7 +90,34
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259286
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -92,7 +90,34
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259343
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private void
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259447
--- Diff: core/src/org/apache/cloudstack/storage/to/PrimaryDataStoreTO.java
---
@@ -51,6 +50,7 @@
private final String url;
private Map
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259407
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -328,15 +412,64 @@ private void
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259373
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private void
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259356
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -380,6 +513,122 @@ private void
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r77259462
--- Diff:
api/test/org/apache/cloudstack/api/command/test/CreateSnapshotCmdTest.java ---
@@ -0,0 +1,130 @@
+// Licensed to the Apache Software
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77626328
--- Diff:
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreDriver.java
---
@@ -25,6 +25,13 @@
import
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77628932
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -2045,62 +2045,74 @@ protected void migrate(final VMInstanceVO vm
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77629961
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xen610/XenServer610MigrateWithStorageReceiveCommandWrapper.java
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77631355
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixCreateStoragePoolCommandWrapper.java
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1671#discussion_r77631682
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/wrapper/xenbase/CitrixDeleteStoragePoolCommandWrapper.java
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1671
@mike-tutkowski I've reviewed the code. it LGTM, my only concern is of
migrating between two different managed storage when they don't have same tags
(which would ideally be t
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1600
Support Backup of Snapshots for Managed Storage
This PR adds an ability to Pass a new parameter, locationType,
to the âcreateSnapshotâ API command. Depending on the locationType
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1600
@karuturi @jburwell Can we merge this in? Anthing left from my side?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski Currently, all the info in the `TestData` is hardcoded.
Would it be possible to add a system to override some values so that I can test
this as well (IP addresses for example
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1600
@jburwell I've rebased against the master. The merge should be good now.
I've addressed your comments as well. @mike-tutkowski has ran his tests on this
functionality.
https://
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1600
@jburwell Squashed the commits. You can run the smoke tests on this. This
change is mostly on the managed storage side so running any volume related
tests would be helpful apart from the tests
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1600
@jburwell Rebased with master and resolved conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1600
@mike-tutkowski I've added your updated tests and rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1600
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1600
Support Backup of Snapshots for Managed Storage
This PR adds an ability to Pass a new parameter, locationType,
to the âcreateSnapshotâ API command. Depending on the locationType
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1600
@mike-tutkowski @jburwell I've re-opened the PR to trigger jenkins again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user syed opened a pull request:
https://github.com/apache/cloudstack/pull/1423
[CLOUDSTACK-9296] Start ipsec for client VPN
This fix starts the IPSEC daemon when enabling client side vpn
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user syed opened a pull request:
https://github.com/apache/cloudstack/pull/1424
[CLOUDSTACK-8973] Fix create template from snapshot returning null in case
of region store
This PR fixes a case where when we create a template from a snpashot in a
region wide store, we don&#
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1424#discussion_r54762197
--- Diff: server/src/com/cloud/api/ApiResponseHelper.java ---
@@ -1388,7 +1388,7 @@ public TemplateResponse
createTemplateUpdateResponse(ResponseView view
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1424#discussion_r54762401
--- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
@@ -275,6 +277,8 @@
private StorageCacheManager cacheMgr;
@Inject
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-194962876
@kiwiflyer : Rebase done. Here is the log from the VR when I enable client
side vpn
```
2016-03-10 17:01:25,876 merge.py load:60 Loading data bag type
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-196429053
@remibergsma I beleive there is a [marvin
test](https://github.com/apache/cloudstack/blob/master/test/integration/smoke/test_vpc_vpn.py)
for this but I beleive it was
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-196448014
@remibergsma Going through the VPN tests on Marvin, I see that it is not
actually testing if VPN is working. It just check if we can enable VPN without
any errors but
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1439#issuecomment-196448464
@rodrigo93 Do you know why we have `Void` return types? I've seen them and
not sure why they were added.
---
If your project is set up for it, you can reply to
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-201355723
@kollyma This was happening for swift because the `template.properties`
file was not correctly populated. So, when a management restart happens, it
syncs data from
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-205922970
@bvbharatk it looks to be a problem with the test. Volume creation should
work irrespective of my changes.
---
If your project is set up for it, you can reply to
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-205981012
Sure @swill . I've sqashed them
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-207676112
@swill I've squashed the commits
@kollyma I'm sorry I missed your message. Do you still see a problem?
Something strage that I see in your out
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-207898130
@rafaelweingartner Done. Although I didn't create any test cases yet. There
is nothing much to test. The function doesn't throw any execptions, doesn
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-207898283
@swill I beleieve we can do a better test. After the VPN is set up we can
do something like
`ike-scan -M 172.16.21.200` to see if the VPN opened up. I'll
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-208176655
@rafaelweingartner Updated the comment as a javadoc.
For the test. I am not sure what the best strategy is. Maybe you can help
me understand better. Would
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-209390353
@rafaelweingartner I've written a simple test which will fail if someone
throws an exception and it is not caught. I've tried mocking the `s_logger` but
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-209759974
For sure @rafaelweingartner. As I have outlined in my mail to you, I've
been basically following the practices that have been put in place by the
previous devel
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-211374488
@swill I have added a marvin test to see if the VPN service starts
correctly however I am having trouble getting marvin to work correctly. When I
run the test I get
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-211455173
Loving the discussion here guys! Based on the comments by @jburwell I found
http://stackoverflow.com/questions/1827677/how-to-do-a-junit-assert-on-a-message-in-a
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-211995051
@rafaelweingartner I've added the test mocking the `BufferedWriter`. When I
tried to run the tests I found that the test required `agent.properties` and
`log4
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-211996541
@bhaisaab Do you have an idea of why Marvin is failing on my dev setup?
I've followed the guide mentioned
[here](https://cwiki.apache.org/confluence/di
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1423
[CLOUDSTACK-9296] Start ipsec for client VPN
This fix starts the IPSEC daemon when enabling client side vpn
You can merge this pull request into a Git repository by running:
$ git pull
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1501#issuecomment-212800599
LGTM based on code review @mike-tutkowski cc @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-212907833
@jburwell @rafaelweingartner I've added the test for checking the logged
message using the gist provided by @jburwell. I've also added a `log4j.xml`
becaus
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62505096
--- Diff:
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/HypervisorHostListener.java
---
@@ -21,7 +21,13 @@
import
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62505426
--- Diff: engine/components-api/src/com/cloud/agent/Listener.java ---
@@ -87,6 +93,18 @@
boolean processDisconnect(long agentId, Status state
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62505386
--- Diff: engine/components-api/src/com/cloud/agent/Listener.java ---
@@ -87,6 +93,18 @@
boolean processDisconnect(long agentId, Status state
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62508121
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -933,7 +937,7 @@ private PlugNicAnswer execute
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62509667
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
---
@@ -18,40 +18,69
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62509977
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
---
@@ -65,22 +94,182 @@ public
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62511172
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
---
@@ -91,18 +280,5 @@ public
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r62513240
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -1570,17 +1578,35 @@ private boolean checkCIDR(final HostPodVO pod,
final String
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/816#issuecomment-217890036
@mike-tutkowski I've reviewed the code and it LGTM. I have a few minor
comments that should be fairly simple to adress.
---
If your project is set up for it, yo
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-217971133
@rafaelweingartner @jburwell Sorry for the late reply to this. I was on
vacation and returned today. I've decided to use John's approach for the
logging
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-217972386
@rhtyd Squashed. It is pending a LGTM. If you can have a quick look at this
one, it would be awesome!
---
If your project is set up for it, you can reply to this
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-217972968
@swill Sqashed. I believe this is good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user syed commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-218154430
@swill the problem is because of `LocalNfsSecondaryStorageResourceTest`.
Before my commit, tests were ignored for this module probably because of the
above file
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1600
@mike-tutkowski @jburwell looks like we are green now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user syed opened a pull request:
https://github.com/apache/cloudstack/pull/1711
Xenserver7
This PR adds support for XenServer 7. I have manually done the following
tests
* Create a new cluster with XenServer7
* Add Primary storage: Should create an SR on XS7
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r83933003
--- Diff: scripts/vm/hypervisor/xenserver/xenserver70/patch ---
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1711
@koushik-das Thank you for the review! I've added the guest OS mappings and
hypervisor capabilities.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1692
@PaulAngus I will test this out on my XenServer7 setup. I would need some
help to understand how you are running these. I'll PM you on Slack
---
If your project is set up for it, you can rep
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1692
I'm running the smoke tests on my setup. I will post the results as soon as
they have completed.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1692
My tests have finished. I had run into some issues where one of the tests
got stuck when cleaning everything. I have yet to determine the root cause.
I've had 8 test cases. Here i
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1692
@PaulAngus were there any tests that were expected to fail? If so I can
exclude them and try to debug the ones that were supposed to run correctly.
---
If your project is set up for it, you can
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1692
Thanks @murali-reddy for confirming this. Based on that this PR LGTM. Thank
you guys for fixing the smoke tests. This is a very needed requirement for
getting stable releases :+1:
---
If your
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1711
@PaulAngus I'm running the tests that failed for you on my setup. I will
update with what I find.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1711
@PaulAngus
`test_volumes:TestCreateVolume.test_01_create_volume`
I've tested the failed checks. I found a problem with the marvin check that
was doing size check. I'v
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1726
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1697#discussion_r84712741
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
---
@@ -374,8 +375,24 @@ public SnapshotInfo
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1711
@PaulAngus would it be possible to run another round of tests on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1732
LGTM as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1711
@rhtyd @PaulAngus I will verify the failed tests (except VPC and private
gateway) and update this. It would be nice if we can get this into 4.10
---
If your project is set up for it, you can
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1711
@jburwell Got it. I want to stabilize the tests and once everything looks
green here. I will open a PR against 4.9
---
If your project is set up for it, you can reply to this email and have your
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1711
@jburwell I have reviewed all the smoke tests and I have not found at any
place we skipping because of a version mismatch so we are good there. I still
have to figure out why some of the tests are
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1600
Thanks @mike-tutkowski
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1746#discussion_r86163158
--- Diff: core/src/com/cloud/storage/template/HttpTemplateDownloader.java
---
@@ -117,7 +116,7 @@ public boolean retryMethod(final HttpMethod method
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1746#discussion_r86163529
--- Diff: core/src/com/cloud/storage/template/HttpTemplateDownloader.java
---
@@ -117,7 +116,7 @@ public boolean retryMethod(final HttpMethod method
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1740
> Wait until ACS created the snapshot. ACS is creating a snapshot on local
storage and is transferring this snapshot to secondary storage. But the latest
snapshot on local storage will stay th
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r86864517
--- Diff: setup/db/db/schema-4910to41000.sql ---
@@ -35,4 +35,192 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,
hypervisor_type, hypervi
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1711
@PaulAngus @jburwell I've added more changes and rebased. now My tests are
now running without errors. I did add the ` --config
global{metadata_read_only=0} ` as suggested by @PaulAngus an
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1750
LGTM as well. Thanks for the fix @murali-reddy
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1749
@mike-tutkowski I believe you are right. I don't see how the errors would
call the managed storage. In any case, I am setting up my new environment with
SolidFire today. I will run this P
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1711
XenServer 7 Support
This PR adds support for XenServer 7. I have manually done the following
tests
- Create a new cluster with XenServer7
- Add Primary storage: Should create an SR on
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1711
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1711
@PaulAngus @jburwell This PR is looking good now. Can we re-run the tests
with this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user syed commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1711#discussion_r87848428
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/XenServer700Resource.java
---
@@ -0,0 +1,32
101 - 200 of 536 matches
Mail list logo
