Re: Unable to start secondary storage in DevCloud

2013-07-09 Thread Syed
have any settings to recommend that I can fiddle around and make this VM come up though I do not know what exactly this is used for. Thanks for your help. I was able to get something working. Thanks -Syed WARN [cloud.consoleproxy.ConsoleProxyManagerImpl] (consoleproxy-1:) Exception while

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-22 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1951 @rhtyd If I understand correctly if we add the DB changes in 4.9.2->4.9.3 then after forward merging, upgrade from 4.9.2->4.10.0 should not have any problems with idempotency correct?

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-22 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1829 @anshul1886 it looks like #672 is closed so that leaves us with #1941 , Are we targeting it for 4.10? If yes, then there are some comments there which you might want to address there. If we do

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-22 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1768 I agree with @DaanHoogland , as @marcaurele mentioned, the only file we need to worry about is `schema-481to490-cleanup.sql` the rest of them are either empty or change the configuration where the

[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...

2017-02-22 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1962 CLOUDSTACK-9798 - Resizing root disk fails when using SolidFire This one is easy to reproduce: 1. Create a VM with where the root disk goes to the managed solidfire 2. Stop the VM

[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...

2017-02-22 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1963 CLOUDSTACK-9799 - Unable to create volume from snapshots with "_" in solidfire Steps to reproduce: 1. Create a volume using the SolidFire plugin 2. Take a snpshot of the vo

[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...

2017-02-22 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1962 @mike-tutkowski This happens when you don't specify IOPS in the service offering for the VM --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...

2017-02-22 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1962 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...

2017-02-22 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1962 CLOUDSTACK-9798 - Resizing root disk fails when using SolidFire This one is easy to reproduce: 1. Create a VM with where the root disk goes to the managed solidfire 2. Stop the VM

[GitHub] cloudstack issue #1963: CLOUDSTACK-9799 - Unable to create volume from snaps...

2017-02-23 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1963 @mike-tutkowski If you already have this in your PR, I can close this. Let me know! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...

2017-02-23 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1963#discussion_r102798055 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -711,6 +711,7 @@ private void

[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...

2017-02-23 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1963 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-27 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1951 Thanks @rhtyd for confirming. LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-27 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1829 @rhtyd @anshul1886 I suggest merging this first as the changes here are very limited and tested. We can refactor the change out from #1941 --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...

2017-02-27 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1962 @mike-tutkowski If you already have incorporated these changes, I'll close this one. If possible, please add me as reviewer when you open the other PR --- If your project is set up for it

[GitHub] cloudstack pull request #1962: CLOUDSTACK-9798 - Resizing root disk fails wh...

2017-02-27 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1962 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1740: CLOUDSTACK-9572 Snapshot on primary storage not clea...

2017-03-23 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1740 Thanks @yvsubhash Did the code review and it LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #876: CLOUDSTACK-8865: Adding SR doesn't create Stor...

2017-04-01 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/876#discussion_r109299000 --- Diff: plugins/storage/volume/cloudbyte/src/org/apache/cloudstack/storage/datastore/lifecycle/ElastistorPrimaryDataStoreLifeCycle.java --- @@ -359,7

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2015-12-14 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164469053 @DaanHoogland I agree, someone must have kept this limit way back and forgot about it. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2016-01-11 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-170667305 Hi Guys ( @bhaisaab, @DaanHoogland, @remibergsma ).Did you get a chance to look at this? I think we can remove this safely. --- If your project is set up for it

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-01-12 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1331 Fix Sync of template.properties in Swift When using Swift as a secondary storage, we create a template.properties file which stores the metadata about the template. Currently the data which is

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-12 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1332 Add ability to download templates in Swift This PR adds the ability to download templates when using Swift as a secondary storage. Uses the "temp_url" feature of Swift so that tempa

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-01-21 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1331#discussion_r50443906 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java --- @@ -942,6 +931,83 @@ protected

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-01-21 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1331#discussion_r50446719 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java --- @@ -942,6 +931,83 @@ protected

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-01-21 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-173678575 Jira ticket : [CLOUDSTACK-9247](https://issues.apache.org/jira/browse/CLOUDSTACK-9247) I've tested this on our local setup and it works as expected. -

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-21 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r50451763 --- Diff: plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java --- @@ -67,7 +73,28 @@ public

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-21 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r50451895 --- Diff: plugins/storage/image/swift/src/org/apache/cloudstack/storage/datastore/driver/SwiftImageStoreDriverImpl.java --- @@ -67,7 +73,28 @@ public

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-21 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r50452491 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-21 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-173688390 JIRA: [CLOUDSTACK-9248](https://issues.apache.org/jira/browse/CLOUDSTACK-9248) Tested this on our local setup. Created a template and generated the download

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-176289614 Added unit tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51153892 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51153916 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51153907 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-01-28 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1332#discussion_r51154027 --- Diff: utils/src/main/java/com/cloud/utils/SwiftUtil.java --- @@ -236,4 +247,60 @@ public static boolean deleteObject(SwiftClientCfg cfg, String path

[GitHub] cloudstack pull request: Add ability to download templates in Swif...

2016-02-03 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1332#issuecomment-179502412 Can we get this merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-02-08 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-181507090 Fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-02-09 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-182023310 @DaanHoogland I'm not sure why the tests are failing. My changes shouldn't have affected that --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

2016-02-15 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-184250180 LGTM. I've also been testing this in my dev environment with no issues so far --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack-cloudmonkey pull request: Import error when running clo...

2015-10-02 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/10 Import error when running cloudmonkey The cloudmonkey install from pip does not run and gives an import error because the latest `requests` package dropped the

[GitHub] cloudstack-cloudmonkey pull request: Import error when running clo...

2015-10-03 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/10#issuecomment-145297866 This was a problem with my setup where I had multiple versions of `request`. Closing as not a bug --- If your project is set up for it, you can reply to

[GitHub] cloudstack-cloudmonkey pull request: Import error when running clo...

2015-10-03 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack-cloudmonkey/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Fix Instance creation with swift as Secon...

2015-11-23 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1112 Fix Instance creation with swift as Secondary Storage [CLOUDSTACK-9061] Swift is currently broken when used as Secondary storage. This fix does the right thing when creating directories on the

[GitHub] cloudstack pull request: Fix Instance creation with swift as Secon...

2015-11-27 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix Instance creation with swift as Secon...

2015-11-27 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1112#issuecomment-160187393 Guys, I am closing this and opening this request against 4.6.1 as I have been told that it is the new way now. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Fix secondary storage not working with sw...

2015-11-27 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1133 Fix secondary storage not working with swift Original PR and discussion at #1112 You can merge this pull request into a Git repository by running: $ git pull https://github.com/syed

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2015-12-11 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1223 Remove template ulimit from createtmplt.sh and createvolume.sh Both createvolume.sh and createtmplt.sh have a 40GB hardcoded limit for the size of the template that gets created. I could not

[GitHub] cloudstack pull request: Remove template ulimit from createtmplt.s...

2015-12-11 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1223#issuecomment-164039298 @remibergsma Done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-219160595 @swill looks like jenkins failed because of some licence issue in one file. I've checked all the files that I have changed and every one seems to have the co

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-219162095 @swill I got the file from jenkins and it points to `utils/testsmallfileinactive` ... I have no idea where this file came from --- If your project is set up for it

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-219163000 https://builds.apache.org/job/cloudstack-pr-analysis/1323/artifact/target/rat.txt here is the link to the file --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1331 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-219166142 @DaanHoogland sure ... doesn't hurt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-05-13 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1331 Fix Sync of template.properties in Swift When using Swift as a secondary storage, we create a template.properties file which stores the metadata about the template. Currently the data which is

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-16 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-16 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-18 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-18 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-18 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-18 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-18 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-18 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu

2016-05-19 Thread syed
Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1552#issuecomment-220349481 Can cofirm the dhcp folder on Ubuntu Trusty LTS (14.04) LGTM. ``` $ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-20 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1424 [CLOUDSTACK-8973] Fix create template from snapshot returning null in case of region store This PR fixes a case where when we create a template from a snpashot in a region wide store, we don&#

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

2016-05-20 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-24 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-24 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-26 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-05-26 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1423 [CLOUDSTACK-9296] Start ipsec for client VPN This fix starts the IPSEC daemon when enabling client side vpn You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1584 LGTM based on the code review. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1598: [CLOUDSTACK-9423] Add ability to get virtual ...

2016-06-27 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1598 [CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs With object store like Swift as secondary storage, if a compressed VHD is uploaded as a template, the `VHDProcessor

[GitHub] cloudstack issue #1598: [CLOUDSTACK-9423] Add ability to get virtual size of...

2016-06-27 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1598 Yes @swill I've tested this on my local setup. On Mon, Jun 27, 2016 at 5:16 PM, Will Stevens wrote: > @syed <https://github.com/syed> my understanding is that y

[GitHub] cloudstack issue #1597: added constant for magic code

2016-06-28 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1597 Looks like there are some trailing space problems. Can you please fix that @vcharmcaster ``` /home/jenkins/jenkins-slave/workspace/cloudstack-pr-analysis/services/console-proxy

[GitHub] cloudstack issue #1595: ui: show resize volume button to all users

2016-06-28 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1595 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack issue #1598: [CLOUDSTACK-9423] Add ability to get virtual size of...

2016-06-28 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1598 @swill. I've fixed the whitespaces and rebased everything. Should be good now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack issue #1597: added constant for magic code

2016-06-28 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1597 @vcharmcaster it looks like your commit still did not fix the problems. Can you check the problems I mentioned in my previous comments. There are some trailing spaces and tabs which need to be

[GitHub] cloudstack issue #1598: [CLOUDSTACK-9423] Add ability to get virtual size of...

2016-06-29 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1598 @swill if you can merge this before you cut the release, it would be awesome. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request #1598: [CLOUDSTACK-9423] Add ability to get virtual ...

2016-06-30 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1598 [CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs With object store like Swift as secondary storage, if a compressed VHD is uploaded as a template, the `VHDProcessor

[GitHub] cloudstack pull request #1598: [CLOUDSTACK-9423] Add ability to get virtual ...

2016-06-30 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-06-30 Thread syed
GitHub user syed opened a pull request: https://github.com/apache/cloudstack/pull/1600 Support Backup of Snapshots for Managed Storage This PR adds an ability to Pass a new parameter, locationType, to the “createSnapshot” API command. Depending on the locationType

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-06-30 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 This was done in two parts: The work to add the API parameter was done by @mike-tutkowski and the work to enable this on the backend was done by me. The rebase destroyed history but I

[GitHub] cloudstack pull request #1598: [CLOUDSTACK-9423] Add ability to get virtual ...

2016-06-30 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1598: [CLOUDSTACK-9423] Add ability to get virtual ...

2016-06-30 Thread syed
GitHub user syed reopened a pull request: https://github.com/apache/cloudstack/pull/1598 [CLOUDSTACK-9423] Add ability to get virtual size of compressed VHDs With object store like Swift as secondary storage, if a compressed VHD is uploaded as a template, the `VHDProcessor

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-07-02 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 Good catch @mike-tutkowski. I will fix it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular VMware vms creation as ful...

2016-07-04 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1602 @nvazquez is there a use case where you would want some VMWare hypervisors to not do a full clone? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-07-04 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 Sure @mike-tutkowski --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-07-04 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 A bit of background on how this feature works. When locationType is specified as `Archve`, a snaphsot is taken at the storage, but the copy to seconday storage is done via the hypervisor as it is

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-07-04 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski , the list snapshot already returns the `loacationType`. I think you've already added that. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request #1602: CLOUDSTACK-9422: Granular 'vmware.create.full...

2016-07-04 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1602#discussion_r69485338 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java --- @@ -1353,6 +1363,20 @@ public void prepare

[GitHub] cloudstack pull request #1602: CLOUDSTACK-9422: Granular 'vmware.create.full...

2016-07-04 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1602#discussion_r69486019 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java --- @@ -1353,6 +1363,20 @@ public void prepare

[GitHub] cloudstack pull request #1604: improvement: systemvm slow operations

2016-07-05 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1604#discussion_r69583623 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py --- @@ -228,7 +228,7 @@ def processCLItem(self, num, nw_type): if('lo

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-07-05 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1604 @romain-dartigues do we know why the `arping` is failing? Ideally, if the vif is configured correctly, the arping should go through properly. If the `arping` fails, do we still know that the

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

2016-07-05 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1602 Thanks @serg38 my question is more along the lines of can this `fullClone`/ `linkedClone` functionality be extended to other hypervisors, in that case, we can make the code hypervisor agnostic. If

[GitHub] cloudstack issue #1586: CLOUDSTACK-9410 Data Disk shown as detached in XS

2016-07-05 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1586 agree with @yvsubhash. I don't see an need to set the name-label to `detached` the code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-07-05 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski I've fixed the problem where the volume was not being detached after the copy. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

2016-07-06 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1602 Thanks guys. The code LGTM based on the code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-07-06 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1604 Thanks @romain-dartigues based on your comments the code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-07-06 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1604 we do have to remember that arping is ipv4 only so we need to fix this for ipv6 too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-07-11 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski I think the `Destroyed` state should suffice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-07-13 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1600 Thanks @karuturi for your comments, I will get to them as soon as I have some free cycles. Right now this is only supported for XenServer as this requires the backend to be able to do native

[GitHub] cloudstack issue #1642: System VMs on Managed Storage

2016-08-17 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1642 @mike-tutkowski the code LGTM. We have a managed storage in-house. I will run it there and report if I see any problems. --- If your project is set up for it, you can reply to this email

  1   2   3   4   5   6   >