GitHub user swill opened a pull request:
https://github.com/apache/cloudstack/pull/1525
Status of tests
This PR is not meant to be merged, but instead be able to give a point in
time status of our current tests (on KVM).
I have just finished a 3 day run of all of our tests
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1525#issuecomment-216065039
And now for the files...
**Associated Uploads**
**`/tmp/MarvinLogs/2MVR8P:`**
*
[failed_plus_exceptions.txt](https://objects
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1351#issuecomment-216225603
@rhtyd & @DaanHoogland I don't have the ability to test this as I have a
KVM setup, can one of you post some test results using VMware?
---
If your proje
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-216226380
@kiwiflyer thank you. I will merge this today...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-216227189
I can prioritize CI on this one as it is ready otherwise. It is worth
doing a test run since a lot has happened since this was rebased. Thx...
---
If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-216228565
I think this is ready to merge. @remibergsma has shown screenshots to
verify the UI change does what it is supposed to and we have the LGTMs required.
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216231216
I will make sure this gets into 4.9 because I think it is really needed.
We do need one more LGTM on the code. Also, since this PR does have some
implications
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-216233168
@rhtyd in general, I agree with you. The main blocker with that is the
fact that very few people have the ability to test regional templates. The
code is pretty
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1526#issuecomment-216248435
You can close this PR. Once #1495 is merged, it will be forward merged
into 4.8 and master, so this PR is not needed. Thanks... :)
---
If your project is set up
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-216258261
Running CI now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-216266457
I think the two commits are fine in this case, so just leave it as it is.
ð
Can we get some LGTM code reviews on this one? Thanks...
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-216267457
@rhtyd is there a reason you want him to rebase to master? We still
support 4.7, so all fixes to that branch will be forward merged to 4.8 and
master. I think this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-216267768
I am also fine with these being separate commits as they are functionally
separate.
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-216270026
Squash yes, but this can remain open against 4.7 as we are still fixing
bugs and such against 4.7 and it is still supported (until 4.9 is released).
Anything merged
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-216274536
I think this one is ready to merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-216274944
@jburwell I will be doing a group of merges in a couple of hours which will
include this one. If you have any pending concerns with this one, speak up
soon
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-216273377
@remibergsma requires force push again. Travis timed out...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-216285170
How do I test this and verify it is working?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-216287103
I need some code reviews on this one. Also, @DaanHoogland you may have to
push again. Our lovely checkers are being annoying again...
---
If your project is set
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-216286395
We are missing one code review on this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216289074
@kiwiflyer do you have test results on this one? Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1490#issuecomment-216289492
We need more more code review on this one...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1488#issuecomment-216289908
Need to run CI against this one to verify...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-216291321
I don't have the ability to test HyperV. Can anyone verify this PR for me?
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1408#issuecomment-216293581
@wido is this code currently deployed and working in your prod environment?
@rhtyd any suggestions for validating this code before merge? Have you tested
this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-216294699
I need some code reviews here. @jburwell can you let me know what that
status of your review is?
---
If your project is set up for it, you can reply to this email
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-216296327
Missing one code review on this one. @rafaelweingartner? I saw you post
in this thread, so I am calling you out. :P
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216298669
No worries. Thanks... I also am a bit behind. I apparently have to just
assume I won't get any work done on mondays. :P
---
If your project is set up f
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-216300372
@rafaelweingartner This one seems to be in OK shape. I am missing one code
review, given that you have actively reviewed this code, can I get your final
status
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1330#issuecomment-216301175
We are still accepting bug fixes in 4.7 and 4.8, but all features should be
added to master. Anything merged into 4.7 or 4.8 will be forward merged up
through
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1321#issuecomment-216302010
All tests have passed on this and we have the required number of code
reviews. There are no merge conflicts, so I think we should be fine to merge
this PR as is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1490#issuecomment-216302867
I think this one is ready to merge given the scope of the change. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-216305760
@DaanHoogland thanks...
@sudhansu7 can you do a force push to kick off the travis run again so we
can get this PR green. Thx...
---
If your project is set
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-216306144
I am missing code reviews on this one...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1374#issuecomment-216307729
#1515 is going in today and then we will validate that this one and #1376
don't have merge conflicts once #1515 is in and they will follow right after...
-
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-216308956
@rafaelweingartner thanks for the review. :) I think what @rhtyd meant is
anything outstanding is only cosmetic, I don't think he meant the entire
discu
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-216309958
@jburwell no worries, I know how that goes. :) Thanks for your support
regardless...
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1463#issuecomment-216310118
Thanks @nvazquez, I think this one is ready now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1408#issuecomment-216319525
I am pretty comfortable with this because @wido is already using this. I
don't have an SG environment setup right now for testing, so I would have to
buil
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-216321608
@rafaelweingartner thanks. I understand completely...
I know the `final` stuff is debatable, but I don't think that should block
a PR. :)
I
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-216325329
We need another code review. How should I test this, does it have to be a
manual test?
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1374#issuecomment-216327688
@DaanHoogland this is opened against `master` though while #1515 is opened
against `4.8`, so the forward merge of #1515 will affect this one...
---
If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1374#issuecomment-216331189
@DaanHoogland I think this PR should probably be opened against the `4.7`
branch though in order for your point to be valid. Right?
---
If your project is set up
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-216333866
How should I test this? I think this is in a pretty good place pending
some verification...
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1374#issuecomment-216347252
@milamberspace I think that is probably the best option. Then I will merge
the new one (with these changes) first and forward merge and then merge #1515
and then if
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r61807823
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java
---
@@ -1363,24 +1364,15 @@ private Answer attachVolume
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1321#discussion_r61808445
--- Diff:
engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java ---
@@ -505,4 +513,24 @@ public void testSendStopWithNullAnswer
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1527#issuecomment-216371746
Previous PR was #1374, for book keeping...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216378613
Thank you @kiwiflyer. ð
@rhtyd can you force push this PR again to try to get Jenkins green?
Thanks... Otherwise this one is ready...
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216433479
Obviously this merge conflict exists because something has been refactored
in master which was not merged into previous versions. We need to understand
what was
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1321#issuecomment-216440946
Thanks @rhtyd. I will do a CI run on master before I merge anything else.
I will also pull in a couple people who I know have worked on this code to
review your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216441837
Thanks @rhtyd, this makes me feel a little more comfortable. @borisroman
if you can give us a bit of an outline of what you have tested, I think it will
help
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216442130
@rhtyd thanks for fixing the merge conflicts. ð
@GabrielBrascher and @mike-tutkowski, I know you guys have spent some time
with this file, would you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216541819
@mike-tutkowski, yes I think the change is expected. I just want some more
eyes on this since it did not go through the usual CI and code review channels
because we
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1525#issuecomment-21603
A few more details.
The full run took: `55h 59m 30s`
The following tests took longer than an hour to complete:
```
1h 01m 46s => /
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216559351
Great, thanks for the additional details @borisstoyanov. ð Once Rohit
and John are in agreement on the final details, I think we are ready to merge
this one
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-216560940
Thank you sir...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1304#issuecomment-216560467
Thank you @sanju1010, I will get this in for testing again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216572547
No worries @GabrielBrascher, I realized after I CCed you that you really
just fixed a typo. :) Thanks for the feedback...
---
If your project is set up for it
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-216573789
Since both Jenkins and Travis are green, I agree that we don't need to do
any further testing on this one.
I will give this a LGTM, can I get one
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-216575327
@nitt10prashant no problem. Thanks for the work. I just want to remind
you that the 4.9 release will be frozen on May 16th, so if you want to get it
into that
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-216576269
I was having problems with this in my CI, but I am still trying to
determine if it is my environment or not. I will try again once I get master
tested (since we
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1463#issuecomment-216576816
Yes, this one is ready. I just need to verify master is in a good state
before I continue merging into master. We had a merge conflict yesterday which
we resolved
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1485#issuecomment-216578573
My CI does not have the capability of testing this, so even if I ran CI it
would not cover this. I tend to agree that his is fine as is.
---
If your project is set
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-216581383
Perfect, this one is queued up to be merged... Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-216582523
Can you force push again to see if we can get Jenkins green. The errors in
Jenkins are not ones I am used to seeing, but Travis is green, so I suspect
that a force
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-216884149
Please force push to kick off travis again. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-216884501
BTW, travis is showing exceptions in OOBM now, so you probably want to
review those...
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-216885592
@wido can you rebase for me? We apparently have merge conflicts now.
Thanks...
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1455#issuecomment-216887066
@sanju1010 can you address @DaanHoogland's concerns?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1515#issuecomment-216889762
Please rebase this PR to fix the merge conflicts. Thanks... #1527 has
been merged into 4.7 and then forward merged to 4.8 and then master. Once the
merge
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1376#issuecomment-216889967
This PR currently has merge conflicts, but #1515 is next in line, so you
may want to wait till it is merged before you fix these conflicts.
---
If your project is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-216893135
Just as an update for everyone. CI ran against master with the merge
conflict fix and everything went smoothly, so we are all set. Thanks for the
help on this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-216893394
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 4h 28m 09s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-216893678
The one failure above is unrelated to this fix and pops up periodically in
my environment. Above is a passing CI result...
---
If your project is set up for it
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-216896697
@serg38, I just saw your communication with @koushik-das. I will let him
verify the fix you are working on and we will go from there. Thanks...
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217188537
Is there a reason we need to spend 5 minutes waiting for this test every
build?
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217188135
@rhtyd I am still having problems with the tests in this PR, but now it is
in master.
This is causing builds to fail...
```
testConnection
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r62207228
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,208 @@
package com.cloud.utils.testcase
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r62207167
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,208 @@
package com.cloud.utils.testcase
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217220334
@rhtyd but `totalTestCount = 5` and I don't think that `completedTestCount`
will ever be larger than `4`, so I don't know how that check could be right..
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217227191
In my lasts run, not a single test passed in the time frame something is
wrong. Previously it was failing on 4/5, but this time it timed out without a
single test
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217227342
Thanks, will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217252920
@rhtyd I have some bad news on this PR. I have been having issues in CI
ever since this got merged into master. When the tests don't run (and fail
which cause
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-217264750
@rhtyd we have merge conflicts. can you fix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-217268926
Thank you for working on fixing this. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-217269248
Can you do a force push to kick of Jenkins again. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1528#issuecomment-217269826
Thanks @mike-tutkowski. I will run CI against this one just to be sure we
did not break anything...
---
If your project is set up for it, you can reply to this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-217271201
So is this going to be another reason Travis fails randomly? :( If we
know it is going to fail randomly, we probably want to remove it from the
Travis tests to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-217272766
I confirmed that reverting this PR locally does fix my DeployDatacenter
issues.
I did an initial test with #1534 and it did get past the DeployDatacenter
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1534#issuecomment-217278185
Well the test runs a lot faster/cleaner now. ð
```
Running com.cloud.utils.testcase.NioTest
2016-05-05 22:53:54,828 INFO [utils.testcase.NioTest
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-217319127
OK. Sounds good. :) Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-217322125
@Slair1 is that confirmation that this code worked for you? It is a bit
unclear what you were communicating. Thx.
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1529#issuecomment-217323925
@dmabry thank you. This type of feedback is very useful for me (as the RM)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-217341007
@Slair1 perfect, thanks for confirming. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-217456452
I will get this CI'ed. I have 4 new CI boxes in play now, but I am trying
to figure out how to stabilize master, so I will run this as soon as I get
master s
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-217460449
Can I get one more code review on this one? Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-217471150
Unless someone is able to verify this, I think we have to take the
screenshots from @remibergsma as verification. Not very many people have the
ability to test
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-217471716
Can you do a force push again. Jenkins has been in this state for 3 days
now. Thx...
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1385#issuecomment-217471764
Can you do a force push again. Jenkins has been in this state for 3 days
now. Thx...
---
If your project is set up for it, you can reply to this email and have
901 - 1000 of 1169 matches
Mail list logo
