Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-204714215
@bhaisaab: whether or not we 'can' find a working configuration is not
really the point here. I don't think it is acceptable that we break support for
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-204985068
@kollyma Can you squash the commits for me and I will then merge this in.
Thanks...
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r58316653
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
---
@@ -484,6 +489,10 @@ public
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205047143
@abhinandanprateek would you mind rebasing to current master so I can test
this in my CI? Thanks...
---
If your project is set up for it, you can reply to this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1455#issuecomment-205111794
### CI RESULTS
**MULTIPLE FAILURES, NEEDS WORK!**
There are problems with this code. Here is a summary of the issues. I
have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205473828
### CI RESULTS
**HAS FAILURES, NEEDS WORK!**
Please accress the following issue
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205488087
I don't think there are any CI tests that will actually test this. Can we
assume the verifications that you guys have done is good enough? Also, I see
that Je
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205501305
I agree. I just want to make sure others agree with us...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205509785
I agree. @bhaisaab do you mind adding a Jira ticket for this just so we
have a record of it.
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1461#issuecomment-205615803
### CI RESULTS
**85/85 TESTS PASS**
Everything is looking pretty good from this side.
**Associated Uploads
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1444#discussion_r58480834
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/LibvirtComputingResourceTest.java
---
@@ -484,6 +489,10 @@ public
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1457#issuecomment-205883002
@rafaelweingartner I can run tests via KVM, but I don't have the ability to
run tests against VMware hardware. Are tests against KVM good enough in this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205885703
@abhinandanprateek: Thank you. I will run the whole set of tests against
it again tonight. I have to let the current tests finish and run this on its
own because I
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-205892559
@abhinandanprateek slight delay. I am going to blow away my CI setup and
reinstall it now to get it running on SSD drives so I can better parallelize my
tests
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1457#issuecomment-205892175
Perfect. Thank you both for verifying this. I probably won't be able to
get to testing this till tomorrow evening because I am about to reinstall my CI
to g
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1332#issuecomment-205926253
@syed can you squash the commits. This is best applied as a single commit.
Thx.
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-205937640
I will get CI run against this PR as soon as I have my CI reinstalled.
Thanks @mike-tutkowski
---
If your project is set up for it, you can reply to this email
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-206435758
I would like to get at least one code review with a LGTM before I merge. I
am pretty confident with the tests run. As long as we get 105 tests passing in
that CI
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-206440627
Just got my CI back up and running. I will be getting it running against a
few PRs ASAP.
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-206438944
@koushik-das Can you specify which functionality tests were broken by which
PR? Thanks...
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1316#issuecomment-206441793
@DaanHoogland you ran this against real hardware correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-206443694
yes, I can add that note. I will get CI run against this once I get
through my backlog a bit.
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1464#issuecomment-206458563
I don't have the ability to test vcenter. Is there anyone else who has the
ability to test vcenter who can post the test results of a CI run?
---
If your pr
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-206460206
I don't have the ability to test this. Would you mind running the
following tests to verify there are no issues in the setup once the DC has been
deployed and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1326#issuecomment-206462142
I think all of the tests that fail regularly have been removed from that
test suite now. I believe we need all those tests passing, so we should review
the failures
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-206466138
Ok, I understand what is going on here better. @DaanHoogland would you
mind reviewing this for us? Thanks...
---
If your project is set up for it, you can reply
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1254#discussion_r58776967
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaSummaryCmd.java
---
@@ -59,7 +59,7 @@ public QuotaSummaryCmd
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1461#issuecomment-206559157
@bhaisaab would you mind doing a `push -f` on this PR to kick off the
Jenkins job again so we can verify it is not failing before I merge. Thx.
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1316#issuecomment-206664435
I am not sure how that tests this code though. I have that same setup, but
I don't think I have the ability to test this configuration. Am I wrong?
---
If
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1363#discussion_r58813816
--- Diff:
api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java ---
@@ -77,7 +80,18 @@ public Long getServiceOfferingId
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1254#issuecomment-206684033
We have one LGTM and it is passing CI, is this ready to merge then?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1457#issuecomment-206921614
## CI RESULTS
**84/85 TESTS PASSED**
The only failed test is a test that often fails in my environment and is
unrelated to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-206925982
## CI RESULTS
### 84/85 TESTS PASSED
The only failed test is a test that often fails in my environment and is
unrelated to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1459#issuecomment-206927968
I have run CI against this PR, but I am not going to post the results yet
because I think my test environment likely influenced the results. I think I
am trying to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-206932399
I think this is ready pending a code review. Can someone who has spent
some time reviewing this PR with Mike please give me the go ahead on this PR
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-206935772
Hmmm, not sure how I feel about this. My inbox can't handle a whole bunch
of new findbugs issues. :)
@remibergsma would you mind giving me some guidan
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1316#issuecomment-206934467
Since this is a net new test that I do not have the ability to test and
because the tests that have been run are passing, I think this PR is ready.
Are we in
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1254#issuecomment-206936718
Thank you guys. I will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-206946085
@Slair1 can you please squash your commits. I will get this into my CI
queue so we can get this merged... Thanks...
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-206949345
@kiwiflyer they conflict in what sense? They change different lines of
code, so I don't expect git to have an issue with them. Can you clarify?
---
If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-206954412
Is there a way to manually kick off travis on a specific PR, or is the only
way to have the author do a `push -f`?
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1457#issuecomment-206958139
Based on @rafaelweingartner's code review and the CI results, I think this
is ready to merge.
---
If your project is set up for it, you can reply to this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-206963095
Thanks @bhaisaab, sorry to keep having you do that. I know it is just
semantics, but I want to avoid doing `--force` merges. I got your travis fixes
merged in
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1457#issuecomment-206978473
@rafaelweingartner Ya, ideally I would like to try to get two code reviews
for each PR. I try to do a quick code review on each, but with the number for
PRs I am
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-206981349
@DaanHoogland I have some issues with networking when using redundant VRs
in my environment. I consistently have this type of issue, and it is
unrelated to the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-206982108
@rafaelweingartner yes, I will be running CI on this when the merge
conflicts have been resolved. nothing should be committed to master without CI
run against it
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1453#issuecomment-206983175
haha, trying to be. it is turning into a full time job...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1457#issuecomment-207014015
@serg38 awesome, thank you. I will get this merged...
Yes, good new about Accelerite. I am very hopeful they will be able to add
value to the ACS community
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-207022111
I can't specifically test the VMware functionality, but I can validate that
it does not break anything else. I have added this to my queue for CI.
---
If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207062648
No worries. :) This should work:
https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207101177
No one is allowed to push code to `apache/cloudstack`, you have to push it
to your fork where your PR is coming from. Does that make sense?
---
If your project is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-207107811
## CI RESULTS
### 84/85 TESTS PASSED
The test that failed is a test that commonly fails in my environment and
has been
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-207109385
@abhinandanprateek tests have passed, thanks for the updates. Can you do a
`push -f` to kick off a Jenkins run so we can try to get this PR all green
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-207112861
Yes, I think this one is ready. I am trying to get two LGTM code reviews
on every PR, so can one of @DaanHoogland or @pdube give me a LGTM, I have one
from
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-207113402
@rafaelweingartner yes, I think this is ready too.
I am trying to get two LGTM for every PR, so can someone else from the dev
list give me a review?
---
If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207144084
Once you get your local branch setup correctly with the squashed commit,
you should be able to do a `push - f` to replace what is in the PR with what
you have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-207155639
No problem. Ya it took me a couple pull requests to figure out how they
work. Thanks for taking the time to do this for me. :)
---
If your project is set up for it
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1230#discussion_r59020704
--- Diff: engine/storage/snapshot/pom.xml ---
@@ -37,6 +37,11 @@
test-jar
test
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-207424478
It looks like I have two LGTM on this PR and the tests are passing. This
one is ready? Any final comments?
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1422#issuecomment-207510466
Yes, I think this is good. I will add it to the list of merges I will do
later today.
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1478#issuecomment-207533662
@Slair1 If you create a new PR or if a different PR solves the problem you
ran into, can you please post the PR number that replaces this one? This helps
me
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-207536244
Can you rebase and give me a squashed commit for this?
Also, regarding the code. I have seen a lot of people cleaning up code to
remove the `_` in front of
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-207537254
Just for the future reference. If you want to kick off the rebuild of a
PR, you can do a `push -f` which will trigger a new build even if the code did
not change in
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207539579
Can you squash your commits and do a `push -f` to update your branch so
this gets merged as a single commit?
This does not change anything that could fail
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-207542455
I have not seen a style guide, but I have not looked. I have just seen a
bunch of PRs recently and there seems to be a consistent work to remove the
`_`s in the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-207551688
Oh, I understand. Thanks... :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-207553542
@syed I have not looked into this. Is it possible for us to improve the
test so it actually tests that the VPN works?
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-207555946
@syed can you squash the commits please and do a `push -f` to update the PR
branch?
Do you have any feedback for @kollyma if he is seeing a similar issue as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-207591089
I saw travis failing with this earlier. I will see if I can figure out
what is going on. Thx...
---
If your project is set up for it, you can reply to this email
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1466#issuecomment-207624970
Thank you very much for the quick follow up on this, it is greatly
appreciated. :+1: I will review the linked PR.
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207625716
@bhaisaab thanks for doing this. I suspect the travis run will fail so I
will have to break my own rule and force merge. :) I will wait for it to
finish
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207627057
Thank you @kiwiflyer. Once Jenkins finishes I will merge this since we
have the code reviews we need and there is no logical changes that need to be
tested (since
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207628400
Yes, that is what I plan to do. I just saw a different squash commit
complete successfully, so it seems that travis is not 'always' failing, even
tho
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207631157
I will have to think about that a bit. I think it would be valuable, but I
have to get my head around if there are implications in doing that. Are
there any
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1481#issuecomment-207631254
Ya, probably a good discussion to take to dev@.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-207714662
@kiwiflyer Jenkins is failing. Not sure how the error could be related to
your code changes, so can you do a `push -f` again to kick it off again.
Here is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-207917699
thank you sir. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-208322941
@kiwiflyer Sorry to do this to you, but would you mind squashing your
commits and doing a `push -f` again? Thanks...
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-208326140
I am going to add this to my CI queue. Please reconfirm the LGTM's votes
based on the updated code. Thanks...
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-208328877
Can I get the commits squashed and repushed with `push -f`. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208330435
@DaanHoogland do you know what is going on with jenkins in this case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-208347246
Some history is fine, but we don't need the whole history for every change
in master.
I don't think this adds much by adding it to the master c
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-208361233
@NuxRo asked that I review this. @DaanHoogland I see you opened this,
would you mind rebasing. I suspect it is still valid considering the fact that
not a huge
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-208504591
So my understand is there was a FindBugs issue originally. In the process
of fixing the issue, some logic was changed to introduce an issue. This commit
is to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-208521278
We still need LGTM code reviews for this PR and I will add this to my queue
for CI. Thanks...
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1263#issuecomment-208535036
@GabrielBrascher yes, this is something that we are trying to work through.
We have updated the source to give more verbose logging so we can better
understand the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-208578340
Can I get some code reviews on this PR? I have added it to my CI queue...
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1473#issuecomment-208579265
Can I get one more person to give me a LGTM on this? I am confident with
the tests provided for this change and I will count my LGTM review on this PR.
---
If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1473#issuecomment-208579371
@remibergsma can you give me a `push -f` on this to try to kick off Jenkins
again. Thx...
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1471#issuecomment-208581097
This seems like a reasonable change to me. I am guessing 2 seconds is long
enough, but I don't really understand what other variables could add contention
and
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1470#discussion_r59290164
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/facade/AbstractConfigItemFacade.java
---
@@ -104,13 +109,25 @@ public static
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-208590690
I will add this to my CI queue. Do we want to maintain commit history for
the two commits in this case?
Also, I am looking for code reviews on this one
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208591476
Can you either close and reopen or do a `push -f` to try to kick off
travis. I am confident in this PR, but I want everything green before we
merge... Thank you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1479#issuecomment-208676729
@kiwiflyer woohoo!!! thank you for all the support on this. i will merge
this in the morning with my next batch.
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1475#issuecomment-208891268
Isn't there references to these files? Forget the ones in `target`, but
the references in `cloudstack/scripts/installer/windows/client.wxs` should
probab
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1487#issuecomment-208907818
@DaanHoogland I already ran tests against this one as #1449. I am planning
to merge this today...
---
If your project is set up for it, you can reply to this email
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-208909441
I am not sure what is going on with Jenkins and Travis now days, but they
are being very flaky. Maybe the added load of people being more active is
messing with
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-208914356
Do we have any assurances that this works and does not break anything? Do
we need to run CI or how do we validate this?
---
If your project is set up for it, you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-208915830
@DaanHoogland for the test that often fails in my environment, check
@remibergsma's comments here:
https://github.com/apache/cloudstack/pull/1449#issueco
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-208922778
I would like to get the LGTM from @remibergsma and @pdion891 before I merge
this. Thanks for all the hard work @jayapalu..
---
If your project is set up for it
601 - 700 of 1169 matches
Mail list logo
