Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218804870
Thanks guys. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-218805790
@mike-tutkowski can you rebase this PR as we now have merge conflicts. Can
you review the recent comments and I will get this queued up to get CI run
against it as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218806166
@marcaurele I have merged fixes to Jenkins and Travis, can you force push
again to kick off those runs again. Sorry for the inconvenience, hopefully
this is the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-218806800
@SudharmaJain please rebase as we now have merge conflicts. Ideally we
would have some verification that this works as expected. I don't have the
ability to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-218807140
@sudhansu7 I pushed fixes to Jenkins and Travis this morning. Can you
please force push again so we can get this green. Thanks...
---
If your project is set up
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1455#issuecomment-218807584
@sanju1010 we have merge conflicts now. Can you please rebase against the
current master. Thanks...
---
If your project is set up for it, you can reply to this
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1376#issuecomment-218808022
@milamberspace can you do a force push again. I have pushed fixes to
Jenkins and Travis this morning, so with a new push we should be able to get
this green. Thx
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-218808523
@syed can you force push this one again to see if we can get Jenkins to
pass now. We have fixed some issues with Jenkins and Travis this morning.
Thx...
---
If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-218810209
@DaanHoogland can you force push as we should have fixes for Jenkins and
Travis in place now. If we can get some final verification on this one then we
can get into
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1464#issuecomment-218810586
anyone able to pick this up for validation and giving me a final code
review???
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-218811415
@remibergsma sorry to do this to you again. can you force push again. I
have pushed fixes to jenkins and travis this morning so hopefully we can get
this all green
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-218811089
@ustcweizhou can you force push again so we get this PR all green. We
pushed some fixes to jenkins and travis this morning, so we should be good with
a force push
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1436#issuecomment-218813851
@sanju1010 can you please review this? I am not worried about the issue
with `` because I have verified that issue already existed. However, the
following problem
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-218836777
Thank you @SudharmaJain. Is there anything you can provide to show this
works as expected? Screenshots or something? I don't have the ability to CI
this,
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-218838385
Can I get another code review so this can be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1456#issuecomment-218838201
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 4h 19m 54s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1491#issuecomment-218838753
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 2
Errors: 0
Duration: 4h 19m 11s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1491#issuecomment-218838932
Can I get some code review on this PR? Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1450#issuecomment-218839655
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 8h 34m 12s
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1450#issuecomment-218839846
Can I get some code review on this one? Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-218842214
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 9
Errors: 10
Duration: 10h 09m 15s
```
**Summary of
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-218842740
@dsclose we have merge conflicts on this one now. Also, prior to merging
the PRs that caused the conflicts, I ran the above CI. You will probably want
to review
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-218844537
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 2
Errors: 0
Duration: 9h 17m 35s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1460#issuecomment-218844975
I think this one is ready...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/985#issuecomment-218846952
This failed during compiling:
```
[INFO] Apache CloudStack Plugin - Hypervisor KVM . FAILURE [11.036s]
```
Here is the error
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1491#issuecomment-218858373
yep, sounds good...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218861696
I see the following error which is causing the PR #1297 to fail.
Suggestions
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-218867747
Can we get screenshots or something to verify this works? Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1538#issuecomment-218868153
@rhtyd Can you re-push now that we have fixed the issue that is failing in
travis? Thx...
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-218869670
This PR currently have merge conflicts. Can you rebase please? Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1269#issuecomment-218869828
Can I get some code review on this? Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218875130
Jenkins for #1537 is also being held up by these tests:
```
---
T E S T S
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218879748
Sorry to do this to you again @marcaurele. Can you rebase and force push
again. I have disabled the test in `master` that was blocking this in Jenkins
because we
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1538#issuecomment-218879096
I have forced pushed this because it is blocking other PRs that are only
pending Jenkins and Travis and since we are so close to freeze date, I don't
want stu
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1543#issuecomment-218947527
Thanks for the fix @rhtyd and for testing this @kiwiflyer. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1543#issuecomment-219071379
Most of these things are fixes to Jenkins and travis issues, so those jobs
being green is good validation of the fixes. The main functionality change has
been
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-219073755
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 4h 18m 48s
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-219074192
@syed can you force push or close and reopen the PR to kick off travis and
jenkins? I think this one seems to be in a pretty good state now...
---
If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219074669
I will rerun CI on this now. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219077134
@kiwiflyer thanks, I will run CI against it as well. It is good to have CI
posted as well as manual verification. that gives us the most confidence that
everything
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-219079650
Thank you for your patience sir. ð I will get this merged...
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-219081336
@ustcweizhou would you mind doing a force push or close and reopen this PR
to kickoff jenkins so we are all green when @kiwiflyer posts his test results.
This will
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-219082129
This one is looking pretty good. Can we get some code review on it so we
can move it forward. Thanks...
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1503#issuecomment-219082695
### CI RESULTS
```
Tests Run: 82
Skipped: 0
Failed: 0
Errors: 3
Duration: 8h 28m 52s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1503#issuecomment-219083712
I have never seen these test failures before, so I believe they are somehow
related to this change. @olivierlemasle can you review the CI results and post
your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1513#issuecomment-219084090
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 0
Duration: 9h 01m 07s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1513#issuecomment-219084969
@insom, @dmabry and @kiwiflyer, the CI failure seems like it could be
related to this change, but I can't be sure. Can you guys provide some
guidance since a
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-219086756
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 9h 17m 55s
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-219087700
The CI does not cover the actual code, but instead makes sure nothing else
is broken by these changes. The test results provided by @nlivens show the
tests for the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219088009
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 9h 21m 07s
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-219088252
This one is coming back with a clean bill of health. I think we are ready
on this one. Can I get some code review? Thanks...
---
If your project is set up for it
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1513#issuecomment-219091474
@insom yes, I tend to agree with you. the main reason I highlighted it was
because the error was network related and the code changed details related to
an
Github user swill commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/38#issuecomment-219092042
Thanks for taking care of this @rhtyd. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-219093207
I am counting my own code review on this one given the scope of the change
and the fact that a review is the only thing holding this up. I will merge
this one
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-219093988
I will run this through my KVM CI right now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1543#issuecomment-219095904
Thanks for the effort stabilizing Jenkins and Travis the last few days.
This has been super helpful as we get close to the freeze. Very much
appreciated. Most of
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/798#issuecomment-219096839
@maneesha-p can you rebase and push so we can get this PR green? I would
love some code review as well. Thx...
---
If your project is set up for it, you can reply
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1543#discussion_r63215404
--- Diff: test/integration/component/test_acl_listvolume.py ---
@@ -357,9 +357,9 @@ def tearDownClass(cls):
cls.apiclient = super
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1543#discussion_r63215625
--- Diff: test/integration/component/test_acl_listvolume.py ---
@@ -357,9 +357,9 @@ def tearDownClass(cls):
cls.apiclient = super
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-219100429
This one errored again in both Jenkins and Travis. Not sure if that
signifies an actual problem or if things are just acting up. I fix to some of
the issues in
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1521#issuecomment-219101062
We have merge conflicts on this one. As soon as the merge conflicts are
sorted out, I will run CI against it and hopefully we can get some code reviews
quickly so
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-219104928
Ya, I like this. I think this is a nice advancement. If we are going to
try to get this into 4.9, I will need some help getting this moving forward
cause we are
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-219105793
Awesome, thanks guys. I will merge this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1513#issuecomment-219109520
Holy errors batman!!!
It looks like it started like this:
```
[INFO] --- cobertura-maven-plugin:2.6:instrument (default-cli) @
cloud-server
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-219123470
I think we should merge this one at this point. @sverrirab my
understanding is that once #1533 is merged, this will be required. If that is
the case, when this one
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1503#issuecomment-219126476
I am running my CI against it again to make sure this does not pop again.
If it doesn't then I will merge it right away as Jenkins and Travis are green.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/669#issuecomment-219129109
Thanks @anshul1886. Keep in mind that the freeze date for 4.9 is Monday
next week.
---
If your project is set up for it, you can reply to this email and have your
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-219130130
@SudharmaJain can you re-push or close and reopen this PR to kick off
Jenkins again?
@rhtyd and @nvazquez I know you both use VMware. I don't have a w
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-219134524
@rhtyd I can run CI on this, but it is based against 4.6. I am not sure
what to do about that. Should @ustcweizhou at least rebase against 4.7 so we
can get it in
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-219137064
I have tried to CI this PR a couple times. I get the following during
Deploy DC.
```
Deploy DC Started
Exception Occurred :['Traceback
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1241#issuecomment-219137690
@kansal can you close and reopen for do a force push to try to get Jenkins
green. I am not sure what to do about this PR because I don't know that I have
a w
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-219141565
I think we are ok on this one. thanks @rhtyd. I will merge this one...
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-219150983
@syed failed again. :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-219160164
Ok, we need one more review on this.
tag:needsreview tag:needreview
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-219168493
Please verify why the jobs are failing and re-push this PR to try to get it
green. I need to verify the process to test new system templates and how to
build and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-219168754
ok, thank you sir. ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-219169003
That is fine, I don't mind doing that. Is that the process here? This is
the first time I have handled a 4.6 PR. Will a 4.6 ever be released, or is
that jus
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-219169448
Ok, what I will do is merge it into 4.6 and forward merge it to 4.7 and
then run CI on it there. I also need to verify what is forward merged from 4.6
because I
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-219412742
@kiwiflyer & @dmabry for testing, I merged this into 4.7 in my lab and then
forward merged it to 4.8 and ran CI there. Everything came back clean. How
has
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219413266
### CI RESULTS
```
Tests Run: 57
Skipped: 0
Failed: 4
Errors: 14
Duration: 5h 15m 07s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-21941
As you can see, I am still having a hell of a time with CI on this one. :(
---
If your project is set up for it, you can reply to this email and have your
reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219415201
Looks like travis is complaining. Not sure why...
```
==
ERROR: test suite for
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/866#issuecomment-219415944
@bvbharatk this PR has merge conflicts. Can you rebase and fix the merge
conflicts and re-push? Thanks...
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219450328
Man something is up with Jenkins now days. We have a completely different
set of errors now. There seems to be two or three different situations that
different PRs
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219462622
I will run CI against it again today to see if it was an issue with that
environment.
---
If your project is set up for it, you can reply to this email and have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1536#issuecomment-219494283
I just realized this one changes the system vm. Did you deploy a new system
VM when you tested this one @DaanHoogland?
---
If your project is set up for it, you can
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1536#issuecomment-219497791
So does this change require that we push new system VM templates?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1536#issuecomment-219499886
So far I don't think any of the other changes that have gotten in have
required system template changes. Which is why I am asking. There is one that
I thi
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-219536627
@dsclose can you rebase and re-push this PR to try to get it green. We are
down to the wire now. I will probably merge some PRs that only have jenkins
failing if
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-219537584
@remibergsma would you mind rebasing and re-pushing? We don't have the
reason why Jenkins failed, but Travis passed, so I am considering making a
judgment ca
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-219538622
@SudharmaJain can you rebase and push to see if we can get this green for
the 4.9 freeze...
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-219538895
@sudhansu7 can you rebase and push to see if we can get this green before
the freeze? Thx...
---
If your project is set up for it, you can reply to this email and
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1513#issuecomment-219537126
@insom we are down to the wire here. I would like to see if we can get
this green and merge it before the freeze. Can you rebase and push again to
kick the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1455#issuecomment-219539120
@sanju1010 we have merge conflicts now. Can you please rebase against the
current master. Code freeze is basically now, so if you want this in we need to
get busy
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1424#issuecomment-219539528
@syed can you rebase and force push this one? Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-219540048
@DaanHoogland can you rebase and push this one again to see if we can get
travis to finally pass? thx...
---
If your project is set up for it, you can reply to
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1464#issuecomment-219540711
This one is pretty much ready, but without verification that it works and
without the required code reviews I can't really justify merging it. I just
don'
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1486#issuecomment-219541268
This one is ready to merge. I would love another code review on this one
as it is green and the CI is clean...
---
If your project is set up for it, you can reply
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-219546552
there were a couple fixes to jenkins and travis in a commit a few days ago,
so i wanted to make sure those fixes were in the code base when you pushed. I
am
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-219551825
I think I am going to have to revert this PR because it seems to be
responsible for the `addHost` issue I am having in all my CI environments while
doing DeployDC
101 - 200 of 1169 matches
Mail list logo
