[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-21 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @jburwell That was default behavior for few years to allow deletion of the template even if active VMs exist. Deletion of the template on secondary doesn't remove the template copy on pr

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar A part is still missing that will use forced option in UI but give a user option to cancel deletion if active VMs exist --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar Well. API use cases can be recoded but not UI. Presently we can delete templates in UI even with active VMs. With your changes there will be no recourse. An easy option will be

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi @anshul1886 Can we tweak line 278 of test_snaphsot.py from self.services["nfs"], to self.services["nfs2"], and re-merge this PR so it d

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 @karuturi I agree with @nvazquez . This PR can be safely merged and then B.O. runtime environment needs to be adjusted to define nfs2 mountpoint in test_data.py --- If your project is set up

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @borisstoyanov @rhtyd Can we re-test this with B.O. ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

2017-02-23 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1958#discussion_r102753237 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -508,7 +507,7 @@ public String updateConfiguration(final long userId

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rafaelweingartner Can you review latest updates from @nvazquez . Since tests are passing this PR will be ready for merging to 4.10 --- If your project is set up for it, you can reply to this

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-26 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rhtyd @karuturi To fix errors in B.O in test_02_list_snapshots_with_removed_data_store we need to merge PR1961 and then adjust test_data on B.O side to have correct mapping for nfs2 label

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-28 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 Thanks @priyankparihar . We verified in our environment that all is working fine including UI part. LGTM I think this one is tag:mergeready --- If your project is set up for it

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-28 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @rhtyd @borisstoyanov @DaanHoogland Can we get B.O. management server log to check why exception is generated? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-01 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r103719599 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -3614,6 +3604,26 @@ public UserVmVO doInTransaction(TransactionStatus status) throws

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-03-01 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1774 @borisstoyanov That would be awesome . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-02 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Can you kick off B.O for Vmware again? Hopefully it will pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-03 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 @rhtyd @borisstoyanov did you have a chance to add nfs2 test data in B.O. ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-03 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 Still fails but error is different now Exception: Job failed: {jobprocstatus : 0, created : u'2017-03-03T09:20:53+', jobresult : {errorcode : 530, errortext : u'Unable to

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-05 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Thanks. Can you check in B.O. what is value of global configuration 'vmware.create.full.clone', if the same configuration is set for the primary storage pool and if

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-06 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 LGTM tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1989 @abhinandanprateek I am curious if this PR will allow deploying VM with Data disk attached? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2017-03-06 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1879 LGTM @nvazquez Can we test it with shared networking? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-03-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1774 LGTM tag: mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #793: CLOUDSTACK-8827: Move the VM snapshots stuck in trans...

2017-03-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/793 @anshul1886 I am curious if there is a way to cancel stuck vmsnapshot jobs without restarting management server. E.g. VM deployment go to error start upon any failure in the process. --- If

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-08 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @mike-tutkowski @karuturi @koushik-das @rafaelweingartner Please review the fix for 4.10 blocker --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-08 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez Should we simply replace storage_tag_view instead of switching queries over to another view? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez Is storage_tag_view still in use after this change that reference old way of retrieving the tags? If not should we remove it? E.g. host tags don't have a separate view. --- If

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov @rhtyd Can you kick off new round of tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @rhtyd @borisstoyanov Can you kick off new tests for this release blocker? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-10 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r105409367 --- Diff: test/integration/component/test_rootvolume_resize.py --- @@ -0,0 +1,1140 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @priyankparihar I think we need to improve smoke test test_deploy_vm_root_resize.py and introduce the logic you implemented in component test test_rootvolume_resize.py. We would want smoke

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @mike-tutkowski Can you test this fix in your environment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-12 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @sadhugit NFS supports root disk resize with full clones. I don't see any restriction in the code and it actually works on Vmware no matter what kind of underlying storage technology is use

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-03-12 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1257 @sureshanaparti I've been thinking if there is better way to re-sync all portgroups and I couldn't come up with easy alternative. With that said if we are copying portgroups for newly

[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

2017-03-12 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1253 @sureshanaparti Why don't we just remove Config for this setting and leave default to be 8? Your logic to handle v4.1 will take care of old installations. As of May 2016 Vsphere 4

[GitHub] cloudstack issue #2002: CLOUDSTACK-9831: Previous pod_id still remains in th...

2017-03-13 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2002 @sudhansu7 Shouldn't we update POD id upon a successful migration? If migration fails we will have wrong POD id in the DB. --- If your project is set up for it, you can reply to this emai

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-14 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r105932339 --- Diff: test/integration/smoke/test_deploy_vm_root_resize.py --- @@ -114,7 +114,13 @@ def test_00_deploy_vm_root_resize(self): # 2. root

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-20 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez Looks like Travis cant SSH into management server during the test . 2017-03-17 19:26:58,672 - DEBUG - mount -t nfs nfs:/export/automation/1/testprimary /mnt/marvin-1b4190cb

[GitHub] cloudstack issue #2017: CLOUDSTACK-9847 vm_network_map is not getting cleane...

2017-03-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2017 @SudharmaJain Isn't it duplicate to PR1613 that is already merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

2017-03-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2019 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @cloudsadhu Thanks for the changes. LGTM on the code review. @borisstoyanov @rhtyd @DaanHoogland Can you kick off another round of test for vmware and Xen for this PR ? --- If your project is

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-28 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Can you also kick off vmware test in parallel? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-28 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r108580807 --- Diff: test/integration/smoke/test_deploy_vm_root_resize.py --- @@ -114,36 +134,46 @@ def test_00_deploy_vm_root_resize(self): # 2. root

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-30 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @priyankparihar Fortunately those API are already written. As per PR1767 you can get VM details including rootdiskcontroller using listVirtualMachines API and listTemplates. So if we are

[GitHub] cloudstack issue #2002: CLOUDSTACK-9831: Previous pod_id still remains in th...

2017-03-30 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2002 LGTM on the code review. @borisstoyanov @rhtyd Can you kick off tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-04-05 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Let's re-run vmware B.O test for this PR now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2017-04-13 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1836 @rhtyd @karuturi This is a new improvement introduced in PR1941 that allows volume and VM snapshots to coexist. Now, test test_01_test_vm_volume_snapshot in test_vm_snapshots.py needs to be

[GitHub] cloudstack issue #2043: CLOUDSTACK-9876: Removed test test_01_test_vm_volume...

2017-04-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2043 LGTM on the code change. @borisstoyanov @rhtyd @DaanHoogland Can we re-kick vmware test for this PR? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2017-04-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1762 @yvsubhash Please, take this up. So far this PR hasn't moved forward. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack issue #2044: CLOUDSTACK-9877 Cleanup unlinked templates

2017-04-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2044 @DaanHoogland Can you clarify few questions/concerns 1. This change will likely to break restoreVirtualMachine functions. At the very least users should be able to turn off new behavior with

[GitHub] cloudstack issue #2044: CLOUDSTACK-9877 Cleanup unlinked templates

2017-04-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2044 @DaanHoogland Thanks. But for #1 the requirement for the code changes is that the template is deleted from cloudstack. In this condition restoreVirtualMachines when template ID is not specified

[GitHub] cloudstack issue #2044: CLOUDSTACK-9877 Cleanup unlinked templates

2017-04-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2044 @DaanHoogland Not for us since we still use link clones but I am sure tons of other might be affected. Interestingly enough that with PR 1773 merged the default behavior in API is not to allow

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

2016-01-25 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-174554271 Unfortunately NFS version negotiation doesn't work properly with all storage vendors. Some vendors e.g. Tintri require that vers=3 is supplied in mount co

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

2016-01-25 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-174746870 I believe the main reason is to provide the most of backward compatibility. image_store_details doesn't have NFS version in existing installations so after

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

2016-02-16 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-184799968 Hi committers, Can someone perform a second review and merge it at the earliest? We would like this to be part of 4.9? --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-9252: Support configurable NFS...

2016-02-17 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1361#issuecomment-185256350 If requirements to use particular NFS version is known beforehand it can be specified during the image store creation using details argument details[0].key

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-12-06 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-162319994 Since you are testing L3 connectivity existing switch patch to router shouldn't overlap an ip range used by the new subnet. Cidr #1 should work fine . You

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-12-07 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-162532791 This index comes from schema-40to410.sql: CREATE TABLE `cloud`.`nicira_nvp_router_map` ( `id` bigint unsigned NOT NULL AUTO_INCREMENT COMMENT &#x

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

2015-12-10 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-163684761 Assuming everything else is ready e.g. service controllers, transport zone, management server, STT tunnels in-between then to create L2 gateway (page 89 of the User

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-05-11 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218466672 @swill Last Travis run for this PR was a success for test_list_ids_parameter. Which PR gives an issue? Marvin Init Successful === TestName

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-05-11 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218480013 The issue that it couldn't find a snaphsot because it is already cleaned by account cleanup. +cls._cl

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

2016-05-11 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218543261 @swill PR1539 passed Jenkins and Travis. After you merge it should resolve the issue in other PRs --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8830 - [Vmware] VM snapshot fa...

2016-05-13 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/798#issuecomment-219067011 It would be nice if this is resolved. The issue still exists in 4.9 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-13 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-219154273 This doesn't seem to be related to this PR.Can you post managment-server.log extract around the failure time? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-16 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219468957 @remibergsma In some private cloud environments nested virtualization is not a good fit so it is generally disabled. That's fine but we found that it would be

[GitHub] cloudstack pull request: CLOUDSTACK-9379: Support nested virtualiz...

2016-05-16 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1542#issuecomment-219473209 @remibergsma, @DaanHoogland Current global support for nested virtualization is only vmware specific and done in VmwareGuru. Are you proposing to move the

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

2016-05-20 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-220652018 @swill Travis passed. Looks like it is ready to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request #1593: CLOUDSTACK-9417: Usage module refactoring

2016-06-19 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1593#discussion_r67618240 --- Diff: usage/conf/log4j-cloud_usage.xml.in --- @@ -48,7 +48,7 @@ under the License

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-06-19 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @jburwell If no sanity-check-last-id is present it will run Sanity on the whole cloud_usage data set and then create a new sanity-check-last-id file. The whole part of sanity checking related to

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular VMware vms creation as ful...

2016-07-04 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @syed. On Vmware using link cloned was a default behavior. The primary use cases are: - storage saving if underlying arrays don't support deduplication - speed of the deployme

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

2016-07-04 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @syed. The default behavior won't change. The proposed enhancement will add an ability to control link/full clone deployment of a primary storage level. If it is not defined there a cu

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

2016-07-05 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @syed. Absolutely it can although the effort seems to be well beyond and scope of this PR. @nvazquez and I have only access to vmware hypervisors at this point. If there is an interest to expand

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-08-04 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1615 Ping for second review -- @GabrielBrascher, @rhtyd, @wido, @rafaelweingartner --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-04 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 Ping for review -- @sateesh-chodapuneedi, @rhtyd, @koushik-das --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-12 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1542 @rafaelweingartner That's correct. At this point advanced VM details and advanced template details have no UI exposure. At some point we can bring in PR to show this in UI and allow API

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1615 @jburwell Are there any outstanding issues with this PR? It is waiting for second LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 @rafaelweingartner @swill Will you be able to review this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1602 @jburwell Are there any outstanding issues with this PR? It is waiting for second LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @karuturi @jburwell There are 2 LGTM in this PR. Packaging, Travis and Jenkins all passed. Can this be merged? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1560 @rafaelweingartner @jburwell @rhtyd @koushik-das Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1542 @jburwell @rhtyd @koushik-das Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @jburwell LGTM for the test part. This PR was extensively tested on Environment: RHEL 6 management servers, Vmware ESX5.5 and 6.0 with advanced networking --- If your project is set up for

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-08-17 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1615 @jburwell Support for NFS version for Secondary storage is already merged via PR 1361. Since there were integration tests developed and executed over there we seem to be needed tests only for

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

2016-08-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1651 Debian returns: 1 packets transmitted, 1 packets received, 0% packet loss CentOs returns: 1 packets transmitted, 1 received, 0% packet loss, time 4ms Between those 2 we could be

[GitHub] cloudstack pull request #:

2016-08-22 Thread serg38
Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/commit/db854a35790c77099e9f82a4e2dd77edd5be3eed#commitcomment-18732552 Don't you need to put a space in from of 0 to exclude e.g 100% packet loss ? --- If your project is set up for it, yo

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Im...

2016-08-22 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1605#discussion_r75796954 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2042,49 +2043,46 @@ protected void

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 @jburwell The support for passing vGPU parameters is already implemented via PR1310 which has a test case. This PR is only performance optimization by reducing an extra reconfgtask which save

[GitHub] cloudstack issue #1650: fix macchinina template specificied for vmware in Ma...

2016-08-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1650 We tried macchinina template during test cases on ESX with E1000 adapter and VMs doesn't come with eth0 causing test_internal_lb.py and test_vpc_vpn.py to fail on a real hypervisor test

[GitHub] cloudstack issue #1656: CLOUDSTACK-9466: Fix fk constraint failure in upgrad...

2016-08-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1656 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1657: [lts/blocker] CLOUDSTACK-9467: Add symlink to key fi...

2016-08-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1657 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd Confirming. No issues on usage and management servers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Fix for test_network_acl,...

2016-08-24 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 LGTM for the test. Exception in network_acl_test **before the fix** [root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//NB313W/results.txt Test network ACL lists and items in VPC

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Fix for test_network_acl,...

2016-08-24 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 Also we wrote a tester for SshHelper.sshExecute method. It was returning output of SSHexecute command as it gets received by sshExecute. Here they are 100 sequential runs (success if result is

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-08-24 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1605 LGTM for testing. Vmware ESX 5.5 and 6.0 hypervisors, advanced networking, RHEL 6 management servers [root@ussarlabcsmgt41 ~]# cat /tmp//MarvinLogs/test_volumes_930LZ3/results.txt|grep

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-25 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 LGTM with smoke testing. RHEL 6 management servers, advanced networking, Vmware 5.5 .and 6 hypervisors [root@ussarlabcsmgt41 smoke]# cat /tmp//MarvinLogs/test_volumes_340FH1

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

2016-08-26 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1651 LGTM for testing Before sshClient: DEBUG: {Cmd: ping -c 3 8.8.8.8 via Host: 10.140.12.103} {returns: [u'PING 8.8.8.8 (8.8.8.8) 56(84) bytes of data.', u'64 bytes from 8.

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

2016-08-29 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 @jburwell With this PR test_network_acl is successfull [root@ussarlabcsmgt41 Aug_23_2016_16_49_32_8HYYKG]# tail results.txt Test network ACL lists and items in VPC ... === TestName

[GitHub] cloudstack issue #1660: CLOUDSTACK-9470: [BLOCKER] Bug in SshHelper affectin...

2016-08-29 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1660 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-29 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1593 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...

2016-08-29 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1560 @rhtyd @jburwell Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

  1   2   3   >