[GitHub] cloudstack pull request: add DHCP lease folders for Ubuntu

2016-05-18 Thread romain-dartigues
GitHub user romain-dartigues opened a pull request: https://github.com/apache/cloudstack/pull/1552 add DHCP lease folders for Ubuntu Add "/var/lib/dhcp/*" to the search path for Ubuntu; tested under Ubuntu Precise and Trusty, not yet with newer releases. You can

[GitHub] cloudstack pull request: systemvm - Python code cleanup

2016-05-31 Thread romain-dartigues
GitHub user romain-dartigues opened a pull request: https://github.com/apache/cloudstack/pull/1575 systemvm - Python code cleanup While debugging an issue on the System VM (to be reported later once we will have validated it behaviour); I took the opportunity to make some minor

[GitHub] cloudstack pull request: systemvm - Python code cleanup

2016-05-31 Thread romain-dartigues
Github user romain-dartigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1575#discussion_r65191566 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/set_redundant.py --- @@ -1,47 +0,0 @@ -#!/usr/bin/python --- End diff

[GitHub] cloudstack pull request: systemvm - Python code cleanup

2016-06-01 Thread romain-dartigues
Github user romain-dartigues commented on the pull request: https://github.com/apache/cloudstack/pull/1575 Thank you @wido for pointing it. Some problems are still present in #1547; should I wait it to be merged to redo the patch on top of it or do you have other suggestions

[GitHub] cloudstack issue #1575: systemvm - Python code cleanup

2016-06-11 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1575 Sorry, I missed your post and I'm not sure @swill question was addressed to me, but if it's the case: this is purely code cleanup and a few bugfixes (only due to ty

[GitHub] cloudstack pull request #1603: Vrouter fixes pylint

2016-07-05 Thread romain-dartigues
GitHub user romain-dartigues opened a pull request: https://github.com/apache/cloudstack/pull/1603 Vrouter fixes pylint In my dreams, all Python code pass through pylint and must validate before a merge. This merge request is becoming quite big, maybe too much; I'd li

[GitHub] cloudstack issue #1575: systemvm - Python code cleanup

2016-07-05 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1575 As suggested by @wido, rebase + new pull request in #1603. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #1575: systemvm - Python code cleanup

2016-07-05 Thread romain-dartigues
Github user romain-dartigues closed the pull request at: https://github.com/apache/cloudstack/pull/1575 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1604: improvement: systemvm slow operations

2016-07-05 Thread romain-dartigues
GitHub user romain-dartigues opened a pull request: https://github.com/apache/cloudstack/pull/1604 improvement: systemvm slow operations On our setup we had issues with vrouters when a large number of VM were created at once. The vrouters try to arping the gateway (to

[GitHub] cloudstack issue #1603: Vrouter fixes pylint

2016-07-05 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1603 Hi @The-Loeki, and thank you for your prompt comment! For your side notes: * this is mostly a preference, I don't care what you use but here are my argument fo

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-07-05 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1604 @syed > there could be a possibility of having an ipv6 gateway Right, but IPv6 does not use ARP but [NDP](https://en.wikipedia.org/wiki/Neighbor_Discovery_Proto

[GitHub] cloudstack issue #1603: Vrouter fixes pylint

2016-08-06 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1603 OK, will get back on it during the week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1603: Vrouter fixes pylint

2016-08-12 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1603 Done. Le me know what you think about it (I don't think Jenkins failed because of my edits?). --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-10-25 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1604 @rhtyd < JIRA issue [#9568](https://issues.apache.org/jira/browse/CLOUDSTACK-9568) I'll rebase as soon as possible. --- If your project is set up for it, you can

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-11-20 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1604 @rhtyd pong (is it OK like that? please advise) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-11-21 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1604 I'll need help to understand what gone wrong. I just peeked at `pr1604-t379-kvm-centos7/test_vpc_router_nics_CC22OE/results.txt` and: `TestVPCNics: DEBUG: SSH r

[GitHub] cloudstack pull request #1604: improvement: systemvm slow operations

2016-11-23 Thread romain-dartigues
Github user romain-dartigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1604#discussion_r89310394 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsHelper.py --- @@ -179,12 +179,12 @@ def get_hostname(): return

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-11-23 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1604 @rhtyd < separate function done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-12-05 Thread romain-dartigues
Github user romain-dartigues commented on the issue: https://github.com/apache/cloudstack/pull/1604 @murali-reddy I'm not in position to run tests anymore @dpassante could you take the lead for it? --- If your project is set up for it, you can reply to this email and have