[GitHub] cloudstack issue #1603: Vrouter fixes pylint

2016-08-06 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1603 @romain-dartigues can you rebase against latest master and push -f? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1604: improvement: systemvm slow operations

2016-08-06 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1604 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

2016-08-06 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1602 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-08-06 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1593 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1597: added constant for magic code

2016-08-06 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1597 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery

2016-08-06 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1599 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1592: CLOUDSTACK-9416 (Bug in ACS master GUI) : Enabling S...

2016-08-06 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1592 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1629: CLOUDSTACK-9449: Fix typo in user role description

2016-08-06 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1629 @blueorangutan help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1629: CLOUDSTACK-9449: Fix typo in user role description

2016-08-07 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1629 @pdion891 thanks I'll fix that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cloudstack pull request #1541: Systemd packaging for Ubuntu 16.04

2016-08-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1541#discussion_r73830805 --- Diff: debian/control --- @@ -3,7 +3,7 @@ Section: libs Priority: extra Maintainer: Wido den Hollander Build-Depends: debhelper (>

[GitHub] cloudstack pull request #1541: Systemd packaging for Ubuntu 16.04

2016-08-08 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1541#discussion_r73830916 --- Diff: debian/cloudstack-agent.install --- @@ -18,12 +18,11 @@ /etc/cloudstack/agent/agent.properties /etc/cloudstack/agent

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1630: Add projectid to project details page

2016-08-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1630 LGTM, @pdion891 can we have a screenshot to confirm regression testing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1631: Fix debian build error due to commit 3315eb5

2016-08-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1631 @karuturi I checked there was an internal infra issue, I'll kick it again @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cloudstack issue #1631: Fix debian build error due to commit 3315eb5

2016-08-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1631 @blueorangutan thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1631: Fix debian build error due to commit 3315eb5

2016-08-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1631 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1620: oobm: simply change password transactional lo...

2016-08-08 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1620 oobm: simply change password transactional logic - Simplifies change password transactional logic without using pessmistic locks - Adds a re-enter password field in the UI to valid ipmi

[GitHub] cloudstack pull request #1620: oobm: simply change password transactional lo...

2016-08-08 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1620 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1631: Fix debian build error due to commit 3315eb5

2016-08-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1631 @karuturi yes debugging, hold on. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1631: Fix debian build error due to commit 3315eb5

2016-08-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1631 @karuturi I've fixed the issue, it was env config related on one of the slaves. Since debian repo got built successfully. We can merge your PR. --- If your project is set up for it, yo

[GitHub] cloudstack issue #1626: [blocker] Fix systemvm template build

2016-08-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1626 @karuturi I'll work on it, get blueorangutan to upload them to the comments or someplace else. For now, you may see the build log attached in this comment; [systemfix-job17.txt](

[GitHub] cloudstack issue #1115: CLOUDSTACK-9064: The users should be able to create ...

2016-08-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1115 @abhinandanprateek was this merged in 4.9 as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1115: CLOUDSTACK-9064: The users should be able to create ...

2016-08-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1115 @abhinandanprateek great thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1626: [blocker] Fix systemvm template build

2016-08-09 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1626 @karuturi that is fine, we're not doing systemvmtemplate for 4.9 or maybe 4.10. This fixes the systemvm template build issue, so please merge on 4.9 branch and fwd merge it. It's becau

[GitHub] cloudstack issue #1626: [blocker] Fix systemvm template build

2016-08-09 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1626 Thanks @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1630: Add projectid to project details page

2016-08-09 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1630 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-08-09 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1545 LGTM, @wido looks like this will require a new systemvm template? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-08-09 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1545 @wido thanks @jburwell With 4.9/lts we've reproduced many issues around patchviasocket timing out. If this is a better and more robust approach, should we have this fix in 4.9/lts as

[GitHub] cloudstack pull request #1633: CLOUDSTACK-9452: use optparse instead of argp...

2016-08-10 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1633 CLOUDSTACK-9452: use optparse instead of argparse in patchviasocket Use optparse that is supported by python 2.3+, instead of argparse that is supported by python 2.7+. On KVM hosts which

[GitHub] cloudstack issue #1633: [blocker] CLOUDSTACK-9452: use optparse instead of a...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1633 @karuturi @jburwell @wido @sverrirab please review, it's a blocker for kvm centos6 hosts without argparse/python2.7 installed. I could run an existing test: (gave same results befor

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1615 @jburwell the test pipeline had issues, I'll rekick it once I can get the issues sorted. For now, only package works without any issues. We also found/fixed a blocker that failed all of ou

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1615 @blueorangutan package @jburwell @nvazquez since a new code commit was made, we need to call package before we could kick in tests. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1545 @wido thanks, @PaulAngus found an issue with the kvm patchviasocket script and I've sent a fix #1533 I was not sure what was causing the failure and saw this PR which looked promising.

[GitHub] cloudstack issue #1633: [blocker] CLOUDSTACK-9452: use optparse instead of a...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1633 @wido I'm sorry we will need to support CentOS6 kvm hosts, just because you don't use it does not mean we should not support for people. It is a valid `blocker` as the KVM CentOS6

[GitHub] cloudstack issue #1633: [blocker] CLOUDSTACK-9452: use optparse instead of a...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1633 CentOS6 default/epel repos don't have python 2.7 :) There are large installations running old code, old hardware, old kernels/OSs; they will get upgraded over time, but they need to be supp

[GitHub] cloudstack issue #1633: [blocker] CLOUDSTACK-9452: use optparse instead of a...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1633 @wido @sverrirab will adding python-argparse as a dependency be an acceptable solution to the problem? this package is available on el6, but python 2.7 is not available (without using one of the

[GitHub] cloudstack pull request #1633: [blocker] CLOUDSTACK-9452: use optparse inste...

2016-08-10 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1633 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1634: [blocker] CLOUDSTACK-9452: add python-argpars...

2016-08-10 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1634 [blocker] CLOUDSTACK-9452: add python-argparse dependency on el6,7 rpms The patchviasocket script was rewritten in Python from PR #1533 and made assumptions that Python 2.7 would be available

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @wido sure I'll spend sometime testing them as well. Since this is packaging only changes, should we get this on 4.9 for the lts /cc @jburwell @karuturi ? --- If your project is set up f

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 Build system did not have dh-systemd pkg installed, rekicked build job. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @wido can you apply the PR on 4.9/master and fix build? I got following failures. It would be great if this PR can opened for 4.9. Thanks. Error from Jenkins build: dh_install

[GitHub] cloudstack issue #1612: CLOUDSTACK-9446: Marvin and integration-tests packag...

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1612 Just to note here for future reference: this PR was backported to 4.5 and 4.6 branches as well. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...

2016-08-11 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1632 @karuturi @jburwell test keyword has been disabled due to infrastructural issues, I'll try to get this fixed today. Also, we need to run package first, to evaluate build/test/package c

[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...

2016-08-11 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1632 @nathanejohnson LGTM, but this bug affects 4.9 as well; please close this PR and reopen against 4.9. Your PR when accepted will be merged on 4.9 and fwd-merged on master. Thanks. --- If your

[GitHub] cloudstack issue #1632: Honor the forced parameter for stopVirtualMachine ap...

2016-08-11 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1632 @ProjectMoon With our current branch support policy, we should merge bugfixes/changes on master and the last release branch (i.e. 4.9 and also since 4.9 is current/to-be lts branch). I'm

[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...

2016-08-11 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...

2016-08-11 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1599 Marvin: Fix codegenerator to work with API discovery This fixes Marvin cloudstackAPI generator to work with a live running mgmt server's api discovery. You can merge this pull request i

[GitHub] cloudstack issue #1546: [WIP][4.10+/long-term] Moving towards Java8 and Spri...

2016-08-12 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1546 I'll split this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1638 CLOUDSTACK-9456: Use Spring 4 and Java 8 This changes makes CloudStack use spring 4 and Java 8: - Bumps jdk version to 1.8 - Use jdk8 for Travis CI - Bump spring

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1638 @blueorangutan I see, slaves need Java8 installed. Fixing that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1638 CLOUDSTACK-9456: Use Spring 4 and Java 8 This changes makes CloudStack use spring 4 and Java 8: - Bumps jdk version to 1.8 - Use jdk8 for Travis CI - Bump spring

[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1638 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1638#discussion_r74574871 --- Diff: pom.xml --- @@ -92,22 +85,22 @@ 1.5.1 1.2.8 2.0.4 -2.5 +3.1.0 1.2 1.2.1

[GitHub] cloudstack pull request #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-12 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1638#discussion_r74580238 --- Diff: pom.xml --- @@ -92,22 +85,22 @@ 1.5.1 1.2.8 2.0.4 -2.5 +3.1.0 1.2 1.2.1

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-15 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1638 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-15 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1638 Thanks @marcaurele for your fix, it has been included in the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1641: CLOUDSTACK-9459: the try's catch block was shortenin...

2016-08-16 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1641 LGTM, the only change is to move the catch block to the end so the ResultSet is not closed once the code comes out of the try-catch block. --- If your project is set up for it, you can reply to

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-08-16 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1542 @nvazquez @serg38 how about we remove vmware.nested.virtualization.perVM and instead if the user vm detail exists and is true, it overrides the global setting? --- If your project is set up for

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-16 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1638 @pdion891 we're neither breaking any backward compatibility wrt APIs, or schema, nor we've made any core change (mgmt server core, cmd-answer patterns, rpcs/serialization, or the plu

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Use Spring 4 and Java 8

2016-08-16 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1638 @jburwell Running tests against JRE 1.7, 1.8 is do-able. But I really want our master to use JDK 1.8. If we want to be able to run ACS mgmt server, agents etc against JRE 1.8 on both 4.9/lts and

[GitHub] cloudstack issue #1638: CLOUDSTACK-9456: Migrate master to Spring 4.x

2016-08-17 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1638 @jburwell fixed, it's jdk7+spring4 now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack pull request #1611: marvin: deploy clusters in separate threads

2016-08-17 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1611#discussion_r75074266 --- Diff: tools/marvin/marvin/deployDataCenter.py --- @@ -224,6 +225,15 @@ def createClusters(self, clusters, zoneId, podId, vmwareDc=None

[GitHub] cloudstack issue #1642: System VMs on Managed Storage

2016-08-17 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1642 @blueorangutan package @mike-tutkowski LGTM, we don't have any hardware to test it. I guess since builds have passed and if packaging passes too, we can merge with enough re

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

2016-08-17 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1640 @blueorangutan package LGTM, @abhinandanprateek can you review this as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stop...

2016-08-17 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1640#discussion_r75089504 --- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java --- @@ -282,7 +282,9 @@ public void scheduleRestartForVmsOnHost(final HostVO host

[GitHub] cloudstack issue #1634: [blocker] CLOUDSTACK-9452: add python-argparse depen...

2016-08-18 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1634 @karuturi @jburwell can we merge this, this is only packaging related fix. Using above packages, installation confirmed that argparse was installed on el6/el7 kvm hosts. --- If your project is

[GitHub] cloudstack pull request #1629: CLOUDSTACK-9449: Fix typo in user role descri...

2016-08-18 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1629 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9....

2016-08-18 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1646 [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1 This adds db upgrade path from 4.9.0 to 4.9.1 and fixes a typo in default user role description (CLOUDSTACK-9449) /cc @karuturi @jburwell

[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery

2016-08-18 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1599 Pinging for review -- @karuturi @jburwell @koushik-das @swill @pdion891 and others. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1511: 4.9/master bountycastle changes

2016-08-18 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1511 rebased against latest master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-18 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @wido can you reopen or edit the PR for base branch 4.9? Let's get this merged, as we'll need to support Ubuntu 16.04 for our LTS release. --- If your project is set up for it, you ca

[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery

2016-08-18 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1599 @jburwell yes, this PR does not implement API-discovery based generation but rather fixes the fields that the (api discovery based) codegenerator should produce in the generated python classes

[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery

2016-08-18 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1599 @jburwell the Travis build failed due to tearDown error in one of the tests: === TestName: test_listVM_by_id_as_user_vmsfromotherdomain | Status : EXCEPTION === I'll re-kick it

[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...

2016-08-18 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1599 Marvin: Fix codegenerator to work with API discovery This fixes Marvin cloudstackAPI generator to work with a live running mgmt server's api discovery. You can merge this pull request i

[GitHub] cloudstack pull request #1599: Marvin: Fix codegenerator to work with API di...

2016-08-18 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1

2016-08-18 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 @jburwell this makes sense, I'll update the PR and also fix this on master. Regarding 4.8 branch, I'm not sure so I'll ask @swill -- Will can you run setnextversion.sh on 4.

[GitHub] cloudstack issue #1599: Marvin: Fix codegenerator to work with API discovery

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1599 @jburwell fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 @jburwell @karuturi fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1646: [4.9/LTS] Add upgrade path from 4.9.0 to 4.9.1, chan...

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1646 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @wido if this helps you I can port your PR to 4.9 and push on asf remote so we can work on it together? Cherry-picking to 4.9 would against cause conflicts, and nice we've a fwd-merging

[GitHub] cloudstack pull request #1647: CLOUDSTACK-9462: Systemd support for Ubuntu 1...

2016-08-19 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1647 CLOUDSTACK-9462: Systemd support for Ubuntu 16.04 Created this based on @wido 's origin PR #1541 . Requesting for review and testing -- @jburwell @karuturi @wido @vincentb

[GitHub] cloudstack issue #1541: Systemd packaging for Ubuntu 16.04

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1541 @wido I've used your PR to create this new branch on asf remote (so we both and anyone else can collaborate) and this PR: #1647 -- let's close this PR and continue on the new one a

[GitHub] cloudstack pull request #1648: test/integration: fix tearDown order in list_...

2016-08-19 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1648 test/integration: fix tearDown order in list_acl_ tests This fixes tearDown issues because of which few Travis tests have failed such as: https://travis-ci.org/apache/cloudstack/jobs

[GitHub] cloudstack pull request #1649: CLOUDSTACK-9463: Fix dynamic-roles migrate sc...

2016-08-19 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1649 CLOUDSTACK-9463: Fix dynamic-roles migrate script for old format The old commands.properties format included the full class name such as: createAccount

[GitHub] cloudstack issue #1649: CLOUDSTACK-9463: Fix dynamic-roles migrate script fo...

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1649 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1647: [lts] CLOUDSTACK-9462: Systemd support for Ubuntu 16...

2016-08-19 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1647 @wido given it's a pure packaging fix, and as per RMs we've enough LGTMs but we lack a test LGTM -- I can help merge this after some tests wrt usage and kvm agent (on ubuntu 16.04

[GitHub] cloudstack issue #1650: fix macchinina template specificied for vmware in Ma...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1650 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1651 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1648: test/integration: fix tearDown order in list_...

2016-08-22 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1648 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1652 LGTM, the Travis test failures are not related to this PR but with tearDown issues fixed here: https://github.com/apache/cloudstack/pull/1648 --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request #1648: test/integration: fix tearDown order in list_...

2016-08-22 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1648 test/integration: fix tearDown order in list_acl_ tests This fixes tearDown issues because of which few Travis tests have failed such as: https://travis-ci.org/apache/cloudstack

[GitHub] cloudstack issue #1641: CLOUDSTACK-9459: the try's catch block was shortenin...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1641 Ran tests, failure before the fix: 2016-08-22 14:11:09,496 DEBUG [c.c.u.d.ScriptRunner] (main:null) (logid:) UPDATE `cloud`.`ntwk_offering_service_map` SET Provider='VpcVirtualR

[GitHub] cloudstack issue #1641: CLOUDSTACK-9459: the try's catch block was shortenin...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1641 Based on tests and review, merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1620: oobm: simply change password transactional logic

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1620 Trillian test results wrt oobm: Tests out-of-band management background powerstate sync ... === TestName: test_oobm_background_powerstate_sync | Status : SUCCESS === ok Tests out

[GitHub] cloudstack issue #1620: oobm: simply change password transactional logic

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1620 Merging based on review and test results above, thanks @blueorangutan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1621: [CLOUDSTACK-9444] Fix a little issue from PR1610 if ...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1621 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1653: Prevent DNS reflection attacks

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1653 LGTM, we need to also test for users who connect to VPN on that network (will DNS work for them as well?). --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1648: test/integration: fix tearDown order in list_acl_ te...

2016-08-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1648 The specific tests run with simulator only, so travis test results should be acceptable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

<    1   2   3   4   5   6   7   8   9   10   >