[GitHub] cloudstack pull request: CLOUDSTACK-9380: fix NPE in listDomains A...

2016-05-17 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1550#issuecomment-219783461 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-219953009 @anshul1886 can you share the details, which APIs. Also, are you facing this on master or on your personal/feature branch? --- If your project is set up for it, you

[GitHub] cloudstack pull request: dynamic-roles: remove unnecessary order b...

2016-05-18 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1551 dynamic-roles: remove unnecessary order by ID On some MySQL server envs, this may cause a SQL statement error, though I was unable to reproduce it. Since it's not needed, an ord

[GitHub] cloudstack pull request: [WIP][4.10+/long-term] Moving towards Jav...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1546#issuecomment-219985859 @resmo have you found if Travis specific reliance on oraclejdk7/8 causes any issue with building/testing CloudStack? --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-219986204 @anshul1886 I'm unable to reproduce the shared issues nor they were caught by CI/Jenkins/Travis runs. The role specific rules in role_permissions table have

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-219988321 @anshul1886 with dynamic-roles feature, we no longer want to use or promote use of commands.properties file which is why this has been removed in master. We no

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-220005496 @anshul1886 okay, let's debug; - After you mvn re-built cleanly, did you run mvn deploydb? - If yes, what is the output of: select * from configuration

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-220090191 @swill Travis and your CI are passing with this feature during which a data center is deployed and all sorts of APIs are called so it's likely an env issue spe

[GitHub] cloudstack pull request: dynamic-roles: remove unnecessary order b...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220091668 @swill I got a report that the GenericDaoBase generate query with multiple filters (order by clauses) may fail for MySQL: SELECT role_permissions.id

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-220093571 @swill yes sir. I'll personally make sure to perform another test round tomorrow both with UI, marvin and APIs/cloudmonkey. --- If your project is set up f

[GitHub] cloudstack pull request: This branch implements the CSV and native...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/351#issuecomment-220094312 @swill yeah I've asked @anshul1886 few questions and waiting for answers. Btw, since we're in a release/branch freeze, this feature PR need to be held unti

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-220230192 @anshul1886 I'm yet to see chrome dev-tool screenshots, actual errors reported in the UI and see answers for questions I asked; again -- the role_id in acc

[GitHub] cloudstack pull request: dynamic-roles: remove unnecessary order b...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220236481 @swill I've tested dynamic-roles features both with maven and rpms. I've tested the rpm/deb packages, including upgrade cases using this repository: (lat

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-220237753 @anshul1886 is this environment installed using rpms/deb or it's a developer machine with Ubuntu 12.04? Would you prefer a GTM to get to the bottom of the

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-220238585 @anshul1886 if you need help join this GTM now: https://app.gotomeeting.com/?meetingId=981540549 (or use the meeting id for a desktop client). I've personally t

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-18 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-220241843 @swill I had a GTM with Anshul to figure out the issue, his environment is not clean and I've asked him to setup a new environment (effectively a new dev box).

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-19 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1545#discussion_r63849851 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -1978,11 +1978,16 @@ So if getMinSpeed

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-19 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1545#discussion_r63849902 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtDomainXMLParser.java --- @@ -171,6 +173,25 @@ public boolean

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-19 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1545#discussion_r63850026 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java --- @@ -1209,25 +1209,95 @@ public String toString

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-19 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1545#discussion_r63850379 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -1978,11 +1978,16 @@ So if getMinSpeed

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-19 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1545#issuecomment-220278587 In general, a good idea and would be useful for flushing out disk IO and doing clean shutdown of VRs and vms. There are some outstanding issues, but the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-19 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220289585 @swill I was able to reproduce the addHost issue and fixed it. I was able to deploy against a KVM env with two clusters with Ubuntu and CentOS based hosts in each

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-19 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-19 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1549 CLOUDSTACK-9348: NioConnection improvements Reopened PR with squashed changes for a re-review and testing after https://github.com/apache/cloudstack/pull/1493 and sub-sequent PRs got reverted

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-19 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220380081 @swill yes, this PR includes all the reverted changes and the addHost fix. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-19 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-19 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1549 CLOUDSTACK-9348: NioConnection improvements Reopened PR with squashed changes for a re-review and testing after https://github.com/apache/cloudstack/pull/1493 and sub-sequent PRs got reverted

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-19 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220380639 @swill thanks, though the latter changes are all packaging related. I've built rpm/deb repository to show packaging works: http://packages.shapeblue.com/cloud

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-05-19 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-220389940 @swill the problem was environment dependent where an unclean environment was used to build/run management server, it is recommended to git clean -fdx one's

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220533786 @swill the error suggests the template response is missing the key 'status' in its json response. It may happen if there has been any change around

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220545220 Thanks @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1540#issuecomment-220545140 @swill let's merge this? thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Explicitely load JDBC driver before creat...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1553#issuecomment-220547372 LGTM, I am aware about the issue and the changes are therefore needed. Thanks @nlivens --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: dynamic-roles: packaging improvements

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1551#issuecomment-220675652 Thanks @swill if we keep getting this error, I'll try to find some time to see what's causing this as well --- If your project is set up for it, you ca

[GitHub] cloudstack pull request: CLOUDSTACK-9377: Fix metrics pagesize iss...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1540#issuecomment-220675720 Thanks @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-20 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220675936 @swill thank you for your time in testing this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-21 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220766648 @swill if it's failing for addHost, can you send the mgmt server log, marvin log and the agent log, and details of the environment (as much as possible). I can

[GitHub] cloudstack pull request: Add Java Default Certificat Authorities i...

2016-05-22 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1555#issuecomment-220882622 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9348: NioConnection improvemen...

2016-05-22 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1549#issuecomment-220893971 @swill I ran tests on latest master using packages: http://packages.shapeblue.com/cloudstack/custom/master-latest/ I was able to deploy a zone with two KVM

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

2016-05-23 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/846#discussion_r64197154 --- Diff: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java --- @@ -1087,4 +1087,11 @@ public HostVO findByPublicIp(String publicIp

[GitHub] cloudstack pull request: Bug-ID: CLOUDSTACK-8870: Skip external de...

2016-05-23 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/846#issuecomment-220939007 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add channel to Instances...

2016-05-23 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1545#issuecomment-221165022 LGTM, to use this feature. KVM users will need to use new systemvmtemplates, can we get #1531 merged as well? /cc @swill --- If your project is set up for it, you

[GitHub] cloudstack pull request: systemvmtemplate: fix build and upgrade t...

2016-05-23 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1531#issuecomment-221165014 Ping @wido @swill @DaanHoogland @abhinandanprateek can we get some review/lgtm thanks. This fixes build environment issues, updates readme and updates to use the

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-24 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1511 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-24 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1511 4.9/master bountycastle changes This PR adds bountycastle related version and code fixes from @DaanHoogland on top of https://github.com/apache/cloudstack/pull/1510 I could not fix

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-24 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-221189095 Done @DaanHoogland --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-24 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-221215124 @DaanHoogland I don't know, can you rebase and squash push -f? --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Change template_host_ref...

2016-05-25 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1562#issuecomment-221538713 LGTM, simple fix. Tested on local database. tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-25 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1511 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

2016-05-25 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1511 4.9/master bountycastle changes This PR adds bountycastle related version and code fixes from @DaanHoogland on top of https://github.com/apache/cloudstack/pull/1510 I could not fix

[GitHub] cloudstack pull request:

2016-05-27 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/commit/8af677a0f0b2a74db74223fc3d0e2d3e9549e960#commitcomment-17655645 In pom.xml: In pom.xml on line 91: @pdion891 @swill get it here: https://github.com/rhtyd/cloudstack-nonoss --- If

[GitHub] cloudstack pull request: fix noredist build because of missing mav...

2016-05-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1569#issuecomment-222354088 @swill there is a ipmitool pkg that needs to be installed before each run. I'll send a PR for a workaround. The packages.shapeblue.com repository is down,

[GitHub] cloudstack pull request: fix noredist build because of missing mav...

2016-05-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1569#issuecomment-222354130 @pdion891 usually, I clone this repo: https://github.com/rhtyd/cloudstack-nonoss and execute the install-non-oss.sh script in that repo: https://github.com/rhtyd

[GitHub] cloudstack pull request: fix noredist build because of missing mav...

2016-05-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1569#issuecomment-222354132 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: travis: use ipmitool from ubuntu reposito...

2016-05-29 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1570 travis: use ipmitool from ubuntu repository @swill @pdion891 please review, merge this once Travis is green. The packages.shapeblue.com server is unreachable which is causing a wget command to

[GitHub] cloudstack pull request:

2016-05-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/commit/8af677a0f0b2a74db74223fc3d0e2d3e9549e960#commitcomment-17659126 In pom.xml: In pom.xml on line 91: Since noredist required additional jars, recommended approach is to git clone this

[GitHub] cloudstack pull request:

2016-05-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/commit/8af677a0f0b2a74db74223fc3d0e2d3e9549e960#commitcomment-17662189 In pom.xml: In pom.xml on line 91: @pdion891 I think it's a grey area on where to host the noredist jars, also I

[GitHub] cloudstack pull request: travis: use ipmitool from ubuntu reposito...

2016-05-29 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1570#issuecomment-222416264 @swill can you merge this, as it would fix the ipmitool issue. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Dockerfile4.9

2016-05-30 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1435#discussion_r65123586 --- Diff: tools/docker/Dockerfile.centos6 --- @@ -18,14 +18,16 @@ FROM centos:6 MAINTAINER "Apache CloudStack" -LA

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1574#discussion_r65158988 --- Diff: framework/db/src/com/cloud/utils/db/DriverLoader.java --- @@ -0,0 +1,49 @@ +package com.cloud.utils.db; + +import

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1574#discussion_r65159038 --- Diff: framework/db/src/com/cloud/utils/db/DriverLoader.java --- @@ -0,0 +1,49 @@ +package com.cloud.utils.db; + +import

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1574#discussion_r65159171 --- Diff: framework/db/src/com/cloud/utils/db/DriverLoader.java --- @@ -0,0 +1,49 @@ +package com.cloud.utils.db; + +import

[GitHub] cloudstack pull request: Make sure that the DB drivers are loaded ...

2016-05-31 Thread rhtyd
Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1574#issuecomment-222653613 In general, LGTM though it's up to general community acceptance. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cloudstack issue #1531: systemvmtemplate: fix build and upgrade to debian 7....

2016-06-05 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1531 @rhtyd Maybe we can replace all this with a Packer build? I already did that for Cosmic and I think it's at least 90% the same so it should be fairly easy. As a matter of fact, we use C

[GitHub] cloudstack issue #1531: systemvmtemplate: fix build and upgrade to debian 7....

2016-06-06 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1531 @remibergsma sounds good to me, would you like to send a PR; port your work to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request #1531: systemvmtemplate: fix build and upgrade to de...

2016-06-07 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1531#discussion_r66175607 --- Diff: tools/appliance/definitions/systemvmtemplate/configure_systemvm_services.sh --- @@ -19,7 +19,7 @@ set -e set -x

[GitHub] cloudstack pull request #1531: systemvmtemplate: fix build and upgrade to de...

2016-06-07 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1531#discussion_r66175640 --- Diff: tools/appliance/definitions/systemvmtemplate/definition.rb --- @@ -27,15 +27,15 @@ architectures = { :i386

[GitHub] cloudstack issue #1531: systemvmtemplate: fix build and upgrade to debian 7....

2016-06-07 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1531 Alright, I've fixed the debian version without changing systemvmtemplate version. @remibergsma we can get this merged for the time being, and let's have your packer stuff -

[GitHub] cloudstack pull request #1584: CLOUDSTACK-9409: Add role_id to cloud_usage.a...

2016-06-07 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1584 CLOUDSTACK-9409: Add role_id to cloud_usage.account Adds role_id column to cloud_usage.account, fixes UsageDaoImpl to insert Accounts with role_id from account table. This fixes a

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1584 @nvazquez I've tested and with this fix unable to reproduce your issue, can you help review and test this PR? Thanks. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1584: [BLOCKER][FIX] CLOUDSTACK-9409: Add role_id to cloud...

2016-06-08 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1584 Thanks @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack pull request #1588: packaging: remove openjdk install deps on clo...

2016-06-08 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1588 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1588: packaging: remove openjdk install deps on clo...

2016-06-08 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1588 packaging: remove openjdk install deps on cloudstack-agent - Removes openjdk as installation requirement, for oracle jre users we don't need that - Adds oracle JDK home (default)

[GitHub] cloudstack-www pull request #27: downloads: update page for security release...

2016-06-09 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack-www/pull/27 downloads: update page for security releases /cc @pdion891 @DaanHoogland @wido @karuturi @runseb @swill and others You can merge this pull request into a Git repository by running

[GitHub] cloudstack-www issue #27: downloads: update page for security releases

2016-06-09 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack-www/pull/27 Thanks @runseb will do that --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1582: CLOUDSTACK-9408 for the move away from download.clou...

2016-06-13 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1582 @DaanHoogland I did not test it, but LGTM. As a project we can also publish a sql file or python script that would update the links (systemvm and default templates) in the db of existing

[GitHub] cloudstack pull request #1595: ui: show resize volume button to all users

2016-06-23 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1595 ui: show resize volume button to all users ![screenshot from 2016-06-23 12-29-56](https://cloud.githubusercontent.com/assets/95203/16294438/436f6dbc-393e-11e6-91b5-cb2e49a01cc6.png) The

[GitHub] cloudstack issue #1595: ui: show resize volume button to all users

2016-06-25 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1595 Thanks @remibergsma /cc @swill ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1549: CLOUDSTACK-9348: NioConnection improvements

2016-06-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1549 @swill may I have the mgmt server and agent logs when the failures were intercepted. This is to make sure it's not your environment specific issue. I'll also need the JRE version in us

[GitHub] cloudstack pull request #1549: CLOUDSTACK-9348: NioConnection improvements

2016-06-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1549#discussion_r68709839 --- Diff: utils/src/main/java/com/cloud/utils/nio/NioConnection.java --- @@ -125,7 +125,7 @@ public boolean isStartup() { public Boolean call

[GitHub] cloudstack pull request #1599: Independent marvin

2016-06-28 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1599 Independent marvin The aim is to make marvin independent of CloudStack. I had started this work few months ago, but recently resumed it after working on Trillian. - The aim is to show

[GitHub] cloudstack issue #1599: Independent marvin

2016-06-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1599 /cc @swill @jburwell @abhinandanprateek @murali-reddy @DaanHoogland @wido --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1549: CLOUDSTACK-9348: NioConnection improvements

2016-06-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1549 @swill close to two months now. Can you add the mgmt server logs, heap dump and any other dumps which can help me fix the issue. @swill @kiwiflyer Can you please open a JIRA issue where you

[GitHub] cloudstack pull request #1601: CLOUDSTACK-9348: Reduce Nio selector wait tim...

2016-07-01 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1601 CLOUDSTACK-9348: Reduce Nio selector wait time This reduced the Nio loop selector wait time, this way the selector will check frequently (as much as 100ms per iteration) and handle any

[GitHub] cloudstack issue #1601: CLOUDSTACK-9348: Reduce Nio selector wait time

2016-07-04 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1601 @glennwagner can you also comment if you saw any unusual CPU usage? thanks for testing this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1599: Independent marvin

2016-07-05 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1599 @wido yes, with this PR we can split marvin to its own repository. As an example to show it's doable, here is a repository I extracted from cloudstack master -- https://github.com/rhtyd/m

[GitHub] cloudstack issue #1605: CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve p...

2016-07-05 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1605 In general, a good idea. I've not tested it though. @nvazquez can you re-kick Jenkins by pushing -f on the PR --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1591: Updating Alert codes

2016-07-06 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1591 We'll need to check this against the consumers of the response, based on present alert codes we may need to update it. We'll also need to see when the alert code diverged, why some of

[GitHub] cloudstack issue #1583: Update L10N resource files with 4.9 strings from Tra...

2016-07-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1583 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1601: CLOUDSTACK-9348: Reduce Nio selector wait tim...

2016-07-10 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1601 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1601: CLOUDSTACK-9348: Reduce Nio selector wait tim...

2016-07-10 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1601 CLOUDSTACK-9348: Reduce Nio selector wait time This reduced the Nio loop selector wait time, this way the selector will check frequently (as much as 100ms per iteration) and handle any

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

2016-07-10 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1607 LGTM @ProjectMoon can you push -f, the Jenkins build failed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1610: packaging: Add db.X.driver=jdbc:mysql to db.properti...

2016-07-12 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1610 @wido lgtm, though we would also want the same change in the centos6's spec file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack-cloudmonkey issue #13: fix bug in using readline in Windows

2016-07-15 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack-cloudmonkey/pull/13 Thanks for the fix @phillipkent somehow I forgot to merge this. Merging this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1601: CLOUDSTACK-9348: Reduce Nio selector wait time

2016-07-15 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1601 @swill before you cut the next RC, please include this as @glennwagner and @PaulAngus found a blocker around addHost API without this fix. Thanks. --- If your project is set up for it, you can

[GitHub] cloudstack issue #1595: ui: show resize volume button to all users

2016-07-15 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1595 @swill this is a simple UI bugfix, please consider merging for 4.9.0 rc2 as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request #1611: marvin: deploy clusters in separate threads

2016-07-15 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1611 marvin: deploy clusters in separate threads This speeds up cluster deployment by Marvin, each cluster deployment can be executed in separate threads. This for example, allows for setting up a

[GitHub] cloudstack issue #1611: marvin: deploy clusters in separate threads

2016-07-15 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1611 One can test deployment of a large simulator environment using this cfg file with marvin+Simulator: [1000.cfg.txt](https://github.com/apache/cloudstack/files/365853/1000.cfg.txt

[GitHub] cloudstack pull request #1611: marvin: deploy clusters in separate threads

2016-07-17 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1611#discussion_r71099557 --- Diff: tools/marvin/marvin/deployDataCenter.py --- @@ -224,6 +225,16 @@ def createClusters(self, clusters, zoneId, podId, vmwareDc=None

[GitHub] cloudstack issue #1601: CLOUDSTACK-9348: Reduce Nio selector wait time

2016-07-18 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1601 Thanks @swill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

<    1   2   3   4   5   6   7   8   9   10   >