Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2033
@karuturi done, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/2033
[master/4.10+] CLOUDSTACK-9462: Support for Ubuntu 14.04/16.04 with
tomcat6/tomcat7
This extends work from @ustcweizhou from
https://github.com/apache/cloudstack/pull/1950 by fixing some
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/2033
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2033
@ustcweizhou thanks, yes there is a minor difference around the init-helper
version that's all
@karuturi jenkins/travis re-kicked.
@blueorangutan package
---
If your project is s
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2034
Verified the mangle table firewall rules are now ACCEPT instead of RETURN.
Pinging for review -- @wido @jayapalu @karuturi @abhinandanprateek
@DaanHoogland /cc @PaulAngus
---
If your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1980
@karuturi this is a simple UI change with screenshots attached, and has
enough LGTM. Please merge this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@karuturi thanks I'll see how I can help. This PR though looks like a bug
to me, though not a blocker.
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2037
LGTM
@wido can you change the base branch to 4.9, to get this in 4.9 branch as
well? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2037
Lgtm
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2037
@pdion891 I'll run regression tests
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1837
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1836
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2033
@blueorangutan test ubuntu kvm-ubuntu
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1836
@blueorangutan test matrix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1837
@blueorangutan test matrix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1836
@karuturi based on the latest Trillian tests on current master, I see a
regression in vmware env for:
==
FAIL
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1875
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack-cloudmonkey/pull/13#issuecomment-218304743
LGTM, based on the changes I think it should work on all Python versions
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-218357625
@swill I've fixed the issues, here are the changes:
[changes.diff.txt](https://github.com/apache/cloudstack/files/258551/changes.diff.txt)
The conf
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-218358868
@swill done, though if it fails again we may ignore that as long as travis
is green
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62790877
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r62790898
--- Diff:
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-218369488
@swill all green now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-218370503
Thanks you @swill finally :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218373527
@jburwell can you do a final review, LGTM or share further improvements.
Thanks.
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218374853
@PaulAngus can you squash the changes, so on the PR we get the changes as
one single commit.
You can do:
```
git checkout master # your master
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1104#issuecomment-218375367
@wolf29 can you rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1376#issuecomment-218376280
@swill @milamberspace weird, we've lost our Travis integration with PRs
here. https://travis-ci.org/apache/cloudstack/ says "The repository at
apache/clou
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1537#issuecomment-218398335
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1538
NioTest: relax test counts to pass under timeout
Relaxes test count to pass under fixed test timeout (60s). With these
settings,
malicious clients can thereotically block main IO loop for a
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218411583
I've rebased against latest master and pushed -f
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62820395
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/vpc/VPCOSPFConfigUpdateCmd.java
---
@@ -0,0 +1,207 @@
+// Licensed to the Apache Software
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218421442
@nvazquez can you check why test_03_list_snapshots failed in the Travis
run, with tearDown exception.
---
If your project is set up for it, you can reply to this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1539#issuecomment-218652190
LGTM, cc @swill let's merge this first to avoid other PRs failing
---
If your project is set up for it, you can reply to this email and have your
reply appe
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1511
4.9/master bountycastle changes
This PR adds bountycastle related version and code fixes from @DaanHoogland
on top of https://github.com/apache/cloudstack/pull/1510
I could not fix
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218656345
@DaanHoogland done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218656836
@kiwiflyer along with this patch, have you also applied the optimization
patch #1534 (make sure to apply the patch on both mgmt server and KVM agent) ?
We can debug
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1539#issuecomment-218657103
I think one way to cleanup would be to do it case by case basis for each
test case manually instead of relying on the class level cleanup. Also, it's
best to
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1539#discussion_r62967100
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -194,10 +194,7 @@ def setUpClass(cls):
cls._cleanup
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1502
CLOUDSTACK-9299: Out-of-band Management for CloudStack
Support access to a hostâs out-of-band management interface (e.g. IPMI,
iLO,
DRAC, etc.) to manage host power operations (on/off
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1502
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218666241
@jburwell fixed the ProcessRunner issues, please do a final review and LGTM
or suggest changes. Thanks.
@nvazquez @swill I've fixed two CI issues (Travi
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1538#issuecomment-218669737
@swill @nvazquez @mike-tutkowski appreciate if we can discuss the issue
here instead of ML, we'll lose discussion otherwise and I'm unable to keep up
disc
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218677864
tag:mergeready
/cc @swill all green now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/37#issuecomment-218678381
@pdion891 let's merge this now that the feature PR has been accepted
---
If your project is set up for it, you can reply to this email and have your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/37#issuecomment-218690491
Thanks @borisstoyanov merging this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-218713732
@DaanHoogland there is a known issue in test_list_ids_parameter test
causing issue. You can force travis by doing a pull --rebase and/or git commit
--amend and then
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1539#discussion_r62994980
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -194,10 +194,7 @@ def setUpClass(cls):
cls._cleanup
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1539#discussion_r63011767
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -194,10 +194,7 @@ def setUpClass(cls):
cls._cleanup
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-218746528
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1540
CLOUDSTACK-9377: Fix metrics pagesize issue
Fixes listing of clusters and host to list all clusters/hosts by passing
pagesize=-1.
/cc @koushik-das @swill @DaanHoogland -- fixes the
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218942524
@kiwiflyer thanks, I think I've found two issues -- I'll tag you on another
PR, please test that in your lab and share if that fixes your CPU issue. /cc
@s
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1543
CLOUDSTACK-9348: Make NioConnectio loop less aggressive
- Reverts ea2286 that introduced a wakeup on each connection loop run.
- In SSL handshake code removes delegated tasks to be run in
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1543#discussion_r63129136
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -615,7 +615,10 @@ public static boolean doHandshake(final SocketChannel
socketChannel
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218943901
PR that aims to fix CPU issue -
https://github.com/apache/cloudstack/pull/1543
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218944171
@swill thanks, will have a look at it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1541#issuecomment-218945458
@wido thanks, much needed. I had a quick look, I could not find a
cloudstack-management.sysconfig.
---
If your project is set up for it, you can reply to this email
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1544
CLOUDSTACK-9299: Fix test failures on CI
- Fixes oobm integration test to skip if known ipmitool bug is hit
- Fixes ProcessTest unit test case to use sleep
/cc @swill @kiwiflyer
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218945625
@swill I've tried to fix them here:
https://github.com/apache/cloudstack/pull/1544
---
If your project is set up for it, you can reply to this email and have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-218945981
@swill screenshots to prove it does not break the existing; in the
screenshot we see pagesize passed as -1 (i.e lists all). The pagesize change is
only in zone and
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1543#issuecomment-218947733
@kiwiflyer Thanks you for testing this so quickly and sharing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1544
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1544#issuecomment-218948374
Closing this one, moving the commit to the Nio cpu fix PR #1543
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1541#issuecomment-218957622
I was able to build the packages on Ubuntu 16.04:
cloudstack-agent_4.9.0-SNAPSHOT~xenial_all.deb
cloudstack-common_4.9.0-SNAPSHOT~xenial_all.deb
cloudstack
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1495#issuecomment-218959080
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1432#discussion_r63136614
--- Diff: tools/docker/Dockerfile ---
@@ -20,7 +20,7 @@
FROM ubuntu:14.04
MAINTAINER "Apache CloudStack"
-LABEL Vendor=&
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1376#issuecomment-218959204
LGTM
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1333#issuecomment-218959269
LGTM @nitin-maharana can you comment on Koushik's remark and also share
screenshot
---
If your project is set up for it, you can reply to this email and have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1280#issuecomment-218959384
LGTM (just code review), based on what @anshul1886 says there should not be
backward compatibility issue though I've not verified this by performing manual
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1244#issuecomment-218959426
This needs to be rebased @kishankavala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1241#issuecomment-218959511
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1241#issuecomment-218959533
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-218959585
@swill this can be CI tested and merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1104#issuecomment-218959629
This needs to be rebased @wolf29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1543
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1516#issuecomment-218962171
@sudhansu7 yeah, my bad -- I've fixed them here:
https://github.com/apache/cloudstack/pull/1543
---
If your project is set up for it, you can reply to this
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1543
Fix Nio/CPU issue and CI failures
- Reverts ea2286 that introduced a wakeup on each connection loop run.
- In SSL handshake code removes delegated tasks to be run in separate
threads
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-218978559
My bad, it is fixed here: https://github.com/apache/cloudstack/pull/1543
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1541#issuecomment-218980050
@wido alright, but while we're at it let's see if we can fix the mgmt
server as well.
I tested agent and was able to perform setup:
``
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1541#issuecomment-218980350
Tested installation and started cloudstack-usage that seems to be working
as well:
```
root@antrix:/var/log/cloudstack/agent# systemctl status cloudstack
Github user rhtyd commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1541#discussion_r63148448
--- Diff: debian/cloudstack-agent.install ---
@@ -18,12 +18,11 @@
/etc/cloudstack/agent/agent.properties
/etc/cloudstack/agent
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1543#issuecomment-218987023
I've also fixed a integration/component test that has failed on Travis
several time for various PRs due to cleanup order (tearDown
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1546
[4.10+/long-term] Moving towards Java8 and Spring4
This is a long term fix aiming to do following:
- Use Java8 for both building and running CloudStack
- Use Spring-framework 4.2.x
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1546#issuecomment-219012985
Request for comments - @jburwell @DaanHoogland @wido @DaanHoogland
@abhinandanprateek @imduffy15 @kiwiflyer @terbolous and others
---
If your project is set up for
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1546#issuecomment-219014328
@wido it's true that the package is not in the default, but Java8 is
available through few popular ppa(s). We need to migrate to Java8 since Java7
has EOL-ed f
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1541#issuecomment-219015333
@wido I'm LGTM on agent and usage package, it's a good first steps. Though,
I also want to see mgmt server as well. For enabling the services, we can have
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/38#issuecomment-219015461
Thanks Abhi, since the feature PR is merged. I'm merging the doc PR as well.
---
If your project is set up for it, you can reply to this email and
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1543#issuecomment-219095201
Thanks @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1540
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1540
CLOUDSTACK-9377: Fix metrics pagesize issue
Fixes listing of clusters and host to list all clusters/hosts by passing
pagesize=-1.
/cc @koushik-das @swill @DaanHoogland -- fixes the
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219203017
@swill done, closed and reopened to kick CIs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1546#issuecomment-219203300
@jburwell Thanks, I'll split the changes into separate PR if everyone
demands that. Otherwise each distinct pieces are implemented as separate
commits that c
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219416836
@koushik-das I'm assuming, pragmatically no one should have 1k or 10k hosts
in a `single` cluster; or similarly 1k or 10k clusters in a `single` zone.
@
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219474182
@swill I looked at recent Jenkins errors and they seem to be environment
related:
1. Jenkins failed during initialization to checkout the git tag/sha, it
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1540
CLOUDSTACK-9377: Fix metrics pagesize issue
Fixes listing of clusters and host to list all clusters/hosts by passing
pagesize=-1.
/cc @koushik-das @swill @DaanHoogland -- fixes the
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1540
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1540#issuecomment-219615189
@swill it's all green now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-219616568
@swill alright, I'll squash them and open a new PR that could be reviewed
merged later
---
If your project is set up for it, you can reply to this email and
GitHub user rhtyd opened a pull request:
https://github.com/apache/cloudstack/pull/1549
CLOUDSTACK-9348: NioConnection improvements
Reopened PR with squashed changes for a re-review and testing after
https://github.com/apache/cloudstack/pull/1493 and sub-sequent PRs got reverted
201 - 300 of 2445 matches
Mail list logo