[GitHub] cloudstack pull request #1960: CLOUDSTACK-9782: Host HA and KVM HA provider

2017-02-22 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1960 CLOUDSTACK-9782: Host HA and KVM HA provider Host-HA offers investigation, fencing and recovery mechanisms for host that for any reason are malfunctioning. It uses Activity and Health checks

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Requesting for review - @abhinandanprateek @DaanHoogland @rashmidixit @karuturi @koushik-das --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 Requesting for review - @DaanHoogland @abhinandanprateek @karuturi @koushik-das @syed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/843 @blueorangutan help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/843 @blueorangutan test centos7 xenserver-65sp1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1941 @blueorangutan test centos7 xenserver-65sp1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1903: [4.9] CLOUDSTACK-9356: FIX Cannot add users in VPC V...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1903 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1945 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1212 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #926: [4.10] CLOUDSTACK-7984: Collect network statistics fo...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/926 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1829 This is ready for merge @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1770: CLOUDSTACK-9628: Fix Template Size in Swift as Secon...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1770 @karuturi this is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1896 @karuturi pure translation changes, we need one more LGTM, otherwise this is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1946 LGTM. @karuturi this is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 LGTM, I'll test it manually as soon as I get some free time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1945 @karuturi this is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1947: CLOUDSTACK-9789: Fix releasing secondary guest IP fa...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1947 @karuturi this is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1856: [4.9] CLOUDSTACK-9569: propagate global configuratio...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1856 @karuturi this is ready for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1212 @karuturi this is ready for merge, using past review/test results. Though, I'll kick one more round of testing. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 Verified packages built alright with the change. ![screenshot from 2017-02-22 16-09-11](https://cloud.githubusercontent.com/assets/95203/23207997/55394784-f919-11e6-9b50-a8c2897fd939.png

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-02-22 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1950#discussion_r102430976 --- Diff: debian/control --- @@ -16,6 +16,7 @@ Description: A common package which contains files which are shared by several C Package: cloudstack

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-02-22 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1950#discussion_r102431194 --- Diff: debian/control --- @@ -16,6 +16,7 @@ Description: A common package which contains files which are shared by several C Package: cloudstack

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 @koushik-das there is plan for 4.9.3, though the db schema change to insert/update the hypervisor capability need to go into 4.10.0 either with this PR carefully fwd-merged (which I can help with

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 Install log on Ubuntu 16.10: root@antrix:/# apt-get install cloudstack-management -V Reading package lists... Done Building dependency tree Reading state information... Done

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 /cc @karuturi LGTM, manual tests confirm that mgmt server can be installed and setup on Ubuntu 16.04+. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 Additional notes, I still found issues with mgmt server not working afterwards likely due to permission/sudoers issue: 017-02-22 18:37:25,076 INFO [c.c.s.ConfigurationServerImpl

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-22 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 @wido can you comment on this PR, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1951 @syed yes there is no problem I see, with `INSERT IGNORE` we can have this db change in both paths resulting in same final state. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1829 Okay @syed either PR need to be merged to solve the issue of restart bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1941 LGTM. @karuturi let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1896 LGTM. @karuturi let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 @ustcweizhou can you check the permissions issue I hit in my test, as share in my comment above? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1903: [4.9] CLOUDSTACK-9356: FIX Cannot add users in VPC V...

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1903 LGTM. @karuturi let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack issue #1945: CLOUDSTACK-9787: Fix wrong return value in NetUtils....

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1945 LGTM. @karuturi let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks @rashmidixit awaiting your review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1946: CLOUDSTACK-9788: Fix exception listNetworks with pag...

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1946 LGTM. @karuturi let's merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack issue #1212: [4.9] CLOUDSTACK-9136: remove ssh keypairs along wit...

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1212 LGTM @karuturi this is ready for merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1907: Fix public IPs not being removed from the VR when de...

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1907 LGTM @karuturi this is ready for merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1915: CLOUDSTACK-9746 system-vm: logrotate config causes c...

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1915 LGTM @karuturi this is ready for merge Ping @abhinandanprateek in case you want to review? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1954 Thanks @dmabry LGTM @karuturi this is ready for merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1954 @dmabry can we have this in 4.9 as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-26 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1935 @nvazquez can you check if the failures in above test results are related to your changes, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1949: Automated Cloudstack bugs 9277 9276 9275 9274 9273 9...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1949 @shwetaag I see some new failures in Travis around component tests, can you close and reopen this PR to rekick Travis tests? If Travis fails again, please see the failed tests and fix them

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1961 @serg38 okay, we can add this to test_data /cc @PaulAngus --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1960 [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA provider Host-HA offers investigation, fencing and recovery mechanisms for host that for any reason are malfunctioning. It uses Activity

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-27 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1948: [CLOUDSTACK-9793] Faster IP in subnet check

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1948 LGTM, @karuturi can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubuntu 14....

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1950 LGTM. Tested manually on local Ubuntu installation. Fixed the permission issue by fixing sudoers manually and JAVA_HOME issue by fixing the variable in /etc/default/cloudstack

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1768 @marcaurele can we have a unit test to confirm that this does not break upgrade for older systems, also by changing the order for all older versions, the way someone would upgrade from say 4.3 to

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @borisstoyanov can you see the failure in Travis with test_list_infrastructure_metrics test case? Thanks @rashmidixit you're right I added this as a plugin to keep it separate from the

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rashmidixit the current UI does not support support pluggability of components within UI like the backend does. We can have a separate tab but not the implementation that the current metrics

[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

2017-02-27 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1944 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

2017-02-27 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1944 CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by re-implementing the logic at the

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-02-27 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1950#discussion_r103382438 --- Diff: debian/control --- @@ -16,14 +16,15 @@ Description: A common package which contains files which are shared by several C Package

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1944 Thanks @rashmidixit @karuturi this is ready for merge, as soon as Travis passes. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1975: Fix build failure on master

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1975 LGTM, found the build failure locally today. Introduced in `a2428508`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #1768: CLOUDSTACK 9601: Upgrade: change logic for up...

2017-02-27 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1768#discussion_r103388263 --- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java --- @@ -424,27 +421,9 @@ protected void upgrade(CloudStackVersion dbVersion

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1768 @marcaurele I appreciate the cleanup, it should have been like this from the beginning but since we've the workflow to execute all the upgrades first and then the cleanup. In `https://githu

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-27 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1958 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1954: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1954 Thanks @dmabry looks like this has been already merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1974: CLOUDSTACK-9795: moved logrotate from cron.daily to ...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1974 LGTM, looks like we'll have to backport by cherry-picking this given the PR for master has been merged. Thanks @dmabry --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1257 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1241 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1302 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103397573 --- Diff: api/src/org/apache/cloudstack/api/command/admin/ha/DisableHAForClusterCmd.java --- @@ -0,0 +1,114 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KV...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1960#discussion_r103397882 --- Diff: api/src/org/apache/cloudstack/api/command/admin/host/PrepareForMaintenanceCmd.java --- @@ -108,4 +108,8 @@ public void execute

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1960 Thanks @DaanHoogland wherever applicable I'll address the comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1257 @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r103404351 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2226,17 +2227,33 @@ int getReservedCpuMHZ

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r103404645 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2226,17 +2227,33 @@ int getReservedCpuMHZ

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r103405279 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2226,17 +2227,33 @@ int getReservedCpuMHZ

[GitHub] cloudstack pull request #1302: CLOUDSTACK-9104: VM naming convention in case...

2017-02-28 Thread rhtyd
Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1302#discussion_r103405341 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -2226,17 +2227,33 @@ int getReservedCpuMHZ

[GitHub] cloudstack issue #1241: CLOUDSTACK-9162: Unable to add VPN user via API with...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1241 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1302: CLOUDSTACK-9104: VM naming convention in case vmware...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1302 I've left some outstanding comments, I'm -1 on the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] cloudstack-docs issue #19: Updating The Nuage VSP Plugin Documentation for A...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack-docs/pull/19 LGTM thanks. /cc @karuturi we can merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1779 I think we'll need to discuss, I'm not sure if we should hide hosts that are disabled and cluster is un-managed. /cc @DaanHoogland @abhinandanprateek comment? --- If your project is

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1960 @koushik-das I've shared a list of advantages of this work over existing framework on dev@ that explain why existing VM-HA framework cannot be used for host-ha implementation. If you&#x

[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

2017-02-28 Thread rhtyd
Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1944 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1944: CLOUDSTACK-9783: Improve metrics view perform...

2017-02-28 Thread rhtyd
GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1944 CLOUDSTACK-9783: Improve metrics view performance This improves the metrics view feature by improving the rendering performance of metrics view tables, by re-implementing the logic at the

[GitHub] cloudstack issue #1269: CLOUDSTACK-8867: Added retry logic to reconnect to h...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1269 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1278 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1253 @sureshanaparti sure @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1257 @sureshanaparti can check if failure in the above test results are due to your changes, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1836 /cc @karuturi -- I'm running health check for latest master/4.10 RC1 cut from current HEAD @blueorangutan package --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1836 @blueorangutan test matrix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1957 LGTM (code review). @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1959: CLOUDSTACK-9786:API reference guide entry for associ...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1959 LGTM, code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1784: CS-505: Marvin test to check VR internal DNS Service

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1784 Test looks good to me, @abhinandanprateek should we target/include this in 4.9 as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1784: CS-505: Marvin test to check VR internal DNS Service

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1784 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1843: CLOUDSTACK-9687: if the allocated amount is 0 the ca...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1843 LGTM. @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1930: CLOUDSTACK-9687: if the allocated amount is 0 the ca...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1930 This can be closed if https://github.com/apache/cloudstack/pull/1843 is fwd-merged, please check @abhinandanprateek --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1933: CLOUDSTACK-9569: add router.aggregation.command.each...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1933 LGTM. @abhinandanprateek is this PR different or is a subset of https://github.com/apache/cloudstack/pull/1856 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-28 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1958 /cc @karuturi ready for merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1980: CLOUDSTACK-9805: Display VR list in network d...

2017-03-01 Thread rhtyd
GitHub user rhtyd opened a pull request: https://github.com/apache/cloudstack/pull/1980 CLOUDSTACK-9805: Display VR list in network details ![screenshot from 2017-03-01 14-52-26](https://cloud.githubusercontent.com/assets/95203/23453709/64f31f8a-fe8f-11e6-8281-a06e27bf3a14.png

[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details

2017-03-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1980 @ustcweizhou @PaulAngus sure, I can add a tab filter to allow only admins to see this. Right now, whoever can see the network tab(s) can see this tab too. I'll fix this asap. --- If

[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details

2017-03-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1980 @PaulAngus @ustcweizhou fixed now, the tab is displayed only to admins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1923: CLOUDSTACK-9765: centos: packaging: fix missing path...

2017-03-01 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1923 LGTM. @karuturi not a blocker, but then we'll need to document the workaround (manual fix) in the release notes. If RC1 has any blockers, let's include this in RC2. --- If your proj

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-02 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1813 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-02 Thread rhtyd
Github user rhtyd commented on the issue: https://github.com/apache/cloudstack/pull/1961 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

  1   2   3   4   5   6   7   8   9   10   >