[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-23 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rhtyd Will be trying this out today - will post my comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rhtyd On the contrary, I think you adding metrics as pluggable API is a good idea. However, to seriously make the feature pluggable the UI component should also load based on a plugin

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-27 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rhtyd I guess this is fine for now. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM I...

2017-02-28 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1852 @ustcweizhou The reason for not putting this in vmActionFilter is that the snapshot action itself is allowed when a VM is shut down. We only want to disable the option for memory snapshot

[GitHub] cloudstack issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM I...

2017-02-28 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1852 ping @koushik-das. When VM is running and snapshot option is clicked, the memory option is enabled. ![vm-running-state](https://cloud.githubusercontent.com/assets/13415006

[GitHub] cloudstack pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy t...

2017-02-28 Thread rashmidixit
GitHub user rashmidixit reopened a pull request: https://github.com/apache/cloudstack/pull/1894 CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time A user can currently copy or register a template with only one zone at a time. The idea of

[GitHub] cloudstack pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy t...

2017-02-28 Thread rashmidixit
Github user rashmidixit closed the pull request at: https://github.com/apache/cloudstack/pull/1894 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1848: CLOUDSTACK-9693 Cluster View - Status symbol does no...

2017-02-28 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1848 @koushik-das : Please see attached image. With these changes, when a cluster is unmanaged, the status will change to Unmanaged as below. Earlier it used to show up as enabled (whereas in

[GitHub] cloudstack issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy template...

2017-02-28 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1894 @karuturi requesting your review on this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1877: CLOUDSTACK-9716: Change of network to rvr for bareme...

2017-02-28 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1877 @harikrishna-patnala, @sadhugit Can you please review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

2017-03-13 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @ustcweizhou The popup is to indicate that no hosts were found. If I remove that, then there will be no visual indication that the search has returned no results. We need to have

[GitHub] cloudstack issue #1884: CLOUDSTACK-9699: Add global setting for enable/disab...

2017-03-14 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1884 Closing this based on the new PR #1944. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request #1884: CLOUDSTACK-9699: Add global setting for enabl...

2017-03-14 Thread rashmidixit
Github user rashmidixit closed the pull request at: https://github.com/apache/cloudstack/pull/1884 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

2017-03-16 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @ustcweizhou I have made appropriate changes. Can you please check once the validations pass? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

2017-03-16 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @ustcweizhou thanks. I guess there was a misunderstanding. I understand what you are saying. I think i will just remove that dialog. The problem is that we are lazy loading the list

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

2017-03-16 Thread rashmidixit
GitHub user rashmidixit reopened a pull request: https://github.com/apache/cloudstack/pull/1889 CLOUDSTACK-9718: Revamp the dropdown showing lists of hosts available for migration in a Zone Refer to [CLOUDSTACK-9718](https://issues.apache.org/jira/browse/CLOUDSTACK-9718) for more

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

2017-03-16 Thread rashmidixit
Github user rashmidixit closed the pull request at: https://github.com/apache/cloudstack/pull/1889 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

2017-03-27 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @karuturi requesting you to merge these changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

2017-04-06 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @karuturi I have rebased with master and pushed. I still see failures in Travis but they dont seem to be with my changes. Can you please check? --- If your project is set up for it, you

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

2017-04-06 Thread rashmidixit
Github user rashmidixit closed the pull request at: https://github.com/apache/cloudstack/pull/1889 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

2017-04-06 Thread rashmidixit
GitHub user rashmidixit reopened a pull request: https://github.com/apache/cloudstack/pull/1889 CLOUDSTACK-9718: Revamp the dropdown showing lists of hosts available for migration in a Zone Refer to [CLOUDSTACK-9718](https://issues.apache.org/jira/browse/CLOUDSTACK-9718) for more

[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...

2017-04-10 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1826 Closing this since #1944 has been merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellan...

2017-04-10 Thread rashmidixit
Github user rashmidixit closed the pull request at: https://github.com/apache/cloudstack/pull/1826 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: [WIP][4.10+/long-term] Moving towards Jav...

2016-05-19 Thread rashmidixit
Github user rashmidixit commented on the pull request: https://github.com/apache/cloudstack/pull/1546#issuecomment-220524210 While we are on the topic of updating the tech stack, have we considered moving to using either LESS or Sass for CSS. CSS pre-processors bring more modularity

[GitHub] cloudstack pull request #1819: CLOUDSTACK-9653 The system capacity was not g...

2016-12-07 Thread rashmidixit
GitHub user rashmidixit opened a pull request: https://github.com/apache/cloudstack/pull/1819 CLOUDSTACK-9653 The system capacity was not getting calculated correctly When listCapacity is used with the sortBy=usage option, the capacity was not getting calculated correctly

[GitHub] cloudstack pull request #1826: CLOUDSTACK-9675: Mem Usage and Mem Allocation...

2016-12-13 Thread rashmidixit
GitHub user rashmidixit opened a pull request: https://github.com/apache/cloudstack/pull/1826 CLOUDSTACK-9675: Mem Usage and Mem Allocation show NaN More for information refer to [CLOUDSTACK-9675](https://issues.apache.org/jira/browse/CLOUDSTACK-9675) You can merge this pull

[GitHub] cloudstack pull request #1848: CLOUDSTACK-9693 Cluster View - Status symbol ...

2016-12-21 Thread rashmidixit
GitHub user rashmidixit opened a pull request: https://github.com/apache/cloudstack/pull/1848 CLOUDSTACK-9693 Cluster View - Status symbol does not change based on Cluster state Refer to [CLOUDSTACK-9693](https://issues.apache.org/jira/browse/CLOUDSTACK-9693) for more details

[GitHub] cloudstack pull request #1852: VM snapshot is disabled if the VM Instance is...

2016-12-21 Thread rashmidixit
GitHub user rashmidixit opened a pull request: https://github.com/apache/cloudstack/pull/1852 VM snapshot is disabled if the VM Instance is off Refer to [CLOUDSTACK-9695](https://issues.apache.org/jira/browse/CLOUDSTACK-9695) for more details. You can merge this pull request into

[GitHub] cloudstack issue #1852: VM snapshot is disabled if the VM Instance is off

2016-12-21 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1852 As part of this fix, added a new property called "isDisabled" for a field in a dialog. If this function returns true, then the field will be disabled. --- If your project is set

[GitHub] cloudstack issue #1848: CLOUDSTACK-9693 Cluster View - Status symbol does no...

2016-12-21 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1848 This is done. Thanks @rhtyd. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...

2016-12-22 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1826 @rhtyd - There have been four things fixed here. I have explained each commit below. Your review/comments is most appreciated. 1. Goto Zone metrics or Hosts metrics. NUmerical

[GitHub] cloudstack pull request #1855: CLOUDSTACK-9697: Better error message if user...

2016-12-22 Thread rashmidixit
GitHub user rashmidixit opened a pull request: https://github.com/apache/cloudstack/pull/1855 CLOUDSTACK-9697: Better error message if user tries to shrink VM ROOT Volume size Skip the API call altogether if the UI detects this case and throw a more user friendly message

[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...

2016-12-22 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1826 Added one more fix to this: 1. List of Virtual Machines will be incorrect if the number is greater than the pagesize. Added -1 to the call of the API. --- If your project is set up

[GitHub] cloudstack issue #1852: VM snapshot is disabled if the VM Instance is off

2016-12-27 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1852 @rhtyd This is a minor improvement and hence in master. I have updated the corresponding bugs' fix version. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...

2016-12-29 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1826 @rhtyd Have you been able to take a look at the commits? Will appreciate your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request #1877: Change of network to rvr for baremetal caused...

2016-12-29 Thread rashmidixit
GitHub user rashmidixit opened a pull request: https://github.com/apache/cloudstack/pull/1877 Change of network to rvr for baremetal caused vm deployment to get stuck Refer to [CLOUDSTACK-9716](https://issues.apache.org/jira/browse/CLOUDSTACK-9716) for more details You can merge

[GitHub] cloudstack pull request #1819: CLOUDSTACK-9653 The system capacity was not g...

2016-12-30 Thread rashmidixit
GitHub user rashmidixit reopened a pull request: https://github.com/apache/cloudstack/pull/1819 CLOUDSTACK-9653 The system capacity was not getting calculated correctly When listCapacity is used with the sortBy=usage option, the capacity was not getting calculated correctly

[GitHub] cloudstack pull request #1819: CLOUDSTACK-9653 The system capacity was not g...

2016-12-30 Thread rashmidixit
Github user rashmidixit closed the pull request at: https://github.com/apache/cloudstack/pull/1819 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1884: Add global setting for enable/disable Metrics...

2017-01-02 Thread rashmidixit
GitHub user rashmidixit opened a pull request: https://github.com/apache/cloudstack/pull/1884 Add global setting for enable/disable Metrics feature The Metrics view for each type of entity basically fires APIs and calculates required values on the client end. For e.g. to display

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

2017-01-04 Thread rashmidixit
GitHub user rashmidixit opened a pull request: https://github.com/apache/cloudstack/pull/1889 CLOUDSTACK-9718: Revamp the dropdown showing lists of hosts available for migration in a Zone Refer to [CLOUDSTACK-9718](https://issues.apache.org/jira/browse/CLOUDSTACK-9718) for more

[GitHub] cloudstack pull request #1894: CLOUDSTACK-9700 Allow user to Register/Copy t...

2017-01-06 Thread rashmidixit
GitHub user rashmidixit opened a pull request: https://github.com/apache/cloudstack/pull/1894 CLOUDSTACK-9700 Allow user to Register/Copy templates to multiple zones at the same time A user can currently copy or register a template with only one zone at a time. The idea of

[GitHub] cloudstack issue #1884: CLOUDSTACK-9699: Add global setting for enable/disab...

2017-01-09 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1884 Thank you @jburwell. I will incorporate the comments in a couple of days and resubmit. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...

2017-01-11 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1826 @rhtyd Please take a look now. I have squashed the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request #1852: CLOUDSTACK-9695: VM snapshot is disabled if t...

2017-01-12 Thread rashmidixit
Github user rashmidixit closed the pull request at: https://github.com/apache/cloudstack/pull/1852 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request #1852: CLOUDSTACK-9695: VM snapshot is disabled if t...

2017-01-12 Thread rashmidixit
GitHub user rashmidixit reopened a pull request: https://github.com/apache/cloudstack/pull/1852 CLOUDSTACK-9695: VM snapshot is disabled if the VM Instance is off Refer to [CLOUDSTACK-9695](https://issues.apache.org/jira/browse/CLOUDSTACK-9695) for more details. You can merge

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

2017-01-23 Thread rashmidixit
Github user rashmidixit commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1889#discussion_r97313518 --- Diff: ui/scripts/ui-custom/migrate.js --- @@ -0,0 +1,127 @@ +// Licensed to the Apache Software Foundation (ASF) under one --- End diff

[GitHub] cloudstack issue #1894: CLOUDSTACK-9700 Allow user to Register/Copy template...

2017-01-23 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1894 Attaching new screens for the changes made here. ![copytemplate-withsearchzone](https://cloud.githubusercontent.com/assets/13415006/22205048/27f14e6a-e19b-11e6-8ba3-e0d4d8e7993a.PNG

[GitHub] cloudstack issue #1855: CLOUDSTACK-9697: Better error message if user tries ...

2017-02-14 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1855 @sadhugit I have updated the bug description based on your comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1884: CLOUDSTACK-9699: Add global setting for enable/disab...

2017-02-14 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1884 @rhtyd Thanks for the update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

2017-02-15 Thread rashmidixit
Github user rashmidixit commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1889#discussion_r101275471 --- Diff: api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java --- @@ -206,7 +206,7 @@ public void execute

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

2017-02-15 Thread rashmidixit
Github user rashmidixit commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1889#discussion_r101275818 --- Diff: api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java --- @@ -206,7 +206,7 @@ public void execute

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

2017-02-16 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1889 @karuturi ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1819: CLOUDSTACK-9653 The system capacity was not getting ...

2017-02-16 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1819 Looked at the errors. None of them have anything to do with the code changes. ping @karuturi. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1826: CLOUDSTACK-9675: Cloudstack Metrics Miscellaneous bu...

2017-02-16 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1826 @rhtyd I will take a look. However, this pull request is to do with additional bug fixes. Can you please review. --- If your project is set up for it, you can reply to this email and have