Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46148014
--- Diff:
api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java ---
@@ -0,0 +1,12 @@
+package com.cloud.network.guru
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46148337
--- Diff: setup/db/db/schema-460to470.sql ---
@@ -18,3 +18,5 @@
--;
-- Schema upgrade from 4.6.0 to 4.7.0;
--;
+
+ALTER TABLE
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46148362
--- Diff: setup/db/db/schema-461to470.sql ---
@@ -18,3 +18,5 @@
--;
-- Schema upgrade from 4.6.1 to 4.7.0;
--;
+
+ALTER TABLE
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46159749
--- Diff: api/src/com/cloud/network/Networks.java ---
@@ -251,6 +252,10 @@ public static URI fromString(String candidate) {
if
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46287923
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkUuidCommandWrapper.java
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1094#discussion_r46306167
--- Diff:
plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/element/NiciraNvpElement.java
---
@@ -239,8 +244,51 @@ public boolean
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-161048814
@miguelaferreira besides fixing these issues and writing marvin test, what
else would be needed to include this feature in version 4.7? Would it be
possible, or
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-161315034
Thanks @miguelaferreira I really appreciate that! Thanks a lot for your
help!
I'll try to make it before the deadline. I'm not that into Python but I
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-161320788
Sure, I couldn't find you mail address, mine is in my profile
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162187421
Hi @remibergsma @miguelaferreira
I've been working in marvin test file to cover this new features, those are
test03 y test04 in test/integration/
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1178#issuecomment-162231638
Ok, I'll post results later
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162990802
@remibergsma my mistake, I meant to modify schema-460to470.sql
and schema-461to470.sql but not
setup/db/db/schema-410to420-cleanup.sql as I did.
I'll
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-163373604
ping @remibergsma would be great to test this new functionalities
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-163383576
@miguelaferreira configuration needed is very complicated, I could not be
able to include it on
test/integration/plugins/test_nicira_controller.py, tests added
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218321496
Done, now it passed but somehow Jenkins test was not executed
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218467920
@swill it's strange, as @serg38 says it succeeds for us and for
@koushik-das, I'll investigate. Is there any log of the failure?
---
If your project
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218468571
@rhtyd sure, I'll examine this. This tests are introduced in #1497, I'll
work on this
---
If your project is set up for it, you can reply to this emai
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1497#issuecomment-218499768
Done @swill @serg38
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1539
CLOUDSTACK-9378: Fix for #1497
JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9378
After #1497 was merged, test_list_ids_parameter.py failed on Travis. It was
noticed
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218514854
@rhtyd @kiwiflyer @swill a PR for fixing the problem #1539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218520519
@rhtyd @kiwiflyer @swill a PR for fixing the problem #1539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218520703
Sorry, I confused PRs. Please ignore my last comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1539#issuecomment-218766563
@swill @rhtyd @DaanHoogland I reordered cleanup as in [@rhtyd's
commit](https://github.com/apache/cloudstack/pull/1502/co
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1539#discussion_r63026066
--- Diff: test/integration/smoke/test_list_ids_parameter.py ---
@@ -194,10 +194,7 @@ def setUpClass(cls):
cls._cleanup
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1542
CLOUDSTACK-9379: Support nested virtualization at VM level on VMware
Hypervisor
## Introduction
[JIRA TICKET](https://issues.apache.org/jira/browse/CLOUDSTACK-9379)
It is
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1542#issuecomment-219051673
Hi @DaanHoogland, unfortunately I really didn't examine it for other
hypervisors. In our environment we only use VMware ESXi hypervisor, that's the
m
Github user nvazquez closed the pull request at:
https://github.com/apache/cloudstack/pull/1539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1539#issuecomment-219077065
Thanks, closed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-219083470
@koushik-das I only use Vmware hypervisor so I couldn't test it for Xen or
KVM. However, I reviewed code and found
`copySnapshotToTemplateFromNfsToNfsXens
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r63377708
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java
---
@@ -79,6 +80,25 @@
VMTemplateZoneDao
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-219466200
@GabrielBrascher thanks for your review! I pushed changes fixing issues
you've found.
@koushik-das I've replied your comment, sorry for late repl
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-220427628
@koushik-das I pushed new changes including an intermediate class as you
suggested
@swill hopefully CI passes now
---
If your project is set up for it, you
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-220608044
Thanks @swill @koushik-das! Sorry I was missing a license header, I pushed
it now.
---
If your project is set up for it, you can reply to this email and have
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r64042208
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/image/NfsImageStoreDriverImpl.java
---
@@ -0,0 +1,30 @@
+package
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1560
CLOUDSTACK-9368: DS template copies donâÂÂt get deleted in VMware ESXi with
multiple clusters and zone wide storage
JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1560#issuecomment-221623024
Hi @rafaelweingartner thanks for your comments!
I extracted to a method and added test cases for this new method. Also
changed Exception to
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1560#discussion_r64617338
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -5510,6 +5501,27 @@ public Answer execute
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1542#issuecomment-222046182
Hi @ustcweizhou @DaanHoogland @remibergsma,
I moved global config definitions to `ConfigKey.java` instead of
`Config.java` and `schema-481to490.sql
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1584
Thanks @rhtyd for this fix!
Just for the record, this was error before this fix:
2016-06-07 11:04:51,233 ERROR [cloud.usage.UsageManagerImpl]
(Usage-Job-1:null
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1584
Cool, thanks @swill!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1593
CLOUDSTACK-9417: Usage module refactoring
### Introduction
Usage sanity check file was not been updated on sanity check.
It is proposed:
* New usage folder `/var/cache
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Could this be reviewed for VMware please? Then I can work on extending it
to other HVs
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1594
CLOUDSTACK-9407: vm_network_map table doesnt get cleaned up properly
JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9407
### Introduction
It was found out that in
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1593
Thanks @wido! I refactored debian packaging and added fedora21's
`cloud.spec` file
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1593
Thanks @jburwell for your review!
About your first question, as @serg38 said file will be created on sanity
check run if it didn't exist, and then it would just upda
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1594#discussion_r67907224
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1577,8 +1577,9 @@ private void advanceStop(final VMInstanceVO vm
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1594#discussion_r67907159
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -2086,6 +2089,18 @@ public boolean expunge(UserVmVO vm, long
callerUserId, Account
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1594#discussion_r67907402
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1577,8 +1577,9 @@ private void advanceStop(final VMInstanceVO vm
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1594
Thanks @jburwell @swill for reviewing!
I refactored this PR based on @jburwell comments, it would be nice if it
can be included!
---
If your project is set up for it, you can reply to
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1593#discussion_r67938119
--- Diff: usage/src/com/cloud/usage/UsageSanityChecker.java ---
@@ -72,7 +72,9 @@ protected boolean checkItemCountByPstmt(CheckCase
checkCase) throws
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1602
CLOUDSTACK-9422: Granular VMware vms creation as full clones on HV
### Introduction
For VMware, It is possible to decide creating VMs as full clones on ESX HV,
adjusting
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@syed adding to use cases that @serg38 mentioned, I edited PR's title which
could be confusing
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Thanks @syed for your comments!
I agree with @serg38 that extension to other hypervisors could be done in a
separate PR
---
If your project is set up for it, you can reply to this email
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1605
CLOUDSTACK-9428: Fix for CLOUDSTACK-9211 - Improve performance
JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9428
### Introduction
On #1310 passing vRAM size
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1605#discussion_r69735338
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2015,19 +2016,20 @@ protected StartAnswer
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1605#discussion_r69735374
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2015,19 +2016,20 @@ protected StartAnswer
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1605
Thanks @rhtyd @sateesh-chodapuneedi for your reviews! I pushed new chages
based on @sateesh-chodapuneedi comments, now Jenkins passed.
---
If your project is set up for it, you can reply to
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1613
CLOUDSTACK-9436: Release network resources on expunge command
JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9436
Improvement for #1594
Due to error on `test
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1613
That's great! Thanks @swill for your help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1615
CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS version changeable in UI
JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9438
### Introduction
From #1361 it
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73154622
--- Diff:
engine/schema/src/org/apache/cloudstack/storage/datastore/db/ImageStoreDaoImpl.java
---
@@ -16,7 +16,7 @@
* specific language
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73156809
--- Diff: setup/db/db/schema-481to490.sql ---
@@ -545,3 +545,6 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor`
(uuid,hypervisor_type, hypervis
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73156984
--- Diff:
engine/schema/src/org/apache/cloudstack/storage/datastore/db/ImageStoreDetailVO.java
---
@@ -23,61 +23,61 @@
import
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Thanks @koushik-das!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Hi @DaanHoogland @remibergsma @ustcweizhou,
I rebased master branch for this pull request as it's been opened for a
while, could it be reviewed please?
---
If your proje
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1560
Hi guys,
This pull request it's been opened for a while, @rafaelweingartner,
@bvbharatk you've reviewed it before, could you give your blessing to this PR?
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1602
I rebased master branch and pushed again, could it be ran again?
@blueorangutan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r73753271
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
---
@@ -1353,6 +1363,20 @@ public void prepare
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r73753345
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -537,15 +540,51 @@ public Answer
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r73753387
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -537,15 +540,51 @@ public Answer
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Oh that's sad, no problem, thanks anyways @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1602
Thanks @jburwell for your review! I refactored based on your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r74067226
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ---
@@ -145,6 +156,9 @@ public void execute() {
if
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r74067440
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -520,6 +528,16 @@ public String updateConfiguration(final long userId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r74067494
--- Diff: server/src/com/cloud/storage/ImageStoreDetailsUtil.java ---
@@ -20,48 +20,68 @@
import javax.inject.Inject;
+import
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r74068727
--- Diff: server/src/com/cloud/storage/ImageStoreDetailsUtil.java ---
@@ -20,48 +20,68 @@
import javax.inject.Inject;
+import
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Done, thanks @jburwell for your review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1615
Sure, done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r74301008
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageSubsystemCommandHandler.java
---
@@ -66,19 +68,28 @@ public
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rafaelweingartner thanks a lot for your help as always!
I refactored based on your comments. I really liked your review, especially
your refactor on `shouldEnableNestedVirtualization
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
@rafaelweingartner I agree it wasn't the best solution but I meant to
include it for the sake of testing `configureNestedVirtualization` method.
Which approach can I take to test this m
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Thanks @rafaelweingartner, I agree with you, I refactored it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Sure, done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
I had removed it, I saw your comment in that file and I included it in last
refactor, I forgot to mention it in my last comment :)
---
If your project is set up for it, you can reply to this
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1542#discussion_r74667063
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2184,7 +2184,7 @@ int getReservedCpuMHZ
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1542
Thanks @rafaelweingartner
This is the link to JIRA ticket:
https://issues.apache.org/jira/browse/CLOUDSTACK-9457
---
If your project is set up for it, you can reply to this email and
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1593#discussion_r74807418
--- Diff: usage/src/com/cloud/usage/UsageSanityChecker.java ---
@@ -72,7 +72,9 @@ protected boolean checkItemCountByPstmt(CheckCase
checkCase) throws
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1593#discussion_r74966728
--- Diff: usage/src/com/cloud/usage/UsageSanityChecker.java ---
@@ -72,7 +72,9 @@ protected boolean checkItemCountByPstmt(CheckCase
checkCase) throws
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1605
Thanks @sateesh-chodapuneedi!
You've mentioned before that you will test this in your env, can you please
share your tests results?
---
If your project is set up for it, you can rep
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1593
@jburwell Sure, they are squashed now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1605
@rafaelweingartner Thanks for your review! I'll work on your suggestions!
@jburwell Sure, I'll work on it
---
If your project is set up for it, you can reply to this email and
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1660
CLOUDSTACK-9470: [BLOCKER] Fix for test_network_acl, SshHelper
## Problem
In a Vmware environment, running `test_network_acl` we examined why
sometimes it failed and sometimes it passed
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1605
Thanks @rafaelweingartner for your review! I've been working on it and
pushed changes based on your comments!
The only thing I need to mention is that actually I can't remo
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1605
Thanks @rafaelweingartner! I pushed new changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1605
Done, thanks @rafaelweingartner! I'll start working on adding Marvin tests
for this PR as @jburwell suggested.
---
If your project is set up for it, you can reply to this email and have
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1660
Hi @rhtyd, it would be nice to include it in 4.9. I tried rebasing branch
4.9 but it tries to update poms to 4.10 version, what do you suggest me to do?
---
If your project is set up for it
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1660
Done, thanks @rhtyd for your help, it was really useful!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1660#discussion_r76517779
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -195,6 +195,15 @@ public static void scpTo(String host, int port, String
user
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1660#discussion_r76517786
--- Diff: utils/src/main/java/com/cloud/utils/ssh/SshHelper.java ---
@@ -195,6 +195,15 @@ public static void scpTo(String host, int port, String
user
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1660
Thanks @rhtyd @jburwell for reviewing!
@jburwell sure, now PR is targeted to 4.9 branch. Jenkins hadn't started
properly last time and failed, with last refactor it started properly. I
101 - 200 of 396 matches
Mail list logo
