Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@rafaelweingartner thanks for reviewing! I extracted code to new methods
and also added unit tests for them
---
If your project is set up for it, you can reply to this email and have your
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@rafaelweingartner I think I got your point, I tried to keep code as
similar as it was before, by declaring `rollBackState` as static class variable
on line 114. This way inner `finally` block
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1847
@borisstoyanov @rhtyd I was checking BlueOrangutan logs:
In `test_primary_storage_8NPG5G\runinfo.txt` lines 27-30, there's PS
creation:
2017-02-20 11:03:59,678 -
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@rafaelweingartner no problem, I should have mentioned about changing the
variable to static. I'll work on your last comments :)
---
If your project is set up for it, you can reply to
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102530895
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean
cleanup
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102531047
--- Diff: server/test/com/cloud/user/DomainManagerImplTest.java ---
@@ -134,4 +164,67 @@ public void testFindDomainByIdOrPathValidId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102529801
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean
cleanup
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102531132
--- Diff: server/src/com/cloud/user/DomainManagerImpl.java ---
@@ -273,82 +289,133 @@ public boolean deleteDomain(long domainId, Boolean
cleanup
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1961
Fix for test_snapshots.py using nfs2 instead of nfs template
Fix for marvin test failure introduced in #1847
Cc: @borisstoyanov @rhtyd @karuturi
You can merge this pull request
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1961
@borisstoyanov great, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1935#discussion_r102556528
--- Diff: server/test/com/cloud/user/DomainManagerImplTest.java ---
@@ -134,4 +164,67 @@ public void testFindDomainByIdOrPathValidId
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1961
@karuturi @borisstoyanov next step will be updating Marvin's folder
`test_data.py` file and configure an url for key "nfs2" similar as it was done
for "nfs", this wa
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
Hi @rafaelweingartner, I've refactored the code instead of using
`rollBackState` as static. I think that using static variable could lead to a
problem if new methods are invoked from an
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1961
Hi @karuturi @rhtyd @borisstoyanov,
I've pushed a new commit for fixing `test_snapshots.py` failure. Can you
please run tests against Vmware and Kvm?
These were results in ou
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1961#discussion_r103932149
--- Diff: test/integration/smoke/test_snapshots.py ---
@@ -275,7 +275,7 @@ def
test_02_list_snapshots_with_removed_data_store(self
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1961
@borisstoyanov actually disk is not being dettached from vm before
migrating it, it is using vm's ROOT disk, it can be done on Vmware by setting
`livemigrate='true'` to migrat
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1961
@borisstoyanov I refactored marvin test to migrate a detached disk instead
of vm's root volume as it was before. Can you please test it again in your env?
---
If your project is set up f
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1961
That's great! Thanks @borisstoyanov for your help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1879
Sure @serg38, after enabling HA on cluster, stopping VR and the starting VR
we got this exception on ESXi 6:
2017-03-06 12:18:14,654 ERROR [cloud.vm.VmWorkJobDispatcher]
(Work-Job
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@sureshanaparti sure, we use version 6.0.0, build 3634794
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1994
CLOUDSTACK-9827: Storage tags stored in multiple places
Issue description: https://issues.apache.org/jira/browse/CLOUDSTACK-9827
### Fixes
- Create Primary Storage: Persist tags
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
Hi @rafaelweingartner, you're right, it was basically that fix.
I've pushed another commit due to issue reported by @mike-tutkowski in
mailing list:
I have an NFS SR
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@serg38 actually is not being used anymore, I'll add removalof the view on
last commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@mike-tutkowski awesome, thanks for testing this PR!
@rafaelweingartner thanks for reviewing, I'll work on changes proposed
@karuturi sure, I'll work on it, thanks
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@rafaelweingartner I pushed changes and squashed my commits as it could be
easier to review. I also added unit tests for new methods
---
If your project is set up for it, you can reply to
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105796076
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105796786
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105796872
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105797159
--- Diff:
engine/schema/src/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImpl.java
---
@@ -409,15 +460,13 @@ public StoragePoolVO
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1918
@jayakarteek @rafaelweingartner what about retrieving CPU performance
metric for usage using
[PerfomanceManager](https://pubs.vmware.com/vsphere-60/index.jsp#com.vmware.wssdk.apiref.doc
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1278
Hi @rafaelweingartner @anshul1886 @GabrielBrascher,
I've read this PR's comments several times and I think I could understand
@anshul1886's point. Please correct me if
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1879
@sureshanaparti I pulled the latest code and repeated the first test
scenario, got the same failure: `Message: The setting of vmConfig is invalid
for cluster CLD100.`. I attach the full
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105989477
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,68 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105990460
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +90,68 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105992671
--- Diff:
engine/schema/test/com/cloud/storage/dao/StoragePoolTagsDaoImplTest.java ---
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r105998903
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r106002237
--- Diff:
engine/schema/test/org/apache/cloudstack/storage/datastore/db/PrimaryDataStoreDaoImplTest.java
---
@@ -0,0 +1,151 @@
+// Licensed to
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r106303439
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r106311985
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
Hi @karuturi, I've been working on marvin tests, I hope posting them today
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1994#discussion_r106724343
--- Diff:
engine/schema/src/com/cloud/storage/dao/StoragePoolTagsDaoImpl.java ---
@@ -77,4 +92,71 @@ public void deleteTags(long poolId
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@karuturi I added marvin tests to simulate tests performed by
@mike-tutkowski.
This are results in our env:
[root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//011CTF
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
Thanks @serg38, we are using `mgtSvr` details provided in .cfg file, should
we use these for Marvin too?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
Thanks @mike-tutkowski! I pushed force to kick off Travis again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@karuturi I refactored last marvin test which was failing on Travis. These
are results in our env:
[root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//4GSNSY/results.txt
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1994
@karuturi Travis is now failing as it doesn't find key "nfs2"
2017-03-24 17:33:45,621 - CRITICAL - EXCEPTION:
test_03_migration_options_storage_tags: ['Traceba
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/2021
CLOUDSTACK-9854: Fix test_primary_storage test failure due to live migration
Fix for test_primary_storage integration tests on simulator.
When finding storage pool migration options
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/2021
Thanks @borisstoyanov, I made little refactor due to failure, can you
please re kick tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/2019
LGTM, travis failure is not related to this PR, it is fixed in #2021
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/2021
@karuturi sure, done! I rebased master and pushed, now Travis passes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Hi @rhtyd, thanks for this great improvement! Along with @serg38 we've been
testing in our env and got some failures on `listHostsMetrics` and
`listVolumeMe
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1935
@borisstoyanov I've rebased master branch, can we re-run tests on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1918
LGTM for testing. Tested on Vmware 6.0, I attach some screenshots for test
scenarios, in which vm was deployed using service offering, infinite loop was
executed to increase CPU utilization
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1944
Please ommit my last comment, we were using commons-beanutils version 1.8.3
instead of 1.9.2
LGTM
[root@ussarlabcsmgt41 cloudstack]# cat /tmp//MarvinLogs//DVIXST
Github user nvazquez commented on the issue:
https://github.com/apache/cloudstack/pull/1879
Thanks @sureshanaparti! I tested scenarios and work as expected!
I attach some screenshots:
- Test scenario 1: Enable HA after VR created, stop VR, start VR.
 a vm (id=) which is al
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-173439752
Thanks for your help @cristofolini!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1361
Support configurable NFS version for Secondary Storage mounts
JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-9252
### Description of the problem
After starting
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-175056442
Hi @rafaelweingartner,
Thanks for your review! I agree with @serg38, it was thought just to extend
the functionality by adding an entry on
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-175103859
Ok, @rafaelweingartner I'll work on refactoring this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-176351414
Hi @bhaisaab ,
Which test files would you like me to run? Is this ok with this command on
each file?
nosetests --with-marvin --marvin-config=setup/dev
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-176752434
@rafaelweingartner I pushed some changes according to your comments. Is it
better like this?
---
If your project is set up for it, you can reply to this email
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-178190394
Hi @rafaelweingartner
Thanks for your comments! I've been working following your indications,
however I didn't create any test case.
I wan
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-178346694
@rafaelweingartner thanks for your reply!
I'm familiar to Spring, I've worked with it, I know how it works but I
wouldn't say I know it i
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-180363651
Hi @bhaisaab can you help me testing this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-181041714
Hi @DaanHoogland can you help us with Jenkins build? A test file
SecondaryStorageManagerTest.java is failing, but that file is not
in the branch. I could compile
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-181571630
Thanks @DaanHoogland, I pushed again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-181644342
This time it failed for timeout
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-181646997
Sure, I'll do it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-181909261
Thanks a lot @rafaelweingartner for your words and your help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-185194859
Sure @kishankavala, to set NFS version for a store with id
STORE_ID you'll need to insert a record in
image_store_details_table which has:
* sto
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-186444960
Hi @bhaisaab sorry I couldn't post this earlier but I've been working on
another pull request and couldn't be able to test this one before.
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/935
From4.5.1: NSX/Nicira Plugin does not support NSX v4.2.1
JIRA Ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-8956
You can merge this pull request into a Git repository by running
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-148715124
Hi @miguelaferreira @remibergsma
Thanks a lot for your help. I will try to make a better description of the
problem and work on commits and code as you
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-149582907
@miguelaferreira @remibergsma
Thanks again for your help! As you suggested I rebased master branch. I
also added a more detailed description of the patch on
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-150012697
### VMware vSphere API version from 5.1 to 5.5:
Since vSphere API version 5.5,
[OpaqueNetworks](https://www.vmware.com/support/developer/converter-sdk
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-150676496
@miguelaferreira thanks a lot for your help and advices! As suggested I
post test_nicira_controller.py results:
$ cat /tmp/MarvinLogs
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-155418071
@wilderrodrigues Thanks a lot Wilder!
@miguelaferreira Thanks for following this PR and testing it!
---
If your project is set up for it, you can reply to
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157154339
@miguelaferreira Great, I rebased my branch to master and pushed again
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157718592
@remibergsma It looks like it is not finding 5.5 jar. These are the steps I
followed:
* Download VMware-vSphere-SDK-5.5.0-1284541.zip file from
https
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157727519
@DaanHoogland Hi! No, just renaming the old jar (version 5.1) will fail
because it doesn't contain opaque network classes. Those ones are introduced in
th
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157731551
@DaanHoogland No, it's not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157739765
@DaanHoogland Ok, sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-157782057
@DaanHoogland those warnings are in files that don't belong to my pull
request.
I could see in
http://jenkins.buildacloud.org/job/build-master-slowbuild
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1094
CLOUDSTACK-9074: Support shared networking in NiciraNVP Plugin
JIRA TICKET:
https://issues.apache.org/jira/browse/CLOUDSTACK-9074
Design Document:
https://cwiki.apache.org
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-159007416
Thanks @remibergsma !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-159634391
@remibergsma thanks Remi, I rebased to master branch and resolved a few
conflicts
---
If your project is set up for it, you can reply to this email and have your
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/commit/e66dd8c1e00abb9a3b4cbe0b8b50c83b251a728c#commitcomment-14620035
Hi @davidamorimfaria ,
I had the same issue that @pdion891 had. I added missing quotes as you
suggested in PR#1114 but
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-160636372
@miguelaferreira thanks for reviewing! Sure, would be great to discuss them
---
If your project is set up for it, you can reply to this email and have your
reply
1 - 100 of 396 matches
Mail list logo
