Github user nitt10prashant closed the pull request at:
https://github.com/apache/cloudstack/pull/1563
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitt10prashant commented on the issue:
https://github.com/apache/cloudstack/pull/1563
Not needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user nitt10prashant closed the pull request at:
https://github.com/apache/cloudstack/pull/1573
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitt10prashant commented on the issue:
https://github.com/apache/cloudstack/pull/1573
not needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1048#issuecomment-164736785
can you please share test result ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1048#issuecomment-164740710
LGTM based on code review and test case result
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1199#issuecomment-172463466
LGTM
based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1190#issuecomment-172466590
LGTM
Test revert snapshot on XenServer ... ===
TestName:test_01_check_revert_snapshot | Status SUCCESS ===
ok
---
If your project is set up for it
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-182784773
LGTM ..based on code review and result .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/1417
CLOUDSTACK-9289:Automation for feature deploy vm from vmsnapshot
Automation for deploy vm from snapshot .
1-Test to create VM from vm snapshots without data disk
2-Deploy vm from
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1031#discussion_r53300709
--- Diff: test/integration/testpaths/testpath_storage_migration.py ---
@@ -248,6 +248,11 @@ def setUpClass(cls):
DomainName
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/226
CLOUDSTACK-8439:Automation for feature CPU/Memory overcommit
Tested on xen,kvm,vmware environments
Test result:
--
enge cpu/mem.overprovisioning.factor at
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/252
Automation for feature Enable configuring local storage use for system VMs
at zone level
You can merge this pull request into a Git repository by running:
$ git pull https
Github user nitt10prashant closed the pull request at:
https://github.com/apache/cloudstack/pull/252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/253
CLOUDSTACK-8471:Automation for feature Enable configuring local storage use
for system VMs at zone level
CLOUDSTACK-8471
You can merge this pull request into a Git repository by running
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/263#issuecomment-104206860
List service offerings for systemvms and verify there should be two ... ===
TestName: test_01_list_system_offerngs_1_consoleproxy | Status : SUCCESS
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/507
CLOUDSTACK-8577: fixing script testpath_disable_enable_zone
disable enable cluster ... === TestName: test_01_disable_enable_cluster |
Status : SUCCESS ===
ok
disable enable host
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/518
CLOUDSTACK-8583 :fixing issue related to script test_stopped_vm
ested
Test Deploy Virtual Machine with startVM=true parameter ... === TestName
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/960
CLOUDSTACK-8975:skip test case if niciraNvp settings are not available in
config file
root/cloudstack/test/integration/smoke/test_nicira_controller.py is failing
if niciraNvp settings
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150161922
@miguelaferreira i was going though mail thread and found this
"I think the test should fail if the config is not right, or otherwise be
exclud
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150501158
@runseb
"I personally fail to see the benefit of skipped tests versus a failed test"
If i may ,
skip is a type of failure where y
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-151720250
based on discussion closing the PR
Thanks @remibergsma @runseb @miguelaferreira @pvr9711 for great discussion
.
---
If your project is set up for it
Github user nitt10prashant closed the pull request at:
https://github.com/apache/cloudstack/pull/960
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/994#issuecomment-153285936
LGTM based on code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1000#issuecomment-153287076
LGTM Based on code understanding
One line change if attribute is there then proceed to cleanup if
hasattr(self, "data_volume_cr
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/1153
CLOUDSTACK-9087:adding projectid parameter to create method of class
VmSnapshot
Adding projectid parameter to class VmSnapshot of base.py .
You can merge this pull request into a Git
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1153#issuecomment-161931625
@pdube you are right projectid is not required , i did check API doc but
got confused with UI and took it as doc bug.
when createVMSnapshot is being
Github user nitt10prashant closed the pull request at:
https://github.com/apache/cloudstack/pull/1153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitt10prashant closed the pull request at:
https://github.com/apache/cloudstack/pull/507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user nitt10prashant reopened a pull request:
https://github.com/apache/cloudstack/pull/507
CLOUDSTACK-8577: fixing script testpath_disable_enable_zone
disable enable cluster ... === TestName: test_01_disable_enable_cluster |
Status : SUCCESS ===
ok
disable enable
Github user nitt10prashant closed the pull request at:
https://github.com/apache/cloudstack/pull/507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/565
CLOUDSTACK-8615 :skip all tests in test_ps_limits.py for lxc
issue
---
All test cases are failing due to unsupported storage type
solution
---
skip
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/565#issuecomment-119188008
Test assign Vm to different account ... SKIP: unsupported storage type
Test assign Vm to different account ... SKIP: unsupported storage type
Stop
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/567
CLOUDSTACK-8583 : fixing issue related to script test/integration/comâ¦
issue
---
Few testcases are failing because of unsupported storage type .Deploy vm
with data disk is
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/566#discussion_r34134668
--- Diff: test/integration/component/test_project_template.py ---
@@ -0,0 +1,172 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/566#discussion_r34134700
--- Diff: test/integration/component/test_project_template.py ---
@@ -0,0 +1,172 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/566#discussion_r34134758
--- Diff: test/integration/component/test_user_taglisting.py ---
@@ -0,0 +1,129 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/566#discussion_r34134916
--- Diff: test/integration/component/test_project_template.py ---
@@ -0,0 +1,172 @@
+# Licensed to the Apache Software Foundation (ASF) under
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/570
CLOUDSTACK-8620 :skip test cases if rbd storage is not available in lâ¦
skipping tests based on storage for lxc hype and fixing pep8 issues
test result
=
Test
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/569#issuecomment-119887574
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/569#discussion_r34238492
--- Diff: test/integration/component/test_blocker_bugs.py ---
@@ -663,7 +663,14 @@ def test_01_restart_network_cleanup(self):
#all
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/569#issuecomment-119913350
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/579
CLOUDSTACK-8626 :[Automation]fixing test/integration/component/test_pâ¦
â¦s_max_limits.py for lxc hypervisor
test results
Test Try to deploy VM with admin
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/585
CLOUDSTACK-8631 :changing if condition in component/test_ss_max_limitâ¦
test result
Test Try to deploy VM with admin account where account has not used ... ===
TestName
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/585#issuecomment-121210527
its there in ticket
On Tue, Jul 14, 2015 at 5:03 PM, sanju1010 wrote:
> Can you please specify the reason for changing the if condition
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/595
CLOUDSTACK-8639:fixing calculation mistakes in component/test_ss_domaâ¦
test result
=
Test secondary storage limit of domain and its sub-domains ... ===
TestName
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/613#discussion_r35197771
--- Diff: test/integration/testpaths/testpath_uuid_event.py ---
@@ -0,0 +1,198 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/619#issuecomment-125107406
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/638#issuecomment-126589627
can you post test results ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/638#issuecomment-126656909
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/644#issuecomment-127186217
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/158#issuecomment-127891937
enabled = enabled if enabled else 'true'
will set enable to true if enable is false or None which is unexpected,
ideally enable shoul
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/671#issuecomment-129401139
Looks Good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/675#discussion_r36731289
--- Diff: test/integration/testpaths/testpath_usage.py ---
@@ -2879,6 +2882,60 @@ def test_07_positive_tests_usage(self
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/675#discussion_r36732367
--- Diff: test/integration/testpaths/testpath_usage.py ---
@@ -2879,6 +2882,60 @@ def test_07_positive_tests_usage(self
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-129836794
can we get test result ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/667#discussion_r36733719
--- Diff: test/integration/testpaths/testpath_restore_vm.py ---
@@ -0,0 +1,201 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-129837984
can we get test results ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/665#discussion_r36733882
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/665#discussion_r36734207
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/665#discussion_r36734361
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/665#discussion_r36735392
--- Diff: test/integration/testpaths/testpath_multiple_snapshot.py ---
@@ -0,0 +1,279 @@
+# Licensed to the Apache Software Foundation (ASF
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/665#issuecomment-129846827
can you update test results ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/683#discussion_r36845123
--- Diff: test/integration/component/test_simultaneous_volume_attach.py ---
@@ -0,0 +1,264 @@
+# Licensed to the Apache Software Foundation
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/683#discussion_r36845173
--- Diff: test/integration/component/test_simultaneous_volume_attach.py ---
@@ -0,0 +1,264 @@
+# Licensed to the Apache Software Foundation
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/683#discussion_r36940905
--- Diff: test/integration/component/test_simultaneous_volume_attach.py ---
@@ -0,0 +1,256 @@
+# Licensed to the Apache Software Foundation
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/683#issuecomment-130587552
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/646#issuecomment-130588174
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/713
CLOUDSTACK-8745 : verify usage after root disk migration
put storage in maintenance mode and start ha vm and check usage ... ===
TestName: test_ha_with_storage_maintenance | Status
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379373
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379426
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37379748
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37380762
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/713#discussion_r37380740
--- Diff: test/integration/component/maint/test_ha_pool_maintenance.py ---
@@ -0,0 +1,229 @@
+#!/usr/bin/env python
+# Licensed to the
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/713#issuecomment-132476722
test result of enough storage is not available to perform test
put storage in maintenance mode and start ha vm and check usage ... SKIP:
sufficient
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/665#issuecomment-132583048
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/724#discussion_r37625731
--- Diff: test/integration/component/test_escalations_routers.py ---
@@ -0,0 +1,189 @@
+# Licensed to the Apache Software Foundation (ASF
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/742
[Automation]Volume migration between pools times out in ACS, but but the
migration completes on Xenserve
Ticket :CLOUDSTACK-8771
description:
Volume migration between
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/688#issuecomment-134972409
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-139530956
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nitt10prashant closed the pull request at:
https://github.com/apache/cloudstack/pull/742
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/871#issuecomment-142493294
LGTM!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/871#issuecomment-142820449
@remibergsma Next time sure I will add some details .for this PR i have
updated my comments .
---
If your project is set up for it, you can reply to this
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-220521199
@swill i do not see any comment on parent ticket CLOUDSTACK-8676 , i have
asked Sateesh to update the ticket , will update the PR as soon as i hear from
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/1563
CLOUDSTACK-9389:changing check_string from 3 packets received to 3 reâ¦
test cases were failing due to invalid check_string so changing
check_string from "3 packets rec
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222438208
test result
Prashants-MacBook-Pro:test_routers_network_ops_TWUWR8 prashant$ cat
results.txt
Test redundant router internals
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222439377
@swill i don't see any issue in my setup , please checktest result
[results.txt](https://github.com/apache/cloudstack/files/289139/result
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563#issuecomment-222635435
@koushik-das as you have asked done following
1- moved check_string to test_data.py
2-provided test result
can you review changes .
---
If
GitHub user nitt10prashant opened a pull request:
https://github.com/apache/cloudstack/pull/1573
CLOUDSTACK-9396:fixing issue related to script test_dhcphosts
fixing following
1-issue related to check_String:changed check string to "3 received" and
use test_data
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563
@swill My MS is running on Rhel6.3 , in script we are doing ssh to guest
vm and then trying to ping 8.8.8.8 so ping is dependent on guest template OS ,
in my case i am using
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1563
@swill Thinking about 3(.*?) received , i have placed check_string in
test_data.py , which can be modified depend on guest OS type . I followed cent
os ping pattern since most
Github user nitt10prashant commented on the issue:
https://github.com/apache/cloudstack/pull/1563
-->I think it is important that the test data does not need to be changed
for our automated(ish) CI to show the tests are passing
@swill i think test-data meant to be changed dep
Github user nitt10prashant commented on the issue:
https://github.com/apache/cloudstack/pull/1563
@swill just curious to know Which guest OS you are using ? Since Cent OS
template is default in ACS i modified test_data for cent OS.
Regx should be consider ?
->I Ag
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1377#issuecomment-188173843
this is redundant case , and checking time to create vmsnapshot is not
required for this bug.
I have talked to @sarathkouk , he understood the issue and
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/713#issuecomment-191098254
sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1417#discussion_r55160105
--- Diff: test/integration/component/test_deploy_vm_from_snapshot.py ---
@@ -0,0 +1,644 @@
+# Licensed to the Apache Software Foundation (ASF
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1417#issuecomment-198314365
@GabrielBrascher @sanju1010 i have removed redundant code
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60531171
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1500#discussion_r60531417
--- Diff: test/integration/component/test_volumes.py ---
@@ -603,7 +603,144 @@ def test_01_volume_attach_detach(self):
"
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/1501#issuecomment-212767179
LGTM based on code review @mike-tutkowski can you provide test results
---
If your project is set up for it, you can reply to this email and have your
1 - 100 of 109 matches
Mail list logo
