GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1335
CLOUDSTACK-9230: Remove unnecessary return statement from cloudStack.js
Removed the unnecessary return statement.
The statement is never reached.
You can merge this pull request
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1336
CLOUDSTACK-9231: Root volume migration from one primary to another primary
storage within the same cluster is failing
EXPECTED BEHAVIOUR:
Root Volume
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1337
CLOUDSTACK-9235: Autoscale button is missing in VPC
Autoscale button is missing. This should not be the case since we are able
to add NS as the external LB provider in VPC
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1338
CLOUDSTACK-9236: Load Balancing Health Check button displayed when
non-NetScaler offering is used
Load balancing health check option / button should only be displayed when a
NetScaler
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1338#issuecomment-171381086
@rafaelweingartner : Super I will make the modification on both PRs.
Thanks.
---
If your project is set up for it, you can reply to this email and have
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1339
CLOUDSTACK-9237: Create LB Healthcheck issues - button alignment and error
message goes outside the window
Browser - Chrome Version 47.0.2526.106 m
Steps to Repro
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1339#issuecomment-171604545
Oops my mistake. I will make one. Thanks @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1340
CLOUDSTACK-9237: Create LB Healthcheck issues - button alignment and error
message goes outside the window
Browser - Chrome Version 47.0.2526.106 m
Steps to Repro
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1339#issuecomment-171607891
Created a request against 4.7. (PR #1340)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/1339
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1319#issuecomment-172376856
Sure @remi
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1338#issuecomment-173436054
Thanks @remibergsma. Sorry I saw your comments bit late. You have already
figured it out. Thanks @DaanHoogland
---
If your project is set up for it, you
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1333#issuecomment-174411698
Hi @rafaelweingartner , I have updated the required change. Please have a
look. Thank you.
---
If your project is set up for it, you can reply to this
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1333#issuecomment-174578490
@rafaelweingartner : Yes, it will be forward merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1390
CLOUDSTACK-9267: String is not localized on create instance wizards.
Repro Steps:
==
1. Setup basic environments as normal.
2. Open a browser, go to Web Console
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-178522940
I thought of making a small explanation. But I follow this template while
making a PR so that it would be easy for committer to review very fast. Anyway
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-178526046
There is one more localised issue in the project page, So instead of
creating a new one adding it to this PR only.
---
If your project is set up for it
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1394
CLOUDSTACK-9268: Display VM in Load balancing rule in UI
Steps of Repro:
=
1:Create VMs
2:Make LoadBalancing rule in GUI
ãName:WWW
ãPrivatePort:80
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1394#issuecomment-178716448
Before Fix:
=
.
Configure physical network
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1398
CLOUDSTACK-9270: UI alignment gone bad in multiple places - VM Instance,
Network, Egress rules
Steps to Repro:
Please see the snapshots attached.
Fix
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1399
CLOUDSTACK-9272: No option in UI to add GSLB with service type "HTTP"
Steps to Repro:
Go to Regions -> Local -> View GSLB -> Add GSLB
Click
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-184053093
@rafaelweingartner : Its already present in our code. It translates the
dictionary keys.
---
If your project is set up for it, you can reply to this email
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/897
CLOUDSTACK-8919: Slow UI response while loading the list of networks in
network tab.
Instead of searching for each network, now it is searching for each zone.
For basic zone, it will
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/823#issuecomment-144333001
Hi @remibergsma,
I rebased my commit against the current master.
I added unit test for the change.
Thanks,
Nitin
---
If your project is
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/891#issuecomment-144361240
Hi @runseb, Added two snapshots of before change and after change.
Before Change:
![pr_891_before_change](https://cloud.githubusercontent.com
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/903
CLOUDSTACK-8928: While adding VMs to LB rule, default NIC IP is always
displayed rather than the IP corresponding to the NIC where LB is being created
While calling the listNics API
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/906
CLOUDSTACK-8930: Showing blank screen when click 'Next' link in final step
of Add Zone wizard.
Issue:
Showing blank screen with 'Next' and 'Cancel'
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/906
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/906#issuecomment-146100382
@milamberspace Thanks for making a new PR.
Closed my PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/903#issuecomment-146101066
@runseb I think there is no automated tests for this. I will try to write
one. Thanks.
---
If your project is set up for it, you can reply to this email and
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/915#issuecomment-147202774
Thanks @milamberspace @karuturi @bhaisaab @DaanHoogland..
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/945
CLOUDSTACK-8962: Dedicated cluster is used for virtual routers that belong
to non-dedicated account
Earlier the deployment planner was not handling the case of virtual
routers.(In
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/953
CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance
Added a new Icon in Instance page to launch the VM from the snapshot.
A new icon over VM snapshot object, which
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/945#issuecomment-150112575
Sure @remibergsma. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/953#issuecomment-150837653
Sure @remibergsma I will do that. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/903#issuecomment-150840976
@remibergsma I was busy in some other works. Within 3-4 days I will work on
this and will give an update. Thank you.
---
If your project is set up for it
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/897#issuecomment-152412317
Thanks @sudhansu7. I had also the similar idea. @remibergsma @runseb please
look at the comments of sudhansu. Thanks.
---
If your project is set up for it
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/823#issuecomment-152453158
I tested this with this scenario.
There are three service offerings.
{
"listserviceofferingsresponse": {
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/903#issuecomment-152456961
Hi @runseb @remibergsma I don't understand how to write a test for this. If
you have any idea of how to write one, please help me out. Thanks.
---
If
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/903#issuecomment-153083572
Thanks @karuturi @remibergsma.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/897#issuecomment-153093925
Hi @remibergsma, I tried rebasing with current master. There is no conflict
as such.
I think you were trying to merge the PR #987, But this PR is
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1076
CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load
For setting the width of each data item for each row of Port Forwarding
rules, it was processing all rules
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1077
CLOUDSTACK-9069: Newly added project is not showing in the drop down until
the browser is refreshed.
The created or deleted project was added to/deleted from the list but it
was
Github user nitin-maharana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1076#discussion_r45074032
--- Diff: ui/scripts/ui/widgets/multiEdit.js ---
@@ -279,7 +279,7 @@
}
// Align width to main
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1080
CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nitin
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/1080
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1076#issuecomment-157440647
Hi @remibergsma
Actually 4.6 is nine commits behind this branch. So I am making one more
pull request with different branch. Thanks.
---
If your
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1081
CLOUDSTACK-9068: Listing Port Forwarding Rules take too much time to load
For setting the width of each data item for each row of Port Forwarding
rules, it was processing all rules
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1082
CLOUDSTACK-9069: Newly added project is not showing in the drop down until
the browser is refreshed.
The created or deleted project was added to/deleted from the list but it
was not
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/1076
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1082#issuecomment-159181399
@rafaelweingartner This is happening in 4.5. I checked with this master.
---
If your project is set up for it, you can reply to this email and have your
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1077#issuecomment-159181731
@rafaelweingartner This PR will merge with current master. and #1082 Will
merge in branch 4.6. Thanks.
---
If your project is set up for it, you can reply
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1082#issuecomment-159346524
I tested in chrome and firefox.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1082#issuecomment-161256224
I checked in Internet Explorer and Chromium browser also. It is working
fine.
---
If your project is set up for it, you can reply to this email and have
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1150
CLOUDSTACK-8968: UI icon over VM snapshot to deploy user instance
Added a new Icon in Instance page to launch the VM from the snapshot.
A new icon over VM snapshot object, which
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/953
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/953#issuecomment-161262674
Made a pull request to merge in 4.6. So closing this PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/1077
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1077#issuecomment-161263377
Closing this PR. As #1082 is there to merge in 4.6. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1150#issuecomment-162612180
@bhaisaab @DaanHoogland I updated the change with current 4.6 branch and
removed the commented codes. @remibergsma This only supports in VMware. Thanks
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1082#issuecomment-162762394
Hi @remibergsma, here I attached the snapshots. See the cursor arrows.
Changes made in network.js file.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/785
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/786
CLOUDSTACK-8821: UI Change
It provides appropriate message in the UI when configuring the firewall
rules in Network page.
If the default egress policy is allow, then it says to block
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-138648018
I tested on 4.5. I used mysql 5.6 client. It is working perfectly fine.
I think the squirrel client doesn't support the replace function or there
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-138650940
I am making one more pull request with your solution from a different
branch.
---
If your project is set up for it, you can reply to this email and have
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/790
CLOUDSTACK-8805: Domains become inactive automatically.
Handled the '%' case by replacing that with a literal character rather than
a wildcard character.
You can merge this pu
Github user nitin-maharana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/786#discussion_r39011419
--- Diff: ui/scripts/network.js ---
@@ -1612,6 +1613,36
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/791
CLOUDSTACK-8821: UI Change while configuring firewall rule.
It provides appropriate message in the UI when configuring the firewall
rules in Network page.
If the default egress
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-138810904
Yes, It can be possible. But I have not hard-coded this change, I followed
the way sql queries are generated everywhere. This way of generating SQL query
is
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/786
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-139152995
@rafaelweingartner Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-139862762
@DaanHoogland I will write unit tests for this. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/823
CLOUDSTACK-8847: ListServiceOfferings is returning incompatible tagged
offerings when called with VM id
When calling listServiceOfferings with VM id as parameter. It is returning
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/790#issuecomment-140999446
@remibergsma Yes this one should be closed. PR #775 does the same thing.
Thanks.
---
If your project is set up for it, you can reply to this email and have
Github user nitin-maharana closed the pull request at:
https://github.com/apache/cloudstack/pull/790
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-141015775
@DaanHoogland, @rafaelweingartner Yes I understand, I also think there
should be test cases for a change because we don't know the entire logic. As
the
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-141687462
Thanks for the suggestion. yes, I will follow the same. I will make an
another PR with the change and test file.
---
If your project is set up for it, you
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-143041644
Hi. Here we have to access the database to see the behaviour of replace
function. Because the replace function is evaluated in database server side.
But in
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/891
CLOUDSTACK-8913: Search box in Templates tab out of alignment
Increased the margin and padding to accomodate all the boxes inside toolbar.
You can merge this pull request into a Git
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/891#issuecomment-143419034
Sorry Its Decreased not increased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/775
### ACS CI BVT Run
**Sumarry:**
Build Number 131
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3
_Link to logs Folder
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/786
Hi @GabrielAnca,
Generally we show some information in notification field(Top-Right side
corner), which disappears after one or two seconds. But that is used in case of
any event
Congrats Rafael.
On Tue, Feb 23, 2016 at 10:13 PM, Ahmad wrote:
> Congrats Rafael!
>
> > On Feb 23, 2016, at 12:19 AM, Daan Hoogland
> wrote:
> >
> > The Project Management Committee (PMC) for Apache CloudStack
> > has asked Rafael Weingartner to become a committer and we are pleased to
> > ann
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1390#issuecomment-188609151
@rafaelweingartner : I have tested all changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1333#issuecomment-212799750
@koushik-das: Actually this dialog appears after the first CIDR unchanged
confirmation dialog. If its an admin account, Even if we select yes/no, it will
be
Github user nitin-maharana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1255#discussion_r60544347
--- Diff: ui/scripts/network.js ---
@@ -6517,7 +6445,192
Github user nitin-maharana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1255#discussion_r60544256
--- Diff: ui/scripts/network.js ---
@@ -4508,99 +4524,11 @@
$('').addClass(
Github user nitin-maharana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1255#discussion_r60544689
--- Diff: ui/scripts/network.js ---
@@ -6517,7 +6445,192
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1321#issuecomment-212898459
@koushik-das : I also think the same. Yes, that would be better. I will
raise another PR with removing the existing implementation. pinging @agneya2001
Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1333#issuecomment-214306315
@koushik-das : I will check it. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1758
CLOUDSTACK-9588: Add Load Balancer functionality in Network page is
Redundant.
Steps to Reproduce:
Network -> Select any network -> Observer Add Load Balancer tab
The &qu
Github user nitin-maharana commented on the issue:
https://github.com/apache/cloudstack/pull/1758
The Add Load Balancer tab was removed.
The same
GitHub user nitin-maharana opened a pull request:
https://github.com/apache/cloudstack/pull/1771
CLOUDSTACK-9611: Dedicating a Guest VLAN range to Project does not work.
Description:
=
Trying to dedicate a guest VLAN range to an account fails. Either API
101 - 200 of 243 matches
Mail list logo
