Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@serg38 Not sure to understand what you mean with:
> If I get it right with your proposed changes, upgrade scripts become
obsolete since all the changes can be done in upgrade scri
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1768
I'll try to make my point clearer with a better use case. Let say you were
running version ACS 4.4.2 and wish to upgrade to 4.7.1. After installing the
4.7.1, when ACS starts for the
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1768
As a reminder for `-cleanup` SQL scripts:
> We rarely need cleanup scripts, only when some field/value is required
during the data migration and has to be dropped later
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@syed I would prefer to move what's inside `schema-481to490-cleanup.sql` to
the end of the file `schema-481to490.sql` as it would have been the way of
processing during an update from 4
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1768
I looked at the code inside `Upgrade481to490.java` and I cannot understand
why the table alterations have been made inside the Java class instead of the
SQL file. Because now we cannot move
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1768
Forget my last comment, the files can remains as they are.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1944#discussion_r103143033
--- Diff: plugins/metrics/pom.xml ---
@@ -0,0 +1,55 @@
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@rhtyd I don't see how I could write such a test case. My point is exactly
what you're saying, the upgrade would be different today for anyone who comes
from an older version, whi
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1768#discussion_r103394277
--- Diff: engine/schema/src/com/cloud/upgrade/DatabaseUpgradeChecker.java
---
@@ -424,27 +421,9 @@ protected void upgrade(CloudStackVersion
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1832
@karuturi Ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/2027
Activate NioTest following changes in CLOUDSTACK-9348 PR #1549
The first PR #1493 re-enabled the NioTest but not the new PR #1549.
@rhtyd the test fails locally on my laptop. Is
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/2027
@rhtyd the `NioTest` result is not consistent on my laptop and fails from
time to time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/2027
@rhtyd I found one issue with the test and `NioConnection` class. This kind
of intermittent problem are always hard to search for a root cause, but after
lots of logging I finally found why
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/2027
@rhtyd I moved the PR against 4.9 and rebased the changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user marcaurele commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218370950
@swill did a force push by changing the last commit description
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user marcaurele closed the pull request at:
https://github.com/apache/cloudstack/pull/1532
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user marcaurele reopened a pull request:
https://github.com/apache/cloudstack/pull/1532
DAO: Hit the cache for entity flagged as removed too
I came along this part of the code and I don't see any reason why the cache
should not be used when fetching with the "rem
Github user marcaurele commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-218731447
I don't get what's the relation between my change and the jenkins build
failling. Should I trigger another one?
---
If your project is set up for i
Github user marcaurele commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-219010730
checks are finally ok...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1554
API: improve resource limits comprenhension
Add resource type name in request and response.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user marcaurele commented on the pull request:
https://github.com/apache/cloudstack/pull/1341#issuecomment-222067277
Hi! Talking with @footplus on the mailing list, I realized that this patch
is not correct. It's missing modifications on the VO objects to let the String
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1567
CLOUDSTACK-9238: Fix URL length to 2048 for all url fields in VO
I will update the PR to add max field length in the API commands too
You can merge this pull request into a Git repository
Github user marcaurele commented on the pull request:
https://github.com/apache/cloudstack/pull/1341#issuecomment-222071694
I guess a PR is easier, so here you go
https://github.com/apache/cloudstack/pull/1567
---
If your project is set up for it, you can reply to this email and
Github user marcaurele commented on the pull request:
https://github.com/apache/cloudstack/pull/1567#issuecomment-222094671
Because not all varchar columns have been updated to a length of 2048 in
the DB, so there will be a mismatche between API, VO and the database.
---
If your
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1638#discussion_r74574588
--- Diff: pom.xml ---
@@ -92,22 +85,22 @@
1.5.1
1.2.8
2.0.4
-2.5
+3.1.0
1.2
1.2.1
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1638#discussion_r74575182
--- Diff: pom.xml ---
@@ -92,22 +85,22 @@
1.5.1
1.2.8
2.0.4
-2.5
+3.1.0
1.2
1.2.1
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1638#discussion_r74588212
--- Diff: pom.xml ---
@@ -92,22 +85,22 @@
1.5.1
1.2.8
2.0.4
-2.5
+3.1.0
1.2
1.2.1
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1638#discussion_r74739489
--- Diff: pom.xml ---
@@ -92,22 +85,22 @@
1.5.1
1.2.8
2.0.4
-2.5
+3.1.0
1.2
1.2.1
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1640
CLOUDSTACK-9458: Fix HA bug when VMs are stopped on agent disconnect
VM are being restarted even if they don't have HA enabled. If the agent
gets back online before the command ex
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1640#discussion_r75091738
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -282,7 +282,9 @@ public void scheduleRestartForVmsOnHost(final HostVO
host
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1640
I'll do the long explanation regarding the bug in production we had.
Twice we had the VPN going down between 2 of our zones which resulted in
the lost of the communication be
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1640#discussion_r75252604
--- Diff: server/src/com/cloud/ha/HighAvailabilityManagerImpl.java ---
@@ -497,7 +498,7 @@ protected Long restart(final HaWorkVO work
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1640
> Would you mind adding these notes to the bug ticket?
@jburwell All PR comments are going automatically into the jira ticket
comment thanks to the ID matching (I think).
---
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@koushik-das We are running a fork based on 4.4.2 with lots of
cherry-pickings.
But even if the host is down, why would you want to schedule a restart if
the VM are not HA enabled
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1640
I understand your point of the release, but we're not in an ideal world
where everyone runs the latest version. I try to do my best to look at the
current code in CS to find possible
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@koushik-das
> If the MS is not able to determine the state of the VM, it tries fencing
off the VM (using the various fencers available). If VM cannot be fenced off
successfully,
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@koushik-das which is IMHO wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@jburwell I changed the commit and PR to point to 4.9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1532
DAO: Hit the cache for entity flagged as removed too
I came along this part of the code and I don't see any reason why the cache
should not be used when fetching with the "removed
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1532#discussion_r62453258
--- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java ---
@@ -969,7 +969,12 @@ public T findByUuidIncludingRemoved(final String uuid
Github user marcaurele commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-217820309
@sateesh-chodapuneedi not quite, you're missing a case. If the cache is
null (not configured) you will always return `null`, which is not the goal.
---
If
Github user marcaurele commented on the pull request:
https://github.com/apache/cloudstack/pull/1532#issuecomment-217820629
I pushed a change to write the method following the good practive you're
mentioning. I also updated the sibling method findById to follow the same
pra
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1709
CLOUDSTACK-7982 - KVM live migration
This is the forward port of our KVM live migration implementation in 4.4.2
to the master branch.
Feedback is welcome. I still have to write the
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1709
Is there a way to get the management server log of the travis job?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1709
@rhtyd I found the log but it doesn't give the mgmt server log output, only
the job's output which got a `Command failed due to Internal Server Error` in
an API response. I
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1723
Fix GroupBy (+ having) condition and tests
The GroupBy + having isn't used currently in the code but was not clean. It
removes unused arguments and variables and adds a test based on
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1709#discussion_r84632272
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
---
@@ -943,6 +962,11 @@ public boolean
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1730
VMTemplateZone needs some love
It's incorrect to use the findIncludingRemovedBy and
listIncludingRemovedBy for the common list and find operation. Moreover
the DAO is tryi
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1730#discussion_r86242383
--- Diff:
engine/schema/src/com/cloud/storage/dao/VMTemplateZoneDaoImpl.java ---
@@ -84,14 +84,11 @@ public VMTemplateZoneVO findByZoneTemplate(long
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1730
@rhtyd I triggered another jenkins build by rebasing my branch on master
this morning. I hope it will fix the failing test.
---
If your project is set up for it, you can reply to this email
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1730
No, there isn't any bug related to this yet. I discovered this when I
implemented something new in our CS (allow a template to be re-downloaded from
its url via the `CopyTemplate` co
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1730#discussion_r87170352
--- Diff:
engine/schema/src/com/cloud/storage/dao/VMTemplateZoneDaoImpl.java ---
@@ -84,14 +84,11 @@ public VMTemplateZoneVO findByZoneTemplate(long
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1760
CLOUDSTACK-9593: userdata: enforce data is a multiple of 4 characters
Python base64 requires that the string is a multiple of 4 characters but
the Apache codec does not. RFC says is not
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1760
@jburwell done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1764
Should not fetch resource count for removed entity
Fetch the number of resourceCount by domain and account excluding the
removed ones.
Signed-off-by: Marc-Aurèle Brothier
You
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1764
Will fix the checks in `ConfigurationServerImpl`:
-
https://github.com/apache/cloudstack/blob/master/server/src/com/cloud/server/ConfigurationServerImpl.java#L1426
-
https
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1760
I changed the code to make it resilient to incorrect data that are already
in the database. Moreover, instead of throwing an error when the padding is not
present, it appends it. I think
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1768
CLOUDSTACK 9601: Upgrade: change logic for update path for files
For going from version A to version D, it uses to run the SQL files in
that order: A -> B -> C -> D -> A-
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1768
The second commit can be removed if the cleanup is not wanted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1640
To get back to your previous comment @koushik-das on the broken scenario:
what happen if the host is not reachable and the VMs are using a remote
storage. With the fencing operation marking
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1760
@rhtyd the SQL function I'm using to fix current user data in the database
is not present in MySQL 5.5, but only in 5.6 (TO_BASE64, FROM_BASE64). I have
to find a workaround, either i
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1554
I added the JIRA ticket. Isn't it simpler if you do the squash when you'll
merge the PR on master?
---
If your project is set up for it, you can reply to this email and have
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1760
@rhtyd The DB update class for the DatabaseUpgradeChecker doesn't work on
Travis. Is there something I'm doing wrong, or missed something?
---
If your project is set up for i
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1760
right, I forgot about the match required with the version in the pom. I
thought I should prepare the stuff for the next 4.9.x release but that cannot
work unless the pom files are updated
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1798
API: affinitygroupids or affinitygroupnames must be given
Return an exception if both parameter are missing.
Signed-off-by: Marc-Aurèle Brothier
You can merge this pull request
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1832
@karuturi It's a good feature but I don't see where the job gets actually
cancelled. Reading the changes I can only see that the response of the job will
become a cancelled oper
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1832
@karuturi Ok thanks for the clarifications, and it's the scenario I thought
about too. That being said, I'm currently thinking of a new approach for the
command sequencer beca
Github user marcaurele commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1832#discussion_r92676861
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentAttache.java ---
@@ -399,10 +414,22 @@ public void send(final Request req, final
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1934
[CLOUDSTACK-9772] Template: perform a HEAD request to check file size from
a URL
Signed-off-by: Marc-Aurèle Brothier
You can merge this pull request into a Git repository by running
GitHub user marcaurele opened a pull request:
https://github.com/apache/cloudstack/pull/1936
[CLOUDSTACK-9773] API: don't break API output with non-printable characters
Signed-off-by: Marc-Aurèle Brothier
You can merge this pull request into a Git repository by ru
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1936
Forced push to trigger another build. Looks like the failed test is not
stable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1934
@borisstoyanov Dunno what's wrong with the failed tests. Its' failing at
https://github.com/apache/cloudstack/blob/master/plugins/storage/image/default/src/org/apache/cloudsta
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1934
@remibergsma Good point, I was aware of that difference, which I think
doesn't help to make systems reliable.
Another improvement would be to remove this function and refactor the
Github user marcaurele commented on the issue:
https://github.com/apache/cloudstack/pull/1768
@rhtyd Changing the sequence is only idempotent if you have been upgrading
to each new versions step by step. If you jumped other versions, then the path
is different for each original
74 matches
Mail list logo
