Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1956
LGTM by Rafael in commit review above (for acspr).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1946
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1885
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/669
tag:needslove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/351
tag:needslove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1948
LGTM from borisstoyanov in a commit comment (acspr)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1948
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1907
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1941
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1955
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1955
@karuturi 3 x LGTM, testing successful. Ready for Merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-218446038
Remi,
I'm seeing some issues with this PR, related to the way the VR scripts
utilize the argv file name for other uses. We spent a fair bit of
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218473922
---
If your project is set up for it, you can
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218473890
@rhtyd We're still seeing some odd behaviour related to the agent with this
PR (and PR1534) applied to 2 of our hardware labs. What we're seeing is 10
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218592243
LGTM. Tested in a hardware lab.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1472#issuecomment-218607629
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1474#issuecomment-218607576
LGTM. Tested in a hardware lab.
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-218611825
LGTM. Tested in hardware lab and works as designed.
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218763389
@rhtyd I'll work on pulling some trace logs and a debugger on the agent if
the trace logs don't show anything.
For reference, These patches were
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218776521
@rhtyd With the agent in trace mode, I see this scrolling through very
rapidly:
2016-05-12 09:36:01,707 TRACE [utils.nio.NioConnection]
(pool-1-thread-1
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218802890
@swill We'll pull this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218835105
@remibergsma I'm porting this patch set into our 4.8 QA branch currently. I
noticed 709be45 is in here as well (force encap). Can you pull that out of this
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1482#issuecomment-218838012
ok, I'm just blind and didn't see the additional commit to remove the
forceencaps. :-)
---
If your project is set up for it, you can reply to this
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-218943044
@rhtyd Sounds good. Thanks for taking a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1543#issuecomment-218947359
@rhtyd This patch seems to have fixed the cpu issue. I've got this running
on a hardware lab right now.
We'll also install this on a larger lab to
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-219033178
We're working on getting this tested as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1520#issuecomment-219033610
@swill This one is green now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219076184
We have the fixes pulled in for testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219137126
Hot add static route:
---
If your project
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1470#issuecomment-219137482
Kill the Master VR:
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this email and
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this email and
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this email and
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this email and
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
Tested in a 4.8 lab. Verified as per screen shots that all RFC 1918 and RFC
6598 ranges work. Attempting to use a public cidr produces an error as
expected. Interface is correctly configured
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1608
We have QA'd the patch and confirm that it prevents the agent from crashing
when an unexpected exception occurs from upstream RBD libs.
LGTM
---
If your project is set up f
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1635
References: https://github.com/apache/cloudstack/pull/1632
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
LGTM, tested in our lab.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1644
LGTM, tested in our lab.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1644
@wido Nice feature for Ceph users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@wido This is also nice for users of Ceph.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
CLOUDSTACK-9461
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1606
John, I'll defer to Aaron on this, as he submitted the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
For reference, here are the DB entries:
. The
way we do it is we snap to volume (clone), shut the vm down, then detach the
old disk and reattach the new di
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
I took a look at the code last night and it seems that we're no longer
specifying the source format when calling qemu-img convert. We're relying on
qemu-img's auto detection o
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/872
Yeah, I think this one is dead unless it gets reworked into a new PR. We
might be able to help a bit on this one as well.
---
If your project is set up for it, you can reply to this email and
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@karuturi - So, note that this feature addition only affects KVM when
using RBD as the back-end storage.
---
If your project is set up for it, you can reply to this email and have your
Github user kiwiflyer commented on the issue:
https://github.com/apache/cloudstack/pull/1644
@jburwell We found an issue on Friday related to a use case related to
snapshot to template. We're working on it. More soon.
---
If your project is set up for it, you can reply to this
GitHub user kiwiflyer opened a pull request:
https://github.com/apache/cloudstack/pull/1428
Addresses CLOUDSTACK-9300 where the MySQL HA StaticStrategy class faiâ¦
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/myENA
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-192309041
I've manually tested this on 4.7.1 and also on master.
Prior to the patch, the following exception was thrown:
016-03-03 12:00:13,204
GitHub user kiwiflyer opened a pull request:
https://github.com/apache/cloudstack/pull/1429
CLOUDSTACK-9285 - Agent throws an exception on reconnect and fails
Agent throws an exception that can never be recovered from when the agent
attempts to reconnect and is sent a RST. This
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-192913387
Daan,
Sorry about that. I've fixed it, pushed the commit and checks are now
passing.
- Simon
---
If your project is set up for it, yo
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1429#issuecomment-192913591
Daan,
Sorry about that. I've fixed it, pushed the commit and checks are now
passing.
Simon
---
If your project is set up for it, you can
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-192928078
We've tested this patch against master. Snapshots work correctly and data
is displayed in UI when using supported storage backend (NFS), so nice work!
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-192928201
---
If your project is set up for it
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-192928190
---
If your project is set up for
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-192928225
---
If your project is set up for it
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-193404245
Hi Remi,
Yes, we tested it with HA disabled. David is going to upload the logs for
reference.
The mysql-connector is also referenced in the
GitHub user kiwiflyer opened a pull request:
https://github.com/apache/cloudstack/pull/1430
CLOUDSTACK-9285 for 4.7.x
Per Daan's request, here is a pull request for the 4.7.x release.
You can merge this pull request into a Git repository by running:
$ git pull
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-193485886
@remibergsma In reference to other releases, yes this might also be broken
on Ubuntu. We don't use Ubuntu, so having someone chime in who can test this
wou
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-193508523
@ustcweizhou Thanks for the advice. Maybe I can catch you on the slack
channel tomorrow to discuss a little, so I better understand the logic between
start and
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-193796033
@ustcweizhou
So after looking at our issue and the one reported originally in 9285, I
think they're two different issues. One related to initial conne
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-193820061
@ustcweizhou I've cleaned up the other 2 exceptions and also removed the
newline you pointed out eariler.
---
If your project is set up for it, you can rep
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-193851127
@ustcweizhou Does 3683dff work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1426#issuecomment-193861558
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-193864782
@syed Can you squash the 2 commits please?
Can you provide some logs showing the fix works?
---
If your project is set up for it, you can reply to this email
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1414#issuecomment-193866958
Makes sense. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1402#issuecomment-193872249
Since forceencaps is no by default, I think this is a fair change. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1422#issuecomment-193873854
I agree that it would be nice for this to be configurable (in the future).
But I will say that those 5 fields are also the ones we use religiously when in
VR
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1433#issuecomment-197845922
Tested patch on a 4.7.1 lab.
Prior to patch:
INFO [cloud.usage.UsageServer] (main:null) (logid:) UsageServer ready...
INFO
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1429#issuecomment-198513018
Closing this PR, as this issue has been address more cleanly in my other PR
against 4.7 - https://github.com/apache/cloudstack/pull/1430
---
If your project is
Github user kiwiflyer closed the pull request at:
https://github.com/apache/cloudstack/pull/1429
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-199787118
Test log for reconnect scenerio:
Agent throws an exception that can never be recovered from when the agent
attempts to reconnect and is sent a RST. This
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-200347989
@DaanHoogland
So I've been digging into this a bit. I could be very wrong here, but it
seems that XenserverSnapshotStrategy is a very inacc
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200901622
I want to point out that this is taking care of the case where you have a
load balancer between the agents and the management server (see original issue
notes
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200906752
@rafaelweingartner This is used in both the system VM agent and the host
(hypervisor) agent.
---
If your project is set up for it, you can reply to this
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200908383
@swill This exception is thrown when the NIO operations used to establish
the connection to the management server on port 8250 fail.When this exception
gets
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200918379
@rafaelweingartner Yes, you are correct. I like your suggestion. I'll log
the exception with the failure.
In terms of the persistent connectio
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200956335
@swill Yes, I'll work on this either today or tomorrow and get a new PR
submitted.
Thanks guys.
---
If your project is set up for it, you can rep
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205512194
Pulled this in manually and tested it.
