Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785361
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py ---
@@ -0,0 +1,85 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785576
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785711
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785662
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785806
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785864
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62785940
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786006
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786093
--- Diff: test/integration/component/test_ospf.py ---
@@ -0,0 +1,477 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786148
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786188
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786232
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786260
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786345
--- Diff: test/integration/smoke/test_ospf_zone_config.py ---
@@ -0,0 +1,165 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786497
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -903,6 +906,10 @@ static boolean areCidrsNotEmpty(String cidrA, String
cidrB
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786538
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1135,6 +1142,21 @@ public static boolean isSameIpRange(final String
cidrA
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786638
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String
cidr
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786731
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String
cidr
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786802
--- Diff:
utils/src/main/java/com/cloud/utils/net/cidr/BadCIDRException.java ---
@@ -0,0 +1,33 @@
+//
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62786873
--- Diff:
utils/src/main/java/com/cloud/utils/net/cidr/BadCIDRException.java ---
@@ -0,0 +1,33 @@
+//
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787032
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787065
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787123
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787129
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787143
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787136
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787151
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787378
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787416
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787426
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787493
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787530
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787612
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787677
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787904
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62787923
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788152
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788201
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788312
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788397
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788491
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR.java ---
@@ -0,0 +1,98 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788572
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java ---
@@ -0,0 +1,172 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788636
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR6.java ---
@@ -0,0 +1,95 @@
+//
+// Licensed to the Apache Software Foundation (ASF
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788718
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDRFactory.java ---
@@ -0,0 +1,79 @@
+//
+// Licensed to the Apache Software Foundation
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62788791
--- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDRFactory.java ---
@@ -0,0 +1,79 @@
+//
+// Licensed to the Apache Software Foundation
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1371#issuecomment-218355774
@abhinandanprateek Reading through the code, it seems like there could be
benefit from the following value objects:
* IpAddress interface whose
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62892193
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +232,211 @@ private
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r62892410
--- Diff: core/src/com/cloud/agent/api/StartupRoutingCommand.java ---
@@ -35,7 +35,7 @@
long memory;
long dom0MinMemory
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-218784278
@swill @rhtyd LGTM based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63108616
--- Diff: engine/schema/src/com/cloud/dc/dao/ClusterDaoImpl.java ---
@@ -260,4 +268,41 @@ public boolean remove(Long id) {
sc.setParameters
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63110833
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -55,65 +68,98 @@
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63110957
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -132,31 +171,52 @@ public
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63110910
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -132,31 +171,52 @@ public
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63111572
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +258,207 @@ private
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63111670
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +258,207 @@ private
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63111740
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +258,207 @@ private
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63111842
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -172,78 +258,207 @@ private
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63111964
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -255,99 +448,153 @@ private
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63112646
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63112751
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +600,205 @@ private
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63112811
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +600,205 @@ private
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1403#discussion_r63112842
--- Diff:
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
---
@@ -361,59 +608,225 @@ private
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r63127043
--- Diff: api/src/com/cloud/network/vpc/OSPFZoneConfig.java ---
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1546#issuecomment-219047291
@rhtyd I think it would be a good idea to this PR up a bit. I see three
distinct pieces:
1. **Spring 4 Upgrade**: Spring 4 supports both Java7 and Java8
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/1403#issuecomment-219148309
@DaanHoogland in my experience, stack traces are a critical piece of
information for operationally debugging CloudStack. Unfortunately, our logging
lacks the
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1593#discussion_r67563826
--- Diff: usage/src/com/cloud/usage/UsageSanityChecker.java ---
@@ -72,7 +72,9 @@ protected boolean checkItemCountByPstmt(CheckCase
checkCase) throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1593#discussion_r67565090
--- Diff: usage/conf/log4j-cloud_usage.xml.in ---
@@ -48,7 +48,7 @@ under the License
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1593
@nvazquez when users upgrade existing usage servers, will the location
change of the ```sanity-check-last-id``` file impact their operation?
/cc @abhinandanprateek
---
If your
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1593
@swill I noticed that the associated JIRA ticket was opened after the 4.9.0
freeze, but is targeted against 4.9.0. Should it be included in 4.9 or
deferred to 4.10?
---
If your project is
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1594#discussion_r67571985
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1577,8 +1577,9 @@ private void advanceStop(final VMInstanceVO vm
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1594#discussion_r67571914
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -1577,8 +1577,9 @@ private void advanceStop(final VMInstanceVO vm
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1594#discussion_r67572107
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -2086,6 +2089,18 @@ public boolean expunge(UserVmVO vm, long
callerUserId, Account
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1594
@swill I noticed that the ticket was opened after the 4.9.0 code freeze,
but it is targeted to 4.9.0. Is it severe enough to be included in 4.9.0 or
should it deferred to 4.9.1/4.10?
---
If
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1626#discussion_r73559738
--- Diff: tools/appliance/definitions/systemvmtemplate/definition.rb ---
@@ -27,15 +27,15 @@
architectures = {
:i386
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1626#discussion_r73559749
--- Diff: tools/appliance/definitions/systemvmtemplate/definition.rb ---
@@ -27,15 +27,15 @@
architectures = {
:i386
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1623#discussion_r73604377
--- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java ---
@@ -1698,6 +1698,22 @@ public String acquireGuestIpAddress(Network network,
String
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1623
@ProjectMoon have you run the ``test_redundant_router_cleanups``,
``test_redundant_router_services``, and ``test_redundant_router_upgrades`` test
cases for this PR?
Also, is there a
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1622
@rhtyd Travis appears to have failed due to a missing file. Could you
please investigate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1622#discussion_r73605500
--- Diff: api/src/org/apache/cloudstack/api/response/TemplateResponse.java
---
@@ -169,6 +169,10 @@
@Param(description = "additional key/
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1622
@ProjectMoon is there a JIRA associated with this change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/351
@anshul1886 @rhtyd it appears that there was a push to get this merged for
the 4.9 release, but a conflict may have occurred with the Dynamic Role-based
API Checker enhancement. Were you able
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/384
@pritisarap12 @remibergsma referenced PR #720 which appears to implement a
similar set of tests. How do the tests in this PR differ?
it also appears that the Travis build is failing
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/540
@likitha is this PR still pertinent?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/669
@anshul1886 it appears that there was a push to get this PR into 4.9, but
@bvbharat found5 test failures and 3 skips. What is the status of resolving
these issues?
---
If your project is set
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r73613017
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -1402,6 +1402,12 @@ public VM
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r73613353
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public void
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/672
@anshul1886 could please squash the three commits and add the ticket
reference to the commit message?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/672#discussion_r73613647
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -4251,6 +4257,34 @@ public void
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1621
@borisstoyanov do you have the bandwidth to manually test upgrading 4.8 to
4.9 using this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1622
@ProjectMoon Travis is now passing, but Jenkins failed. Could you please
investigate the failure and fix it?
---
If your project is set up for it, you can reply to this email and have your
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1602
@rhtyd can you re-kick this PR for @blueorangutan?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r73742107
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
---
@@ -1353,6 +1363,20 @@ public void prepare
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r73742358
--- Diff:
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
---
@@ -1353,6 +1363,20 @@ public void prepare
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r73744705
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -537,15 +540,51 @@ public Answer
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r73744970
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -537,15 +540,51 @@ public Answer
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1602#discussion_r73745286
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageSubsystemCommandHandler.java
---
@@ -66,19 +68,28 @@ public
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73764835
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ---
@@ -145,6 +156,9 @@ public void execute() {
if
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73765448
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -520,6 +528,16 @@ public String updateConfiguration(final long userId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73765615
--- Diff: server/src/com/cloud/storage/ImageStoreDetailsUtil.java ---
@@ -20,48 +20,68 @@
import javax.inject.Inject;
+import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1615#discussion_r73765825
--- Diff: server/src/com/cloud/storage/ImageStoreDetailsUtil.java ---
@@ -20,48 +20,68 @@
import javax.inject.Inject;
+import
701 - 800 of 1884 matches
Mail list logo
