[GitHub] cloudstack pull request: findbugs: write to static from instance

2015-07-07 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/539#discussion_r34026647 --- Diff: server/src/com/cloud/api/auth/APIAuthenticationManagerImpl.java --- @@ -52,17 +55,25 @@ public void setApiAuthenticators(List authenticators

[GitHub] cloudstack pull request: CLOUDSTACK-8652: remove old upgrade code

2015-07-20 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/608#issuecomment-122928905 -1 @DaanHoogland what is the reasoning for removing the old upgrade code (please amend the commit to explain the reasoning for posterity)? As far as I know, we

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-10 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/650#discussion_r36621140 --- Diff: plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java --- @@ -322,21 +306,11 @@ public

[GitHub] cloudstack pull request: APIServlet, AuthCmd, SAML fixes

2015-08-11 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/650#discussion_r36737719 --- Diff: plugins/user-authenticators/saml2/src/org/apache/cloudstack/api/command/SAML2LoginAPIAuthenticatorCmd.java --- @@ -322,21 +306,11 @@ public

[GitHub] cloudstack pull request: CLOUDSTACK-8748: VM UUID accessible in Cr...

2015-08-19 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/717#issuecomment-132540113 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8749: KVM - cleanup linklocal ...

2015-08-19 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/718#discussion_r37435429 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java --- @@ -287,7 +287,7 @@ private void

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37571366 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37572081 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37572286 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37572319 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37572729 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37573045 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37573761 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37573927 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37580929 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDao.java --- @@ -0,0 +1,43 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37581010 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582361 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582377 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582389 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582401 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582427 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582453 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582431 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java --- @@ -0,0 +1,201 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582467 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582475 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaAccountDaoImpl.java --- @@ -0,0 +1,73 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582547 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java --- @@ -0,0 +1,72 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582530 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java --- @@ -0,0 +1,72 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582598 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java --- @@ -0,0 +1,72 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582622 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,64 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582759 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,64 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37582819 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,64 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37583016 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37583025 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37583163 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37583437 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37583449 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,138 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37583531 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,106 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37584764 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,85 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37585801 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaEmailTemplateUpdateCmd.java --- @@ -0,0 +1,111 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37585845 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java --- @@ -0,0 +1,143 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37585892 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaStatementCmd.java --- @@ -0,0 +1,143 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37586539 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaTariffListCmd.java --- @@ -0,0 +1,93 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37586787 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37586853 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37586898 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37587109 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37587088 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37587187 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-20 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37587233 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-21 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37623820 --- Diff: framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java --- @@ -0,0 +1,92 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-21 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37627680 --- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java --- @@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days

[GitHub] cloudstack pull request: Quota master

2015-08-21 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37627808 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java --- @@ -0,0 +1,72 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-21 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37627849 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java --- @@ -0,0 +1,64 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-21 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37628117 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-21 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37628373 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-21 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37628668 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-21 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37628774 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-21 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-133407337 @DaanHoogland in addition to failing to convey the intention of the action, the open then close pattern is incredibly expensive due to rapid, unnecessary churn on

[GitHub] cloudstack pull request: Quota master

2015-08-24 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/689#issuecomment-134245543 @abhi An connection pool makes acquiring a scarce resource less expensive, but it is not cost-free. By taking a connection when the pool is under load, the

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/735#discussion_r37865908 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java --- @@ -286,7 +287,11 @@ private void

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-25 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/735#issuecomment-134591140 While it is a small nit and not expressly within the scope of this PR, could you fix the spelling mistake in the ``deleteExitingLinkLocalRouteTable`` name

[GitHub] cloudstack pull request: CLOUDSTACK-8749: Add checks to prevent ma...

2015-08-25 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/733#issuecomment-134595147 See comments on PR #735 regarding extracting the parsing logic and unit testing. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37946859 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,85 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37946936 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java --- @@ -0,0 +1,136 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947002 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java --- @@ -0,0 +1,136 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947073 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilder.java --- @@ -0,0 +1,62 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947136 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947139 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947194 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947237 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947252 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947294 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947297 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947561 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947679 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947704 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947741 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947791 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37947918 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948373 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948706 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948797 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948835 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,419 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948903 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948934 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948942 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37948979 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949008 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949049 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949030 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949069 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949073 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949093 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949107 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949186 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949195 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949444 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,296 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949568 --- Diff: server/src/com/cloud/api/dispatch/ParamProcessWorker.java --- @@ -294,6 +294,14 @@ private void setFieldValue(final Field field, final BaseCmd

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949627 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF

[GitHub] cloudstack pull request: Quota master

2015-08-25 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/689#discussion_r37949667 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,471 @@ +//Licensed to the Apache Software Foundation (ASF

<    1   2   3   4   5   6   7   8   9   10   >