Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1729
@rhtyd LGTM on code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1730
@marcaurele Are these fixes against some bugs, checking as there is no
ticket number mentioned in the PR.
---
If your project is set up for it, you can reply to this email and have
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1735
LGTM on code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1765
Cloudstack 9586: When using local storage with Xenserver prepareTemplate
does not work with multiple primary store
The race condition will happen whenever there are multiple primary
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1765#discussion_r88393320
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
---
@@ -100,36 +100,25
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1640
@marcaurele for a host that is found to be down we go ahead and schedule a
restart for HA enabled VM, this is good.
For the VMs that are not HA enabled they will continue to
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd squashed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1766
@rhtyd reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1766
@murali-reddy @rhtyd looks good to me on code review. Marvin test is neat.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1762
Even trying the full transaction again could be problematic as there might
be checks done before firing the transaction that may not be valid now.
The thing is it may mostly work
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1765#discussion_r89574062
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
---
@@ -100,36 +100,25
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1519
@LGTM on code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1784
CS-505: Marvin test to VR DNS Service
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack CS-505
Alternatively
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1784
@rhtyd the test_router_dns checks external dns service on virtual router.
This test case checks the internal dns service from the user VMs.
---
If your project is set up for it, you
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1755
LGTM on code review @rhtyd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1784#discussion_r90411487
--- Diff: test/integration/smoke/test_router_dnsservice.py ---
@@ -0,0 +1,268 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1784#discussion_r90411534
--- Diff: test/integration/smoke/test_router_dnsservice.py ---
@@ -0,0 +1,268 @@
+# Licensed to the Apache Software Foundation (ASF) under
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1784
@jburwell made the appropriate changes.
@murali-reddy impact of multiple NIC on DNS do you think we add a test
for that too ?
---
If your project is set up for it, you can
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r90438253
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
---
@@ -538,7 +562,7
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@jburwell rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1765#discussion_r90594670
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
---
@@ -100,36 +100,25
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@rhtyd I have reverted to the sr name as it was.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1784
@rhtyd this can be merged if Murali feels multi nic test is also good to
have we can add it later. cc @murali-reddy but lets not delay this as this test
is complete in itself
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1600#discussion_r91006590
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
---
@@ -538,7 +562,7
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1807
@syed can you look at this 'revert' i guess this is going to be an issue
with the managed storage change that has been put in. cc @rhtyd
---
If your project is set up f
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1807
@syed yes I assume that PR in itself is good. You need to consider the
broken test and broken upgrade ,where upgrading users will have path without
the extension.
---
If your
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1659
LGTM on code review and testing @murali-reddy @rhtyd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1763
@sudhansu7 can you update on CLOUDSTACK-9376, were you able to check/test ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1763
LGTM on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1807
@syed @swill the change is good. What needs to be considered is what
happens with old snapshots, from a older version upgraded to this version, that
are without the .vhd extension. If
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1807
@syed @swill @rhtyd @serg38 I think i missed some updates. This PR will
only break the original PR. The patch suggested by @serg38 looks good.
@syed in a upgraded setup, I think
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1807
@syed please do a check of various snapshot functions on a upgraded setup.
@rhtyd this PR can be closed.
---
If your project is set up for it, you can reply to this email
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1800
@rhtyd this is good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1823
LGTM on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1839
CLOUDSTACK-9683: system.vm.default.hypervisor will pin the hypervisorâ¦
⦠for VR too with this fix
You can merge this pull request into a Git repository by running:
$ git
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1839
@blueorangutan help
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1839
@blueorangutan test centos6 kvm-centos6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1839
@blueorangutan test centos6 kvm-centos6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1843
WIP: instrumeted code
WIP
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-9687
Alternatively you
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1843
@blueorangutan package
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1839
@rhtyd most of the automation environments are single hypervisor one, so
will end up creating a mixed hypervisor zone for this test only. If that can be
done i can put one together
Github user abhinandanprateek commented on the issue:
https://github.com/apache/cloudstack/pull/1888
lgtm on code review @rhtyd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1930
CLOUDSTACK-9687: if the allocated amount is 0 the capacity updates arâ¦
â¦e not done, resulting in wrong values being shown as allocated value
instead of zero
You can merge this
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1931
CLOUDSTACK-9473: Storage pool checker is ignored on resize and migratâ¦
â¦e volume.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user abhinandanprateek closed the pull request at:
https://github.com/apache/cloudstack/pull/1931
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1932
CLOUDSTACK-9473: Storage pool checker is ignored on resize and migratâ¦
â¦e volume.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user abhinandanprateek closed the pull request at:
https://github.com/apache/cloudstack/pull/1932
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user abhinandanprateek opened a pull request:
https://github.com/apache/cloudstack/pull/1933
CLOUDSTACK-9569: add router.aggregation.command.each.timeout to agentâ¦
â¦.properties
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user abhinandanprateek reopened a pull request:
https://github.com/apache/cloudstack/pull/1933
CLOUDSTACK-9569: add router.aggregation.command.each.timeout to agentâ¦
â¦.properties
You can merge this pull request into a Git repository by running:
$ git pull https
Github user abhinandanprateek closed the pull request at:
https://github.com/apache/cloudstack/pull/1933
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
401 - 450 of 450 matches
Mail list logo
