[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

2017-02-21 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1958 CLOUDSTACK-5806: add presetup to storage types that support over prov… …isioning Ideally this should be configurable via global settings You can merge this pull request

[GitHub] cloudstack pull request #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2...

2017-02-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/815#discussion_r102671303 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -4717,8 +4717,8 @@ public VirtualMachine migrateVirtualMachineWithVolume(Long

[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

2017-02-24 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1958#discussion_r102918123 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -508,7 +507,7 @@ public String updateConfiguration(final

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-24 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1958 @borisstoyanov a condition got inverted by the change (serg38 pointed that out above), it is fixed now. Can you rerun the tests. --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1960 @koushik-das The current framework is specifically implemented for Host HA with KVM HA as the initial implementation. This framework is supposed to replace the framework that is

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @anshul1886 Should not we disallow any VM to be deployed in a disabled Pod, why just the VR ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @anshul1886 Should not we disallow any VM to be deployed in a disabled Pod, why just the VR ? cc @rhtyd @karuturi Lets merge this shapeblue/cloudstack-apple@359f652

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @anshul1886 Should not we disallow any VM to be deployed in a disabled Pod, why just the VR ? cc @rhtyd @karuturi --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request #1675: CLOUDSTACK-9453: WIP

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1675 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack issue #1675: CLOUDSTACK-9453: WIP

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1675 @rhtyd closing this PR as relevant portion of this are already in codebase via other VRs. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @anshul1886 I am not sure I thought deployment planner for VR and a regular VM is same. If a regular VM is not allowed in a cluster that is under disabled pod then the VR should also

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @anshul1886 If you trace the method planDeployment in DeploymentPlanningManagerImpl then you will see that orderCluster is getting invoked at line 500. By that time I think the

[GitHub] cloudstack pull request #1979: CLOUDSTACK-9198: Donot allow VMs to be deplye...

2017-03-01 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1979 CLOUDSTACK-9198: Donot allow VMs to be deplyed on host that are in di… …sabled pod You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @koushik-das @anshul1886 If we allow admin to deploy resources on disabled resources then this fix is fine. Even with the fix a non admin user will be able to restart a VM on a

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @anshul1886 @koushik-das I think with above info the fix looks good. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request #1979: CLOUDSTACK-9198: Donot allow VMs to be deplye...

2017-03-02 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1979 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack pull request #1989: WIP: support for multidisk OVA files

2017-03-05 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1989 WIP: support for multidisk OVA files Signed-off-by: Abhinandan Prateek You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @serg38 Yes, the aim of the PR is to enable deployment from templates with multiple data disks. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan test vmware --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan test vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up...

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1779#discussion_r104609930 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -2488,6 +2488,22 @@ public boolean maintenanceFailed(final long hostId

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan cancel --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1779 code review LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-08 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-08 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-08 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-08 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1995: CLOUDSTACK-9828: GetDomRVersionCommand fails ...

2017-03-09 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1995 CLOUDSTACK-9828: GetDomRVersionCommand fails to get the correct versi… …on as output Fix tries to return the output as a single command, instead of appending output from

[GitHub] cloudstack issue #1995: CLOUDSTACK-9828: GetDomRVersionCommand fails to get ...

2017-03-09 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1995 @ustcweizhou the file exists and the script works on the VR. It is not able to return the complete output though via the router_proxy. The signature file is part of the template

[GitHub] cloudstack issue #1995: CLOUDSTACK-9828: GetDomRVersionCommand fails to get ...

2017-03-09 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1995 @ustcweizhou another observation is that with the same systemvm.iso and VR templates; get version works on with some hosts while consistently failing in some cases. --- If your

[GitHub] cloudstack issue #1989: WIP: CLOUDSTACK-4757: support for multidisk OVA file...

2017-03-09 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 This PR is basically merging https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/multiple-disk-ova. And continue to build on it. --- If your project is

[GitHub] cloudstack pull request #1989: WIP: CLOUDSTACK-4757: support for multidisk O...

2017-03-09 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1989 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack pull request #1989: WIP: CLOUDSTACK-4757: support for multidisk O...

2017-03-09 Thread abhinandanprateek
GitHub user abhinandanprateek reopened a pull request: https://github.com/apache/cloudstack/pull/1989 WIP: CLOUDSTACK-4757: support for multidisk OVA files Signed-off-by: Abhinandan Prateek You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request #1989: WIP: CLOUDSTACK-4757: support for multidisk O...

2017-03-09 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1989 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack pull request #1998: Multidisk ova

2017-03-09 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1998 Multidisk ova You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack multidisk-OVA Alternatively you can review

[GitHub] cloudstack issue #1998: CLOUDSTACK-4757: WIP: support for multidisk OVA file...

2017-03-09 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1998 @sateesh-chodapuneedi you have worked on it, will you list down what needs to be additionally done on this PR to make it production ready. Will be really good if you can participate

[GitHub] cloudstack pull request #1998: CLOUDSTACK-4757: WIP: support for multidisk O...

2017-03-10 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1998 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack pull request #2014: IR24:WIP

2017-03-21 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2014 IR24:WIP You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack ir24 Alternatively you can review and apply these

[GitHub] cloudstack issue #2014: WIP

2017-03-21 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2014 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #2014: WIP

2017-03-23 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2014 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #2020: IR25: WIP

2017-03-28 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2020 IR25: WIP You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack ir25 Alternatively you can review and apply

[GitHub] cloudstack issue #2020: IR25: WIP

2017-03-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2020 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-03-31 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2014 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #2020: WIP: Expire VM snapshots

2017-04-02 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2020 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #2024: CLOUDSTACK-9857: With this change if agent di...

2017-04-03 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2024 CLOUDSTACK-9857: With this change if agent dies the systemd will catc… …h it properly and show process as exited You can merge this pull request into a Git repository by running

[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2014 @borisstoyanov checking --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #2020: WIP: Expire VM snapshots

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/2020 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after co...

2017-04-04 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2026 CLOUDSTACK-9861: Expire VM snapshots after configured duration Default value of the account level global config vmsnapshot.expire.interval is -1 that conforms to legacy behaviour

[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2014 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configure...

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2026 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2014 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/2014 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack pull request #2029: CLOUDSTACK-9857: With this change if agent di...

2017-04-06 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2029 CLOUDSTACK-9857: With this change if agent dies the systemd will catc… …h it properly and show process as exited You can merge this pull request into a Git repository by running

[GitHub] cloudstack issue #2024: CLOUDSTACK-9857: With this change if agent dies the ...

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2024 @rhtyd @karuturi here is the cherry picked PR on 4.9 https://github.com/apache/cloudstack/pull/2029 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request #2029: CLOUDSTACK-9857: With this change if agent di...

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/2029 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cloudstack issue #2001: CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2001 @LGTM on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2030#discussion_r110145761 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -128,6 +129,7 @@ public

[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2030#discussion_r110145877 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -550,15 +552,21 @@ public boolean

[GitHub] cloudstack pull request #2035: CLOUDSTACK-9867:VM snapshot on primary storag...

2017-04-07 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2035 CLOUDSTACK-9867:VM snapshot on primary storage usage metrics You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue

[GitHub] cloudstack issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage...

2017-04-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2035 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-04-09 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1960 @koushik-das I see that main issue is that this is being confused as VM HA framework. Will like to again add that this framework is not for VM-HA but for host HA. With this

[GitHub] cloudstack pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after co...

2017-04-10 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2026#discussion_r110594291 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -232,3 +232,5 @@ WHERE (o.cpu is null AND o.speed IS NULL AND o.ram_size IS NULL) AND

[GitHub] cloudstack issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage...

2017-04-12 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2035 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request:

2015-05-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/commit/fb0bfd5d4f446656cdb136f2a05e5b27f680578a#commitcomment-10998674 Rajani, you want to merge your commit ? It looks good to me. The first set of tests have usually run without

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98087158 The way HA is implemented, “null” is a valid return value from an investigator. The valid values are Up, Down or null. https://cwiki.apache.org

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98091401 I agree with Koushik here. The purpose of an HA investigator is to either say that host is UP or Down or it does not know for sure. A host that has not

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98093700 Daan, Yes, I agree. We can define a proper state and introduce it. I guess there is some tribal knowledge involved here that Koushik and myself were

[GitHub] cloudstack pull request: return a state instead of null in Abstrac...

2015-05-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/211#issuecomment-98148840 Another thing to note is that while changing some of this legacy understanding, it is not just the code that needs improvement/change, it is all the

[GitHub] cloudstack pull request: server: Introduce Unknown Status to be us...

2015-05-02 Thread abhinandanprateek
Github user abhinandanprateek commented on the pull request: https://github.com/apache/cloudstack/pull/222#issuecomment-98430113 The issue has got entangled, let me try to summarise what each of us has been trying to do: The initial fix itself takes a step into right

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41826727 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41826803 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaTariffDaoImpl.java --- @@ -0,0 +1,137 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41826854 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java --- @@ -0,0 +1,81 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827227 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/ServiceOfferingDaoImpl.java --- @@ -0,0 +1,86 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827287 --- Diff: framework/quota/src/org/apache/cloudstack/quota/dao/UserVmDetailsDaoImpl.java --- @@ -0,0 +1,62 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827329 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java --- @@ -0,0 +1,147 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827414 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827531 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827559 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827602 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827702 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java --- @@ -0,0 +1,422 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827796 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaStatementResponse.java --- @@ -0,0 +1,130 @@ +//Licensed to

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827959 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827948 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41827968 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828072 --- Diff: plugins/database/quota/src/org/apache/cloudstack/quota/QuotaServiceImpl.java --- @@ -0,0 +1,304 @@ +//Licensed to the Apache

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828093 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaAlertManagerImpl.java --- @@ -0,0 +1,444 @@ +//Licensed to the Apache Software

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828125 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828171 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828178 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828218 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828211 --- Diff: usage/src/org/apache/cloudstack/quota/QuotaManagerImpl.java --- @@ -0,0 +1,397 @@ +//Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828262 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java --- @@ -0,0 +1,132 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828291 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaBalanceCmd.java --- @@ -0,0 +1,132 @@ +//Licensed to the

[GitHub] cloudstack pull request: Quota

2015-10-12 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/768#discussion_r41828868 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaCreditsCmd.java --- @@ -0,0 +1,147 @@ +//Licensed to the

  1   2   3   4   5   >