gland
>
>
> On Dec. 23, 2013, 6:13 p.m., Mandar Barve wrote:
> >
> > ---
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/16385/
> > ---
sshkeypair
Thanks,
Mandar Barve
Thanks,
Mandar Barve
Server.java:376
> error: server/src/com/cloud/api/ApiServer.java: patch does not apply
> Patch failed at 0001 Squashed commits for CloudStack-4406
> The copy of the patch that failed is found in:
>/Users/daan/cloudstack/cloudstack/.git/rebase-apply/patch
>
> - daan Hoogland
>
gt; don't need them. As the methods are static and per class they can
> return either true or false. without vars containing those values.
>
> hope this clariifies
>
> On Tue, Feb 11, 2014 at 8:54 AM, Mandar Barve
> wrote:
> > Daan,
> > I am still failing to u
virtualmachines
create user
update user
create sshkeypair
Thanks,
Mandar Barve
CloudMonkey following commands have been tested to make sure secret
key/password is stripped from the response
list users
list accounts
list virtualmachines
create user
update user
create sshkeypair
Thanks,
Mandar Barve
Diff: https://reviews.apache.org/r/16385/diff/
Testing
---
Using CloudMonkey following commands have been tested to make sure secret
key/password is stripped from the response
list users
list accounts
list virtualmachines
create user
update user
create sshkeypair
Thanks,
Mandar Barve
Hi,
I tried to reproduce the issue but couldn't get this to fail for
insufficient space. I then injected an exception trying to list files from
a non existent path (added this code in the "try" block). This landed me
into the exception handling code. It raised correct exception saying "file
I tested this with CS 4.3.
Thanks,
Mandar
On Tue, Mar 4, 2014 at 9:09 PM, Mike Tutkowski wrote:
> Hi,
>
> Can you tell me what release you tested this with? I noticed the problem
> while developing on CloudStack 4.3.
>
> Thanks!
>
>
> On Tue, Mar 4, 2014 at
We surely need a way to make this generic since cleanString looks for
specific keywords to filter. I will take a look at this. Using @Parameter
may have its own limitations like running through the entire list of
parameters per API before deciding which ones to exclude. But let me take a
look.
I b
Hi Mike,
Did you get a chance to look at this?
Thanks,
Mandar
On Wed, Mar 5, 2014 at 10:12 AM, Mandar Barve wrote:
> I tested this with CS 4.3.
>
> Thanks,
> Mandar
>
>
> On Tue, Mar 4, 2014 at 9:09 PM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
Guess in addition to the command level flag that we have Parameter walk
will need to be done only for the already identified "sensitive" responses
as discussed on the thread so this may be fine.
Thanks,
Mandar
On Mon, Mar 10, 2014 at 9:34 AM, Mandar Barve wrote:
> We surely need
w two snapshots, but no active VDI. I should see
> two hypervisor snapshots and an active VDI.
>
> Thanks!
>
>
> On Mon, Mar 10, 2014 at 9:27 AM, Mike Tutkowski <
> mike.tutkow...@solidfire.com> wrote:
>
>> I did look at it, but haven't had a chance to try t
va 1600488
utils/test/com/cloud/utils/StringUtilsTest.java 5a90300
Diff: https://reviews.apache.org/r/20117/diff/
Testing
---
Tested the strip logic in the pilot patch for listUsers command response.
Thanks,
Mandar Barve
look for such sub strings. This can remove the need for
iterative code.
Thanks,
Mandar
On Tue, Apr 8, 2014 at 1:32 PM, Mandar Barve wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&g
Thanks,
Mandar
On Mon, Apr 14, 2014 at 10:45 AM, Daan Hoogland wrote:
> How about augmenting on loadtime?
>
> mobile bilingual spell checker used
> Op 14 apr. 2014 07:06 schreef "Mandar Barve" :
>
>> This solution for which I have posted a pilot patch has following
braries can be shipped under
> > Apache license, please advise on this part.
> >
> > Thanks,
> > Alena.
> >
> > On 4/14/14, 10:06 AM, "Daan Hoogland" wrote:
> >
> >>you got my drift. we could also replace the regex with a tree of flags
>
Oh all I meant was stuffing the existing search string that cleanString
uses with all identified "sensitive" keywords. And I guess if it starts
getting GIANT it won't make sense.
On Tue, Apr 15, 2014 at 11:36 AM, Daan Hoogland wrote:
> On Tue, Apr 15, 2014 at 6:01 AM, Man
r the return code. I tried this
and this will return a non zero error code to the management server. It may
still not return the child process's exception code.
Let me know what you think.
Thanks,
Mandar
On Fri, Mar 14, 2014 at 11:55 AM, Mandar Barve
wrote:
> I tried to reproduce the
Hi all,
Problem: JIRA says list hosts API response didn't return CPU used parameter
value. This bug is reported against version 4.0.2.
I could not reproduce this problem with CS version 4.2.
I used CloudMonkey CLI to fire API commands to the management server. With
a basic zone created that has
Hi all,
I could not reproduce this issue with vesion 4.0.2. I tried creating
hourly snapshot schedule with a keep value of 4. I could see 4 snapshots
retained. Then as mentioned in the bug I deleted the schedule and recreated
with same parameters except changing the keep value to 3. After this
fied
> of your findings. I think resolving it is the proper way to go, and if
> the reporter doesn't close or reopen it withing a month or so, close
> it.
>
> regards
>
> On Mon, Nov 25, 2013 at 9:10 AM, Mandar Barve
> wrote:
> > Hi all,
> > I co
sk to
> verify in the newer version. This can be a hassle for small plants. So
> you could put to resolved with the right fix-version.
>
> regards,
>
>
> On Mon, Nov 25, 2013 at 9:00 AM, Mandar Barve
> wrote:
> > Hi all,
> >
> > Problem: JIRA says li
Works.
Thanks,
Mandar
On Wed, Nov 27, 2013 at 3:13 PM, Daan Hoogland wrote:
> Can you try again, I put you in the contributers group but i am not
> sure if this gives you enough rights
>
> thanks,
> Daan
>
> On Wed, Nov 27, 2013 at 6:56 AM, Mandar Barve
> wrote:
Hi All,
JIRA 4406 expects removal of cleanString() call for performance
improvements. This is called when building audit trail for command
responses and used for removing sensitive data (passwords, secret keys)
from the log buffer. All the API responses do not carry such sensitive
information s
t the same or am I missing something?
Thanks,
Mandar
On Thu, Nov 28, 2013 at 5:22 PM, Daan Hoogland wrote:
> On Thu, Nov 28, 2013 at 10:38 AM, Mandar Barve
> wrote:
> >
> > In my opinion we should implement approach #2. I have tested this
> approach
> > for couple
processing of the api class could prevent oversights by
> developers.
>
> On the other hand we will run into privacy and security related
> situations not foreseeable right now. I am not sure if what I am
> saying will pay off.
>
>
>
> On Thu, Nov 28, 2013 at 3:24 PM, Mandar B
Thanks Daan.
Thanks,
Mandar
On Fri, Nov 29, 2013 at 5:16 PM, Daan Hoogland wrote:
> Mandar,
>
> I agree, go ahead. Let me know if you need any help.
>
> On Fri, Nov 29, 2013 at 12:40 PM, Mandar Barve
> wrote:
> > Hi Daan,
> >I see your point in not both
user
create sshkeypair
Thanks,
Mandar Barve
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16385/#review30699
---
On Dec. 19, 2013, 1:45 p.m., Mandar Barve wrote:
>
> ---
om the execute method
> */
> abstract public void cmdHandlesCriticalData();
>
> in BaseCmd.java?
>
> regards,
> Daan
>
>
> On Mon, Dec 23, 2013 at 12:05 PM, Mandar Barve
> wrote:
>
>>This is an automatically generated e-mail. To reply, visit:
>> https://revie
secret
key/password is stripped from the response
list users
list accounts
list virtualmachines
create user
update user
create sshkeypair
Thanks,
Mandar Barve
/password is stripped from the response
list users
list accounts
list virtualmachines
create user
update user
create sshkeypair
Thanks,
Mandar Barve
the developer to declare such sensitivity
upfront.
Hope that addresses your concern.
Thanks,
Mandar
- Mandar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16385/#review308
ve to override for every cmd. By default its false and
> > the cmds having sensitive information can have methods returning true. Also
> > they do not need to be set in execute. This is static information, doesn't
> > change per command so why this needs to be set ?
>
is static information,
> doesn't change per command so why this needs to be set ?
> >
> > Mandar Barve wrote:
> > Nitin,
> > You are right. This was discussed in the earlier discussion
> thread. You should really have to modify only commands that carry
37 matches
Mail list logo
