[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...

2017-02-21 Thread Ashadeepa
Github user Ashadeepa closed the pull request at: https://github.com/apache/cloudstack/pull/1910 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-21 Thread Ashadeepa
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1957 @rafaelweingartner : This is due to the change in my remote urls. Closing the old PR https://github.com/apache/cloudstack/issues/1910. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request #1959: CLOUDSTACK-9786:API reference guide entry for...

2017-02-21 Thread Ashadeepa
GitHub user Ashadeepa opened a pull request: https://github.com/apache/cloudstack/pull/1959 CLOUDSTACK-9786:API reference guide entry for associateIpAddress needs additional information Going through the code & implementation, it seems like either of the parameters are

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-22 Thread Ashadeepa
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1957 @rafaelweingartner : Regarding that force commit, will surely keep that in mind in future. About keyword documentation, I had gone through several cloudstack apis (E.g. https

[GitHub] cloudstack issue #1942: CLOUDSTACK-9784 : GPU detail not displayed in GPU ta...

2017-02-28 Thread Ashadeepa
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1942 Tested the code changes. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...

2017-01-18 Thread Ashadeepa
GitHub user Ashadeepa opened a pull request: https://github.com/apache/cloudstack/pull/1910 CLOUDSTACK-9748:VPN Users search functionality broken VPN Users search functionality broken If you try to search VPN users with it’s user name, you will not be able to search

[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...

2017-01-29 Thread Ashadeepa
Github user Ashadeepa commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1910#discussion_r98381118 --- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java --- @@ -613,6 +614,10 @@ public void doInTransactionWithoutResult

[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...

2017-01-29 Thread Ashadeepa
Github user Ashadeepa commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1910#discussion_r98381232 --- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java --- @@ -596,7 +597,7 @@ public void doInTransactionWithoutResult

[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...

2017-01-30 Thread Ashadeepa
Github user Ashadeepa commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1910#discussion_r98422211 --- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java --- @@ -596,7 +597,7 @@ public void doInTransactionWithoutResult

[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...

2017-02-16 Thread Ashadeepa
Github user Ashadeepa closed the pull request at: https://github.com/apache/cloudstack/pull/1910 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #1910: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-16 Thread Ashadeepa
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1910 ![test_input_ss](https://cloud.githubusercontent.com/assets/24891090/23020031/12ead576-f46b-11e6-80f6-689e34f18998.PNG) ![test_output_ss](https://cloud.githubusercontent.com/assets

[GitHub] cloudstack pull request #1910: CLOUDSTACK-9748:VPN Users search functionalit...

2017-02-16 Thread Ashadeepa
GitHub user Ashadeepa reopened a pull request: https://github.com/apache/cloudstack/pull/1910 CLOUDSTACK-9748:VPN Users search functionality broken VPN Users search functionality broken If you try to search VPN users with it’s user name, you will not be able to search

[GitHub] cloudstack issue #1910: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-16 Thread Ashadeepa
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1910 @ustcweizhou : Hi, I had tested the same and added my test results in the file TestResults_CLOUDSTACK-9748.txt. As per my previous comment, when both username & keyword are

[GitHub] cloudstack pull request #1957: CLOUDSTACK-9748:VPN Users search functionalit...

2017-02-21 Thread Ashadeepa
GitHub user Ashadeepa opened a pull request: https://github.com/apache/cloudstack/pull/1957 CLOUDSTACK-9748:VPN Users search functionality broken VPN Users search functionality broken If you try to search VPN users with it’s user name, you will not be able to search

[GitHub] cloudstack issue #1910: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-21 Thread Ashadeepa
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1910 @ustcweizhou : Thanks. I have made the changes. New PR : https://github.com/apache/cloudstack/pull/1957. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-21 Thread Ashadeepa
Github user Ashadeepa commented on the issue: https://github.com/apache/cloudstack/pull/1957 @ustcweizhou : My bad. Amended the changes . Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request #1957: CLOUDSTACK-9748:VPN Users search functionalit...

2017-02-21 Thread Ashadeepa
Github user Ashadeepa commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1957#discussion_r10411 --- Diff: server/src/com/cloud/network/vpn/RemoteAccessVpnManagerImpl.java --- @@ -621,6 +627,10 @@ public void doInTransactionWithoutResult