[PR] work on expanding Quota api [cloudstack-go]

2024-07-22 Thread via GitHub
tonymmm1 opened a new pull request, #90: URL: https://github.com/apache/cloudstack-go/pull/90 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-22 Thread via GitHub
nvazquez commented on code in PR #69: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686667880 ## cloudstack_loadbalancer.go: ## @@ -790,6 +852,29 @@ func (lb *loadBalancer) updateFirewallRule(publicIpId string, publicPort int, pr re

Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-22 Thread via GitHub
nvazquez commented on code in PR #69: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686667880 ## cloudstack_loadbalancer.go: ## @@ -790,6 +852,29 @@ func (lb *loadBalancer) updateFirewallRule(publicIpId string, publicPort int, pr re

Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-22 Thread via GitHub
Pearl1594 commented on code in PR #69: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686689894 ## cloudstack_loadbalancer.go: ## @@ -790,6 +852,29 @@ func (lb *loadBalancer) updateFirewallRule(publicIpId string, publicPort int, pr r

Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-22 Thread via GitHub
Pearl1594 commented on code in PR #69: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686689894 ## cloudstack_loadbalancer.go: ## @@ -790,6 +852,29 @@ func (lb *loadBalancer) updateFirewallRule(publicIpId string, publicPort int, pr r

Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-22 Thread via GitHub
weizhouapache commented on code in PR #69: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686729279 ## cloudstack_loadbalancer.go: ## @@ -828,6 +913,42 @@ func (lb *loadBalancer) deleteFirewallRule(publicIpId string, publicPort int, pr

Re: [PR] Add support for NetworkACLs for LB on VPC networks [cloudstack-kubernetes-provider]

2024-07-22 Thread via GitHub
Pearl1594 commented on code in PR #69: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/69#discussion_r1686748302 ## cloudstack_loadbalancer.go: ## @@ -828,6 +913,42 @@ func (lb *loadBalancer) deleteFirewallRule(publicIpId string, publicPort int, pr r

Re: [PR] work on expanding Quota api [cloudstack-go]

2024-07-22 Thread via GitHub
tonymmm1 commented on PR #90: URL: https://github.com/apache/cloudstack-go/pull/90#issuecomment-2243989711 Requesting a review if any mistakes/issues in implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t