Re: [PR] Documentation for adding NFS mount options to storage pool [cloudstack-documentation]

2024-07-02 Thread via GitHub
sureshanaparti merged PR #396: URL: https://github.com/apache/cloudstack-documentation/pull/396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsu

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-07-02 Thread via GitHub
abh1sar commented on PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#issuecomment-2197919963 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-07-02 Thread via GitHub
blueorangutan commented on PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#issuecomment-2197922134 @abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-07-02 Thread via GitHub
blueorangutan commented on PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#issuecomment-2197923789 QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/395. (QA-JID 237) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-07-02 Thread via GitHub
sureshanaparti merged PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsu

Re: [PR] feat: migrate to terraform plugin framework [cloudstack-terraform-provider]

2024-07-02 Thread via GitHub
vishesh92 commented on code in PR #113: URL: https://github.com/apache/cloudstack-terraform-provider/pull/113#discussion_r1662924675 ## cloudstack/resource_cloudstack_service_offering.go: ## @@ -20,246 +20,735 @@ package cloudstack import ( + "context" "fmt" -

Re: [PR] feat: migrate to terraform plugin framework [cloudstack-terraform-provider]

2024-07-02 Thread via GitHub
vishesh92 commented on PR #113: URL: https://github.com/apache/cloudstack-terraform-provider/pull/113#issuecomment-2203967104 @fabiomatavelli There are changes around service offering in PR #77 by @poddm. Does this PR supersede the changes in PR #77? -- This is an automated message from

Re: [PR] feat: migrate to terraform plugin framework [cloudstack-terraform-provider]

2024-07-02 Thread via GitHub
fabiomatavelli commented on PR #113: URL: https://github.com/apache/cloudstack-terraform-provider/pull/113#issuecomment-2203971835 @vishesh92 yes, this will be the first resource updated to the tf framework. Do you think the approach used in the #77 is better, by splitting into different r

Re: [PR] feat: migrate to terraform plugin framework [cloudstack-terraform-provider]

2024-07-02 Thread via GitHub
vishesh92 commented on PR #113: URL: https://github.com/apache/cloudstack-terraform-provider/pull/113#issuecomment-2203982419 > @vishesh92 yes, this will be the first resource updated to the tf framework. Do you think the approach used in the #77 is better, by splitting into different reso