[PR] kvm: add information on UEFI [cloudstack-documentation]

2024-06-14 Thread via GitHub
rohityadavcloud opened a new pull request, #407: URL: https://github.com/apache/cloudstack-documentation/pull/407 Tries to address https://github.com/apache/cloudstack/issues/7126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] kvm: add information on UEFI [cloudstack-documentation]

2024-06-14 Thread via GitHub
rohityadavcloud commented on PR #407: URL: https://github.com/apache/cloudstack-documentation/pull/407#issuecomment-2167412380 Request for review - I'm not sure what else we must document here - @andrijapanicsb @weizhouapache @sureshanaparti @DaanHoogland and others -- This is an automat

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-14 Thread via GitHub
fabiomatavelli commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639582074 ## cloudstack/provider_test.go: ## @@ -20,56 +20,79 @@ package cloudstack import ( + "context" "os" "testing" -

Re: [PR] kvm: add information on UEFI [cloudstack-documentation]

2024-06-14 Thread via GitHub
sureshanaparti commented on PR #407: URL: https://github.com/apache/cloudstack-documentation/pull/407#issuecomment-2167688981 > Request for review - I'm not sure what else we must document here - @andrijapanicsb @weizhouapache @sureshanaparti @DaanHoogland and others @rohityadavcloud

Re: [PR] add APIs [cloudstack-go]

2024-06-14 Thread via GitHub
ahmedali6 commented on code in PR #88: URL: https://github.com/apache/cloudstack-go/pull/88#discussion_r1639726832 ## cloudstack/HostService.go: ## @@ -4753,3 +4772,1202 @@ func (r *UpdateHostPasswordResponse) UnmarshalJSON(b []byte) error { type alias UpdateHostPasswor

Re: [PR] add APIs [cloudstack-go]

2024-06-14 Thread via GitHub
ahmedali6 commented on code in PR #88: URL: https://github.com/apache/cloudstack-go/pull/88#discussion_r1639727102 ## cloudstack/HostService.go: ## @@ -4753,3 +4772,1202 @@ func (r *UpdateHostPasswordResponse) UnmarshalJSON(b []byte) error { type alias UpdateHostPasswor

Re: [PR] add APIs [cloudstack-go]

2024-06-14 Thread via GitHub
ahmedali6 closed pull request #88: add APIs URL: https://github.com/apache/cloudstack-go/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-uns

Re: [PR] add APIs [cloudstack-go]

2024-06-14 Thread via GitHub
ahmedali6 commented on PR #88: URL: https://github.com/apache/cloudstack-go/pull/88#issuecomment-2167909098 Hi. I will close this and make another one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] add +30 more apis [cloudstack-go]

2024-06-14 Thread via GitHub
ahmedali6 opened a new pull request, #89: URL: https://github.com/apache/cloudstack-go/pull/89 This merge requests adds support to the following APIs: ### VirtualMachineService - `importVm` - `unmanageVirtualMachine` - `listUnmanagedInstances` - `importUnmanagedInstance

Re: Endpoint response is different than the docs

2024-06-14 Thread Ahmed Awlaqi
Thanks, is there a docs on how to use this script? I see some variables I need to pass but not sure what they are. On Thu, 13 Jun 2024 at 16:03, Pearl d'Silva wrote: > The build-apidoc.sh script: > https://github.com/apache/cloudstack/blob/main/tools/apidoc/build-apidoc.sh > is responsible for g

Re: Endpoint response is different than the docs

2024-06-14 Thread Wei ZHOU
Hi, you can run "mvn -P developer,systemvm clean install -pl tools/apidoc/" the api doc can be found at tools/apidoc/target/xmldoc/apis/ The api parameters and responses come from the java classes. -Wei On Fri, Jun 14, 2024 at 4:11 PM Ahmed Awlaqi wrote: > > Thanks, is there a docs on how to u

Re: Endpoint response is different than the docs

2024-06-14 Thread Pearl d'Silva
The script can be run something like this: /cloudstack/tools/apidoc$ ./build-apidoc.sh 4.19.0.0 ../../client/target/cloud-client-ui-4.19.0.0.jar ../../client/target/cloud-client-ui-4.19.0.0.jar ./target Which as Wei mentioned is what is done when you build apidoc Thanks ___

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-14 Thread via GitHub
fabiomatavelli commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640109823 ## cloudstack/resource_cloudstack_instance_test.go: ## @@ -312,6 +312,7 @@ func testAccCheckCloudStackInstanceDestroy(s *terraform.State) err

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-14 Thread via GitHub
fabiomatavelli commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640109989 ## cloudstack/resource_cloudstack_instance_test.go: ## @@ -372,6 +375,7 @@ resource "cloudstack_instance" "foobar" { const testAccCloudStackI

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-14 Thread via GitHub
fabiomatavelli commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640110141 ## cloudstack/resource_cloudstack_instance_test.go: ## @@ -404,16 +409,17 @@ resource "cloudstack_instance" "foobar" { name = "terraform-te

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-14 Thread via GitHub
fabiomatavelli commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640110316 ## cloudstack/resource_cloudstack_ipaddress_test.go: ## @@ -137,14 +137,15 @@ func testAccCheckCloudStackIPAddressDestroy(s *terraform.State)

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-14 Thread via GitHub
fabiomatavelli commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640109567 ## cloudstack/resource_cloudstack_disk_test.go: ## @@ -228,6 +228,7 @@ resource "cloudstack_disk" "foo" { const testAccCloudStackDisk_deviceI

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-14 Thread via GitHub
fabiomatavelli commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1640111066 ## cloudstack/resource_cloudstack_network.go: ## @@ -176,14 +175,12 @@ func resourceCloudStackNetworkCreate(d *schema.ResourceData, meta inte

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-14 Thread via GitHub
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2168415802 @vishesh92 issues fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] add +30 more apis [cloudstack-go]

2024-06-14 Thread via GitHub
ahmedali6 commented on PR #89: URL: https://github.com/apache/cloudstack-go/pull/89#issuecomment-2168715054 @vishesh92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u