[PR] Kvm cloudstack repo [cloudstack-documentation]

2024-06-13 Thread via GitHub
rajujith opened a new pull request, #405: URL: https://github.com/apache/cloudstack-documentation/pull/405 adding the section to configure cloudstack repo in KVM installation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[PR] source: add support for Ubuntu 24.04 as both mgmt server and KVM host [cloudstack-documentation]

2024-06-13 Thread via GitHub
rohityadavcloud opened a new pull request, #406: URL: https://github.com/apache/cloudstack-documentation/pull/406 Adds 24.04 and removed 18.04 (eol'd last year) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Endpoint response is different than the docs

2024-06-13 Thread Ahmed Awlaqi
Hi, I faced a problem where the endpoint response is different from what is written in the docs the endpoint is `removeSecondaryStorageSelector` in here https://cloudstack.apache.org/api/apidocs-4.19/apis/removeSecondaryStorageSelector.html we see the response tags but actually non of them are act

Re: [PR] source: add support for Ubuntu 24.04 as both mgmt server and KVM host [cloudstack-documentation]

2024-06-13 Thread via GitHub
rohityadavcloud merged PR #406: URL: https://github.com/apache/cloudstack-documentation/pull/406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-uns

Re: Endpoint response is different than the docs

2024-06-13 Thread Pearl d'Silva
Hi, There does seem to be a difference in the API command definition and the actual response generated. You may either raise an issue at https://github.com/apache/cloudstack/issues or could also contribute towards a fix. The issue seems to be at: https://github.com/apache/cloudstack/blob/main/

Re: Endpoint response is different than the docs

2024-06-13 Thread Ahmed Awlaqi
Hi, I will try to submit a PR for it but do you where I can find the code that generates the API docs to test it. On Thu, Jun 13, 2024 at 2:40 PM Pearl d'Silva wrote: > Hi, > > There does seem to be a difference in the API command definition and the > actual response generated. You may either r

Re: Endpoint response is different than the docs

2024-06-13 Thread Pearl d'Silva
The build-apidoc.sh script:https://github.com/apache/cloudstack/blob/main/tools/apidoc/build-apidoc.sh is responsible for generating the API docs. Regards. From: Ahmed Awlaqi Sent: June 13, 2024 9:39 AM To: dev@cloudstack.apache.org Subject: Re: Endpoint re

Re: [PR] import-vm: remove username, password request params for vm import [cloudstack-documentation]

2024-06-13 Thread via GitHub
sureshanaparti commented on code in PR #401: URL: https://github.com/apache/cloudstack-documentation/pull/401#discussion_r1638353755 ## source/adminguide/virtual_machines/importing_unmanaging_vms.rst: ## @@ -437,8 +437,6 @@ those same credentials are later used for SSH authent

Re: [PR] import-vm: remove username, password request params for vm import [cloudstack-documentation]

2024-06-13 Thread via GitHub
sureshanaparti commented on code in PR #401: URL: https://github.com/apache/cloudstack-documentation/pull/401#discussion_r1638366093 ## source/adminguide/virtual_machines/importing_unmanaging_vms.rst: ## @@ -481,8 +479,6 @@ choose the temporary storage location on the external

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-13 Thread via GitHub
vishesh92 commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2166411819 @fabiomatavelli @poddm I am running a little busy these days. Let me review this PR by next week. -- This is an automated message from the Apache Git Service. To re

Re: [PR] add APIs [cloudstack-go]

2024-06-13 Thread via GitHub
vishesh92 commented on code in PR #88: URL: https://github.com/apache/cloudstack-go/pull/88#discussion_r1639276849 ## cloudstack/HostService.go: ## @@ -4753,3 +4772,1202 @@ func (r *UpdateHostPasswordResponse) UnmarshalJSON(b []byte) error { type alias UpdateHostPasswor

Re: [PR] add APIs [cloudstack-go]

2024-06-13 Thread via GitHub
vishesh92 commented on PR #88: URL: https://github.com/apache/cloudstack-go/pull/88#issuecomment-2167238972 @ahmedali6 Thanks for the PR. It looks good. Just one minor comment which needs to be resolved. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] add APIs [cloudstack-go]

2024-06-13 Thread via GitHub
vishesh92 commented on code in PR #88: URL: https://github.com/apache/cloudstack-go/pull/88#discussion_r1639281442 ## cloudstack/HostService.go: ## @@ -4753,3 +4772,1202 @@ func (r *UpdateHostPasswordResponse) UnmarshalJSON(b []byte) error { type alias UpdateHostPasswor

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-13 Thread via GitHub
vishesh92 commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639289992 ## cloudstack/provider_test.go: ## @@ -20,56 +20,79 @@ package cloudstack import ( + "context" "os" "testing" - "

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-13 Thread via GitHub
vishesh92 commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639294876 ## cloudstack/resource_cloudstack_disk_test.go: ## @@ -228,6 +228,7 @@ resource "cloudstack_disk" "foo" { const testAccCloudStackDisk_deviceID = `

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-13 Thread via GitHub
vishesh92 commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639296109 ## cloudstack/resource_cloudstack_firewall_test.go: ## @@ -188,14 +188,15 @@ func testAccCheckCloudStackFirewallDestroy(s *terraform.State) error

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-13 Thread via GitHub
vishesh92 commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639296948 ## cloudstack/resource_cloudstack_instance_test.go: ## @@ -312,6 +312,7 @@ func testAccCheckCloudStackInstanceDestroy(s *terraform.State) error {

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-13 Thread via GitHub
vishesh92 commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639297083 ## cloudstack/resource_cloudstack_instance_test.go: ## @@ -353,6 +355,7 @@ resource "cloudstack_instance" "foobar" { const testAccCloudStackInstan

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-13 Thread via GitHub
vishesh92 commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639297273 ## cloudstack/resource_cloudstack_instance_test.go: ## @@ -404,16 +409,17 @@ resource "cloudstack_instance" "foobar" { name = "terraform-test"

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-13 Thread via GitHub
vishesh92 commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639297478 ## cloudstack/resource_cloudstack_ipaddress_test.go: ## @@ -137,14 +137,15 @@ func testAccCheckCloudStackIPAddressDestroy(s *terraform.State) erro

Re: [PR] import-vm: remove username, password request params for vm import [cloudstack-documentation]

2024-06-13 Thread via GitHub
shwstppr commented on code in PR #401: URL: https://github.com/apache/cloudstack-documentation/pull/401#discussion_r1639298645 ## source/adminguide/virtual_machines/importing_unmanaging_vms.rst: ## @@ -437,8 +437,6 @@ those same credentials are later used for SSH authenticatio

Re: [PR] import-vm: remove username, password request params for vm import [cloudstack-documentation]

2024-06-13 Thread via GitHub
shwstppr commented on code in PR #401: URL: https://github.com/apache/cloudstack-documentation/pull/401#discussion_r1639298645 ## source/adminguide/virtual_machines/importing_unmanaging_vms.rst: ## @@ -437,8 +437,6 @@ those same credentials are later used for SSH authenticatio

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-13 Thread via GitHub
vishesh92 commented on code in PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#discussion_r1639312096 ## cloudstack/resource_cloudstack_network.go: ## @@ -176,14 +175,12 @@ func resourceCloudStackNetworkCreate(d *schema.ResourceData, meta interface

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-13 Thread via GitHub
vishesh92 commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2167283327 @fabiomatavelli I have reviewed the PR. Changes looks good. I have left comments where I have some questions about the changes. Apart from this, there are sinor cod

Re: [PR] import-vm: remove username, password request params for vm import [cloudstack-documentation]

2024-06-13 Thread via GitHub
sureshanaparti commented on code in PR #401: URL: https://github.com/apache/cloudstack-documentation/pull/401#discussion_r1639324027 ## source/adminguide/virtual_machines/importing_unmanaging_vms.rst: ## @@ -437,8 +437,6 @@ those same credentials are later used for SSH authent

Re: [PR] import-vm: remove username, password request params for vm import [cloudstack-documentation]

2024-06-13 Thread via GitHub
rohityadavcloud merged PR #401: URL: https://github.com/apache/cloudstack-documentation/pull/401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-uns