Re: [PR] Fix providerID handling + label sanitizing [cloudstack-kubernetes-provider]

2024-06-07 Thread via GitHub
vishesh92 commented on PR #46: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/46#issuecomment-2154597439 I tested the above PR with kuberentes 1.28. It doesn't seem to be adding the zone or region labels. I assume it's because this needs some more changes in the impleme

Re: [PR] deployment.yaml: add tolerations [cloudstack-kubernetes-provider]

2024-06-07 Thread via GitHub
vishesh92 merged PR #38: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/38 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsub

Re: [PR] add APIs [cloudstack-go]

2024-06-07 Thread via GitHub
Pearl1594 commented on code in PR #88: URL: https://github.com/apache/cloudstack-go/pull/88#discussion_r1631365419 ## generate/layout.go: ## @@ -211,6 +211,7 @@ var layout = apiInfo{ "releaseHostReservation", "updateHost", "updateH

Re: [PR] add APIs [cloudstack-go]

2024-06-07 Thread via GitHub
ahmedali6 commented on code in PR #88: URL: https://github.com/apache/cloudstack-go/pull/88#discussion_r1631382789 ## generate/layout.go: ## @@ -211,6 +211,7 @@ var layout = apiInfo{ "releaseHostReservation", "updateHost", "updateH

Re: [PR] add APIs [cloudstack-go]

2024-06-07 Thread via GitHub
Pearl1594 commented on code in PR #88: URL: https://github.com/apache/cloudstack-go/pull/88#discussion_r1631388460 ## generate/layout.go: ## @@ -211,6 +211,7 @@ var layout = apiInfo{ "releaseHostReservation", "updateHost", "updateH

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-07 Thread via GitHub
CodeBleu commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2155132268 @poddm @fabiomatavelli @rohityadavcloud What are we waiting on to get this updated? I was looking into testing some other stuff and noticed the version of the cloudst

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-07 Thread via GitHub
poddm commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2155146161 > @poddm @fabiomatavelli @rohityadavcloud What are we waiting on to get this updated? I was looking into testing some other stuff and noticed the version of the cloudstac

Re: [PR] Bump github.com/apache/cloudstack-go/v2 from 2.13.2 to 2.16.1 [cloudstack-terraform-provider]

2024-06-07 Thread via GitHub
CodeBleu commented on PR #119: URL: https://github.com/apache/cloudstack-terraform-provider/pull/119#issuecomment-2155526036 I don't believe this is going to pass, until the following is merged. Or at least the following will fix a lot of those tests failing https://github.com/apac

Re: [PR] feat: migrate to terraform plugin framework [cloudstack-terraform-provider]

2024-06-07 Thread via GitHub
CodeBleu commented on PR #113: URL: https://github.com/apache/cloudstack-terraform-provider/pull/113#issuecomment-2155530628 @fabiomatavelli Just wondering the status of this? Is this dependent on the following being merged? https://github.com/apache/cloudstack-terraform-provider/pu

Re: [PR] feat: migrate to terraform plugin framework [cloudstack-terraform-provider]

2024-06-07 Thread via GitHub
fabiomatavelli commented on PR #113: URL: https://github.com/apache/cloudstack-terraform-provider/pull/113#issuecomment-2155532176 This is ready to be merged @CodeBleu , I just don't have the permission to merge it -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] feat: migrate to terraform plugin framework [cloudstack-terraform-provider]

2024-06-07 Thread via GitHub
CodeBleu commented on PR #113: URL: https://github.com/apache/cloudstack-terraform-provider/pull/113#issuecomment-2155533458 > This is ready to be merged @CodeBleu , I just don't have the permission to merge it I just still see it in "Draft" mode. -- This is an automated message

Re: [PR] feat: migrate to terraform plugin framework [cloudstack-terraform-provider]

2024-06-07 Thread via GitHub
fabiomatavelli commented on PR #113: URL: https://github.com/apache/cloudstack-terraform-provider/pull/113#issuecomment-2155535562 Ah, sorry @CodeBleu , my bad, this is indeed waiting for #71 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Update SDKs [cloudstack-terraform-provider]

2024-06-07 Thread via GitHub
fabiomatavelli commented on PR #71: URL: https://github.com/apache/cloudstack-terraform-provider/pull/71#issuecomment-2155673023 @poddm @rohityadavcloud what is the next step then? Can we merge it? It's all good to be merged so we can continue working on other PRs -- This is an automate