Re: [I] createUser/updateUser APIs need to be POST [cloudstack-go]

2024-05-09 Thread via GitHub
rohit-satya commented on issue #85: URL: https://github.com/apache/cloudstack-go/issues/85#issuecomment-2102321756 @mlsorensen Please assign this to me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [I] createUser/updateUser APIs need to be POST [cloudstack-go]

2024-05-09 Thread via GitHub
shwstppr commented on issue #85: URL: https://github.com/apache/cloudstack-go/issues/85#issuecomment-2102373230 @rohit-satya there is already a PR for this now, https://github.com/apache/cloudstack-go/pull/86. You may help review/test that -- This is an automated message from the Apache G

Re: [PR] Generate methods to reset params [cloudstack-go]

2024-05-09 Thread via GitHub
shwstppr merged PR #84: URL: https://github.com/apache/cloudstack-go/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstack.

Re: [PR] Use POST for user sensitive calls [cloudstack-go]

2024-05-09 Thread via GitHub
vishesh92 commented on code in PR #86: URL: https://github.com/apache/cloudstack-go/pull/86#discussion_r1595362237 ## generate/generate.go: ## @@ -58,6 +58,20 @@ var detailsRequireZeroIndex = map[string]bool{ "updateAccount":true, } +// requiresPost is a prefilled

Re: [PR] Use POST for user sensitive calls [cloudstack-go]

2024-05-09 Thread via GitHub
vishesh92 commented on PR #86: URL: https://github.com/apache/cloudstack-go/pull/86#issuecomment-2102551076 > code looks good to me. Need to verify if the new methods work as expected. Verified createUser & updateUser methods. -- This is an automated message from the Apache Git Serv

Re: [PR] Use POST for user sensitive calls [cloudstack-go]

2024-05-09 Thread via GitHub
mlsorensen commented on code in PR #86: URL: https://github.com/apache/cloudstack-go/pull/86#discussion_r1595570927 ## generate/generate.go: ## @@ -58,6 +58,20 @@ var detailsRequireZeroIndex = map[string]bool{ "updateAccount":true, } +// requiresPost is a prefille

Re: [PR] Use POST for user sensitive calls [cloudstack-go]

2024-05-09 Thread via GitHub
mlsorensen merged PR #86: URL: https://github.com/apache/cloudstack-go/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cloudstac

Re: [PR] Use POST for user sensitive calls [cloudstack-go]

2024-05-09 Thread via GitHub
mlsorensen commented on code in PR #86: URL: https://github.com/apache/cloudstack-go/pull/86#discussion_r1595570927 ## generate/generate.go: ## @@ -58,6 +58,20 @@ var detailsRequireZeroIndex = map[string]bool{ "updateAccount":true, } +// requiresPost is a prefille