Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
shwstppr commented on code in PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#discussion_r1577648386 ## source/_static/images/change-storage-pool-scope-to-zone.png: ## Review Comment: Do we need to update this image if the dialog has changed? -

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
andrijapanicsb commented on PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#issuecomment-2074754055 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#issuecomment-2074755107 @andrijapanicsb a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git S

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
andrijapanicsb commented on PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#issuecomment-2074756067 I don't see the other image, but I've asked BO to build docs again, and if both images are visible, I'm LGTM with the rest, nice explanation. -- This is an automa

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#issuecomment-2074756774 QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/395. (QA-JID 226) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
andrijapanicsb commented on code in PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#discussion_r1577912290 ## source/adminguide/storage.rst: ## @@ -185,6 +185,38 @@ ensure that the protocol is set to "Filesystem". |adding-local-pool-via-ui.png| +C

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
andrijapanicsb commented on code in PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#discussion_r1577912290 ## source/adminguide/storage.rst: ## @@ -185,6 +185,38 @@ ensure that the protocol is set to "Filesystem". |adding-local-pool-via-ui.png| +C

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
andrijapanicsb commented on PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#issuecomment-2074981410 I made a few proposals to make it more readable from the end user (user doesn't necessarily care about "protocol" and "provider" - simply saying "KVM with NFS" is e

[PR] Documentation for adding NFS mount options to storage pool [cloudstack-documentation]

2024-04-24 Thread via GitHub
abh1sar opened a new pull request, #396: URL: https://github.com/apache/cloudstack-documentation/pull/396 Documentation PR for https://github.com/apache/cloudstack/pull/8947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#discussion_r1578304752 ## source/_static/images/change-storage-pool-scope-to-zone.png: ## Review Comment: Yes, updated the image. -- This is an automated message from

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#discussion_r1578312265 ## source/adminguide/storage.rst: ## @@ -185,6 +185,38 @@ ensure that the protocol is set to "Filesystem". |adding-local-pool-via-ui.png| +Changing

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
abh1sar commented on code in PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#discussion_r1578312560 ## source/adminguide/storage.rst: ## @@ -185,6 +185,38 @@ ensure that the protocol is set to "Filesystem". |adding-local-pool-via-ui.png| +Changing

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
abh1sar commented on PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#issuecomment-2075536576 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#issuecomment-2075538481 @abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

Re: [PR] Detail on changing primary storage scope added to adminguide and concepts [cloudstack-documentation]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #395: URL: https://github.com/apache/cloudstack-documentation/pull/395#issuecomment-2075540039 QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/395. (QA-JID 227) -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Documentation for adding NFS mount options to storage pool [cloudstack-documentation]

2024-04-24 Thread via GitHub
abh1sar commented on PR #396: URL: https://github.com/apache/cloudstack-documentation/pull/396#issuecomment-2076323546 @sureshanaparti @rohityadavcloud @shwstppr @harikrishna-patnala please review -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Documentation for adding NFS mount options to storage pool [cloudstack-documentation]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #396: URL: https://github.com/apache/cloudstack-documentation/pull/396#issuecomment-2076326010 @shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service

Re: [PR] Documentation for adding NFS mount options to storage pool [cloudstack-documentation]

2024-04-24 Thread via GitHub
shwstppr commented on PR #396: URL: https://github.com/apache/cloudstack-documentation/pull/396#issuecomment-2076325435 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Documentation for adding NFS mount options to storage pool [cloudstack-documentation]

2024-04-24 Thread via GitHub
blueorangutan commented on PR #396: URL: https://github.com/apache/cloudstack-documentation/pull/396#issuecomment-2076326698 QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/396. (QA-JID 228) -- This is an automated message from the Apache Git Service. To respond to