+1
Agree with the approach, Vishesh.
-Original Message-
From: Wei ZHOU
Sent: Tuesday, June 6, 2023 8:11 PM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Upgrading Mockito & phasing out powermock
lgtm. go ahead Vishesh.
-Wei
On Tue, 6 Jun 2023 at 14:17, Vishesh Jindal
wrot
Hi Daan - thanks for your input. Some comments inline below
Kind Regards
Giles
-Original Message-
From: Daan Hoogland
Sent: Thursday, June 8, 2023 4:17 PM
To: dev@cloudstack.apache.org
Subject: Re: [proposal] Consistency of naming in Cloudstack
Giles, the principle of what you ar
DaanHoogland commented on code in PR #315:
URL:
https://github.com/apache/cloudstack-documentation/pull/315#discussion_r1224018203
##
source/plugins/cloudstack-kubernetes-service.rst:
##
@@ -185,22 +187,24 @@ New Kubernetes clusters can be created using the API or
via the UI.
Giles, just about point one as the others follow from it.
On Fri, Jun 9, 2023 at 10:17 AM Giles Sirett wrote:
>
> Hi Daan - thanks for your input. Some comments inline below
>
>
>
> Kind Regards
> Giles
>
>
>
>
> -Original Message-
> From: Daan Hoogland
> Sent: Thursday, June 8, 2023 4:1
rohityadavcloud commented on PR #60:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/60#issuecomment-1584759050
Thanks for the PR @FarnazBGH I still see the error from the CI:
```==> Checking that code complies with gofmt requirements...
make: *** [GNUmakefile:32: fmt
rohityadavcloud commented on PR #62:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/62#issuecomment-1584759497
Thanks for the PR @Z-eeshan I've pinged a few contributors to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
+1 to use “Instance” in the UI and docs. Everyone knows what " Instance " is,
in my view, just a label to refer to an object in ACS. As Rohit said, it is
under Compute, then it refers to a Compute Instance.
From: Giles Sirett
Date: Thursday, 8 June 2023 at 16:46
To: dev@cloudstack.apache.org
S
rohityadavcloud commented on PR #62:
URL:
https://github.com/apache/cloudstack-terraform-provider/pull/62#issuecomment-1584903704
@Z-eeshan can you check the build failures? (probably a go fmt fix?)
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
+1 thanks Giles.
For the API we could also update the API docs descriptions for methods,
parameters, and response fields (even though we can end up with: parameter:
virtualmachineid and description: ‘Instance ID’ for example)
Regards,
Nicolas Vazquez
From: Marco Sinhoreli
Date: Friday, 9 Jun