[GitHub] [cloudstack-cloudmonkey] borisstoyanov commented on pull request #129: Optimizing network.go

2023-04-26 Thread via GitHub
borisstoyanov commented on PR #129: URL: https://github.com/apache/cloudstack-cloudmonkey/pull/129#issuecomment-1523071434 Since this is a technical depth, not a feature, I'm thinking to push it for next release. I believe we should merge this after we release 6.3 and start building 6.4 on

[GitHub] [cloudstack-cloudmonkey] rohityadavcloud commented on pull request #129: Optimizing network.go

2023-04-26 Thread via GitHub
rohityadavcloud commented on PR #129: URL: https://github.com/apache/cloudstack-cloudmonkey/pull/129#issuecomment-1523076274 Fine by me @borisstoyanov but if this improves the user-experience and is easy to review/test then we should consider to get it in - pl advise @nvazquez @davidjumani

[GitHub] [cloudstack-cloudmonkey] borisstoyanov commented on pull request #129: Optimizing network.go

2023-04-26 Thread via GitHub
borisstoyanov commented on PR #129: URL: https://github.com/apache/cloudstack-cloudmonkey/pull/129#issuecomment-1523100083 There seems to be a bit of performance improvement, but I don't think it's worth risking, since it does require more testing. ``` ➜ cloudstack-cloudmonkey g

[GitHub] [cloudstack-cloudmonkey] weizhouapache commented on pull request #129: Optimizing network.go

2023-04-26 Thread via GitHub
weizhouapache commented on PR #129: URL: https://github.com/apache/cloudstack-cloudmonkey/pull/129#issuecomment-1523161471 > There seems to be a bit of performance improvement, but I don't think it's worth risking, since it does require more testing. > > ``` > ➜ cloudstack-cloudm