[GitHub] [cloudstack-documentation] shwstppr commented on pull request #294: metrics notes

2023-01-30 Thread via GitHub
shwstppr commented on PR #294: URL: https://github.com/apache/cloudstack-documentation/pull/294#issuecomment-1408206396 @andrijapanicsb @borisstoyanov are you good on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack-documentation] DaanHoogland commented on a diff in pull request #294: metrics notes

2023-01-30 Thread via GitHub
DaanHoogland commented on code in PR #294: URL: https://github.com/apache/cloudstack-documentation/pull/294#discussion_r1090331472 ## source/adminguide/virtual_machines.rst: ## @@ -1281,6 +1281,42 @@ CloudStack follows the below sequence of operations to provide GPU/vGPU suppo

[GitHub] [cloudstack-documentation] shwstppr commented on pull request #294: metrics notes

2023-01-30 Thread via GitHub
shwstppr commented on PR #294: URL: https://github.com/apache/cloudstack-documentation/pull/294#issuecomment-1408230773 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #294: metrics notes

2023-01-30 Thread via GitHub
blueorangutan commented on PR #294: URL: https://github.com/apache/cloudstack-documentation/pull/294#issuecomment-1408232199 @shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #294: metrics notes

2023-01-30 Thread via GitHub
blueorangutan commented on PR #294: URL: https://github.com/apache/cloudstack-documentation/pull/294#issuecomment-1408233044 QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/294. (QA-JID 32) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack-documentation] DaanHoogland merged pull request #294: metrics notes

2023-01-30 Thread via GitHub
DaanHoogland merged PR #294: URL: https://github.com/apache/cloudstack-documentation/pull/294 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on a diff in pull request #49: Rahulbcn27 GitHub actions 1

2023-01-30 Thread via GitHub
rohityadavcloud commented on code in PR #49: URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#discussion_r1090418118 ## .github/workflows/build.yml: ## @@ -0,0 +1,26 @@ +name: Build-Check Review Comment: @rahulbcn27 pl add license -- This is an autom

[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on pull request #49: Rahulbcn27 GitHub actions 1

2023-01-30 Thread via GitHub
rohityadavcloud commented on PR #49: URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#issuecomment-1408335670 @rahulbcn27 could you review https://github.com/apache/cloudstack-terraform-provider#testing-the-provider -- This is an automated message from the Apache Git

[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on a diff in pull request #49: Rahulbcn27 GitHub actions 1

2023-01-30 Thread via GitHub
rohityadavcloud commented on code in PR #49: URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#discussion_r1090419904 ## .github/workflows/build.yml: ## @@ -0,0 +1,26 @@ +name: Build-Check + +on: [push, pull_request] + +concurrency: + group: ${{ github.workf

[GitHub] [cloudstack-terraform-provider] rahulbcn27 commented on a diff in pull request #49: Rahulbcn27 GitHub actions 1

2023-01-30 Thread via GitHub
rahulbcn27 commented on code in PR #49: URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#discussion_r1090435227 ## .github/workflows/build.yml: ## @@ -0,0 +1,26 @@ +name: Build-Check Review Comment: license added ## .github/workflows/build.yml

[GitHub] [cloudstack-terraform-provider] rohityadavcloud commented on pull request #49: Rahulbcn27 GitHub actions 1

2023-01-30 Thread via GitHub
rohityadavcloud commented on PR #49: URL: https://github.com/apache/cloudstack-terraform-provider/pull/49#issuecomment-1408364806 For basic build and unit tests this is good. However, we need to explore if some basic CI/CD using https://github.com/apache/cloudstack-terraform-provider#testi

[GitHub] [cloudstack-terraform-provider] rohityadavcloud merged pull request #49: Rahulbcn27 GitHub actions 1

2023-01-30 Thread via GitHub
rohityadavcloud merged PR #49: URL: https://github.com/apache/cloudstack-terraform-provider/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

[GitHub] [cloudstack-documentation] DaanHoogland commented on a diff in pull request #296: infra: edge zones

2023-01-30 Thread via GitHub
DaanHoogland commented on code in PR #296: URL: https://github.com/apache/cloudstack-documentation/pull/296#discussion_r1090493573 ## source/installguide/configuration.rst: ## @@ -764,6 +768,56 @@ Advanced Zone Configuration #. Click Launch. +Edge Zone +* + +.. not

[GitHub] [cloudstack-documentation] shwstppr commented on pull request #296: infra: edge zones

2023-01-30 Thread via GitHub
shwstppr commented on PR #296: URL: https://github.com/apache/cloudstack-documentation/pull/296#issuecomment-1409906677 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #296: infra: edge zones

2023-01-30 Thread via GitHub
blueorangutan commented on PR #296: URL: https://github.com/apache/cloudstack-documentation/pull/296#issuecomment-1409907543 @shwstppr a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #296: infra: edge zones

2023-01-30 Thread via GitHub
blueorangutan commented on PR #296: URL: https://github.com/apache/cloudstack-documentation/pull/296#issuecomment-1409908185 QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/296. (QA-JID 33) -- This is an automated message from the Apache Git Service. To respond to