[GitHub] [cloudstack-terraform-provider] harikrishna-patnala commented on pull request #37: create ssh keypair data-source

harikrishna-patnala commented on PR #37: URL: https://github.com/apache/cloudstack-terraform-provider/pull/37#issuecomment-1154821152 Hi @Damans227, glad to see your changes. I think it is better to create a single PR for all the datasources since it will be easy to identify the feat

[GitHub] [cloudstack-terraform-provider] Damans227 commented on pull request #37: create ssh keypair data-source

Damans227 commented on PR #37: URL: https://github.com/apache/cloudstack-terraform-provider/pull/37#issuecomment-1155109051 > Hi @Damans227, glad to see your changes. > > I think it is better to create a single PR for all the datasources since it will be easy to identify the feature

[GitHub] [cloudstack-terraform-provider] Damans227 commented on pull request #37: create ssh keypair data-source

Damans227 commented on PR #37: URL: https://github.com/apache/cloudstack-terraform-provider/pull/37#issuecomment-1155614186 Merged this branch onto `AddInstanceDataSource`. Therefore, closing it off now. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack-terraform-provider] Damans227 closed pull request #37: create ssh keypair data-source

Damans227 closed pull request #37: create ssh keypair data-source URL: https://github.com/apache/cloudstack-terraform-provider/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack-terraform-provider] Damans227 opened a new pull request, #38: Adding new data sources to cloudstack-terraform-proivder

Damans227 opened a new pull request, #38: URL: https://github.com/apache/cloudstack-terraform-provider/pull/38 Hi @Pearl1594 and @harikrishna-patnala This PR is a continuation of PR: https://github.com/apache/cloudstack-terraform-provider/pull/34. In order to keep everything organized, I re

[GitHub] [cloudstack-terraform-provider] Damans227 closed pull request #34: Add instance data source

Damans227 closed pull request #34: Add instance data source URL: https://github.com/apache/cloudstack-terraform-provider/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [cloudstack-terraform-provider] Damans227 commented on pull request #34: Add instance data source

Damans227 commented on PR #34: URL: https://github.com/apache/cloudstack-terraform-provider/pull/34#issuecomment-1155626994 This PR is now continued on a new branch here: https://github.com/apache/cloudstack-terraform-provider/pull/38 -- This is an automated message from the Apache Git S

[GitHub] [cloudstack-terraform-provider] Damans227 commented on a diff in pull request #38: Adding new data sources to cloudstack-terraform-proivder

Damans227 commented on code in PR #38: URL: https://github.com/apache/cloudstack-terraform-provider/pull/38#discussion_r897347394 ## cloudstack/data_source_cloudstack_ssh_keypair_test.go: ## @@ -0,0 +1,62 @@ +// +// Licensed to the Apache Software Foundation (ASF) under one +//