[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #30: Updating kubernetes version

2021-04-29 Thread GitBox
davidjumani commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-828988987 @rhtyd Added docker builds to travis. Unit tests are needed which is tracked in https://github.com/apache/cloudstack-kubernetes-provider/issues/23 -- T

[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #212: mysql update warnings

2021-04-29 Thread GitBox
DaanHoogland commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-828998030 I've checked that the default gets applied with "MySQL [5.5.5-10.3.25-MariaDB-0ubuntu0.20.04.1]" and "5.5.68-MariaDB". In my local "MySQL [5.7.28-log]" it g

[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #212: mysql update warnings

2021-04-29 Thread GitBox
DaanHoogland commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-828999093 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #212: mysql update warnings

2021-04-29 Thread GitBox
blueorangutan commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-828999707 @DaanHoogland a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apac

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #212: mysql update warnings

2021-04-29 Thread GitBox
blueorangutan commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829000478 Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/212. (SL-JID 50) -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack-documentation] PaulAngus commented on pull request #212: mysql update warnings

2021-04-29 Thread GitBox
PaulAngus commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829019918 Can someone add a link to where this potential issue was reported please. I agree with Andrija, this is a scary message that basically says: upgrading ma

[GitHub] [cloudstack-documentation] andrijapanicsb commented on pull request #212: mysql update warnings

2021-04-29 Thread GitBox
andrijapanicsb commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829047656 This was a one-time issue that our British friends have occurred when upgrading their test env from 4.13 to 4.15 while using a specific version of MySQL 5

[GitHub] [cloudstack-kubernetes-provider] onitake commented on a change in pull request #30: Updating kubernetes version

2021-04-29 Thread GitBox
onitake commented on a change in pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#discussion_r622960377 ## File path: Makefile ## @@ -34,7 +34,7 @@ CMD_SRC=\ .PHONY: all clean docker -all: cloudstack-ccm +all: clean test cloudstack-c

[GitHub] [cloudstack-kubernetes-provider] onitake commented on a change in pull request #30: Updating kubernetes version

2021-04-29 Thread GitBox
onitake commented on a change in pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#discussion_r622960584 ## File path: Dockerfile ## @@ -18,7 +18,7 @@ FROM golang:1.13 as builder COPY . /go/src/github.com/apache/cloudstack-kubernetes-pro

[GitHub] [cloudstack-cloudmonkey] andrijapanicsb opened a new issue #77: set display default - doesn't work

2021-04-29 Thread GitBox
andrijapanicsb opened a new issue #77: URL: https://github.com/apache/cloudstack-cloudmonkey/issues/77 (localcloud) SBCM6> > set display default (localcloud) SBCM6> > list zones Invalid output type configured, please fix that! it allows setting display to default, but later ther

[GitHub] [cloudstack-kubernetes-provider] onitake commented on issue #2: [OLD] Changing from TCP to TCP Proxy doesn't work

2021-04-29 Thread GitBox
onitake commented on issue #2: URL: https://github.com/apache/cloudstack-kubernetes-provider/issues/2#issuecomment-829153469 I'm not sure how we can address this... Maybe we should just put a comment in the readme for now. -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #30: Updating kubernetes version

2021-04-29 Thread GitBox
joschi36 commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-829227139 Hey @davidjumani > Can use the image over at davidjumani/cloudstack-kubernetes-provider:k-v1.18.18 Is it possible that it's not build as a non-

[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #212: mysql update warnings

2021-04-29 Thread GitBox
DaanHoogland commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829233067 @PaulAngus I like your suggestion but I think that is out of scope. Also you and @andrijapanicsb have a point about not giving to vague instructions. I have

[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #212: mysql update warnings

2021-04-29 Thread GitBox
DaanHoogland commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829236065 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #212: mysql update warnings

2021-04-29 Thread GitBox
blueorangutan commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829236877 @DaanHoogland a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apac

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #212: mysql update warnings

2021-04-29 Thread GitBox
blueorangutan commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-829237520 Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/212. (SL-JID 51) -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack-kubernetes-provider] sureshanaparti commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are mean

2021-04-29 Thread GitBox
sureshanaparti commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r623089878 ## File path: README.md ## @@ -145,7 +145,7 @@ The CCM supports the same cloud-config configuration file format used by [the c

[GitHub] [cloudstack-kubernetes-provider] onitake commented on a change in pull request #30: Updating kubernetes version

2021-04-29 Thread GitBox
onitake commented on a change in pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#discussion_r623466535 ## File path: .travis.yml ## @@ -4,4 +4,7 @@ go: - 1.13 - master -script: make test +services: + - docker + +script: make docker

[GitHub] [cloudstack-documentation] rhtyd merged pull request #209: Optional deploy-as-is

2021-04-29 Thread GitBox
rhtyd merged pull request #209: URL: https://github.com/apache/cloudstack-documentation/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this se

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #209: Optional deploy-as-is

2021-04-29 Thread GitBox
rhtyd commented on pull request #209: URL: https://github.com/apache/cloudstack-documentation/pull/209#issuecomment-829793604 @nvazquez can you raise the same against 4.15 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #30: Updating kubernetes version

2021-04-29 Thread GitBox
davidjumani commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-829803339 @joschi36 I've rebuilt it, can you pull it again and try ? @onitake Reverted the change and will open a separate PR -- This is an automated message f