[GitHub] [cloudstack-cloudmonkey] DaanHoogland commented on issue #75: list templates doesn't work with variables

2021-04-27 Thread GitBox
DaanHoogland commented on issue #75: URL: https://github.com/apache/cloudstack-cloudmonkey/issues/75#issuecomment-827398426 Did it really @andrijapanicsb? The shell would always expand the var to include the spaces and than cmk would only get the first part as the value of the parameter.

[GitHub] [cloudstack-cloudmonkey] andrijapanicsb commented on issue #75: list templates doesn't work with variables

2021-04-27 Thread GitBox
andrijapanicsb commented on issue #75: URL: https://github.com/apache/cloudstack-cloudmonkey/issues/75#issuecomment-827399781 Join the Bootcamp in May, and I can show you :) this is how it did work for last few years with CMK 5.3.3, we can take this offline if you want -- This is an aut

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #211: Update docs

2021-04-27 Thread GitBox
rhtyd commented on pull request #211: URL: https://github.com/apache/cloudstack-documentation/pull/211#issuecomment-827498434 @davidjumani conflict on master branch, or is it for 4.15 branch? -- This is an automated message from the Apache Git Service. To respond to the message, please l

Missing Features in the new UI

2021-04-27 Thread David Jumani
Hi, I was going through the new UI and noticed that a few features are not yet implemented in the new UI which exist in the legacy UI and APIs exist in the backend (not sure whether they're still functional). I've made a list of them over at https://github.com/apache/cloudstack/issues/4937 and

[GitHub] [cloudstack-documentation] davidjumani commented on pull request #207: Updating image and docs wrt the new UI

2021-04-27 Thread GitBox
davidjumani commented on pull request #207: URL: https://github.com/apache/cloudstack-documentation/pull/207#issuecomment-827505762 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #207: Updating image and docs wrt the new UI

2021-04-27 Thread GitBox
blueorangutan commented on pull request #207: URL: https://github.com/apache/cloudstack-documentation/pull/207#issuecomment-827506180 @davidjumani a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apach

[GitHub] [cloudstack-documentation] davidjumani commented on pull request #211: Update docs

2021-04-27 Thread GitBox
davidjumani commented on pull request #211: URL: https://github.com/apache/cloudstack-documentation/pull/211#issuecomment-827506189 @rhtyd It's for 4.15, to be merged after #207 is merged -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [cloudstack-documentation] davidjumani commented on pull request #211: Update docs

2021-04-27 Thread GitBox
davidjumani commented on pull request #211: URL: https://github.com/apache/cloudstack-documentation/pull/211#issuecomment-827506347 @blueorangutan docbuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #211: Update docs

2021-04-27 Thread GitBox
blueorangutan commented on pull request #211: URL: https://github.com/apache/cloudstack-documentation/pull/211#issuecomment-827506696 @davidjumani a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apach

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #207: Updating image and docs wrt the new UI

2021-04-27 Thread GitBox
blueorangutan commented on pull request #207: URL: https://github.com/apache/cloudstack-documentation/pull/207#issuecomment-827506735 Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/207. (SL-JID 47) -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #211: Update docs

2021-04-27 Thread GitBox
blueorangutan commented on pull request #211: URL: https://github.com/apache/cloudstack-documentation/pull/211#issuecomment-827507184 Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/211. (SL-JID 48) -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
davidjumani commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827556759 @onitake Agreed, but in the case of a smaller env, there will be 3 pods on maybe 1 or 2 nodes. I'd prefer to have the replicas proportional to the nodes

[GitHub] [cloudstack-kubernetes-provider] davidjumani edited a comment on pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
davidjumani edited a comment on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827556759 @onitake Agreed so not necessarily a deamonset, but in the case of a smaller env, there will be 3 pods on maybe 1 or 2 nodes. I'd prefer to have th

[GitHub] [cloudstack-kubernetes-provider] davidjumani edited a comment on pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
davidjumani edited a comment on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827556759 @onitake Agreed so not necessarily a deamonset, but in the case of a smaller env, there will be 3 pods on maybe 1 or 2 nodes, since most users will

Re: [DISCUSS] Renaming default git branch name from 'master' to 'main'

2021-04-27 Thread Daan Hoogland
great thanks Suresh, I think we should merge these with extreme prejudice so we can smoothen our way of working in time before the 4.16 release pressure kicks in. On Mon, Apr 26, 2021 at 4:02 PM Suresh Anaparti < suresh.anapa...@shapeblue.com> wrote: > Hi all, > > Here is the list of CloudStack r

[GitHub] [cloudstack-documentation] DaanHoogland opened a new pull request #212: mysql update warnings

2021-04-27 Thread GitBox
DaanHoogland opened a new pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212 This adds a mysql specific upgrade notes page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack-documentation] DaanHoogland commented on pull request #212: mysql update warnings

2021-04-27 Thread GitBox
DaanHoogland commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-827616946 @rhtyd @andrijapanicsb I'm not sure if this is working and enough but please chime in @blueorangutan docbuild -- This is an automated message from the

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #212: mysql update warnings

2021-04-27 Thread GitBox
blueorangutan commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-827617689 @DaanHoogland a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. -- This is an automated message from the Apac

[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #212: mysql update warnings

2021-04-27 Thread GitBox
blueorangutan commented on pull request #212: URL: https://github.com/apache/cloudstack-documentation/pull/212#issuecomment-827618334 Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/212. (SL-JID 49) -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
onitake commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-827637589 3+ replicas of the cloud provider seems like total overkill. It doesn't store any state, and it doesn't need to be highly available. It will synchronize to

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
davidjumani commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-828134379 Right, unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
davidjumani commented on pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27#issuecomment-828134518 @rhtyd Can you merge ? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaning

2021-04-27 Thread GitBox
davidjumani commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r621822210 ## File path: README.md ## @@ -145,7 +145,7 @@ The CCM supports the same cloud-config configuration file format used by [the cs

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on a change in pull request #29: Inclusivity changes for CloudStack - rename some offensive words/terms as appropriate, that are meaning

2021-04-27 Thread GitBox
davidjumani commented on a change in pull request #29: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/29#discussion_r621824001 ## File path: Makefile ## @@ -21,7 +21,7 @@ GIT_COMMIT_SHORT=$(shell git rev-parse --short HEAD) GIT_TAG=$(shell git describe --a

[GitHub] [cloudstack-kubernetes-provider] davidjumani opened a new pull request #30: Updating kubernetes version

2021-04-27 Thread GitBox
davidjumani opened a new pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30 Fixes https://github.com/apache/cloudstack-kubernetes-provider/issues/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [cloudstack-kubernetes-provider] davidjumani commented on pull request #30: Updating kubernetes version

2021-04-27 Thread GitBox
davidjumani commented on pull request #30: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/30#issuecomment-828166025 @onitake @joschi36 Can you review ? Can use the image over at `davidjumani/cloudstack-kubernetes-provider:k-v1.18.18` Thanks -- This is an automa

[GitHub] [cloudstack-kubernetes-provider] rhtyd merged pull request #27: Provider should not be a DaemonSet

2021-04-27 Thread GitBox
rhtyd merged pull request #27: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about thi