[GitHub] [cloudstack-primate] utchoang removed a comment on pull request #718: FIX - customize theme

2020-09-18 Thread GitBox
utchoang removed a comment on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-693299441 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme

2020-09-18 Thread GitBox
utchoang commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694708985 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme

2020-09-18 Thread GitBox
utchoang commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694708920 Customize navigation color ![image](https://user-images.githubusercontent.com/13766648/93569679-12097900-f9bc-11ea-97ac-07d9d2adff2a.png)

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme

2020-09-18 Thread GitBox
blueorangutan commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694709147 @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme

2020-09-18 Thread GitBox
blueorangutan commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694712862 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3

[GitHub] [cloudstack-primate] utchoang commented on pull request #718: FIX - customize theme

2020-09-18 Thread GitBox
utchoang commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694713172 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme

2020-09-18 Thread GitBox
blueorangutan commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694713760 @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #718: FIX - customize theme

2020-09-18 Thread GitBox
blueorangutan commented on pull request #718: URL: https://github.com/apache/cloudstack-primate/pull/718#issuecomment-694717686 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3

[GitHub] [cloudstack-primate] utchoang commented on issue #721: [FEATURE] Clicking anywhere on the line (instead of just the radio button) should select the i.e. Offering

2020-09-18 Thread GitBox
utchoang commented on issue #721: URL: https://github.com/apache/cloudstack-primate/issues/721#issuecomment-694734086 @andrijapanicsb @rhtyd cc @svenvogel Does this apply to disk offerings, networks, security, and affinity group? -

[GitHub] [cloudstack-primate] utchoang opened a new pull request #722: Select/checked row when clicking anywhere on the line table

2020-09-18 Thread GitBox
utchoang opened a new pull request #722: URL: https://github.com/apache/cloudstack-primate/pull/722 @rhtyd cc @svenvogel Fixes #721 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [cloudstack-documentation] DaanHoogland merged pull request #137: remove blacklist and whitelist phrases

2020-09-18 Thread GitBox
DaanHoogland merged pull request #137: URL: https://github.com/apache/cloudstack-documentation/pull/137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack-documentation] DaanHoogland opened a new pull request #154: Revert "remove blacklist and whitelist phrases"

2020-09-18 Thread GitBox
DaanHoogland opened a new pull request #154: URL: https://github.com/apache/cloudstack-documentation/pull/154 Reverts apache/cloudstack-documentation#137 politically correct change and also more accurtate but not implemented yet :( ---

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #154: Revert "remove blacklist and whitelist phrases"

2020-09-18 Thread GitBox
rhtyd commented on pull request #154: URL: https://github.com/apache/cloudstack-documentation/pull/154#issuecomment-694746240 Since the changes proposed in the doc PR are not merged upstream with an upgrade path that changes the names of existing settings, we'll need to revert this. @Daan

[GitHub] [cloudstack-documentation] rhtyd merged pull request #154: Revert "remove blacklist and whitelist phrases"

2020-09-18 Thread GitBox
rhtyd merged pull request #154: URL: https://github.com/apache/cloudstack-documentation/pull/154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #137: remove blacklist and whitelist phrases

2020-09-18 Thread GitBox
rhtyd commented on pull request #137: URL: https://github.com/apache/cloudstack-documentation/pull/137#issuecomment-694747165 @DaanHoogland @PaulAngus you may need to re-open the PR and merge only after the upstream PR to apache/cloudstack is merged with a DB upgrade path too ---

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #721: [FEATURE] Clicking anywhere on the line (instead of just the radio button) should select the i.e. Offering

2020-09-18 Thread GitBox
andrijapanicsb commented on issue #721: URL: https://github.com/apache/cloudstack-primate/issues/721#issuecomment-694748548 I would say - let's apply it EVERYWHERE where there are radio buttons? This is an automated message

[GitHub] [cloudstack-primate] rhtyd closed issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...

2020-09-18 Thread GitBox
rhtyd closed issue #704: URL: https://github.com/apache/cloudstack-primate/issues/704 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd merged pull request #716: usermenu: Forgetting path when manually logging out

2020-09-18 Thread GitBox
rhtyd merged pull request #716: URL: https://github.com/apache/cloudstack-primate/pull/716 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on issue #704: [BUG] During logout, the last "URL" is part of the "logged-out" URL - causing issues...

2020-09-18 Thread GitBox
rhtyd commented on issue #704: URL: https://github.com/apache/cloudstack-primate/issues/704#issuecomment-694749018 @andrijapanicsb cc @PaulAngus please review, test and close. I discussed with Andrija and we're now forgetting the path on explicit logout but not on logout due to session ti

[GitHub] [cloudstack-primate] rhtyd commented on issue #719: [FEATURE] Move fetch data to created()

2020-09-18 Thread GitBox
rhtyd commented on issue #719: URL: https://github.com/apache/cloudstack-primate/issues/719#issuecomment-694749546 @davidjumani is that a critical issue, should we do it for 1.0 or 1.1? This is an automated message from the

[GitHub] [cloudstack-primate] rhtyd commented on issue #720: [BUG] "OS Type" not shown in instance view

2020-09-18 Thread GitBox
rhtyd commented on issue #720: URL: https://github.com/apache/cloudstack-primate/issues/720#issuecomment-694749272 @andrijapanicsb I think it is when you move cursor on the OS icon This is an automated message from the Apach

[GitHub] [cloudstack-primate] davidjumani commented on issue #719: [FEATURE] Move fetch data to created()

2020-09-18 Thread GitBox
davidjumani commented on issue #719: URL: https://github.com/apache/cloudstack-primate/issues/719#issuecomment-694757683 It's an improvement, can be done as part of 1.1 This is an automated message from the Apache Git Servic

[GitHub] [cloudstack-documentation] DaanHoogland opened a new pull request #155: remove blacklist and whitelist phrases

2020-09-18 Thread GitBox
DaanHoogland opened a new pull request #155: URL: https://github.com/apache/cloudstack-documentation/pull/155 this was overhastely merged and reverted but is still a valid change; wording is not only more politically correct but also more accurate. some code chamges are prerequisite for it

[GitHub] [cloudstack-primate] utchoang commented on pull request #722: Select/checked row when clicking anywhere on the line table

2020-09-18 Thread GitBox
utchoang commented on pull request #722: URL: https://github.com/apache/cloudstack-primate/pull/722#issuecomment-694771555 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #722: Select/checked row when clicking anywhere on the line table

2020-09-18 Thread GitBox
blueorangutan commented on pull request #722: URL: https://github.com/apache/cloudstack-primate/pull/722#issuecomment-694772022 @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #722: Select/checked row when clicking anywhere on the line table

2020-09-18 Thread GitBox
blueorangutan commented on pull request #722: URL: https://github.com/apache/cloudstack-primate/pull/722#issuecomment-694776060 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/722 (JID-3

[GitHub] [cloudstack-primate] ravening commented on pull request #681: Enable tags for lb rules

2020-09-18 Thread GitBox
ravening commented on pull request #681: URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-694790379 @davidjumani @rhtyd made the change. Please review ![Screenshot 2020-09-18 at 12 30 06](https://user-images.githubusercontent.com/10645273/93587772-aff44800-f9a

[GitHub] [cloudstack-documentation] davidjumani opened a new pull request #156: Adding docs for noVNC

2020-09-18 Thread GitBox
davidjumani opened a new pull request #156: URL: https://github.com/apache/cloudstack-documentation/pull/156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [cloudstack-primate] ravening commented on issue #676: [BUG] ACLs - 2 issues with displaying them

2020-09-18 Thread GitBox
ravening commented on issue #676: URL: https://github.com/apache/cloudstack-primate/issues/676#issuecomment-694808388 @andrijapanicsb did you get chance to test this? This is an automated message from the Apache Git Service.

[GitHub] [cloudstack-documentation] weizhouapache commented on a change in pull request #156: Adding docs for noVNC

2020-09-18 Thread GitBox
weizhouapache commented on a change in pull request #156: URL: https://github.com/apache/cloudstack-documentation/pull/156#discussion_r490877316 ## File path: source/adminguide/systemvm.rst ## @@ -112,13 +112,21 @@ to the VNC port made available via the hypervisor for the con

[GitHub] [cloudstack-documentation] davidjumani commented on a change in pull request #156: Adding docs for noVNC

2020-09-18 Thread GitBox
davidjumani commented on a change in pull request #156: URL: https://github.com/apache/cloudstack-documentation/pull/156#discussion_r490878609 ## File path: source/adminguide/systemvm.rst ## @@ -112,13 +112,21 @@ to the VNC port made available via the hypervisor for the conso

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #723: Adding OS Type to vm detailview

2020-09-18 Thread GitBox
davidjumani opened a new pull request #723: URL: https://github.com/apache/cloudstack-primate/pull/723 Fixes https://github.com/apache/cloudstack-primate/issues/720 ![Screenshot from 2020-09-18 17-20-57](https://user-images.githubusercontent.com/8244774/93594395-5fddab80-f9d3-11ea-90

[GitHub] [cloudstack-primate] davidjumani commented on pull request #723: Adding OS Type to vm detailview

2020-09-18 Thread GitBox
davidjumani commented on pull request #723: URL: https://github.com/apache/cloudstack-primate/pull/723#issuecomment-694824236 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #723: Adding OS Type to vm detailview

2020-09-18 Thread GitBox
blueorangutan commented on pull request #723: URL: https://github.com/apache/cloudstack-primate/pull/723#issuecomment-694824759 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] davidjumani commented on pull request #722: Select/checked row when clicking anywhere on the line table

2020-09-18 Thread GitBox
davidjumani commented on pull request #722: URL: https://github.com/apache/cloudstack-primate/pull/722#issuecomment-694824700 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #722: Select/checked row when clicking anywhere on the line table

2020-09-18 Thread GitBox
blueorangutan commented on pull request #722: URL: https://github.com/apache/cloudstack-primate/pull/722#issuecomment-694825111 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-documentation] davidjumani commented on pull request #156: Adding docs for noVNC

2020-09-18 Thread GitBox
davidjumani commented on pull request #156: URL: https://github.com/apache/cloudstack-documentation/pull/156#issuecomment-694826714 requesting docbuild This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #156: Adding docs for noVNC

2020-09-18 Thread GitBox
ACSGitBot commented on pull request #156: URL: https://github.com/apache/cloudstack-documentation/pull/156#issuecomment-694826755 Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long.

[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #156: Adding docs for noVNC

2020-09-18 Thread GitBox
ACSGitBot commented on pull request #156: URL: https://github.com/apache/cloudstack-documentation/pull/156#issuecomment-694827731 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr156 Build Log Output: No log errors found to report

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #723: Adding OS Type to vm detailview

2020-09-18 Thread GitBox
blueorangutan commented on pull request #723: URL: https://github.com/apache/cloudstack-primate/pull/723#issuecomment-694828789 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/723 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #722: Select/checked row when clicking anywhere on the line table

2020-09-18 Thread GitBox
blueorangutan commented on pull request #722: URL: https://github.com/apache/cloudstack-primate/pull/722#issuecomment-694828936 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/722 (JID-3

[GitHub] [cloudstack-primate] davidjumani commented on pull request #722: Select/checked row when clicking anywhere on the line table

2020-09-18 Thread GitBox
davidjumani commented on pull request #722: URL: https://github.com/apache/cloudstack-primate/pull/722#issuecomment-694836501 @utchoang For some reason selecting disk offering breaks when not clicking on the radio button Th

[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #722: Select/checked row when clicking anywhere on the line table

2020-09-18 Thread GitBox
davidjumani edited a comment on pull request #722: URL: https://github.com/apache/cloudstack-primate/pull/722#issuecomment-694836501 @utchoang For some reason selecting disk offering deselects the option when not clicking on the line but not on the radio button --

[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #722: Select/checked row when clicking anywhere on the line table

2020-09-18 Thread GitBox
davidjumani edited a comment on pull request #722: URL: https://github.com/apache/cloudstack-primate/pull/722#issuecomment-694836501 @utchoang For some reason selecting disk offering deselects the option when clicking on the line and not on the radio button --

[GitHub] [cloudstack-primate] davidjumani commented on pull request #681: Enable tags for lb rules

2020-09-18 Thread GitBox
davidjumani commented on pull request #681: URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-694837132 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #681: Enable tags for lb rules

2020-09-18 Thread GitBox
blueorangutan commented on pull request #681: URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-694837353 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #681: Enable tags for lb rules

2020-09-18 Thread GitBox
blueorangutan commented on pull request #681: URL: https://github.com/apache/cloudstack-primate/pull/681#issuecomment-694841240 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/681 (JID-3

[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #722: Select/checked row when clicking anywhere on the line table

2020-09-18 Thread GitBox
davidjumani edited a comment on pull request #722: URL: https://github.com/apache/cloudstack-primate/pull/722#issuecomment-694836501 @utchoang For some reason selecting disk offering deselects the option when clicking on the line and not on the radio button Could you also change the cur

[GitHub] [cloudstack-primate] rhtyd merged pull request #681: Enable tags for lb rules

2020-09-18 Thread GitBox
rhtyd merged pull request #681: URL: https://github.com/apache/cloudstack-primate/pull/681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on issue #679: [BUG] Tags not possible to be set on a LB rule

2020-09-18 Thread GitBox
rhtyd commented on issue #679: URL: https://github.com/apache/cloudstack-primate/issues/679#issuecomment-694845695 @andrijapanicsb pl test and close This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack-primate] rhtyd closed issue #679: [BUG] Tags not possible to be set on a LB rule

2020-09-18 Thread GitBox
rhtyd closed issue #679: URL: https://github.com/apache/cloudstack-primate/issues/679 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd merged pull request #723: Adding OS Type to vm detailview

2020-09-18 Thread GitBox
rhtyd merged pull request #723: URL: https://github.com/apache/cloudstack-primate/pull/723 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on issue #720: [BUG] "OS Type" not shown in instance view

2020-09-18 Thread GitBox
rhtyd commented on issue #720: URL: https://github.com/apache/cloudstack-primate/issues/720#issuecomment-694846419 @andrijapanicsb pl test and close This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack-primate] rhtyd closed issue #720: [BUG] "OS Type" not shown in instance view

2020-09-18 Thread GitBox
rhtyd closed issue #720: URL: https://github.com/apache/cloudstack-primate/issues/720 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #724: [BUG] minor: center the name of the network for L2 network

2020-09-18 Thread GitBox
andrijapanicsb opened a new issue #724: URL: https://github.com/apache/cloudstack-primate/issues/724 ![image](https://user-images.githubusercontent.com/45762285/93624046-fc0daf80-f9df-11ea-9833-bbf4fa41ff49.png) if possible, center (vertically) L2 networks (other networks have th

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #724: [BUG] minor: center the name of the network for L2 network

2020-09-18 Thread GitBox
andrijapanicsb commented on issue #724: URL: https://github.com/apache/cloudstack-primate/issues/724#issuecomment-694975758 same for other fields - if possible: ![image](https://user-images.githubusercontent.com/45762285/93624219-50189400-f9e0-11ea-883f-fe9f5649d66f.png) -

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #725: [FEATURE] Add CIDR next to the network name, for deploy-as-is templates

2020-09-18 Thread GitBox
andrijapanicsb opened a new issue #725: URL: https://github.com/apache/cloudstack-primate/issues/725 For normal templates, when user chooses some networks to attach the VM to, there is CIDR of that network shown to help user. With deploy-as-is templates, CIDR is not shown - let's add

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #726: [BUG] again, pages refreshed when they should not be

2020-09-18 Thread GitBox
andrijapanicsb opened a new issue #726: URL: https://github.com/apache/cloudstack-primate/issues/726 Deploying a VM, submitted the job in UI, then opened the " new VM" wizard again - and when the PREVIOUS job completed (same happens if deleting a VM previously) - a weird refresh API is sen

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #727: [BUG] Can't "unchoose" data disk from VM deployment wizard

2020-09-18 Thread GitBox
andrijapanicsb opened a new issue #727: URL: https://github.com/apache/cloudstack-primate/issues/727 I clicked by mistake on the additional disk, and now I can't "un-choose" the offering/data disk: ![image](https://user-images.githubusercontent.com/45762285/93630015-8b6b9080-f9e9-11

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #727: [BUG] Can't "unchoose" data disk from VM deployment wizard

2020-09-18 Thread GitBox
andrijapanicsb commented on issue #727: URL: https://github.com/apache/cloudstack-primate/issues/727#issuecomment-695007533 this is only with deploy-as-is templates - the "no thanks" option is missing (exists/is fine for non-deploy-as-is templates) cc @davidjumani ---

[GitHub] [cloudstack-primate] andrijapanicsb closed issue #727: [BUG] Can't "unchoose" data disk from VM deployment wizard

2020-09-18 Thread GitBox
andrijapanicsb closed issue #727: URL: https://github.com/apache/cloudstack-primate/issues/727 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #727: [BUG] Can't "unchoose" data disk from VM deployment wizard

2020-09-18 Thread GitBox
andrijapanicsb commented on issue #727: URL: https://github.com/apache/cloudstack-primate/issues/727#issuecomment-695008720 can't reproduce again (perhaps I scrolled down...) closing. This is an automated message from the Ap