[GitHub] [cloudstack-primate] rhtyd closed issue #652: [BUG] Minor: update label/text

2020-09-02 Thread GitBox
rhtyd closed issue #652: URL: https://github.com/apache/cloudstack-primate/issues/652 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd merged pull request #655: Changing 'to default' to 'as default'

2020-09-02 Thread GitBox
rhtyd merged pull request #655: URL: https://github.com/apache/cloudstack-primate/pull/655 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on issue #652: [BUG] Minor: update label/text

2020-09-02 Thread GitBox
rhtyd commented on issue #652: URL: https://github.com/apache/cloudstack-primate/issues/652#issuecomment-685442641 @andrijapanicsb fixed in https://github.com/apache/cloudstack-primate/pull/655, please review and close the issue --

[GitHub] [cloudstack-primate] rhtyd commented on pull request #657: vm wizard: add MAC Address validator

2020-09-02 Thread GitBox
rhtyd commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-685443073 @blueoragutan package This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [cloudstack-primate] rhtyd removed a comment on pull request #657: vm wizard: add MAC Address validator

2020-09-02 Thread GitBox
rhtyd removed a comment on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-685443073 @blueoragutan package This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack-primate] rhtyd commented on pull request #657: vm wizard: add MAC Address validator

2020-09-02 Thread GitBox
rhtyd commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-68561 @utchoang in the network record if that's an isolated/shared network (or != L2 network) then you can check the `record.cidr` and you can check if the input IP is within

[GitHub] [cloudstack-primate] rhtyd commented on pull request #657: vm wizard: add MAC Address validator

2020-09-02 Thread GitBox
rhtyd commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-685444540 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack-primate] rhtyd merged pull request #661: Hiding vlan uri for non admin users

2020-09-02 Thread GitBox
rhtyd merged pull request #661: URL: https://github.com/apache/cloudstack-primate/pull/661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #657: vm wizard: add MAC Address validator

2020-09-02 Thread GitBox
blueorangutan commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-685445145 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd closed issue #659: [BUG] Regular users should not see their network's VLAN

2020-09-02 Thread GitBox
rhtyd closed issue #659: URL: https://github.com/apache/cloudstack-primate/issues/659 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on issue #644: [BUG] Add message/questions when unmanaging an instance?

2020-09-02 Thread GitBox
rhtyd commented on issue #644: URL: https://github.com/apache/cloudstack-primate/issues/644#issuecomment-685446005 @andrijapanicsb fixed in https://github.com/apache/cloudstack-primate/pull/656 please review and close the issue, thnx -

[GitHub] [cloudstack-primate] rhtyd closed issue #644: [BUG] Add message/questions when unmanaging an instance?

2020-09-02 Thread GitBox
rhtyd closed issue #644: URL: https://github.com/apache/cloudstack-primate/issues/644 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on issue #659: [BUG] Regular users should not see their network's VLAN

2020-09-02 Thread GitBox
rhtyd commented on issue #659: URL: https://github.com/apache/cloudstack-primate/issues/659#issuecomment-685445509 @andrijapanicsb fixed in https://github.com/apache/cloudstack-primate/pull/661 please review and close the issue, thnx -

[GitHub] [cloudstack-primate] rhtyd merged pull request #656: Adding message to unmanage vm

2020-09-02 Thread GitBox
rhtyd merged pull request #656: URL: https://github.com/apache/cloudstack-primate/pull/656 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd merged pull request #654: template/iso listing User role regression from #642

2020-09-02 Thread GitBox
rhtyd merged pull request #654: URL: https://github.com/apache/cloudstack-primate/pull/654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #649: Filter vms based on zones for attaching volumes

2020-09-02 Thread GitBox
rhtyd commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-685446569 ping @davidjumani @Pearl1594 - can you advise if this works/break for a project view, thnx This is an a

[GitHub] [cloudstack-primate] rhtyd commented on pull request #662: Refresh data every 30 seconds

2020-09-02 Thread GitBox
rhtyd commented on pull request #662: URL: https://github.com/apache/cloudstack-primate/pull/662#issuecomment-685447382 This is not ideal or fail-safe, what-if it takes more than n * 30s for the batched jobs to finished (where n is the number of resources on which a group action was perfo

[GitHub] [cloudstack-primate] rhtyd commented on pull request #658: Fixes reload of page on session expiry

2020-09-02 Thread GitBox
rhtyd commented on pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-685450339 Did a quick test LGTM (I deleted the jsession cookie and click a router-link), need more testing for cases (a) on mgmt server restart, (b) on actual session expiry (say

[GitHub] [cloudstack-primate] rhtyd edited a comment on pull request #658: Fixes reload of page on session expiry

2020-09-02 Thread GitBox
rhtyd edited a comment on pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-685450339 Did a quick test LGTM (I deleted the jsession cookie and click a router-link), need more testing for cases (a) on mgmt server restart, (b) on actual session expir

[GitHub] [cloudstack-primate] davidjumani commented on pull request #662: Refresh data every 30 seconds

2020-09-02 Thread GitBox
davidjumani commented on pull request #662: URL: https://github.com/apache/cloudstack-primate/pull/662#issuecomment-685452959 @rhtyd It refreshes the page every 30 seconds irrespective of a batch job to ensure the user always has the latest details available. It also fixes the batch job r

[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #649: Filter vms based on zones for attaching volumes

2020-09-02 Thread GitBox
Pearl1594 commented on a change in pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#discussion_r481901720 ## File path: src/config/section/storage.js ## @@ -101,6 +101,12 @@ export default { label: 'label.action.attach.disk', m

[GitHub] [cloudstack-primate] rhtyd commented on issue #660: [BUG] K8s version - various issues ?

2020-09-02 Thread GitBox
rhtyd commented on issue #660: URL: https://github.com/apache/cloudstack-primate/issues/660#issuecomment-685501566 @andrijapanicsb looks like 2CPU is a requirement and the version needs to be 1.15.0 as there is no k8s 1.15 release but 1.15.0 or 1.15.1 release. Have you followed the docs

[GitHub] [cloudstack-primate] shwstppr commented on issue #660: [BUG] K8s version - various issues ?

2020-09-02 Thread GitBox
shwstppr commented on issue #660: URL: https://github.com/apache/cloudstack-primate/issues/660#issuecomment-685507076 I've added some improvements here, https://github.com/apache/cloudstack/pull/4269, error messages and API param description. I've not explicitly tied 2vCPU, 2GB memory req

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #663: missing tooltips

2020-09-02 Thread GitBox
Pearl1594 commented on pull request #663: URL: https://github.com/apache/cloudstack-primate/pull/663#issuecomment-685560595 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #663: missing tooltips

2020-09-02 Thread GitBox
Pearl1594 opened a new pull request #663: URL: https://github.com/apache/cloudstack-primate/pull/663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #658: Fixes reload of page on session expiry

2020-09-02 Thread GitBox
Pearl1594 commented on pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-685560793 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #649: Filter vms based on zones for attaching volumes

2020-09-02 Thread GitBox
Pearl1594 commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-685673519 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [cloudstack-primate] utchoang commented on pull request #657: vm wizard: add MAC Address validator

2020-09-02 Thread GitBox
utchoang commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-686190959 * Show list IP range and check valid IP range: ![Screenshot_1](https://user-images.githubusercontent.com/13766648/92063645-da001480-edc5-11ea-9dcc-f86c05d39421.png)

[GitHub] [cloudstack-primate] utchoang commented on pull request #657: vm wizard: add MAC Address validator

2020-09-02 Thread GitBox
utchoang commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-686244939 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #664: [WIP] deployvm: Showing additoinal fields in infocard

2020-09-02 Thread GitBox
davidjumani opened a new pull request #664: URL: https://github.com/apache/cloudstack-primate/pull/664 Adds additional fields to the infocard while creating a vm - Pod - Cluseter - Host This is an automated message f

[GitHub] [cloudstack-primate] davidjumani commented on pull request #651: Prevent form from closing if validation fails

2020-09-02 Thread GitBox
davidjumani commented on pull request #651: URL: https://github.com/apache/cloudstack-primate/pull/651#issuecomment-686272652 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] utchoang removed a comment on pull request #657: vm wizard: add MAC Address validator

2020-09-02 Thread GitBox
utchoang removed a comment on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-686244939 @blueorangutan package This is an automated message from the Apache Git Service. To respond t

[GitHub] [cloudstack-primate] utchoang commented on pull request #657: vm wizard: add MAC Address validator

2020-09-02 Thread GitBox
utchoang commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-686281128 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #665: [WIP] Adding events for async job completing

2020-09-02 Thread GitBox
davidjumani opened a new pull request #665: URL: https://github.com/apache/cloudstack-primate/pull/665 An alternative to refreshing the page every 30 seconds This is an automated message from the Apache Git Service. To respon