[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
rhtyd commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-675898993 cc @shwstppr LGTM @blueorangutan package This is an automated message from the Apache Git Service

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
blueorangutan commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-675899267 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd commented on issue #590: [BUG] no expunge when deleting multiple VMs at once

2020-08-19 Thread GitBox
rhtyd commented on issue #590: URL: https://github.com/apache/cloudstack-primate/issues/590#issuecomment-675902151 With @davidjumani This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [cloudstack-primate] rhtyd commented on issue #589: [BUG] or an improvement - on new windows, move focus/cursos to the first field

2020-08-19 Thread GitBox
rhtyd commented on issue #589: URL: https://github.com/apache/cloudstack-primate/issues/589#issuecomment-675902421 @davidjumani can you see if it's a good one - otherwise this is good to have but not mandatory for 1.0/GA Th

[GitHub] [cloudstack-primate] rhtyd commented on issue #588: [BUG] switching between Custom and Fixed/Static Compute Offering

2020-08-19 Thread GitBox
rhtyd commented on issue #588: URL: https://github.com/apache/cloudstack-primate/issues/588#issuecomment-675902220 With @davidjumani This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [cloudstack-primate] rhtyd commented on issue #591: [BUG] VM state in UI not updated when deployment failure

2020-08-19 Thread GitBox
rhtyd commented on issue #591: URL: https://github.com/apache/cloudstack-primate/issues/591#issuecomment-675902791 @davidjumani is there a way we can cause the listView to refresh when the async job poll stops? Another way could be to launch the VM and move to the VM once it is deployed i

[GitHub] [cloudstack-primate] rhtyd commented on issue #592: [BUG] Notification message never disapear

2020-08-19 Thread GitBox
rhtyd commented on issue #592: URL: https://github.com/apache/cloudstack-primate/issues/592#issuecomment-675903197 @andrijapanicsb this is expected, all errors are treated like alert dialog boxes in old UI. They are not automatically closed and have a close/cross button to close them. Thi

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
blueorangutan commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-675903649 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/593 (JID-3

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #587: Allow creating snapshot from VM snapshot

2020-08-19 Thread GitBox
rhtyd commented on a change in pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472807049 ## File path: src/config/section/storage.js ## @@ -325,6 +326,16 @@ export default { details: ['name', 'id', 'displayname', 'description', '

[GitHub] [cloudstack-primate] davidjumani commented on issue #590: [BUG] no expunge when deleting multiple VMs at once

2020-08-19 Thread GitBox
davidjumani commented on issue #590: URL: https://github.com/apache/cloudstack-primate/issues/590#issuecomment-675909410 Fixed in https://github.com/apache/cloudstack-primate/pull/594/commits/0facb7a8e69bd33afc30fe20cb54378db7ec8051 ---

[GitHub] [cloudstack-primate] andrijapanicsb closed issue #592: [BUG] Notification message never disapear

2020-08-19 Thread GitBox
andrijapanicsb closed issue #592: URL: https://github.com/apache/cloudstack-primate/issues/592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #592: [BUG] Notification message never disapear

2020-08-19 Thread GitBox
andrijapanicsb commented on issue #592: URL: https://github.com/apache/cloudstack-primate/issues/592#issuecomment-675911737 Sounds good then - thx. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
rhtyd commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-675912527 Regression test LGTM, tried to deploy a VM with some changes in templates and root disk size override T

[GitHub] [cloudstack-primate] rhtyd commented on issue #571: [BUG] Creating Basic Type Zone not supported in primate UI ?

2020-08-19 Thread GitBox
rhtyd commented on issue #571: URL: https://github.com/apache/cloudstack-primate/issues/571#issuecomment-675913172 Thanks for addressing limitation in docs @davidjumani I'll close as @a31amit agrees to use Adv zone as long as all the basic zone features are available (which indeed are)

[GitHub] [cloudstack-primate] rhtyd closed issue #571: [BUG] Creating Basic Type Zone not supported in primate UI ?

2020-08-19 Thread GitBox
rhtyd closed issue #571: URL: https://github.com/apache/cloudstack-primate/issues/571 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #142: Added basic and advanced customization sections to the primate doc

2020-08-19 Thread GitBox
ACSGitBot commented on pull request #142: URL: https://github.com/apache/cloudstack-documentation/pull/142#issuecomment-675918099 Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long.

[GitHub] [cloudstack-documentation] rhtyd commented on pull request #142: Added basic and advanced customization sections to the primate doc

2020-08-19 Thread GitBox
rhtyd commented on pull request #142: URL: https://github.com/apache/cloudstack-documentation/pull/142#issuecomment-675918029 requesting docbuild This is an automated message from the Apache Git Service. To respond t

[GitHub] [cloudstack-documentation] ACSGitBot commented on pull request #142: Added basic and advanced customization sections to the primate doc

2020-08-19 Thread GitBox
ACSGitBot commented on pull request #142: URL: https://github.com/apache/cloudstack-documentation/pull/142#issuecomment-675919229 Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr142 Build Log Output: No log errors found to report

[GitHub] [cloudstack-primate] ravening commented on a change in pull request #587: Allow creating snapshot from VM snapshot

2020-08-19 Thread GitBox
ravening commented on a change in pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472854215 ## File path: src/config/section/storage.js ## @@ -325,6 +326,16 @@ export default { details: ['name', 'id', 'displayname', 'description'

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #587: Allow creating snapshot from VM snapshot

2020-08-19 Thread GitBox
davidjumani commented on a change in pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472866294 ## File path: src/config/section/storage.js ## @@ -325,6 +326,16 @@ export default { details: ['name', 'id', 'displayname', 'descripti

[GitHub] [cloudstack-primate] ravening commented on a change in pull request #587: Allow creating snapshot from VM snapshot

2020-08-19 Thread GitBox
ravening commented on a change in pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472868568 ## File path: src/config/section/storage.js ## @@ -325,6 +326,16 @@ export default { details: ['name', 'id', 'displayname', 'description'

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #587: Allow creating snapshot from VM snapshot

2020-08-19 Thread GitBox
davidjumani commented on a change in pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472871592 ## File path: src/config/section/storage.js ## @@ -325,6 +326,16 @@ export default { details: ['name', 'id', 'displayname', 'descripti

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #587: Allow creating snapshot from VM snapshot

2020-08-19 Thread GitBox
davidjumani commented on a change in pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472871592 ## File path: src/config/section/storage.js ## @@ -325,6 +326,16 @@ export default { details: ['name', 'id', 'displayname', 'descripti

[GitHub] [cloudstack-primate] ravening commented on a change in pull request #587: Allow creating snapshot from VM snapshot

2020-08-19 Thread GitBox
ravening commented on a change in pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472876586 ## File path: src/config/section/storage.js ## @@ -325,6 +326,16 @@ export default { details: ['name', 'id', 'displayname', 'description'

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #587: [WIP] Allow creating snapshot from VM snapshot

2020-08-19 Thread GitBox
davidjumani commented on a change in pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#discussion_r472879243 ## File path: src/config/section/storage.js ## @@ -325,6 +326,16 @@ export default { details: ['name', 'id', 'displayname', 'descripti

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #591: [BUG] VM state in UI not updated when deployment failure

2020-08-19 Thread GitBox
andrijapanicsb commented on issue #591: URL: https://github.com/apache/cloudstack-primate/issues/591#issuecomment-675996030 I had a perhaps related thing - the VM was indeed deployed and started correctly, but its state after, I finished the deployment wizard, was initially "Stopped" and

[GitHub] [cloudstack-primate] davidjumani commented on issue #589: [BUG] or an improvement - on new windows, move focus/cursos to the first field

2020-08-19 Thread GitBox
davidjumani commented on issue #589: URL: https://github.com/apache/cloudstack-primate/issues/589#issuecomment-676005791 Fixed in https://github.com/apache/cloudstack-primate/pull/594/commits/e4580e761148815f4a4c2094bf22dc082cfe9f76 ---

[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
shwstppr commented on a change in pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#discussion_r472897201 ## File path: src/views/compute/DeployVM.vue ## @@ -1791,4 +1806,10 @@ export default { .form-item-hidden { display: none; } + + .va

[GitHub] [cloudstack-primate] davidjumani commented on issue #591: [BUG] VM state in UI not updated when deployment failure

2020-08-19 Thread GitBox
davidjumani commented on issue #591: URL: https://github.com/apache/cloudstack-primate/issues/591#issuecomment-676084840 Refresh after deployment Fixed in https://github.com/apache/cloudstack-primate/pull/594/commits/71c875f50e9114b150599396031178fa76fa3abf --

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
rhtyd commented on a change in pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#discussion_r472931498 ## File path: src/views/compute/DeployVM.vue ## @@ -1791,4 +1806,10 @@ export default { .form-item-hidden { display: none; } + + .vapp-

[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
rhtyd commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676158848 @shwstppr would it be quicker for you to address issues or advise Nicolas? Thanks. @nvazquez @shwstppr cc @davidjumani - pl advise me accordingly happy to merge. --

[GitHub] [cloudstack-primate] rhtyd commented on pull request #587: [WIP] Allow creating snapshot from VM snapshot

2020-08-19 Thread GitBox
rhtyd commented on pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#issuecomment-676162417 @ravening is this still WIP, or ready? This is an automated message from the Apache Git Service. To resp

[GitHub] [cloudstack-primate] rhtyd commented on pull request #587: [WIP] Allow creating snapshot from VM snapshot

2020-08-19 Thread GitBox
rhtyd commented on pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#issuecomment-676161851 LGTM, wil merge this as soon as we merge the upstream 4.14 PR https://github.com/apache/cloudstack/pull/4275 ---

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #594: [WIP] Bug Fixes

2020-08-19 Thread GitBox
rhtyd commented on a change in pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r472949313 ## File path: src/config/eventBus.js ## @@ -0,0 +1,2 @@ +import Vue from 'vue' +export default new Vue() Review comment: @davidjumani what'

[GitHub] [cloudstack-primate] ravening commented on pull request #587: [WIP] Allow creating snapshot from VM snapshot

2020-08-19 Thread GitBox
ravening commented on pull request #587: URL: https://github.com/apache/cloudstack-primate/pull/587#issuecomment-676164060 > @ravening is this still WIP, or ready? @rhtyd this is ready.. waiting for back end pr to get merged -

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #594: [WIP] Bug Fixes

2020-08-19 Thread GitBox
davidjumani commented on a change in pull request #594: URL: https://github.com/apache/cloudstack-primate/pull/594#discussion_r472951520 ## File path: src/config/eventBus.js ## @@ -0,0 +1,2 @@ +import Vue from 'vue' +export default new Vue() Review comment: Used as an e

[GitHub] [cloudstack-primate] shwstppr commented on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
shwstppr commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676209477 ![Screenshot from 2020-08-19 17-13-51](https://user-images.githubusercontent.com/153340/90630854-68f62400-e23f-11ea-966a-a93046081b54.png) Added a-alert component a

[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
rhtyd commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676211248 @nvazquez can you test, I can merge if it works now @blueorangutan package This is an automated mess

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
blueorangutan commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676213006 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
blueorangutan commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676230511 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/593 (JID-3

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
andrijapanicsb commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676254184 Not good - there should be 3 categories, instead of 1: ![image](https://user-images.githubusercontent.com/45762285/90633594-9a162a80-e226-11ea-8a17-e9754b

[GitHub] [cloudstack-primate] andrijapanicsb removed a comment on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
andrijapanicsb removed a comment on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676254184 Not good - there should be 3 categories, instead of 1: ![image](https://user-images.githubusercontent.com/45762285/90633594-9a162a80-e226-11ea-8a1

[GitHub] [cloudstack-primate] rhtyd commented on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
rhtyd commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676259871 Merging this as Abhishek confirms testing this. cc @andrijapanicsb please log further issues, I'm merging this so you can then take latest Primate and carry on vApp back

[GitHub] [cloudstack-primate] rhtyd merged pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
rhtyd merged pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #593: Improve vApps properties section adding categories and sort order

2020-08-19 Thread GitBox
andrijapanicsb commented on pull request #593: URL: https://github.com/apache/cloudstack-primate/pull/593#issuecomment-676285842 LGTM - both the vApp categories and the questions in each - are sorted properly - as in the OVF thx! -

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #595: [BUG] minor: add "MB" to the offering field desc

2020-08-19 Thread GitBox
andrijapanicsb opened a new issue #595: URL: https://github.com/apache/cloudstack-primate/issues/595 ![image](https://user-images.githubusercontent.com/45762285/90641992-21b56680-e232-11ea-8cbf-541b6dcf52d0.png) The unit is missing in the desc - do the sam as "Mhz" for the CPU fi

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering

2020-08-19 Thread GitBox
andrijapanicsb opened a new issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596 Deploying an OVA template with vApp Configurations (which define/require 1000Mhz CPU and 1MB of RAM - see the OVF part below). The Primate doesn't allow (me) to select Small/Medium/Bi

[GitHub] [cloudstack-primate] shwstppr commented on issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering

2020-08-19 Thread GitBox
shwstppr commented on issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596#issuecomment-676408715 @andrijapanicsb current behaviour in Primate is to strictly match configurations for RAM and CPU values. This can be changed if needed ---

[GitHub] [cloudstack-primate] shwstppr edited a comment on issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering

2020-08-19 Thread GitBox
shwstppr edited a comment on issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596#issuecomment-676408715 @andrijapanicsb current behaviour in Primate is to strictly match configurations and offerings for RAM and CPU values. This can be changed if needed -

[GitHub] [cloudstack-primate] rhtyd commented on issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering

2020-08-19 Thread GitBox
rhtyd commented on issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596#issuecomment-676411435 @andrijapanicsb @nvazquez the compute offering does not determine the network speed, which is part of the network offering. The configuration name may therefore get misleadin

[GitHub] [cloudstack-primate] rhtyd commented on issue #595: [BUG] minor: add "MB" to the offering field desc

2020-08-19 Thread GitBox
rhtyd commented on issue #595: URL: https://github.com/apache/cloudstack-primate/issues/595#issuecomment-676414482 Should be quick one - @shwstppr @davidjumani This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering

2020-08-19 Thread GitBox
andrijapanicsb commented on issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596#issuecomment-676418803 @rhtyd this is Daans testing machinge with poor name - no problem there. I get it for the "exact match" - but didn't we communicate hiding all offerings that are "

[GitHub] [cloudstack-primate] andrijapanicsb edited a comment on issue #596: [BUG] "Configuration" values from the vApp appliance vs Compute offering

2020-08-19 Thread GitBox
andrijapanicsb edited a comment on issue #596: URL: https://github.com/apache/cloudstack-primate/issues/596#issuecomment-676418803 @rhtyd this is Daan's testing machine with poor name - no problem there. I get it for the "exact match" - but didn't we communicate hiding all offerings tha

[GitHub] [cloudstack-primate] davidjumani commented on issue #595: [BUG] minor: add "MB" to the offering field desc

2020-08-19 Thread GitBox
davidjumani commented on issue #595: URL: https://github.com/apache/cloudstack-primate/issues/595#issuecomment-676428845 Fixed in https://github.com/apache/cloudstack-primate/pull/594/commits/77c8f68364c80c0bf2866d3e3b2c735b50b1555d ---

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #597: [BUG] Input field for RAM in the custom compute offering needs polishing

2020-08-19 Thread GitBox
andrijapanicsb opened a new issue #597: URL: https://github.com/apache/cloudstack-primate/issues/597 Custom compute offering: ![image](https://user-images.githubusercontent.com/45762285/90658765-3e5a9a00-e244-11ea-808c-652093ceff2d.png) Click inside the RAM field, hit backspac

[GitHub] [cloudstack-primate] andrijapanicsb opened a new issue #598: [BUG] the "job querying" message-box will redirect users back to the previos page

2020-08-19 Thread GitBox
andrijapanicsb opened a new issue #598: URL: https://github.com/apache/cloudstack-primate/issues/598 The title is ugly, but I don't know the terminology, here's what I mean When deleting a template., the following happens: 1. Go to delete a template ![image](https://user-im

[GitHub] [cloudstack-primate] utchoang commented on issue #598: [BUG] the "job querying" message-box will redirect users back to the previos page

2020-08-19 Thread GitBox
utchoang commented on issue #598: URL: https://github.com/apache/cloudstack-primate/issues/598#issuecomment-676947032 @rhtyd cc @svenvogel I will fix this task, Thanks. This is an automated message from the Apache Git Servic

[GitHub] [cloudstack-primate] utchoang opened a new pull request #599: Fix page navigation error when delete template.

2020-08-19 Thread GitBox
utchoang opened a new pull request #599: URL: https://github.com/apache/cloudstack-primate/pull/599 Open for https://github.com/apache/cloudstack-primate/issues/598 @rhtyd cc @svenvogel I've completed this task. Please review it. Thanks. -

[GitHub] [cloudstack-primate] utchoang opened a new pull request #600: VM Wizard: Custom RAM field compute offering

2020-08-19 Thread GitBox
utchoang opened a new pull request #600: URL: https://github.com/apache/cloudstack-primate/pull/600 Open for https://github.com/apache/cloudstack-primate/issues/597 @rhtyd cc @svenvogel I've completed this task. Please review it. Thanks. ![image](https://user-images.githubusercontent.

[GitHub] [cloudstack-primate] utchoang commented on issue #597: [BUG] Input field for RAM in the custom compute offering needs polishing

2020-08-19 Thread GitBox
utchoang commented on issue #597: URL: https://github.com/apache/cloudstack-primate/issues/597#issuecomment-67736 Fixed in https://github.com/apache/cloudstack-primate/pull/600 This is an automated message from the Apach