[GitHub] [cloudstack-primate] rhtyd merged pull request #581: Adding custom success message to updateVmwareDc

2020-08-14 Thread GitBox
rhtyd merged pull request #581: URL: https://github.com/apache/cloudstack-primate/pull/581 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #580: Fr41 fixes

2020-08-14 Thread GitBox
rhtyd commented on pull request #580: URL: https://github.com/apache/cloudstack-primate/pull/580#issuecomment-673949392 Pinging for review - @davidjumani @borisstoyanov @vladimirpetrov @harikrishna-patnala This is an autom

[GitHub] [cloudstack-primate] rhtyd closed issue #577: Improve message on updating VMware DC details

2020-08-14 Thread GitBox
rhtyd closed issue #577: URL: https://github.com/apache/cloudstack-primate/issues/577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd merged pull request #575: Adding Account Switcher for SAML Accounts

2020-08-14 Thread GitBox
rhtyd merged pull request #575: URL: https://github.com/apache/cloudstack-primate/pull/575 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #550: vApps frontend support

2020-08-14 Thread GitBox
rhtyd commented on pull request #550: URL: https://github.com/apache/cloudstack-primate/pull/550#issuecomment-673951799 @shwstppr @nvazquez is this ready for review/testing now? @blueorangutan package This is an automated

[GitHub] [cloudstack-primate] rhtyd commented on pull request #556: German translation

2020-08-14 Thread GitBox
rhtyd commented on pull request #556: URL: https://github.com/apache/cloudstack-primate/pull/556#issuecomment-673952104 Okay @svenvogel I'll merge this PR based on your feedback This is an automated message from the Apache G

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #550: vApps frontend support

2020-08-14 Thread GitBox
blueorangutan commented on pull request #550: URL: https://github.com/apache/cloudstack-primate/pull/550#issuecomment-673952341 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd merged pull request #556: German translation

2020-08-14 Thread GitBox
rhtyd merged pull request #556: URL: https://github.com/apache/cloudstack-primate/pull/556 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] borisstoyanov opened a new issue #582: [BUG] Volume Migration - Replace disk offering selected by default

2020-08-14 Thread GitBox
borisstoyanov opened a new issue #582: URL: https://github.com/apache/cloudstack-primate/issues/582 **Describe the bug** The option is selected by default. Such action shouldn't be executed by default, it should be under admin consideration and explicit request. **To Reproduce**

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #550: vApps frontend support

2020-08-14 Thread GitBox
blueorangutan commented on pull request #550: URL: https://github.com/apache/cloudstack-primate/pull/550#issuecomment-673960989 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/550 (JID-3

[GitHub] [cloudstack-primate] shwstppr commented on pull request #550: vApps frontend support

2020-08-14 Thread GitBox
shwstppr commented on pull request #550: URL: https://github.com/apache/cloudstack-primate/pull/550#issuecomment-673977539 @rhtyd yes, please review This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] rhtyd commented on pull request #484: WIP: Spanish translations

2020-08-14 Thread GitBox
rhtyd commented on pull request #484: URL: https://github.com/apache/cloudstack-primate/pull/484#issuecomment-673988043 @nvazquez ping - will we be able to finish this PR towards 1.0/GA milestone or should we move this to 1.1? -

[GitHub] [cloudstack-primate] rhtyd commented on issue #582: [BUG] Volume Migration - Replace disk offering selected by default

2020-08-14 Thread GitBox
rhtyd commented on issue #582: URL: https://github.com/apache/cloudstack-primate/issues/582#issuecomment-673990668 @davidjumani can you have a look at this? This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack-primate] rhtyd commented on pull request #484: WIP: Spanish translations

2020-08-14 Thread GitBox
rhtyd commented on pull request #484: URL: https://github.com/apache/cloudstack-primate/pull/484#issuecomment-674018933 Tentatively moved to 1.1 as I see many outstanding tasks This is an automated message from the Apache Gi

[GitHub] [cloudstack-primate] rhtyd merged pull request #580: VMware storage capabilities fixes

2020-08-14 Thread GitBox
rhtyd merged pull request #580: URL: https://github.com/apache/cloudstack-primate/pull/580 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-kubernetes-provider] joschi36 commented on pull request #9: Support loadBalancerSourceRanges

2020-08-14 Thread GitBox
joschi36 commented on pull request #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-674026470 Hi @onitake I tested the CCM and saw some issues, here my tests: ## Tests: ### :ballot_box_with_check: Creating Service LoadBalancer without

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #9: Support loadBalancerSourceRanges

2020-08-14 Thread GitBox
onitake commented on pull request #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-674028687 Thanks for testing! We should put all this into automated unit tests. The case that doesn't work is kind of expected... the internal logic is "create

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #583: MigrateVolume : ReplaceDiskOffering defaulting to false

2020-08-14 Thread GitBox
davidjumani opened a new pull request #583: URL: https://github.com/apache/cloudstack-primate/pull/583 Fixes #582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [cloudstack-primate] davidjumani commented on pull request #583: MigrateVolume : ReplaceDiskOffering defaulting to false

2020-08-14 Thread GitBox
davidjumani commented on pull request #583: URL: https://github.com/apache/cloudstack-primate/pull/583#issuecomment-674039530 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #583: MigrateVolume : ReplaceDiskOffering defaulting to false

2020-08-14 Thread GitBox
blueorangutan commented on pull request #583: URL: https://github.com/apache/cloudstack-primate/pull/583#issuecomment-674039878 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #583: MigrateVolume : ReplaceDiskOffering defaulting to false

2020-08-14 Thread GitBox
blueorangutan commented on pull request #583: URL: https://github.com/apache/cloudstack-primate/pull/583#issuecomment-674043447 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/583 (JID-3

[GitHub] [cloudstack-kubernetes-provider] onitake commented on pull request #9: Support loadBalancerSourceRanges

2020-08-14 Thread GitBox
onitake commented on pull request #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-674174681 Ok, so as a first measure, I can make EnsureLoadBalancer fail when it can't create the firewall rules. ---

[GitHub] [cloudstack-kubernetes-provider] onitake edited a comment on pull request #9: Support loadBalancerSourceRanges

2020-08-14 Thread GitBox
onitake edited a comment on pull request #9: URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-674174681 Ok, so as a first measure, I can make EnsureLoadBalancer fail when it can't create the firewall rules. This may leave it in an invalid state, howe