[GitHub] [cloudstack-primate] utchoang commented on issue #510: Build and packaging improvements

2020-07-15 Thread GitBox
utchoang commented on issue #510: URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-658585116 Currently, I have only found a few issues: 1. In node_modules, we use package `@antv/g2`, this package is used in the chart. => Ignore package `@antv/g2` because I th

[GitHub] [cloudstack-primate] utchoang edited a comment on issue #510: Build and packaging improvements

2020-07-15 Thread GitBox
utchoang edited a comment on issue #510: URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-658585116 @rhtyd cc @svenvogel Currently, I have only found a few issues: 1. In node_modules, we use package `@antv/g2`, this package is used in the chart. => Ignore

[GitHub] [cloudstack-primate] utchoang commented on issue #510: Build and packaging improvements

2020-07-15 Thread GitBox
utchoang commented on issue #510: URL: https://github.com/apache/cloudstack-primate/issues/510#issuecomment-658586035 @rhtyd Also can I use `core/lazy_use` instead of `core/use` in main.js? Because to avoid arising unused components. --

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-15 Thread GitBox
davidjumani edited a comment on issue #528: URL: https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179 Bugs : Fixed in #534 - ~While changing a systemvm service offering, need to fetch system offerings by passing `issystem=true`, `virtualmachineid` and `syste

Re: [VOTE] Release Apache CloudStack CloudMonkey 6.1.0

2020-07-15 Thread Riepl, Gregor (SWISS TXT)
+1 (non-binding) I tested a few common and less-common things and found no regressions. Note: I built the binary locally, didn't try the binaries on the Github release page. From: Rohit Yadav Sent: 01 July 2020 06:51 To: dev@cloudstack.apache.org ; us...@cloudst

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-15 Thread GitBox
davidjumani edited a comment on issue #528: URL: https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179 Bugs : Fixed in #534 - ~While changing a systemvm service offering, need to fetch system offerings by passing `issystem=true`, `virtualmachineid` and `syste

[GitHub] [cloudstack-primate] rhtyd merged pull request #436: feature: template ovf properties

2020-07-15 Thread GitBox
rhtyd merged pull request #436: URL: https://github.com/apache/cloudstack-primate/pull/436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #527: Enable searching for templates/iso while vm deployment

2020-07-15 Thread GitBox
rhtyd commented on pull request #527: URL: https://github.com/apache/cloudstack-primate/pull/527#issuecomment-658650838 @davidjumani can you take over and help fix this, if necessary create a new PR based on this. This is a blocker if user is not able to find/select their own templates us

[GitHub] [cloudstack-primate] rhtyd merged pull request #541: Fixing user bug

2020-07-15 Thread GitBox
rhtyd merged pull request #541: URL: https://github.com/apache/cloudstack-primate/pull/541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-15 Thread GitBox
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658656367 @utchoang can you test all views you've changed, review and add missing labels for en.json. I've seen many obvious issues where instead of translation the label is se

[GitHub] [cloudstack-primate] rhtyd merged pull request #531: Add missing internationlization to search and pagination

2020-07-15 Thread GitBox
rhtyd merged pull request #531: URL: https://github.com/apache/cloudstack-primate/pull/531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-15 Thread GitBox
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658657237 @utchoang can you merge latest master and fix conflicts as well, thanks. This is an automated message fr

[GitHub] [cloudstack-primate] rhtyd commented on pull request #540: Contextual info for Service offering forms and upload custom ssl certs

2020-07-15 Thread GitBox
rhtyd commented on pull request #540: URL: https://github.com/apache/cloudstack-primate/pull/540#issuecomment-658657694 @Pearl1594 is this ready for review/merging? This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #540: Contextual info for Service offering forms and upload custom ssl certs

2020-07-15 Thread GitBox
Pearl1594 commented on pull request #540: URL: https://github.com/apache/cloudstack-primate/pull/540#issuecomment-658658141 Yes @rhtyd This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [cloudstack-primate] rhtyd merged pull request #540: Contextual info for Service offering forms and upload custom ssl certs

2020-07-15 Thread GitBox
rhtyd merged pull request #540: URL: https://github.com/apache/cloudstack-primate/pull/540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #540: Contextual info for Service offering forms and upload custom ssl certs

2020-07-15 Thread GitBox
rhtyd commented on pull request #540: URL: https://github.com/apache/cloudstack-primate/pull/540#issuecomment-658672914 LGTM, @Pearl1594 if you do work on such PRs, prioritise forms/components that are User, DomainAdmin facing than only Admin facing. -

[GitHub] [cloudstack-primate] rhtyd commented on issue #520: [BUG] DeployVM Wizard does not properly search for templates

2020-07-15 Thread GitBox
rhtyd commented on issue #520: URL: https://github.com/apache/cloudstack-primate/issues/520#issuecomment-658680813 @davidjumani please address this issue on priority as it's blocking general usability, in addition: - As a user I should be able to search and select template based on the

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
davidjumani opened a new pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542 Fixes #520: - The rootdisk option shouldn't be passed via API if the override is/was not selected, also the value must be a whole number (than floating point). By default in VMware whe

[GitHub] [cloudstack-primate] davidjumani commented on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
davidjumani commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658689351 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
blueorangutan commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658689759 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
blueorangutan commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658693558 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/542 (JID-2

[GitHub] [cloudstack-primate] davidjumani commented on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
davidjumani commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658725579 Tested and working This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [cloudstack-primate] davidjumani edited a comment on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
davidjumani edited a comment on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658725579 @rhtyd Tested and working This is an automated message from the Apache Git Service. To resp

[GitHub] [cloudstack-primate] davidjumani removed a comment on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
davidjumani removed a comment on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658725579 @rhtyd Tested and working This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack-primate] davidjumani commented on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
davidjumani commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658728427 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
blueorangutan commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658728735 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #543: Fix template search

2020-07-15 Thread GitBox
davidjumani opened a new pull request #543: URL: https://github.com/apache/cloudstack-primate/pull/543 Fixes #520 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [cloudstack-primate] davidjumani commented on pull request #543: Fix template search

2020-07-15 Thread GitBox
davidjumani commented on pull request #543: URL: https://github.com/apache/cloudstack-primate/pull/543#issuecomment-658752922 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] davidjumani commented on pull request #543: Fix template search

2020-07-15 Thread GitBox
davidjumani commented on pull request #543: URL: https://github.com/apache/cloudstack-primate/pull/543#issuecomment-658753040 @rhtyd @ravening Please reveiw This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #543: Fix template search

2020-07-15 Thread GitBox
davidjumani commented on a change in pull request #543: URL: https://github.com/apache/cloudstack-primate/pull/543#discussion_r455034076 ## File path: src/views/compute/wizard/TemplateIsoSelection.vue ## @@ -232,6 +236,60 @@ export default { }, changeFilterType (value

[GitHub] [cloudstack-primate] davidjumani commented on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
davidjumani commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658755372 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
blueorangutan commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658756025 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] svenvogel commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-15 Thread GitBox
svenvogel commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658756961 @rhtyd Additional german is ready. i will send it to @utchoang he can add this. K? This is an autom

[GitHub] [cloudstack-primate] davidjumani commented on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
davidjumani commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658759691 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
blueorangutan commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658760204 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #543: Fix template search

2020-07-15 Thread GitBox
blueorangutan commented on pull request #543: URL: https://github.com/apache/cloudstack-primate/pull/543#issuecomment-658763235 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/543 (JID-2

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
blueorangutan commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658764912 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/542 (JID-2

[GitHub] [cloudstack-primate] svenvogel edited a comment on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-15 Thread GitBox
svenvogel edited a comment on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-658756961 @rhtyd Additional german is ready. i will send it to @utchoang he can add this or should @utchoang file a Separate PR? -

[GitHub] [cloudstack-primate] davidjumani commented on pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
davidjumani commented on pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542#issuecomment-658770208 @rhtyd good to go! This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #543: Fix template search

2020-07-15 Thread GitBox
davidjumani commented on a change in pull request #543: URL: https://github.com/apache/cloudstack-primate/pull/543#discussion_r455058969 ## File path: src/views/compute/wizard/TemplateIsoSelection.vue ## @@ -232,6 +236,60 @@ export default { }, changeFilterType (value

[GitHub] [cloudstack-primate] ravening commented on a change in pull request #543: Fix template search

2020-07-15 Thread GitBox
ravening commented on a change in pull request #543: URL: https://github.com/apache/cloudstack-primate/pull/543#discussion_r455137119 ## File path: src/views/compute/wizard/TemplateIsoSelection.vue ## @@ -232,6 +236,60 @@ export default { }, changeFilterType (value) {

[GitHub] [cloudstack-cloudmonkey] weizhouapache opened a new issue #66: Error 432 while list publicipaddresses

2020-07-15 Thread GitBox
weizhouapache opened a new issue #66: URL: https://github.com/apache/cloudstack-cloudmonkey/issues/66 see below ``` (local) 🐵 > list publicipaddresses associatednetworkid=Error 432: The given command:listNetscalerLoadBalancerNetworks does not exist or it is not available for user wit

[GitHub] [cloudstack-cloudmonkey] rhtyd commented on issue #66: Error 432 while list publicipaddresses

2020-07-15 Thread GitBox
rhtyd commented on issue #66: URL: https://github.com/apache/cloudstack-cloudmonkey/issues/66#issuecomment-659158088 Thanks for reporting @weizhouapache can you set debug on and run this. Is this on latest cmk? We probably can get of the heuristic to use any if the related APIs.

[GitHub] [cloudstack-primate] rhtyd merged pull request #542: Fixing rootdisk size override

2020-07-15 Thread GitBox
rhtyd merged pull request #542: URL: https://github.com/apache/cloudstack-primate/pull/542 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd closed issue #520: [BUG] DeployVM Wizard does not properly search for templates

2020-07-15 Thread GitBox
rhtyd closed issue #520: URL: https://github.com/apache/cloudstack-primate/issues/520 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-15 Thread GitBox
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659163484 @svenvogel please send a separate PR, you may want to include new keys introduced in this PR @blueorangutan package -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-15 Thread GitBox
blueorangutan commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659163647 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-15 Thread GitBox
rhtyd commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659163835 Can you review and test @davidjumani @Pearl1594 thanks. This is an automated message from the Apache Git

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-15 Thread GitBox
blueorangutan commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659166140 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/481 (JID-2

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-15 Thread GitBox
Pearl1594 commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659171852 On checking for translations - few success/loading/catch and error messages need translation in DeployVM.vue and IngressEgressRuleConfigure.vue - others pretty much

[GitHub] [cloudstack-primate] davidjumani commented on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-15 Thread GitBox
davidjumani commented on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659172379 @utchoang Could you check the english strings in the following files : src/views/iam/AddAccount.vue : Cancel OK src/views/iam/AddLdapAccount.vue : Con

[GitHub] [cloudstack-primate] Pearl1594 edited a comment on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-15 Thread GitBox
Pearl1594 edited a comment on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659171852 On checking for translations - few success/loading/catch and error messages need translation in DeployVM.vue and IngressEgressRuleConfigure.vue - others prett

[GitHub] [cloudstack-primate] Pearl1594 edited a comment on pull request #481: Compare translation keys and doclinks usage and migration of translation from old UI

2020-07-15 Thread GitBox
Pearl1594 edited a comment on pull request #481: URL: https://github.com/apache/cloudstack-primate/pull/481#issuecomment-659171852 On checking for translations - few success/loading/catch and error messages need translation in DeployVM.vue and IngressEgressRuleConfigure.vue - others prett

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-15 Thread GitBox
davidjumani edited a comment on issue #528: URL: https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179 Bugs : Fixed in #534 - ~While changing a systemvm service offering, need to fetch system offerings by passing `issystem=true`, `virtualmachineid` and `syste

[GitHub] [cloudstack-primate] davidjumani edited a comment on issue #528: Consolidated Bug List from Testing/Review

2020-07-15 Thread GitBox
davidjumani edited a comment on issue #528: URL: https://github.com/apache/cloudstack-primate/issues/528#issuecomment-656987179 Bugs : Fixed in #534 - ~While changing a systemvm service offering, need to fetch system offerings by passing `issystem=true`, `virtualmachineid` and `syste