[GitHub] [cloudstack-primate] ravening commented on pull request #446: Allow creating Compute/Disk offering as Domain admin

2020-06-24 Thread GitBox
ravening commented on pull request #446: URL: https://github.com/apache/cloudstack-primate/pull/446#issuecomment-648642828 @rhtyd @shwstppr its still an issue in the old UI as well. The java code looks good but we see a different behavior in UI. If thats the case we need to fix it in UI r

[GitHub] [cloudstack-primate] rhtyd merged pull request #379: Add support for tiers in PF, LB rules for a VPC

2020-06-24 Thread GitBox
rhtyd merged pull request #379: URL: https://github.com/apache/cloudstack-primate/pull/379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd closed issue #438: Assign a public IP to a VPC guess network

2020-06-24 Thread GitBox
rhtyd closed issue #438: URL: https://github.com/apache/cloudstack-primate/issues/438 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on issue #438: Assign a public IP to a VPC guess network

2020-06-24 Thread GitBox
rhtyd commented on issue #438: URL: https://github.com/apache/cloudstack-primate/issues/438#issuecomment-648659726 @gaaray2k fixed on master, please test/review latest master. Thanks. This is an automated message from the Ap

[GitHub] [cloudstack-primate] rhtyd commented on pull request #428: infra: vr healthcheck

2020-06-24 Thread GitBox
rhtyd commented on pull request #428: URL: https://github.com/apache/cloudstack-primate/pull/428#issuecomment-648662817 Basic tests performed, LGTM. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] rhtyd merged pull request #428: infra: vr healthcheck

2020-06-24 Thread GitBox
rhtyd merged pull request #428: URL: https://github.com/apache/cloudstack-primate/pull/428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd merged pull request #419: Adding custom change affinity view

2020-06-24 Thread GitBox
rhtyd merged pull request #419: URL: https://github.com/apache/cloudstack-primate/pull/419 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #419: Adding custom change affinity view

2020-06-24 Thread GitBox
rhtyd commented on pull request #419: URL: https://github.com/apache/cloudstack-primate/pull/419#issuecomment-648663784 Test LGTM This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [cloudstack-primate] rhtyd commented on pull request #413: Adding custom Vue to change the vm service offering

2020-06-24 Thread GitBox
rhtyd commented on pull request #413: URL: https://github.com/apache/cloudstack-primate/pull/413#issuecomment-648666424 @shwstppr can you review and help test this, compare against legacy UI? I found some issues but I'm not sure if that's because of simulator. Perhaps when VM is stopped w

[GitHub] [cloudstack-primate] rhtyd commented on pull request #444: Fixing ldap form

2020-06-24 Thread GitBox
rhtyd commented on pull request #444: URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648669046 @davidjumani add information pop-over like other forms, add doc-link to the custom form (somewhere put a

[GitHub] [cloudstack-primate] rhtyd commented on pull request #170: Modified forms when SAML is enabled

2020-06-24 Thread GitBox
rhtyd commented on pull request #170: URL: https://github.com/apache/cloudstack-primate/pull/170#issuecomment-648679542 Ref: https://github.com/apache/cloudstack-primate/issues/184 @davidjumani please test This is an auto

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-06-24 Thread GitBox
blueorangutan commented on pull request #235: URL: https://github.com/apache/cloudstack-primate/pull/235#issuecomment-648681980 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-06-24 Thread GitBox
rhtyd commented on pull request #235: URL: https://github.com/apache/cloudstack-primate/pull/235#issuecomment-648681576 @utchoang can we show the filter button of left side of the searchbar? @blueorangutan package This i

[GitHub] [cloudstack-primate] rhtyd commented on pull request #298: Quota UI

2020-06-24 Thread GitBox
rhtyd commented on pull request #298: URL: https://github.com/apache/cloudstack-primate/pull/298#issuecomment-648682312 @utchoang headsup looks like there is a conflict as well This is an automated message from the Apache Gi

[GitHub] [cloudstack-primate] rhtyd commented on pull request #326: Form to Migrate data between Image stores

2020-06-24 Thread GitBox
rhtyd commented on pull request #326: URL: https://github.com/apache/cloudstack-primate/pull/326#issuecomment-648683113 @Pearl1594 can you fix the conflict please? Is it ready for code review? This is an automated message fr

[GitHub] [cloudstack-primate] rhtyd commented on pull request #382: Enabling Role based Users in Projects

2020-06-24 Thread GitBox
rhtyd commented on pull request #382: URL: https://github.com/apache/cloudstack-primate/pull/382#issuecomment-648683701 @Pearl1594 please advise when this is ready for review This is an automated message from the Apache Git

[GitHub] [cloudstack-primate] rhtyd commented on pull request #413: Adding custom Vue to change the vm service offering

2020-06-24 Thread GitBox
rhtyd commented on pull request #413: URL: https://github.com/apache/cloudstack-primate/pull/413#issuecomment-648684635 Investigate if we can safely use the changeSer instead of scale... API for a stopped VM (for all hypervisors?); then fix the UI component to change the API depending

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-06-24 Thread GitBox
blueorangutan commented on pull request #235: URL: https://github.com/apache/cloudstack-primate/pull/235#issuecomment-648686282 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/235 (JID-2

[GitHub] [cloudstack-primate] rhtyd merged pull request #441: autogenview: fix fill edit/update forms

2020-06-24 Thread GitBox
rhtyd merged pull request #441: URL: https://github.com/apache/cloudstack-primate/pull/441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd closed issue #214: [BUG] Compute > Instances - Missing extended search functionality

2020-06-24 Thread GitBox
rhtyd closed issue #214: URL: https://github.com/apache/cloudstack-primate/issues/214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd closed issue #112: [FEATURE] new ldap functionality

2020-06-24 Thread GitBox
rhtyd closed issue #112: URL: https://github.com/apache/cloudstack-primate/issues/112 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd closed issue #162: [BUG] Group action buttons don't work properly (Events, Alerts, VM)

2020-06-24 Thread GitBox
rhtyd closed issue #162: URL: https://github.com/apache/cloudstack-primate/issues/162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on issue #214: [BUG] Compute > Instances - Missing extended search functionality

2020-06-24 Thread GitBox
rhtyd commented on issue #214: URL: https://github.com/apache/cloudstack-primate/issues/214#issuecomment-648695278 PR received This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [cloudstack-primate] rhtyd commented on issue #162: [BUG] Group action buttons don't work properly (Events, Alerts, VM)

2020-06-24 Thread GitBox
rhtyd commented on issue #162: URL: https://github.com/apache/cloudstack-primate/issues/162#issuecomment-648695170 PR received This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack-primate] rhtyd commented on issue #112: [FEATURE] new ldap functionality

2020-06-24 Thread GitBox
rhtyd commented on issue #112: URL: https://github.com/apache/cloudstack-primate/issues/112#issuecomment-648695007 PR received, tested; will merge PR after final review This is an automated message from the Apache Git Servic

[GitHub] [cloudstack-primate] rhtyd removed a comment on issue #361: [FEATURE] Fresh install onboarding

2020-06-24 Thread GitBox
rhtyd removed a comment on issue #361: URL: https://github.com/apache/cloudstack-primate/issues/361#issuecomment-644025145 With @rhtyd This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [cloudstack-primate] rhtyd commented on issue #361: [FEATURE] Fresh install onboarding

2020-06-24 Thread GitBox
rhtyd commented on issue #361: URL: https://github.com/apache/cloudstack-primate/issues/361#issuecomment-648695547 With @shwstppr This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [cloudstack-primate] rhtyd commented on issue #447: [BUG] role id displayed as label when creating an account

2020-06-24 Thread GitBox
rhtyd commented on issue #447: URL: https://github.com/apache/cloudstack-primate/issues/447#issuecomment-648696944 Abhishek's PR fixed it, closing. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] rhtyd closed issue #447: [BUG] role id displayed as label when creating an account

2020-06-24 Thread GitBox
rhtyd closed issue #447: URL: https://github.com/apache/cloudstack-primate/issues/447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] utchoang commented on pull request #298: Quota UI

2020-06-24 Thread GitBox
utchoang commented on pull request #298: URL: https://github.com/apache/cloudstack-primate/pull/298#issuecomment-648705365 @rhtyd I have made some changes to avoid changing ListView. Please review it again. Thanks. This is

[GitHub] [cloudstack-primate] rhtyd opened a new issue #448: Could we check if URL for upload template/iso/volume is valid and display suitable message

2020-06-24 Thread GitBox
rhtyd opened a new issue #448: URL: https://github.com/apache/cloudstack-primate/issues/448 By default if the env is not SSL enabled, upload form fails with incorrect message for uploading template/iso/volume This is an auto

[GitHub] [cloudstack-primate] rhtyd commented on issue #448: Could we check if URL for upload template/iso/volume is valid and display suitable message

2020-06-24 Thread GitBox
rhtyd commented on issue #448: URL: https://github.com/apache/cloudstack-primate/issues/448#issuecomment-648711167 With @shwstppr (last time I checkd I couldn't find a way to validate the https path) This is an automated me

[GitHub] [cloudstack-primate] rhtyd opened a new issue #449: [FEATURE] show quick-view options for VMs?

2020-06-24 Thread GitBox
rhtyd opened a new issue #449: URL: https://github.com/apache/cloudstack-primate/issues/449 Explore ways to show quick-view actions (either all the actions, or most commonly used action start/stop/...) Either as a general component; or specifically for VM (and other user facing views l

[GitHub] [cloudstack-primate] rhtyd commented on issue #449: [FEATURE] show quick-view options for VMs?

2020-06-24 Thread GitBox
rhtyd commented on issue #449: URL: https://github.com/apache/cloudstack-primate/issues/449#issuecomment-648713129 With @davidjumani This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [cloudstack-primate] rhtyd opened a new issue #450: [FEATURE] Swtich to project when route has ?projectid= passed

2020-06-24 Thread GitBox
rhtyd opened a new issue #450: URL: https://github.com/apache/cloudstack-primate/issues/450 If a listview/detailview (in autogenview or dashboard.vue...) if ?projectid=065cbd5b-3787-4f66-9be1-1844a2e98c28 is passed (notice ID is a valid UUID of 36chars len) swtich to the project using list

[GitHub] [cloudstack-primate] rhtyd commented on issue #450: [FEATURE] Swtich to project when route has ?projectid= passed

2020-06-24 Thread GitBox
rhtyd commented on issue #450: URL: https://github.com/apache/cloudstack-primate/issues/450#issuecomment-648715809 With @shwstppr This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [cloudstack-primate] rhtyd opened a new issue #451: Maintain page context in the URL

2020-06-24 Thread GitBox
rhtyd opened a new issue #451: URL: https://github.com/apache/cloudstack-primate/issues/451 The page context for page, pagesize, keyword (maybe filter related things later on...) are not stored on the route/path/params and back/forward missing the context... -

[GitHub] [cloudstack-primate] rhtyd commented on issue #451: Maintain page context in the URL

2020-06-24 Thread GitBox
rhtyd commented on issue #451: URL: https://github.com/apache/cloudstack-primate/issues/451#issuecomment-648717404 With @davidjumani This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [cloudstack-primate] rhtyd opened a new issue #452: Allow admins to configure footer html/string via config.json

2020-06-24 Thread GitBox
rhtyd opened a new issue #452: URL: https://github.com/apache/cloudstack-primate/issues/452 Add an option to show custom footer html/string to be shown to users; and hide the CloudStack/primate version for users (i.e. show only for admins by default) -

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #326: Form to Migrate data between Image stores

2020-06-24 Thread GitBox
Pearl1594 commented on pull request #326: URL: https://github.com/apache/cloudstack-primate/pull/326#issuecomment-648728336 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #326: Form to Migrate data between Image stores

2020-06-24 Thread GitBox
Pearl1594 commented on pull request #326: URL: https://github.com/apache/cloudstack-primate/pull/326#issuecomment-648728597 @rhtyd resolved the conflict. It's ready for review This is an automated message from the Apache Git

[GitHub] [cloudstack-primate] rhtyd commented on pull request #252: Add support to manage network service providers

2020-06-24 Thread GitBox
rhtyd commented on pull request #252: URL: https://github.com/apache/cloudstack-primate/pull/252#issuecomment-648839422 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack-primate] rhtyd commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-06-24 Thread GitBox
rhtyd commented on pull request #235: URL: https://github.com/apache/cloudstack-primate/pull/235#issuecomment-648839282 Thanks @utchoang I'll kick tests @blueorangutan package This is an automated message from the Apache

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #252: Add support to manage network service providers

2020-06-24 Thread GitBox
blueorangutan commented on pull request #252: URL: https://github.com/apache/cloudstack-primate/pull/252#issuecomment-648839786 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-06-24 Thread GitBox
blueorangutan commented on pull request #235: URL: https://github.com/apache/cloudstack-primate/pull/235#issuecomment-648839969 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-06-24 Thread GitBox
blueorangutan commented on pull request #235: URL: https://github.com/apache/cloudstack-primate/pull/235#issuecomment-648845220 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/235 (JID-2

[GitHub] [cloudstack-primate] rhtyd closed issue #452: Allow admins to configure footer html/string via config.json

2020-06-24 Thread GitBox
rhtyd closed issue #452: URL: https://github.com/apache/cloudstack-primate/issues/452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #252: Add support to manage network service providers

2020-06-24 Thread GitBox
blueorangutan commented on pull request #252: URL: https://github.com/apache/cloudstack-primate/pull/252#issuecomment-648847340 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/252 (JID-2

[GitHub] [cloudstack-primate] rhtyd commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-06-24 Thread GitBox
rhtyd commented on pull request #235: URL: https://github.com/apache/cloudstack-primate/pull/235#issuecomment-648850949 @utchoang can you change the following: - Rename clear to reset, click that should reset search and run search without any options selected - search by account for

[GitHub] [cloudstack-primate] rhtyd commented on pull request #252: Add support to manage network service providers

2020-06-24 Thread GitBox
rhtyd commented on pull request #252: URL: https://github.com/apache/cloudstack-primate/pull/252#issuecomment-648854179 Thanks @utchoang let's try and get this merged in soon, can you address: - Render the action button of left side of the tab widget/component - Fix the translation ke

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #413: Adding custom Vue to change the vm service offering

2020-06-24 Thread GitBox
blueorangutan commented on pull request #413: URL: https://github.com/apache/cloudstack-primate/pull/413#issuecomment-648866258 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] davidjumani commented on pull request #413: Adding custom Vue to change the vm service offering

2020-06-24 Thread GitBox
davidjumani commented on pull request #413: URL: https://github.com/apache/cloudstack-primate/pull/413#issuecomment-648865969 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #453: Fixing unable to log into legacy UI while primate is logged in

2020-06-24 Thread GitBox
davidjumani opened a new pull request #453: URL: https://github.com/apache/cloudstack-primate/pull/453 This removes the `sessionkey` cookie which is passed via the legacy UI that causes credential auth issues Fixes https://github.com/apache/cloudstack/issues/4136 --

[GitHub] [cloudstack-primate] davidjumani commented on pull request #453: Fixing unable to log into legacy UI while primate is logged in

2020-06-24 Thread GitBox
davidjumani commented on pull request #453: URL: https://github.com/apache/cloudstack-primate/pull/453#issuecomment-648869105 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #453: Fixing unable to log into legacy UI while primate is logged in

2020-06-24 Thread GitBox
blueorangutan commented on pull request #453: URL: https://github.com/apache/cloudstack-primate/pull/453#issuecomment-648870021 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #413: Adding custom Vue to change the vm service offering

2020-06-24 Thread GitBox
blueorangutan commented on pull request #413: URL: https://github.com/apache/cloudstack-primate/pull/413#issuecomment-648871285 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/413 (JID-2

[GitHub] [cloudstack-primate] rhtyd removed a comment on issue #450: [FEATURE] Swtich to project when route has ?projectid= passed

2020-06-24 Thread GitBox
rhtyd removed a comment on issue #450: URL: https://github.com/apache/cloudstack-primate/issues/450#issuecomment-648715809 With @shwstppr This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack-primate] rhtyd closed issue #450: [FEATURE] Swtich to project when route has ?projectid= passed

2020-06-24 Thread GitBox
rhtyd closed issue #450: URL: https://github.com/apache/cloudstack-primate/issues/450 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #453: Fixing unable to log into legacy UI while primate is logged in

2020-06-24 Thread GitBox
blueorangutan commented on pull request #453: URL: https://github.com/apache/cloudstack-primate/pull/453#issuecomment-648874634 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/453 (JID-2

[GitHub] [cloudstack-primate] davidjumani commented on pull request #444: Fixing ldap form

2020-06-24 Thread GitBox
davidjumani commented on pull request #444: URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-648897686 @rhtyd In the legacy UI, although the default filter is 'No Filter', the initial listLdapUsrers call uses 'Any Domain' as its filter. In this case, using 'No Filte

[GitHub] [cloudstack-primate] rhtyd opened a new pull request #454: autogenview: store API parameters as router query for history

2020-06-24 Thread GitBox
rhtyd opened a new pull request #454: URL: https://github.com/apache/cloudstack-primate/pull/454 This would store pagination, filter and search context in route query which would allow for browser history navigation in list views. Fixes #451 Signed-off-by: Rohit Yadav ---

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #454: autogenview: store API parameters as router query for history

2020-06-24 Thread GitBox
blueorangutan commented on pull request #454: URL: https://github.com/apache/cloudstack-primate/pull/454#issuecomment-648932799 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd commented on pull request #454: autogenview: store API parameters as router query for history

2020-06-24 Thread GitBox
rhtyd commented on pull request #454: URL: https://github.com/apache/cloudstack-primate/pull/454#issuecomment-648931995 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [cloudstack-primate] rhtyd closed pull request #320: Explore Test Automation

2020-06-24 Thread GitBox
rhtyd closed pull request #320: URL: https://github.com/apache/cloudstack-primate/pull/320 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] rhtyd commented on pull request #453: Fixing unable to log into legacy UI while primate is logged in

2020-06-24 Thread GitBox
rhtyd commented on pull request #453: URL: https://github.com/apache/cloudstack-primate/pull/453#issuecomment-648934718 Does not solve, two sessionkey cookies seen still: ``` Cookie: sessionkey=-AL03U08_FMJtQdWlO1mkFIZW_M; JSESSIONID=node0fdxqrpkedzt711zlrg9vkzz3j182.node0; sessionk

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #454: autogenview: store API parameters as router query for history

2020-06-24 Thread GitBox
blueorangutan commented on pull request #454: URL: https://github.com/apache/cloudstack-primate/pull/454#issuecomment-648936903 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/454 (JID-2

[GitHub] [cloudstack-primate] rhtyd commented on pull request #453: Fixing unable to log into legacy UI while primate is logged in

2020-06-24 Thread GitBox
rhtyd commented on pull request #453: URL: https://github.com/apache/cloudstack-primate/pull/453#issuecomment-648944026 does n't solve the issue but i'll merge as Primate shouldn't set sessionkey cookie This is an automated

[GitHub] [cloudstack-primate] rhtyd merged pull request #453: Fixing unable to log into legacy UI while primate is logged in

2020-06-24 Thread GitBox
rhtyd merged pull request #453: URL: https://github.com/apache/cloudstack-primate/pull/453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack-primate] davidjumani commented on pull request #453: Fixing unable to log into legacy UI while primate is logged in

2020-06-24 Thread GitBox
davidjumani commented on pull request #453: URL: https://github.com/apache/cloudstack-primate/pull/453#issuecomment-648949142 Tested by opening a private window with both primate and legacy running locally, logging out / in, only one sessionkey cookie was created. Could you explain what w

Re: [ASK][DISCUSS] Adding support for a new block-storage based primary storage

2020-06-24 Thread Rohit Yadav
Hi Mike, Thanks for replying, you've answered all my concerns as well as the historic background and references. Since the feature is KVM specific I think even if separate volume storage driven/plugin is implemented, it will still require adding support/hooks in various Command handlers in many

[GitHub] [cloudstack-primate] rhtyd opened a new issue #455: Usability issues around VM deployment wizard

2020-06-24 Thread GitBox
rhtyd opened a new issue #455: URL: https://github.com/apache/cloudstack-primate/issues/455 - Check Context sensitive help for list views, actions - Check new deploy VM form's narrative/help text against old UI's VM wizard; add help text to explain terms/sections With @shwstppr

[GitHub] [cloudstack-primate] utchoang commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-06-24 Thread GitBox
utchoang commented on pull request #235: URL: https://github.com/apache/cloudstack-primate/pull/235#issuecomment-649180288 @rhtyd I am not sure a few points: * `Rename clear to reset, click that should reset search and run search without any options selected` means that when clicking th

[GitHub] [cloudstack-primate] rhtyd commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-06-24 Thread GitBox
rhtyd commented on pull request #235: URL: https://github.com/apache/cloudstack-primate/pull/235#issuecomment-649226079 @utchoang - yes, my thought is when a use clicks on the reset/clear we're effectively resetting the search - Two things: (a) add account as a input in the search bo

[GitHub] [cloudstack-primate] rhtyd commented on pull request #444: Fixing ldap form

2020-06-24 Thread GitBox
rhtyd commented on pull request #444: URL: https://github.com/apache/cloudstack-primate/pull/444#issuecomment-649229127 @davidjumani can you discuss with @DaanHoogland ? This is an automated message from the Apache Git Servi

[GitHub] [cloudstack-primate] rhtyd commented on pull request #413: Adding custom Vue to change the vm service offering

2020-06-24 Thread GitBox
rhtyd commented on pull request #413: URL: https://github.com/apache/cloudstack-primate/pull/413#issuecomment-649258458 @shwstppr can you review and test please? This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack-primate] utchoang commented on pull request #235: Compute > Instances - Missing extended search functionality

2020-06-24 Thread GitBox
utchoang commented on pull request #235: URL: https://github.com/apache/cloudstack-primate/pull/235#issuecomment-649276034 @rhtyd I've added an advanced filter search for routers (below image). Thanks. ![image](https://user-images.githubusercontent.com/13766648/85670570-3c180b80-b6eb-1