[GitHub] [cloudstack-primate] shwstppr commented on pull request #217: Identify and access - Add user - duplicated password field

2020-06-15 Thread GitBox
shwstppr commented on pull request #217: URL: https://github.com/apache/cloudstack-primate/pull/217#issuecomment-643947379 @rhtyd this can be reviewed and merged. We will need a custom form for Add Account but this will be useful for Add User -

[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #170: Modified forms when SAML is enabled

2020-06-15 Thread GitBox
shwstppr commented on a change in pull request #170: URL: https://github.com/apache/cloudstack-primate/pull/170#discussion_r439972398 ## File path: src/views/iam/AddAccountForm.vue ## @@ -0,0 +1,270 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #419: Adding custom change affinity view

2020-06-15 Thread GitBox
davidjumani opened a new pull request #419: URL: https://github.com/apache/cloudstack-primate/pull/419 Fixes #386 ![Screenshot from 2020-06-15 12-58-26](https://user-images.githubusercontent.com/8244774/84629462-f21f7080-af07-11ea-874c-25c3470752d2.png) ---

[GitHub] [cloudstack-primate] svenvogel commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
svenvogel commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643954696 > No, I think wr don't need to configure fonts, sizes etc. The feature of providing some way to customise the theme to the end user by means of some config file is e

[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #170: Modified forms when SAML is enabled

2020-06-15 Thread GitBox
Pearl1594 commented on a change in pull request #170: URL: https://github.com/apache/cloudstack-primate/pull/170#discussion_r439981986 ## File path: src/views/iam/AddAccountForm.vue ## @@ -0,0 +1,270 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [cloudstack-primate] rhtyd commented on pull request #419: Adding custom change affinity view

2020-06-15 Thread GitBox
rhtyd commented on pull request #419: URL: https://github.com/apache/cloudstack-primate/pull/419#issuecomment-643959433 @davidjumani can you check old UI, we probably want pagination and search support (the list API could in fact return a lot of rules in very large env; if the count is sa

[GitHub] [cloudstack-primate] utchoang commented on a change in pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
utchoang commented on a change in pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#discussion_r439989945 ## File path: public/config.json ## @@ -0,0 +1,15 @@ +{ + "theme": { +"@primary-color": "#1890ff", Review comment: @rhtyd I checked

[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
rhtyd commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643961120 @svenvogel which logo - the login logo, or the left-top side logo that shows after we login? Or any other? I think instead of config file, we can have a folder to put lo

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
rhtyd commented on a change in pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#discussion_r439987575 ## File path: public/config.json ## @@ -0,0 +1,15 @@ +{ + "theme": { +"@primary-color": "#1890ff", Review comment: @utchoang are these

[GitHub] [cloudstack-primate] ravening opened a new issue #420: [BUG] Links not found

2020-06-15 Thread GitBox
ravening opened a new issue #420: URL: https://github.com/apache/cloudstack-primate/issues/420 **Describe the bug** All the links under https://github.com/apache/cloudstack-primate#primate-development are not accessible **To Reproduce** Steps to reproduce the behavior: 1. C

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #421: Fixing enable/disable HA, OOBM across zone, cluster, host

2020-06-15 Thread GitBox
davidjumani opened a new pull request #421: URL: https://github.com/apache/cloudstack-primate/pull/421 Fixes #394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
rhtyd commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643969510 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
blueorangutan commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643970133 @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] rhtyd commented on issue #420: [BUG] Links not found

2020-06-15 Thread GitBox
rhtyd commented on issue #420: URL: https://github.com/apache/cloudstack-primate/issues/420#issuecomment-643971813 @ravening intentional, need to update the docs; the best place to start is vuejs v2 guide. They are here, I'll update links https://github.com/apache/cloudstack-primate/

[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
rhtyd commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643972658 @utchoang can you move the following keys to the config.json from the `src/config/settings.js`; which would allow the admin configure the API request path, the doc base

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
blueorangutan commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643974160 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/372 (JID-2

[GitHub] [cloudstack-primate] utchoang commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
utchoang commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643981360 @rhtyd cc @svenvogel About changing the logo size. I think the @Seven ideas would be good because the end-user only needs to change the logo size in the config fil

[GitHub] [cloudstack-primate] utchoang edited a comment on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
utchoang edited a comment on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643981360 @rhtyd cc @svenvogel About changing the logo size. I think the @svenvogel ideas would be good because the end-user only needs to change the logo size in th

[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
rhtyd commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643982598 @utchoang do you know which logo is @svenvogel talking about the logo in favicon, or login screen, or post-login (on left-top side) or anything else? --

[GitHub] [cloudstack-primate] rhtyd edited a comment on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
rhtyd edited a comment on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643982598 @utchoang do you know which logo is @svenvogel talking about the logo in favicon, or login screen, or post-login (on left-top side) or anything else? An admin wou

[GitHub] [cloudstack-primate] utchoang commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
utchoang commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643985051 @rhtyd I think all logo (login screen, left-top side,...) This is an automated message from the Apach

[GitHub] [cloudstack-primate] rhtyd closed issue #420: [BUG] Links not found

2020-06-15 Thread GitBox
rhtyd closed issue #420: URL: https://github.com/apache/cloudstack-primate/issues/420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] utchoang commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
utchoang commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643986249 @rhtyd He means when we wanted to change another logo, maybe its size would not be right, so just adjust it using the config file instead of the third software. ---

[GitHub] [cloudstack-primate] utchoang edited a comment on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
utchoang edited a comment on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643986249 @rhtyd cc @svenvogel He means when we wanted to change another logo, maybe its size would not be right, so just adjust it using the config file instead of the

[GitHub] [cloudstack-primate] shwstppr commented on pull request #170: Modified forms when SAML is enabled

2020-06-15 Thread GitBox
shwstppr commented on pull request #170: URL: https://github.com/apache/cloudstack-primate/pull/170#issuecomment-643988197 @Pearl1594 Made some changes to fix translations and layout. Hopefully I've not broken anything ![Screenshot from 2020-06-15 14-06-13](https://user-images.githubus

[GitHub] [cloudstack-primate] shwstppr commented on pull request #257: view: add custom new account form

2020-06-15 Thread GitBox
shwstppr commented on pull request #257: URL: https://github.com/apache/cloudstack-primate/pull/257#issuecomment-643988557 Closing in favour of #170 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack-primate] shwstppr closed pull request #257: view: add custom new account form

2020-06-15 Thread GitBox
shwstppr closed pull request #257: URL: https://github.com/apache/cloudstack-primate/pull/257 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
rhtyd commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643989719 @utchoang okay, I guess first thing then - move all the banner and logo svgs to public/assets (I think you've moved logo, maybe even the error/403/404/500 pngs). I think

[GitHub] [cloudstack-primate] rhtyd commented on pull request #170: Modified forms when SAML is enabled

2020-06-15 Thread GitBox
rhtyd commented on pull request #170: URL: https://github.com/apache/cloudstack-primate/pull/170#issuecomment-643990373 Thanks @shwstppr This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [cloudstack-primate] davidjumani closed pull request #421: DO NOT MERGE : Fixing enable/disable HA, OOBM across zone, cluster, host

2020-06-15 Thread GitBox
davidjumani closed pull request #421: URL: https://github.com/apache/cloudstack-primate/pull/421 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
rhtyd commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-643999170 Note for myself - we'll need to check and get some of the config from legacy UI such as keyboard options: https://github.com/apache/cloudstack/pull/3258/files

[GitHub] [cloudstack-primate] rhtyd opened a new issue #422: UI customisation from legacy UI

2020-06-15 Thread GitBox
rhtyd opened a new issue #422: URL: https://github.com/apache/cloudstack-primate/issues/422 See https://github.com/apache/cloudstack/pull/3258/files This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] utchoang opened a new pull request #423: [FIX] Acquire public IP address does not give IP selection option

2020-06-15 Thread GitBox
utchoang opened a new pull request #423: URL: https://github.com/apache/cloudstack-primate/pull/423 Open for https://github.com/apache/cloudstack-primate/issues/392 @rhtyd cc @svenvogel I've completed this task. Please review and let me know any comments. ![image](https://user-images

[GitHub] [cloudstack-primate] rhtyd commented on issue #374: [FEATURE] a query component for text driven questions to a user

2020-06-15 Thread GitBox
rhtyd commented on issue #374: URL: https://github.com/apache/cloudstack-primate/issues/374#issuecomment-644023081 With @shwstppr This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [cloudstack-primate] rhtyd removed a comment on issue #362: [FEATURE] VR health checks feature

2020-06-15 Thread GitBox
rhtyd removed a comment on issue #362: URL: https://github.com/apache/cloudstack-primate/issues/362#issuecomment-643893549 With @davidjumani This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [cloudstack-primate] rhtyd commented on issue #362: [FEATURE] VR health checks feature

2020-06-15 Thread GitBox
rhtyd commented on issue #362: URL: https://github.com/apache/cloudstack-primate/issues/362#issuecomment-644024664 With @shwstppr This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [cloudstack-primate] rhtyd commented on issue #361: [FEATURE] Fresh install onboarding

2020-06-15 Thread GitBox
rhtyd commented on issue #361: URL: https://github.com/apache/cloudstack-primate/issues/361#issuecomment-644025145 With @rhtyd This is an automated message from the Apache Git Service. To respond to the message, please log

[DISCUSS] Change UI images in CloudStack Docs for 4.15

2020-06-15 Thread Rohit Yadav
All, The images of CloudStack (current/legacy) UI in our documentation are old [1] (some of the screenshots are from UI before the current UI). In the voting thread [2] where we agreed to have Primate succeed the current CloudStack UI and proposed GA release with 4.15, we didn't discuss when an

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #424: Adding rolling maintenance

2020-06-15 Thread GitBox
davidjumani opened a new pull request #424: URL: https://github.com/apache/cloudstack-primate/pull/424 Fixes #363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [cloudstack-primate] davidjumani opened a new pull request #425: Fix unmanage / manager cluster

2020-06-15 Thread GitBox
davidjumani opened a new pull request #425: URL: https://github.com/apache/cloudstack-primate/pull/425 Fixes #396 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [cloudstack-primate] svenvogel commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
svenvogel commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-644149875 @rhtyd @utchoang yes maybe the layout will give us only a fit size of the icon/logs and i agree with a copy and paste of the logo in a folder and overwrite them into

[GitHub] [cloudstack-primate] rhtyd commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
rhtyd commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-644562510 @utchoang let me know when you're done with any other changes, I'll help review and merge this This is

[GitHub] [cloudstack-primate] utchoang commented on pull request #372: Add support for UI customisation

2020-06-15 Thread GitBox
utchoang commented on pull request #372: URL: https://github.com/apache/cloudstack-primate/pull/372#issuecomment-644563490 @rhtyd I will notify you when it is completed with the new user document. This is an automated messag