[GitHub] [cloudstack-primate] shwstppr commented on pull request #289: view: fix list group action

2020-04-24 Thread GitBox
shwstppr commented on pull request #289: URL: https://github.com/apache/cloudstack-primate/pull/289#issuecomment-618847945 @rhtyd refactored some code but couldn't figure how to clear selection for APIs that remove items. Either we clear selection for all API or the current method ---

[GitHub] [cloudstack-primate] rhtyd commented on pull request #309: added color changes for different progress value

2020-04-24 Thread GitBox
rhtyd commented on pull request #309: URL: https://github.com/apache/cloudstack-primate/pull/309#issuecomment-618903370 @shwstppr can you add screenshot for all the thresholds? I think we don't want any different/non-default colour for thresholds below 75/80 (idea is to have feature parit

[GitHub] [cloudstack-primate] rhtyd commented on issue #263: [BUG] Missing side info scroller in the 'New instance' dialog

2020-04-24 Thread GitBox
rhtyd commented on issue #263: URL: https://github.com/apache/cloudstack-primate/issues/263#issuecomment-618904398 @shwstppr we could try to put in a scrollbar inside the affix element, using veritcal scroll like ` overflow-y: scroll;` ? -

[GitHub] [cloudstack-primate] rhtyd commented on issue #262: [BUG] Useless table scrollers on 'New instance' dialog

2020-04-24 Thread GitBox
rhtyd commented on issue #262: URL: https://github.com/apache/cloudstack-primate/issues/262#issuecomment-618904694 @shwstppr it should be possible to hide them with ` overflow-y: hidden;`? This is an automated message from

[GitHub] [cloudstack-primate] rhtyd commented on issue #202: [BUG] Missing functionality - Infrastructure > Virtual routers > Get diagnostic data

2020-04-24 Thread GitBox
rhtyd commented on issue #202: URL: https://github.com/apache/cloudstack-primate/issues/202#issuecomment-618905927 @shwstppr please see ^^ This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack-primate] rhtyd commented on issue #201: [BUG] Missing functionality - Infrastructure > System VMs > Get diagnostic data

2020-04-24 Thread GitBox
rhtyd commented on issue #201: URL: https://github.com/apache/cloudstack-primate/issues/201#issuecomment-618906057 @shwstppr please see ^^ did you use a `response` param? This is an automated message from the Apache Git Serv

[GitHub] [cloudstack-primate] rhtyd commented on issue #265: [BUG] Missing hypervisor parameter in the 'New instance' dialog

2020-04-24 Thread GitBox
rhtyd commented on issue #265: URL: https://github.com/apache/cloudstack-primate/issues/265#issuecomment-618907046 @vladimirpetrov can you test master again, I think this was fixed. When ISO is selected it asks hypervisor dropdown below it. ---

[GitHub] [cloudstack-primate] rhtyd commented on issue #308: [BUG] Apply threshold logic to colour pie-progress red if threshold exceeds 80%

2020-04-24 Thread GitBox
rhtyd commented on issue #308: URL: https://github.com/apache/cloudstack-primate/issues/308#issuecomment-618907999 @shwstppr can you change it like this: below 80% a fixed colour (blue as per the theme); and >= 80% just use 'red' (this is behaviour of the old UI). ---

[GitHub] [cloudstack-primate] rhtyd opened a new issue #310: [BUG] Add role based access checks for custom UI elements/forms

2020-04-24 Thread GitBox
rhtyd opened a new issue #310: URL: https://github.com/apache/cloudstack-primate/issues/310 Log in as read-only root admin and you'll still see some buttons tabs that must be hidden from the logged in user. For this in all such custom components (mostly tabs), a v-if check if needed to sho

[GitHub] [cloudstack-primate] shwstppr commented on issue #263: [BUG] Missing side info scroller in the 'New instance' dialog

2020-04-24 Thread GitBox
shwstppr commented on issue #263: URL: https://github.com/apache/cloudstack-primate/issues/263#issuecomment-618909391 @rhtyd I don't think I'm best placed to address purely UI issues This is an automated message from the Apa

[GitHub] [cloudstack-primate] shwstppr commented on issue #262: [BUG] Useless table scrollers on 'New instance' dialog

2020-04-24 Thread GitBox
shwstppr commented on issue #262: URL: https://github.com/apache/cloudstack-primate/issues/262#issuecomment-618913688 @rhtyd not working for me, ``` .ant-table-header, .ant-table-content, .ant-table-scroll { overflow-y: hidden; } ``` ---

[GitHub] [cloudstack-primate] DaanHoogland opened a new issue #311: [BUG] defaults selection in deploy wizard are missing

2020-04-24 Thread GitBox
DaanHoogland opened a new issue #311: URL: https://github.com/apache/cloudstack-primate/issues/311 **Describe the bug** In the old UI while going through the deployment wizard, the fields for "Compute Offering" and "network" are filled with (reasonable) defaults. In Primate those do not

[GitHub] [cloudstack-primate] DaanHoogland commented on issue #311: [BUG] defaults selection in deploy wizard are missing

2020-04-24 Thread GitBox
DaanHoogland commented on issue #311: URL: https://github.com/apache/cloudstack-primate/issues/311#issuecomment-618918029 @utchoang I think you did the most work on the deployment wizard, can you give a quick assesment of the issue I describe. I will improve the description if needed, but

[GitHub] [cloudstack-primate] shwstppr opened a new pull request #312: view: fix getDiagnostics response display

2020-04-24 Thread GitBox
shwstppr opened a new pull request #312: URL: https://github.com/apache/cloudstack-primate/pull/312 ![Screenshot from 2020-04-24 16-07-48](https://user-images.githubusercontent.com/153340/80204045-c7224a00-8645-11ea-9a21-6b112c8c066b.png) ![Screenshot from 2020-04-24 16-07-21](https://u

[GitHub] [cloudstack-primate] shwstppr commented on a change in pull request #312: view: fix getDiagnostics response display

2020-04-24 Thread GitBox
shwstppr commented on a change in pull request #312: URL: https://github.com/apache/cloudstack-primate/pull/312#discussion_r414478915 ## File path: src/config/section/infra/routers.js ## @@ -102,7 +102,8 @@ export default { targetid: { value: (record) => { r

[GitHub] [cloudstack-primate] shwstppr commented on issue #201: [BUG] Missing functionality - Infrastructure > System VMs > Get diagnostic data

2020-04-24 Thread GitBox
shwstppr commented on issue #201: URL: https://github.com/apache/cloudstack-primate/issues/201#issuecomment-618939735 @rhtyd please have look on new PR when possible This is an automated message from the Apache Git Service.

[GitHub] [cloudstack-primate] shwstppr commented on issue #308: [BUG] Apply threshold logic to colour pie-progress red if threshold exceeds 80%

2020-04-24 Thread GitBox
shwstppr commented on issue #308: URL: https://github.com/apache/cloudstack-primate/issues/308#issuecomment-618943629 ![Screenshot from 2020-04-24 16-22-58](https://user-images.githubusercontent.com/153340/80205416-35680c00-8648-11ea-9c1a-58330f9ab4d3.png) Changes made to PR #309 Ju

[GitHub] [cloudstack-primate] borisstoyanov commented on issue #265: [BUG] Missing hypervisor parameter in the 'New instance' dialog

2020-04-24 Thread GitBox
borisstoyanov commented on issue #265: URL: https://github.com/apache/cloudstack-primate/issues/265#issuecomment-618980809 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack-primate] rhtyd opened a new issue #51: Password enabled VM to display password popup

2020-04-24 Thread GitBox
rhtyd opened a new issue #51: URL: https://github.com/apache/cloudstack-primate/issues/51 On VM deployment or VM reset, display popup or alert with new password This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack-primate] DaanHoogland commented on issue #51: Password enabled VM to display password popup

2020-04-24 Thread GitBox
DaanHoogland commented on issue #51: URL: https://github.com/apache/cloudstack-primate/issues/51#issuecomment-619009543 I'd like to reopen @rhtyd . I fix was merged in December but I encountered this missing on a branch I created from master in april.

[GitHub] [cloudstack-primate] DaanHoogland commented on issue #51: Password enabled VM to display password popup

2020-04-24 Thread GitBox
DaanHoogland commented on issue #51: URL: https://github.com/apache/cloudstack-primate/issues/51#issuecomment-619010997 ![Screenshot from 2020-04-24 13-11-31](https://user-images.githubusercontent.com/2486961/80217654-946d5700-862f-11ea-9dec-6edc094db930.png) That is the old UI. The

[GitHub] [cloudstack-primate] DaanHoogland opened a new pull request #313: Bootintobios

2020-04-24 Thread GitBox
DaanHoogland opened a new pull request #313: URL: https://github.com/apache/cloudstack-primate/pull/313 UI implementation for https://github.com/apache/cloudstack/pull/4021 This is an automated message from the Apache Git Ser

[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #313: Bootintobios

2020-04-24 Thread GitBox
DaanHoogland commented on pull request #313: URL: https://github.com/apache/cloudstack-primate/pull/313#issuecomment-619081426 @rhtyd @shwstppr can you review please? This is an automated message from the Apache Git Service.

[GitHub] [cloudstack-primate] svenvogel opened a new issue #314: [BUG] translation is missing (manage storage / service -> disk offering)

2020-04-24 Thread GitBox
svenvogel opened a new issue #314: URL: https://github.com/apache/cloudstack-primate/issues/314 **Describe the bug** the translation is missing in "disk offering" and maybe "compute offering" **To Reproduce** Steps to reproduce the behavior: 1. Go to 'disk offering' 2. Cli

[GitHub] [cloudstack-primate] svenvogel commented on issue #314: [BUG] translation is missing (manage storage / service -> disk offering)

2020-04-24 Thread GitBox
svenvogel commented on issue #314: URL: https://github.com/apache/cloudstack-primate/issues/314#issuecomment-619231559 @rhtyd @utchoang can you check this and maybe fix? This is an automated message from the Apache Git Servi

[GitHub] [cloudstack-primate] svenvogel edited a comment on issue #314: [BUG] translation is missing (manage storage / service -> disk offering)

2020-04-24 Thread GitBox
svenvogel edited a comment on issue #314: URL: https://github.com/apache/cloudstack-primate/issues/314#issuecomment-619231559 @rhtyd @utchoang can you check this and maybe fix? i dont know if its much work. This is an auto