[GitHub] [cloudstack-primate] utchoang opened a new pull request #92: [WIP] - Register Template Action

2020-01-02 Thread GitBox
utchoang opened a new pull request #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92 @rhtyd cc @svenvogel This is the design of the Custom Register Template action. Please let me know your comments. -

[GitHub] [cloudstack-primate] RitchieVincent commented on issue #84: [WIP] - Guest network: Egress rules tab

2020-01-02 Thread GitBox
RitchieVincent commented on issue #84: [WIP] - Guest network: Egress rules tab URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-570408588 @rhtyd The rest of the guest network tabs should be complete now. There is a quite a lot of work involved in some of the tabs (load

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #89: [WIP] - Register ISO Action

2020-01-02 Thread GitBox
rhtyd commented on a change in pull request #89: [WIP] - Register ISO Action URL: https://github.com/apache/cloudstack-primate/pull/89#discussion_r362686815 ## File path: src/views/image/RegisterIso.vue ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software Foundation (AS

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #89: [WIP] - Register ISO Action

2020-01-02 Thread GitBox
rhtyd commented on a change in pull request #89: [WIP] - Register ISO Action URL: https://github.com/apache/cloudstack-primate/pull/89#discussion_r362686864 ## File path: src/views/image/RegisterIso.vue ## @@ -0,0 +1,231 @@ +// Licensed to the Apache Software Foundation (AS

[GitHub] [cloudstack-primate] rhtyd merged pull request #89: [WIP] - Register ISO Action

2020-01-02 Thread GitBox
rhtyd merged pull request #89: [WIP] - Register ISO Action URL: https://github.com/apache/cloudstack-primate/pull/89 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack-primate] rhtyd closed issue #50: Register ISO Action

2020-01-02 Thread GitBox
rhtyd closed issue #50: Register ISO Action URL: https://github.com/apache/cloudstack-primate/issues/50 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #92: [WIP] - Register Template Action

2020-01-02 Thread GitBox
rhtyd commented on a change in pull request #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#discussion_r362688021 ## File path: src/config/section/image.js ## @@ -50,7 +50,11 @@ export default { icon: 'plus',

[GitHub] [cloudstack-primate] rhtyd commented on issue #92: [WIP] - Register Template Action

2020-01-02 Thread GitBox
rhtyd commented on issue #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#issuecomment-570433576 @utchoang cc @svenvogel - thanks for this, it's a slightly complex form, I think it needs a bit of testing. In my quick testing some of the models

[GitHub] [cloudstack-primate] rhtyd commented on issue #84: [WIP] - Guest network: Egress rules tab

2020-01-02 Thread GitBox
rhtyd commented on issue #84: [WIP] - Guest network: Egress rules tab URL: https://github.com/apache/cloudstack-primate/pull/84#issuecomment-570433793 @RitchieVincent alright, let me review and test this one. I don't see the SG (https://github.com/apache/cloudstack-primate/issues/49) tab ch

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #84: [WIP] - Guest network: Egress rules tab

2020-01-02 Thread GitBox
rhtyd commented on a change in pull request #84: [WIP] - Guest network: Egress rules tab URL: https://github.com/apache/cloudstack-primate/pull/84#discussion_r362689727 ## File path: src/config/section/network.js ## @@ -186,14 +187,20 @@ export default { columns: ['

[GitHub] [cloudstack-primate] utchoang commented on issue #92: [WIP] - Register Template Action

2020-01-02 Thread GitBox
utchoang commented on issue #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#issuecomment-570436201 @rhtyd I will test again and there will be a commit later. Thank you This is an

[GitHub] [cloudstack-primate] rhtyd closed issue #40: Misc Snapshot Actions

2020-01-02 Thread GitBox
rhtyd closed issue #40: Misc Snapshot Actions URL: https://github.com/apache/cloudstack-primate/issues/40 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [cloudstack-primate] rhtyd closed issue #81: CloudStack logo needs padding

2020-01-02 Thread GitBox
rhtyd closed issue #81: CloudStack logo needs padding URL: https://github.com/apache/cloudstack-primate/issues/81 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [cloudstack-primate] rhtyd commented on issue #81: CloudStack logo needs padding

2020-01-02 Thread GitBox
rhtyd commented on issue #81: CloudStack logo needs padding URL: https://github.com/apache/cloudstack-primate/issues/81#issuecomment-570441699 Padded by few pixels now ![Screenshot from 2020-01-03 08-17-24](https://user-images.githubusercontent.com/95203/71704644-80dc7d00-2e01-11ea-91d2

[GitHub] [cloudstack-primate] rhtyd commented on issue #68: Cannot login in MS Edge Browser

2020-01-02 Thread GitBox
rhtyd commented on issue #68: Cannot login in MS Edge Browser URL: https://github.com/apache/cloudstack-primate/issues/68#issuecomment-570441800 Couldn't confirm, let's revisit this the next time it happens. We'll need details of MS Edge version etc. --

[GitHub] [cloudstack-primate] rhtyd closed issue #68: Cannot login in MS Edge Browser

2020-01-02 Thread GitBox
rhtyd closed issue #68: Cannot login in MS Edge Browser URL: https://github.com/apache/cloudstack-primate/issues/68 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack-primate] rhtyd opened a new issue #93: Guest Network: VPN tab

2020-01-02 Thread GitBox
rhtyd opened a new issue #93: Guest Network: VPN tab URL: https://github.com/apache/cloudstack-primate/issues/93 - Show response details on enable remote access VPN for isolated/guest network: ![Screenshot from 2020-01-03 08-21-12](https://user-images.githubusercontent.com/95203/7170474

[GitHub] [cloudstack-primate] rhtyd closed issue #48: WIP - VPN actions

2020-01-02 Thread GitBox
rhtyd closed issue #48: WIP - VPN actions URL: https://github.com/apache/cloudstack-primate/issues/48 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [cloudstack-primate] rhtyd commented on issue #93: Guest Network: VPN tab

2020-01-02 Thread GitBox
rhtyd commented on issue #93: Guest Network: VPN tab URL: https://github.com/apache/cloudstack-primate/issues/93#issuecomment-570443324 @RitchieVincent once you're done with the current guest network tasks, this is another guest-network related task. --

[GitHub] [cloudstack-primate] rhtyd commented on issue #48: WIP - VPN actions

2020-01-02 Thread GitBox
rhtyd commented on issue #48: WIP - VPN actions URL: https://github.com/apache/cloudstack-primate/issues/48#issuecomment-570443385 New tickets created, let's close this. This is an automated message from the Apache Git Servic

[GitHub] [cloudstack-primate] rhtyd commented on issue #92: [WIP] - Register Template Action

2020-01-02 Thread GitBox
rhtyd commented on issue #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#issuecomment-570444241 @utchoang one more point - the form is rather very long, could the form elements be clubbed in the same row, especially when the elements may be s

[GitHub] [cloudstack-primate] utchoang edited a comment on issue #92: [WIP] - Register Template Action

2020-01-02 Thread GitBox
utchoang edited a comment on issue #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#issuecomment-570447242 @rhtyd cc @svenvogel In this regard, I think I will not use popup, but will go to a new route, what do you think? --

[GitHub] [cloudstack-primate] utchoang commented on issue #92: [WIP] - Register Template Action

2020-01-02 Thread GitBox
utchoang commented on issue #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#issuecomment-570447242 @rhtyd cc @svenvogel In this regard, I think I will not use pop up, but will go to a new route, what do you think?

[GitHub] [cloudstack-primate] rhtyd commented on issue #92: [WIP] - Register Template Action

2020-01-02 Thread GitBox
rhtyd commented on issue #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#issuecomment-570453758 No I think popup is fine @utchoang, since it's a single API (does not involve a very complex form). All I'm suggesting is clubbing multiple inputs

[GitHub] [cloudstack-primate] utchoang commented on issue #92: [WIP] - Register Template Action

2020-01-02 Thread GitBox
utchoang commented on issue #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#issuecomment-570470873 @rhtyd cc @svenvogel The switch section I have 2 suggestions: Option 1: ![Screenshot_16](https://user-images.githubusercontent.com/1376664

[GitHub] [cloudstack-primate] rhtyd commented on issue #92: [WIP] - Register Template Action

2020-01-02 Thread GitBox
rhtyd commented on issue #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#issuecomment-570476567 @utchoang while option1 looks good, I think let's go with option2 to be consistent with the other forms. I also dont' mind if you do two checks/sli

[GitHub] [cloudstack-primate] utchoang commented on issue #92: [WIP] - Register Template Action

2020-01-02 Thread GitBox
utchoang commented on issue #92: [WIP] - Register Template Action URL: https://github.com/apache/cloudstack-primate/pull/92#issuecomment-570492458 @rhtyd cc @svenvogel This is my new design. What do you think? 1. Default ![1](https://user-images.githubusercontent.com/13766648/71712353