[GitHub] [cloudstack-primate] svenvogel commented on issue #41: Project View and Actions

2019-12-11 Thread GitBox
svenvogel commented on issue #41: Project View and Actions URL: https://github.com/apache/cloudstack-primate/issues/41#issuecomment-564453511 @rhtyd @utchoang will proceed with this task. do you have some more information? T

[GitHub] [cloudstack-primate] rhtyd commented on issue #41: Project View and Actions

2019-12-11 Thread GitBox
rhtyd commented on issue #41: Project View and Actions URL: https://github.com/apache/cloudstack-primate/issues/41#issuecomment-564454117 I can more details in the next 1-2 hours, basically we want all the project tabs/features as in the old UI @svenvogel

[GitHub] [cloudstack-primate] RitchieVincent opened a new pull request #67: Vm custom action account

2019-12-11 Thread GitBox
RitchieVincent opened a new pull request #67: Vm custom action account URL: https://github.com/apache/cloudstack-primate/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack-primate] rhtyd merged pull request #66: Account Cert Tab

2019-12-11 Thread GitBox
rhtyd merged pull request #66: Account Cert Tab URL: https://github.com/apache/cloudstack-primate/pull/66 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [cloudstack-primate] rhtyd closed issue #46: Account Certs Tab

2019-12-11 Thread GitBox
rhtyd closed issue #46: Account Certs Tab URL: https://github.com/apache/cloudstack-primate/issues/46 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [cloudstack-primate] rhtyd commented on issue #67: VM Migration Action form

2019-12-11 Thread GitBox
rhtyd commented on issue #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#issuecomment-564651630 LGTM, did not test actual API action. Can you adjust the CSS and size of the popup, if possible? @RitchieVincent ![Screenshot from 2019-12-11 2

[GitHub] [cloudstack-primate] RitchieVincent commented on issue #67: VM Migration Action form

2019-12-11 Thread GitBox
RitchieVincent commented on issue #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#issuecomment-564652736 > LGTM, did not test actual API action. Can you adjust the CSS and size of the popup, if possible? > @RitchieVincent > > ![Screenshot fr

[GitHub] [cloudstack-primate] rhtyd commented on issue #58: VM Hardware: NICs and IPs management

2019-12-11 Thread GitBox
rhtyd commented on issue #58: VM Hardware: NICs and IPs management URL: https://github.com/apache/cloudstack-primate/issues/58#issuecomment-564652735 I've updated the screenshot and actions list, please check ^^ @RitchieVincent

[GitHub] [cloudstack-primate] rhtyd commented on issue #67: VM Migration Action form

2019-12-11 Thread GitBox
rhtyd commented on issue #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#issuecomment-564653485 @RitchieVincent I would prefer one host on each row and the checkbox/select button either on left or right (see the screenshot in old UI, we've each host

[GitHub] [cloudstack-primate] RitchieVincent commented on issue #58: VM Hardware: NICs and IPs management

2019-12-11 Thread GitBox
RitchieVincent commented on issue #58: VM Hardware: NICs and IPs management URL: https://github.com/apache/cloudstack-primate/issues/58#issuecomment-564653771 👍 Luckily I haven't started this task yet, nearly finished #57 and then I'll move on to this one. ---

[GitHub] [cloudstack-primate] RitchieVincent commented on issue #67: VM Migration Action form

2019-12-11 Thread GitBox
RitchieVincent commented on issue #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#issuecomment-564654027 > @RitchieVincent I would prefer one host on each row and the checkbox/select button either on left or right (see the screenshot in old UI, we've

[GitHub] [cloudstack-primate] RitchieVincent commented on issue #67: VM Migration Action form

2019-12-11 Thread GitBox
RitchieVincent commented on issue #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#issuecomment-564674383 @rhtyd The requested changes have been completed now. This is an automated messag

[GitHub] [cloudstack-primate] rhtyd commented on issue #67: VM Migration Action form

2019-12-11 Thread GitBox
rhtyd commented on issue #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#issuecomment-564680813 @RitchieVincent please see the minor fixes I've done. Notice and try to use the translation using `{{ $t('some string') }}` as much as possible in your wo

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #67: VM Migration Action form

2019-12-11 Thread GitBox
rhtyd commented on a change in pull request #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#discussion_r356771992 ## File path: src/views/compute/MigrateWizard.vue ## @@ -36,12 +85,146 @@ export default { }, data () { retur

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #67: VM Migration Action form

2019-12-11 Thread GitBox
rhtyd commented on a change in pull request #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#discussion_r356772382 ## File path: src/views/compute/MigrateWizard.vue ## @@ -36,12 +85,146 @@ export default { }, data () { retur

[GitHub] [cloudstack-primate] rhtyd commented on issue #67: VM Migration Action form

2019-12-11 Thread GitBox
rhtyd commented on issue #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#issuecomment-564690091 @RitchieVincent one more thing I forgot, we probably also want some form of pagination. You may check against the old UI. Thanks. ---

[GitHub] [cloudstack-primate] RitchieVincent commented on a change in pull request #67: VM Migration Action form

2019-12-11 Thread GitBox
RitchieVincent commented on a change in pull request #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#discussion_r356819620 ## File path: src/views/compute/MigrateWizard.vue ## @@ -36,12 +85,146 @@ export default { }, data () {

[GitHub] [cloudstack-primate] RitchieVincent commented on issue #67: VM Migration Action form

2019-12-11 Thread GitBox
RitchieVincent commented on issue #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#issuecomment-564721290 > @RitchieVincent one more thing I forgot, we probably also want some form of pagination. You may check against the old UI. Thanks. I thoug

[GitHub] [cloudstack-primate] rhtyd commented on issue #67: VM Migration Action form

2019-12-11 Thread GitBox
rhtyd commented on issue #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#issuecomment-564722457 @RitchieVincent maybe at least call the api with a large pagesize like 500, we can revisit implementing pagination in future?

[GitHub] [cloudstack-primate] rhtyd merged pull request #67: VM Migration Action form

2019-12-11 Thread GitBox
rhtyd merged pull request #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [cloudstack-primate] rhtyd commented on issue #67: VM Migration Action form

2019-12-11 Thread GitBox
rhtyd commented on issue #67: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/pull/67#issuecomment-564791748 I went ahead with some changes, please follow the changes @RitchieVincent This is an auto

[GitHub] [cloudstack-primate] rhtyd commented on issue #56: VM Migration Action form

2019-12-11 Thread GitBox
rhtyd commented on issue #56: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/issues/56#issuecomment-564791944 Fixed This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack-primate] rhtyd closed issue #56: VM Migration Action form

2019-12-11 Thread GitBox
rhtyd closed issue #56: VM Migration Action form URL: https://github.com/apache/cloudstack-primate/issues/56 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use