[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #54: [WIP] Infrasummary SSL

2019-12-03 Thread GitBox
rhtyd commented on a change in pull request #54: [WIP] Infrasummary SSL URL: https://github.com/apache/cloudstack-primate/pull/54#discussion_r353074736 ## File path: src/api/index.js ## @@ -25,6 +25,17 @@ export function api (command, args = {}) { }) } +export functio

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #54: [WIP] Infrasummary SSL

2019-12-03 Thread GitBox
rhtyd commented on a change in pull request #54: [WIP] Infrasummary SSL URL: https://github.com/apache/cloudstack-primate/pull/54#discussion_r353074943 ## File path: src/views/infra/InfraSummary.vue ## @@ -41,11 +41,102 @@ - Some contents... -

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #54: [WIP] Infrasummary SSL

2019-12-03 Thread GitBox
rhtyd commented on a change in pull request #54: [WIP] Infrasummary SSL URL: https://github.com/apache/cloudstack-primate/pull/54#discussion_r353075676 ## File path: src/views/infra/InfraSummary.vue ## @@ -115,17 +211,109 @@ export default { this.loading = false

[GitHub] [cloudstack-primate] rhtyd commented on issue #54: [WIP] Infrasummary SSL

2019-12-03 Thread GitBox
rhtyd commented on issue #54: [WIP] Infrasummary SSL URL: https://github.com/apache/cloudstack-primate/pull/54#issuecomment-561088055 Overall changes needs testing to confirm, upon testing this may be merged. This is an automa

[GitHub] [cloudstack-primate] rhtyd commented on issue #54: [WIP] Infrasummary SSL

2019-12-03 Thread GitBox
rhtyd commented on issue #54: [WIP] Infrasummary SSL URL: https://github.com/apache/cloudstack-primate/pull/54#issuecomment-561088248 @RitchieVincent kindly change the PR status from Draft This is an automated message from the

[GitHub] [cloudstack-primate] RitchieVincent commented on a change in pull request #54: [WIP] Infrasummary SSL

2019-12-03 Thread GitBox
RitchieVincent commented on a change in pull request #54: [WIP] Infrasummary SSL URL: https://github.com/apache/cloudstack-primate/pull/54#discussion_r353077691 ## File path: src/api/index.js ## @@ -25,6 +25,17 @@ export function api (command, args = {}) { }) } +expor

[GitHub] [cloudstack-primate] RitchieVincent commented on a change in pull request #54: [WIP] Infrasummary SSL

2019-12-03 Thread GitBox
RitchieVincent commented on a change in pull request #54: [WIP] Infrasummary SSL URL: https://github.com/apache/cloudstack-primate/pull/54#discussion_r353078211 ## File path: src/views/infra/InfraSummary.vue ## @@ -41,11 +41,102 @@ - Some conten

[GitHub] [cloudstack-kubernetes-provider] onitake edited a comment on issue #9: [WIP] Support loadBalancerSourceRanges

2019-12-03 Thread GitBox
onitake edited a comment on issue #9: [WIP] Support loadBalancerSourceRanges URL: https://github.com/apache/cloudstack-kubernetes-provider/pull/9#issuecomment-560521940 Proposed solution: * Implement a new function `updateFirewallRules` that takes one argument - the LB NAT IP object's U

[GitHub] [cloudstack-primate] svenvogel commented on issue #46: Account View and Actions

2019-12-03 Thread GitBox
svenvogel commented on issue #46: Account View and Actions URL: https://github.com/apache/cloudstack-primate/issues/46#issuecomment-561197415 old view ![image](https://user-images.githubusercontent.com/5433844/70060676-4b1a5d80-15e3-11ea-9e9a-4854420ae345.png) -

[GitHub] [cloudstack-primate] svenvogel edited a comment on issue #46: Account View and Actions

2019-12-03 Thread GitBox
svenvogel edited a comment on issue #46: Account View and Actions URL: https://github.com/apache/cloudstack-primate/issues/46#issuecomment-561197415 old account view ![image](https://user-images.githubusercontent.com/5433844/70060676-4b1a5d80-15e3-11ea-9e9a-4854420ae345.png)

[GitHub] [cloudstack-primate] rhtyd commented on issue #46: Account View and Actions

2019-12-03 Thread GitBox
rhtyd commented on issue #46: Account View and Actions URL: https://github.com/apache/cloudstack-primate/issues/46#issuecomment-561264807 @svenvogel no, not that. The SSH keypair is already implemented and is under the compute navigation group now. I've updated the ticket with details now.

[GitHub] [cloudstack-primate] rhtyd commented on issue #46: Account Certs Tab

2019-12-03 Thread GitBox
rhtyd commented on issue #46: Account Certs Tab URL: https://github.com/apache/cloudstack-primate/issues/46#issuecomment-561270355 Once this issue's PR is up, I'll add details on https://github.com/apache/cloudstack-primate/issues/41 ---

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #53: Issue #27: Implement Tree-view based Domain List View

2019-12-03 Thread GitBox
rhtyd commented on a change in pull request #53: Issue #27: Implement Tree-view based Domain List View URL: https://github.com/apache/cloudstack-primate/pull/53#discussion_r353316541 ## File path: src/components/view/DetailsTab.vue ## @@ -23,7 +23,8 @@ {{

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #53: Issue #27: Implement Tree-view based Domain List View

2019-12-03 Thread GitBox
rhtyd commented on a change in pull request #53: Issue #27: Implement Tree-view based Domain List View URL: https://github.com/apache/cloudstack-primate/pull/53#discussion_r353317043 ## File path: src/config/section/iam.js ## @@ -176,6 +176,17 @@ export default {

[GitHub] [cloudstack-primate] rhtyd commented on issue #53: Issue #27: Implement Tree-view based Domain List View

2019-12-03 Thread GitBox
rhtyd commented on issue #53: Issue #27: Implement Tree-view based Domain List View URL: https://github.com/apache/cloudstack-primate/pull/53#issuecomment-561277294 @utchoang @svenvogel here are some issues from my testing: - On refreshing the view loses context and shows me the root dom

[GitHub] [cloudstack-primate] rhtyd commented on issue #54: [WIP] Infrasummary SSL

2019-12-03 Thread GitBox
rhtyd commented on issue #54: [WIP] Infrasummary SSL URL: https://github.com/apache/cloudstack-primate/pull/54#issuecomment-561277646 I'll review this tomorrow morning @RitchieVincent This is an automated message from the Apa

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #54: [WIP] Infrasummary SSL

2019-12-03 Thread GitBox
rhtyd commented on a change in pull request #54: [WIP] Infrasummary SSL URL: https://github.com/apache/cloudstack-primate/pull/54#discussion_r353332592 ## File path: src/views/infra/InfraSummary.vue ## @@ -115,17 +211,109 @@ export default { this.loading = false

[GitHub] [cloudstack-primate] RitchieVincent commented on a change in pull request #54: [WIP] Infrasummary SSL

2019-12-03 Thread GitBox
RitchieVincent commented on a change in pull request #54: [WIP] Infrasummary SSL URL: https://github.com/apache/cloudstack-primate/pull/54#discussion_r353463927 ## File path: src/views/infra/InfraSummary.vue ## @@ -41,11 +41,102 @@ - Some conten

[GitHub] [cloudstack-primate] rhtyd commented on issue #45: Roles Actions

2019-12-03 Thread GitBox
rhtyd commented on issue #45: Roles Actions URL: https://github.com/apache/cloudstack-primate/issues/45#issuecomment-561498024 PR link https://github.com/shapeblue/cloudstack-primate/pull/1 This is an automated message from t

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #53: Issue #27: Implement Tree-view based Domain List View

2019-12-03 Thread GitBox
rhtyd commented on a change in pull request #53: Issue #27: Implement Tree-view based Domain List View URL: https://github.com/apache/cloudstack-primate/pull/53#discussion_r353568566 ## File path: src/config/section/iam.js ## @@ -176,6 +176,17 @@ export default {

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #53: Issue #27: Implement Tree-view based Domain List View

2019-12-03 Thread GitBox
rhtyd commented on a change in pull request #53: Issue #27: Implement Tree-view based Domain List View URL: https://github.com/apache/cloudstack-primate/pull/53#discussion_r353568779 ## File path: src/views/AutogenView.vue ## @@ -309,6 +326,12 @@ export default {

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #53: Issue #27: Implement Tree-view based Domain List View

2019-12-03 Thread GitBox
rhtyd commented on a change in pull request #53: Issue #27: Implement Tree-view based Domain List View URL: https://github.com/apache/cloudstack-primate/pull/53#discussion_r353568957 ## File path: src/views/iam/TemplateDomainSettings.vue ## @@ -0,0 +1,118 @@ +// Licensed t

[GitHub] [cloudstack-primate] utchoang commented on issue #53: Issue #27: Implement Tree-view based Domain List View

2019-12-03 Thread GitBox
utchoang commented on issue #53: Issue #27: Implement Tree-view based Domain List View URL: https://github.com/apache/cloudstack-primate/pull/53#issuecomment-561503393 @rhtyd Thanks for your response. I will check and fix it.